Originally Posted by sirinsidiator
I tried to update Circonian's LibNotifications and noticed that NOTIFICATION_TYPE_GIFT is not defined, but is used in notifications_gamepad.lua and notifications_keyboard.lua. Not sure why it doesn't throw a lua error there, but when I copy the table into LibNotifications, it does exactly that:
Code:
user:/AddOns/LibNotification/LibNotification/LibNotification.lua:25: table index is nil
stack traceback:
user:/AddOns/LibNotification/LibNotification/LibNotification.lua:25: in function '(main chunk)'
@Chip is this entry unused and should be removed, or is the constant just missing? And could you please make these tables global? The lib breaks on almost every update because it relies on the data in these two files.  |
I'm looking at the latest code and I don't see any references to NOTIFICATION_TYPE_GIFT anywhere. They've all been split into RECEIVED, CLAIMED, and RETURNED variants.
We can make the table globals.