View Single Post
02/07/17, 06:58 AM   #4
Solinur
AddOn Author - Click to view addons
Join Date: Aug 2014
Posts: 78
Originally Posted by sirinsidiator View Post
Nice writeup, just a little bit behind the times. Instead of filtering all combat events in Lua, you should always try to filter them with the built in event filters first, as they offer way better better performance for this task. Afterwards you can filter the remaining events in Lua without much impact
It's not aplicable in this case. With EFFECT_COMBAT_EVENT you don't have info in that event to filter it. You want to have all events where the player is involved, but you only get the "target" unit. (A debuff is cast by the player but then active on another unit, so filtering by player would filter out all debuffs)

You also can not give a list of abilities. Instead you would need to register each ability on its own. (see the custom ability part in CombatMetrics.lua)
  Reply With Quote