I think your issue is related to the somewhat confusing process Addons go through while the game is loading. There are a couple key points to consider.
- Each xml element of your code has to be instantiated before you make a call to it, otherwise it will be nil
- Your files get loaded in the order present in the .txt manifest file (which looks fine for your purposes)
- When a file is loaded, all lua/xml code is processed and run at that point. This is usually safe for variable and function declarations only.
- Your RemiCustomAddon.lua binds your addon to EVENT_ADD_ON_LOADED before all of your elements are actually initialized. Since this is done in the global code area, this happens before your xml has been processed
- ESO is then calling your OnAddonLoaded() function before processing the xml files.
What I usually do to avoid this is to avoid binding to any events from the global space of a LUA file. I instead create an initialize function, then call the initialize function from the <OnInitialized> tags from my xml gui (which then also lets you pass the xml control in to your initialize functions). In your case it would look something like this.
xml Code:
<GuiXml>
<Controls>
<TopLevelControl name="RemiCustomAddonIndicator" mouseEnabled="true" movable="true" clampedToScreen="true">
<Dimensions x="200" y="25" />
<Anchor point="BOTTOM" relativeTo="GuiRoot" relativePoint="CENTER" offsetY="-20" />
<OnInitialized>
-- Call your initialize function from here
RemiCustomAddon:Initialize(self)
</OnInitialized>
<OnMoveStop>
RemiCustomAddon.OnIndicatorMoveStopBagSpace()
</OnMoveStop>
<Controls>
<Label name="$(parent)Label" width="200" height="25" font="ZoFontWinH1" inheritAlpha="true" color="FFA500"
wrapMode="TRUNCATE" verticalAlignment="TOP" horizontalAlignment="CENTER" text="Your bag is almost full!">
<Anchor point="TOP" relativeTo="$(parent)" relativePoint="TOP" />
</Label>
</Controls>
</TopLevelControl>
</Controls>
</GuiXml>
Then your initialize function would look like this
Lua Code:
function RemiCustomAddon:Initialize(control)
-- control -> RemiCustomAddonIndicator
self.inCombat = IsUnitInCombat("player");
EVENT_MANAGER:RegisterForEvent(self.name, EVENT_PLAYER_COMBAT_STATE, self.OnPlayerCombatState)
EVENT_MANAGER:RegisterForEvent(self.name, EVENT_GROUPING_TOOLS_READY_CHECK_UPDATED, self.OnLFGReadyCheckState)
EVENT_MANAGER:RegisterForEvent(self.name, EVENT_PLAYER_ACTIVATED, self.DoesBagHaveSpace)
-- Bind the addon load from here.
EVENT_MANAGER:RegisterForEvent(RemiCustomAddon.name, EVENT_ADD_ON_LOADED, RemiCustomAddon.OnAddOnLoaded)
-- Shouldn't need this call because you also bound it to PLAYER_ACTIVATED, but I included it because you had it in the xml originally
self.DoesBagHaveSpace()
self.savedVariables = ZO_SavedVars:New("RemiCustomAddonSavedVariables", 1, nil, {})
self:RestorePositionBagSpace()
self:RestorePositionFight()
end
That should fix your problem.
Edit: Upon review, you may need to add another initialize function to handle the flightIndicator, change the load order of the xml files, or simply combine your two xml files into one.
Here is what a combination could look like:
xml Code:
<GuiXml>
<Controls>
<TopLevelControl name="RemiCustomAddonIndicators" mouseEnabled="true" movable="true" clampedToScreen="true">
<Dimensions x="200" y="25" />
<Anchor point="BOTTOM" relativeTo="GuiRoot" relativePoint="CENTER" offsetY="-20" />
<OnInitialized>
-- Call your initialize function from here
RemiCustomAddon:Initialize(self)
</OnInitialized>
<OnMoveStop>
RemiCustomAddon.OnIndicatorMoveStopBagSpace()
</OnMoveStop>
<Controls>
<Control name="BagIndicator" mouseEnabled="true" movable="true" clampedToScreen="true">
<Dimensions x="200" y="25" />
<Anchor point="BOTTOM" relativeTo="GuiRoot" relativePoint="CENTER" offsetY="-20" />
<OnMoveStop>
RemiCustomAddon.OnIndicatorMoveStopBagSpace()
</OnMoveStop>
<Controls>
<Label name="$(parent)Label" width="200" height="25" font="ZoFontWinH1" inheritAlpha="true" color="FFA500"
wrapMode="TRUNCATE" verticalAlignment="TOP" horizontalAlignment="CENTER" text="Your bag is almost full!">
<Anchor point="TOP" relativeTo="$(parent)" relativePoint="TOP" />
</Label>
</Controls>
</Control>
<Control name="FightIndicator" mouseEnabled="true" movable="true" clampedToScreen="true">
<Dimensions x="200" y="25" />
<Anchor point="BOTTOM" relativeTo="GuiRoot" relativePoint="CENTER" offsetY="-20" />
<OnMoveStop>
RemiCustomAddon.OnIndicatorMoveStopFight()
</OnMoveStop>
<Controls>
<Label name="$(parent)Label" width="200" height="25" font="ZoFontWinH1" inheritAlpha="true" color="FF0000"
wrapMode="TRUNCATE" verticalAlignment="TOP" horizontalAlignment="CENTER" text="Fighting!">
<Anchor point="TOP" relativeTo="$(parent)" relativePoint="TOP" />
</Label>
</Controls>
</Control>
</Controls>
</TopLevelControl>
</Controls>
</GuiXml>
This will change the global name bindings, but it also lets you do some nice things in the lua
lua Code:
function RemiCustomAddon:Initialize(control)
-- You can now grab child elements of your top level control without worrying about the full global names.
local bagIndicator = GetControl(control, "BagIndicator");
local fightIndicator = GetControl(control, "FightIndicator");
--You can also do this
GetControl(bagIndicator, "Label"):SetText("Now your label text has changed")
self.inCombat = IsUnitInCombat("player");
EVENT_MANAGER:RegisterForEvent(self.name, EVENT_PLAYER_COMBAT_STATE, self.OnPlayerCombatState)
EVENT_MANAGER:RegisterForEvent(self.name, EVENT_GROUPING_TOOLS_READY_CHECK_UPDATED, self.OnLFGReadyCheckState)
EVENT_MANAGER:RegisterForEvent(self.name, EVENT_PLAYER_ACTIVATED, self.DoesBagHaveSpace)
-- Bind the addon load from here.
EVENT_MANAGER:RegisterForEvent(RemiCustomAddon.name, EVENT_ADD_ON_LOADED, RemiCustomAddon.OnAddOnLoaded)
-- Shouldn't need this call because you also bound it to PLAYER_ACTIVATED, but I included it because you had it in the xml originally
self.DoesBagHaveSpace()
self.savedVariables = ZO_SavedVars:New("RemiCustomAddonSavedVariables", 1, nil, {})
self:RestorePositionBagSpace()
self:RestorePositionFight()
end