Skill Trigger

[Carter_DC]

Hi guys,
is there a workaround the lack of a proper event triggered each time an action skill is activated ?

I saw some addons (like sorcerer helper) use a 1 second loop to check for button state, but i'd like to know it's there's a more proper way to go.

[Ayantir]

you can prehook one of the core function which will trigger when user activate a skill. but i don't know really which one to use.

Looked on code, maybe ZO_Skills_AbilitySlot_OnClick..

[merlight]

Originally Posted by Ayantir you can prehook one of the core function which will trigger when user activate a skill. but i don't know really which one to use.

I don't think so, ActionButtonUp -> button:HandleRelease -> OnSlotUp (which is private)
Before the call to OnSlotUp, there's self.button:SetState(BSTATE_NORMAL, false), so you could hook SetState. But gamepads don't use separate Down/Up calls, they use DownAndUp, and these don't call SetState at all. And now when I saw that, I'm thinking of replacing Down with DownAndUp, and Up with empty function, if that works it should fire abilities earlier

Originally Posted by Ayantir Looked on code, maybe ZO_Skills_AbilitySlot_OnClick..

I think OnClick is for actual mouse clicks.

Maybe

* EVENT_ACTION_SLOT_STATE_UPDATED (*luaindex* _slotNum_)

and

* HasActivationHighlight(*luaindex* _slotIndex_)
** _Returns:_ *bool* _status_

?

[Garkin]

Kith in his Srendarr addon uses post hook of the ActionButton's SetState method:

local function ActionFailed(slotnum)
    return GetSlotType(slotnum) == ACTION_TYPE_NOTHING or
    HasCostFailure(slotnum) or
    HasTargetFailure(slotnum) or
    HasRequirementFailure(slotnum) or
    HasWeaponSlotFailure(slotnum) or
    HasStatusEffectFailure(slotnum) or
    HasFallingFailure(slotnum) or
    HasSwimmingFailure(slotnum) or
    HasMountedFailure(slotnum) or
    HasReincarnatingFailure(slotnum) or
    HasRangeFailure(slotnum)
end
 
local ActionButton_SetState_Orig = ActionButton3Button.SetState
 
local function ActionButton_SetState_Hook(self, state, locked)
    ActionButton_SetState_Orig(self, state, locked)
 
    if state == BSTATE_PRESSED and (not ActionFailed(self.slotNum)) then
 
        --your code
 
    end
end
 
ActionButton3Button.SetState = ActionButton_SetState_Hook
ActionButton4Button.SetState = ActionButton_SetState_Hook
ActionButton5Button.SetState = ActionButton_SetState_Hook
ActionButton6Button.SetState = ActionButton_SetState_Hook
ActionButton7Button.SetState = ActionButton_SetState_Hook
ActionButton8Button.SetState = ActionButton_SetState_Hook

[Carter_DC]

i'm gonna look into this, thx guys ! (you're great ! )