Secure Render Mode Bug

[votan]

Neither SCENE_MANAGER nor WINDOW_MANAGER do handle entering/leaving SecureRenderMode properly. (Opening/Closing Crone Market)

SCENE_MANAGER does not wait until all custom fade-scenes reaching SCENE_HIDDEN state.
Any custom fade-scene with a fade-out duration greather than zero will cause security exceptions (Access private function "StopAllMovements" from ...)
One would expect one could dynamically change the fade-out-duration by handling the EVENT_SECURE_RENDER_MODE_CHANGED and call SetHiddenForReason with a zero fade-duration. But this event is not triggered before the market is causing a security exception already. You have no chance to react to this situation.
The only way to overcome this is to create fade-scenes with zero fade-out duration (which is not default value for ZO_FadeSceneFragment!) just for the rare case the market will be opened...

The same thing the other way round: The SCENE_MANAGER does not wait until market scene reaching SCENE_HIDDEN before showing custom scenes again.
Any key-bind function simply doing SCENE_MANAGER:Show("myscene") or SCENE_MANAGER:ShowBaseScene() without checking WINDOW_MNAGER:IsSecureRenderModeEnabled() and skipping any scene change, will cause a security exception.

Please prove I just doing something wrong, but I think the whole SecureRenderMode transition should be reviewed by ZOS.

[XanDDemoX]

My store does something like this. I can reproduce it by clicking tabs on the world map info control and then clicking on the store.

EsoUI/Ingame/Scenes/IngameFragments.lua:430: attempt to access a private function 'StopAllMovement' from insecure code
stack traceback:
	EsoUI/Ingame/Scenes/IngameFragments.lua:430: in function 'ZO_StopMovementFragment:Show'
	EsoUI/Libraries/ZO_Scene/ZO_SceneFragment.lua:126: in function 'ZO_SceneFragment:ShouldBeShown'
	EsoUI/Libraries/ZO_Scene/ZO_SceneFragment.lua:170: in function 'ZO_SceneFragment:Refresh'
	EsoUI/Libraries/ZO_Scene/ZO_Scene.lua:291: in function 'ZO_Scene:RefreshFragmentsHelper'
	EsoUI/Libraries/ZO_Scene/ZO_Scene.lua:299: in function 'ZO_Scene:RefreshFragments'
	EsoUI/Libraries/ZO_Scene/ZO_Scene.lua:256: in function 'ZO_Scene:SetState'
	EsoUI/Libraries/ZO_Scene/ZO_Scene.lua:406: in function 'ZO_RemoteScene:SetState'
	EsoUI/Libraries/ZO_Scene/ZO_SceneManager.lua:155: in function 'ZO_SceneManager:ShowScene'
	EsoUI/Libraries/ZO_Scene/ZO_SceneManager.lua:430: in function 'ZO_SceneManager:OnSceneStateChange'
	EsoUI/Ingame/Scenes/IngameSceneManager.lua:278: in function 'ZO_IngameSceneManager:OnS

[ZOS_ChipHilseberg]

Looking at secure render mode it only impacts which controls draw and which don't, so it doesn't interact with the security violation code. It might be that something else is happening at the same time secure render mode is changing. I know that any scene that uses the stop movement fragment (I'm only seeing crown store and gamepad scenes using it right now) will trigger a violation if the scene is shown from insecure code. Is there some way your code is showing one of those?

[votan]

Originally Posted by ZOS_ChipHilseberg Looking at secure render mode it only impacts which controls draw and which don't, so it doesn't interact with the security violation code. It might be that something else is happening at the same time secure render mode is changing. I know that any scene that uses the stop movement fragment (I'm only seeing crown store and gamepad scenes using it right now) will trigger a violation if the scene is shown from insecure code. Is there some way your code is showing one of those?

If you want to have an example try the current version of Rare Fish Tracker.
It "just" surrounds a TopLevelWindow with a ZO_HUDFadeSceneFragment to handle where and when it is visible. rft is the TopLevelWindow:

RARE_FISH_TRACKER_FRAGMENT = ZO_HUDFadeSceneFragment:New(rft, 500, 0)
    RARE_FISH_TRACKER_FRAGMENT:SetConditional( function()
        if WORLD_MAP_FRAGMENT:IsShowing() then
            return RFT.settings.shown_world
        else
            if IsUnitInCombat("player") then return false end
            return RFT.settings.shown or RFT.isFishing
        end
    end )
    WORLD_MAP_FRAGMENT:RegisterCallback("StateChange", function(oldState, newState)
        if newState == SCENE_FRAGMENT_SHOWING or newState == SCENE_FRAGMENT_HIDING then
            if RFT.settings.shown_world == RFT.settings.shown then RFT:RestorePosition() end
            RARE_FISH_TRACKER_FRAGMENT:Refresh()
        elseif newState == SCENE_FRAGMENT_HIDDEN then
            RFT.RefreshWindowForZone(GetUnitZone('player'))
        end
    end )
    CALLBACK_MANAGER:RegisterCallback("OnWorldMapChanged", function(navigateIn)
        if WORLD_MAP_FRAGMENT:IsShowing() then
            if navigateIn and GetMapType() ~= MAPTYPE_ZONE then return end
            RFT.RefreshWindowForZone(ZO_WorldMap.zoneName)
        else
            RFT.RefreshWindowForZone(GetUnitZone('player'))
        end
    end )
    RARE_FISH_TRACKER_FRAGMENT:RegisterCallback("StateChange", function(oldState, newState)
        if newState == SCENE_FRAGMENT_SHOWING then RFT:RestorePosition() end
    end )
    EVENT_MANAGER:RegisterForEvent("RareFishTracker", EVENT_PLAYER_COMBAT_STATE, function() RARE_FISH_TRACKER_FRAGMENT:Refresh() end)
 
    HUD_SCENE:AddFragment(RARE_FISH_TRACKER_FRAGMENT)
    HUD_UI_SCENE:AddFragment(RARE_FISH_TRACKER_FRAGMENT)
    LOOT_SCENE:AddFragment(RARE_FISH_TRACKER_FRAGMENT)
    WORLD_MAP_SCENE:AddFragment(RARE_FISH_TRACKER_FRAGMENT)

If you change the fade-out duration in line 266 of RareFishWindow.lua (here first line) from 0 to let's say 100 and you make the Rare Fish Tracker window visible, you can't open the store without crash. If you toggle it off first, all is ok.

[XanDDemoX]

Originally Posted by ZOS_ChipHilseberg Looking at secure render mode it only impacts which controls draw and which don't, so it doesn't interact with the security violation code. It might be that something else is happening at the same time secure render mode is changing. I know that any scene that uses the stop movement fragment (I'm only seeing crown store and gamepad scenes using it right now) will trigger a violation if the scene is shown from insecure code. Is there some way your code is showing one of those?

The only usage I have of Fragments is using ZO_FadeSceneFragment in Faster Travel to add its top level controls to the worldmapinfo control :

<TopLevelControl name="FasterTravel_WorldMapWayshrines" inherits="ZO_WorldMapInfoContent">
<OnInitialized>
...
self.fragment = ZO_FadeSceneFragment:New(self)
...
</OnInitialized>

local function AddWorldMapFragment(strId,fragment,normal,highlight,pressed)
    WORLD_MAP_INFO.modeBar:Add(strId, { fragment }, {pressed = pressed,highlight =highlight,normal = normal})
end

local path = "/esoui/art/treeicons/achievements_indexicon_alliancewar_"

AddWorldMapFragment(SI_MAP_INFO_MODE_WAYSHRINES,wayshrineControl.fragment,path.."up.dds",path.."over.dds",path.."down.dds")

path = "/esoui/art/mainmenu/menubar_group_"

AddWorldMapFragment(SI_MAP_INFO_MODE_PLAYERS,playersControl.fragment,path.."up.dds",path.."over.dds",path.."down.dds")

[ZOS_ChipHilseberg]

Thanks for the test code. I was able to repro it here. It seems like the problem is: if you are the last fragment to complete in a scene then you will trigger the code to show the next scene which will be a security violation if that scene includes a fragment that calls a private function immediately on show. Fixing this will be a bit of work to separate out scenes a bit more. In the mean time you should be able to have an animation as long as it's finishes just before the slowest scene fragment.

[votan]

Originally Posted by ZOS_ChipHilseberg Thanks for the test code. I was able to repro it here. It seems like the problem is: if you are the last fragment to complete in a scene then you will trigger the code to show the next scene which will be a security violation if that scene includes a fragment that calls a private function immediately on show. Fixing this will be a bit of work to separate out scenes a bit more. In the mean time you should be able to have an animation as long as it's finishes just before the slowest scene fragment.

Thank you, Chip.
But I don't know, if I got you right. Any fade-out duration greather than zero (even 2ms) raises an exception.

By the way: You can also cause the exception the other way round:
Do this in chat window, while market is open:

/script SCENE_MANAGER:ShowBaseScene()