01/07/17, 04:31 AM | #21 | |
@Chip: Ah, ok. Thanks. BTW: Your addon compatibility aliases have a typo. Code:
IsPOIWayshrine = function(zoneIndex, poiIndex) return GetPoiType(zoneIndex, poiIndex) == POI_TYPE_WAYSHRINE end |
||
01/07/17, 05:25 AM | #22 |
Or maybe add a set of logging function that write directly to the interface log without impacting the game's performance too much.
LogError, LogWarning, LogInfo, LogDebug + SetLogLevel which defaults to LOG_LEVEL_WARNING on live and LOG_LEVEL_DEBUG on pts. The log functions could also write which addon called them, at which time, and from which line e.g: Code:
2017-01-07 12:23:45:678 [ingame] something, ingame/something/somefile.lua:123 2017-01-07 12:23:46:042 [AwesomeGuildStore] another, AwesomeGuildStore/StartUp.lua:42 The alias functions could then all include a LogInfo("deprecated method, consider replacing it"). This could help a lot with debugging addons and also during development where putting a d() call into a loop can cause a client crash. Last edited by sirinsidiator : 01/07/17 at 05:27 AM. |
|
01/07/17, 10:13 AM | #23 |
I just played around with the new housing APIs and
Maybe you could also return the itemLink from GetPlacedHousingFurnitureInfo I also noticed that there is still no function to restore a stringified id64 into a proper id64. It shouldn't be necessary for this case, but it would still be nice to have in some other cases. EDIT: after some more tinkering I found that furnitureDataId is not what I thought it was and multiple itemIds can have the same furnitureDataId. It also looks like there is more than one furniture item with the same name, which means there is currently no way to map furniture to an item based on the data returned from the housing API. Last edited by sirinsidiator : 01/07/17 at 01:28 PM. |
|
01/08/17, 06:42 AM | #24 |
I managed to make it work somewhat.
But there are a few major drawbacks.
|
|
01/08/17, 09:43 AM | #25 |
I just tried to get the new trading house filters to work and found that some things just don't work (yet?).
First I tried to list some furniture and recipes in a guild store and use the vanilla interface. When searching for All items, the 3 furniture items and 6 recipes show up as expected, but when I select the new furnishings category and search for all furnishings / items and recipes I only see 2 recipes instead of the expected 9 items. I then looked through other categories and noticed that the crafting category also has a new subcategory for furnishing formula which show the remaining 4 recipes, but the furniture items never showed besides in the main all items category. Next I tried to add the filter to AwesomeGuildStore and found that there is a typo in the definition of ZO_TRADING_HOUSE_FILTER_FURNITURE_ITEM_TYPE_DATA in line 385 in tradinghouse_filter_shared.lua. The constant for SPECIALIZED_ITEMTYPE_RECIPE_BLACKSMITHING_FURNISHING_DIAGRAM should be SPECIALIZED_ITEMTYPE_RECIPE_BLACKSMITHING_DIAGRAM_FURNISHING instead. When I use the ITEMTYPE_FURNISHING I can find all furnishing items as expected and the recipes also show in the category for recipes, but I cannot get the TRADING_HOUSE_FILTER_TYPE_SPECIALIZED_ITEM to work in order to split them up further. From my standpoint it looks as if the trading house changes are not yet finished. I also tried to figure out what I can do with the increased filter parameter limit and while 16 is already a good improvement, it is still too low. I need at least 20 parameters to be able to add an all category for all crafting materials. The issue where I cannot show shields in the all category for armor would also need a specialized item type for shields that is not linked with weapons and can be combined with the armor category. |
|
01/08/17, 09:46 AM | #26 |
Hey guys,
Does anyone have the style item index for all the new styles? I was looking here but I think people are still working on getting everything updated -> http://wiki.esoui.com/StyleItemIndex Thanks! |
|
01/09/17, 03:33 PM | #27 | |
I was playing around with the new Master Writs to see what local filters I can do for them in the guildstore and noticed that there is a crash bug. I won't post the details here (already sent a bug report ingame), but please fix that before it goes live.
I also thought a bit more about the housing export addon I am making and I think with the possibility to save furniture arrangements it is important that you tie GetNextPlacedHousingFurnitureId() into the housing permission system, otherwise some random visitor could copy my hard work and claim it as their own (exactly what I am doing right now with Solinur's work ). For example you could always return nil when the player does not have decorator permissions or is not the owner himself, that way the homeowner can decide who may copy his work. I think this is especially important when/if the housing leaderboard becomes available.
|
||
01/09/17, 03:56 PM | #28 | |
I'll increase the search term limits to 24 and we'll see how that plays. The shield problem will takes adding some new specialized item types which won't happen until the next major release. |
||
01/09/17, 04:26 PM | #29 | |
As for the placement functions, those trigger an inventory operation and also broadcast a new piece of furniture to everyone when they are used. We have to be careful so that if an addon was made that moved or placed the full contents of the house very frequently it would not grind the servers to a halt. The current mechanism for this is using the message rate limits, but we could potentially build a more robust system for queuing these things in the future. |
||
01/09/17, 04:37 PM | #30 |
|
Are you aware that the Ebony motif items are showing as motif number 36 but that's also the same motif number as Dark brotherhood already uses?
Do you know what motif number Ebony is planned to be? |
01/09/17, 05:25 PM | #31 | |
Join Date: Oct 2014
Posts: 40
|
I've noticed that furnishings bought from the crown store have an item value of 0 while they're non-crown store counterparts have their full item value. It makes sense and all but the problem is that when you try to get the item's value via its item link, it returns the full item value regardless. This not only causes some issues with add-ons that view inventory via item links but it also causes the gamepad interface to list the wrong item value in the tooltips.
|
|
01/10/17, 03:53 AM | #32 | ||
I don't know how your server handles these calls, but in other server based systems a bulk update usually has a performance advantage because of the reduced overhead. I'd think this holds especially true in a case where I would send 1000 individual requests to place all furniture or remove it. I don't expect that it will be added with this update, but I'd love to see an improved way to do this in the future. p.s. please add a return value for itemLink to GetPlacedHousingFurnitureInfo, or add a method GetPlacedHousingFurnitureItemLink |
|||
01/10/17, 04:51 AM | #33 |
|
This happens with every patch. We have to wait and see waht the new numbers are.
|
01/13/17, 08:38 AM | #34 |
hey Chip! will you adress this guild sales history bug in this update?
http://www.esoui.com/forums/showthread.php?t=6695 |
|
QuadroTony |
View Public Profile |
Find More Posts by QuadroTony |
01/13/17, 08:39 AM | #35 | |
|
||
01/14/17, 03:14 PM | #36 |
I just finished the first version of SaveHouse. Unfortunately I could only test it partially, because in the current PTS version HousingEditorRequestItemPlacement produces a crash to desktop whenever I call it for any item in my inventory in any house. I really hope that you can fix that before Homestead goes live.
|
|
01/15/17, 01:16 PM | #37 |
Skin Changer Motif Chapter Books broken
@Chip:
The IsItemLinkBookKnown function returns false on the skin changer motif chapter books. The PTS template knowns all styles. The full books are ok. Two of them have typos in the german description. item ids [73855] [73856] [73857] [73858]<-typo [73859] [73860] [73861] [73862] [73863] [73864] [73865]<-typo [73866] [73867] [73868] And GetItemLinkItemType does not return 61=SPECIALIZED_ITEMTYPE_RACIAL_STYLE_MOTIF_CHAPTER for any chapter book (the second return value). Is this correct? |
|
01/15/17, 02:16 PM | #38 |
While getting AGS ready for Homestead I noticed that the TRADING_HOUSE_FILTER_TYPE_FURNITURE_CATEGORY shows entries for mounts, pets and assistants in the vanilla interface. Seems a bit pointless, or do you plan to make them tradeable?
It also looks like the filter limit is still set to 8. Will the change make it in with the patch tomorrow? And last but not least there is a typo in addoncompatibilityaliases.lua: GetItemLinkRankRequirement should actually be GetItemLinkRecipeRankRequirement. |
|
01/16/17, 12:06 PM | #39 | |
|
I tried GetItemLinkItemType() but never got it to return anything about motif chapters I should add that I checked on PTS today (16th Jan) and now my live characters have been copied over the skin changer motif is behaving correctly. Last edited by Weolo : 01/16/17 at 04:48 PM. Reason: Re-tested on PTS |
|
01/16/17, 01:15 PM | #40 | |
|
||
ESOUI » Developer Discussions » Tutorials & Other Helpful Info » 2.7 Update |
«
Previous Thread
|
Next Thread
»
|
Display Modes |
Linear Mode |
Switch to Hybrid Mode |
Switch to Threaded Mode |
|
|