Converting Destinations from LAM-1.0 to LAM-2.0

SnowmanDK · 11/18/14, 12:30 PM

I am puzzled about a problem I have.

The code using LAM-1.0 is this:

Lua Code:

for k,craftKey in pairs(blackSmithingRules) do
        lam:AddDropdown(panelID, craftKey.."#"..numProfile, getTranslated(craftKey), "", getTranslateTable(sendingType),
        function() return getTranslated(BankManager.Saved[craftKey][numProfile]) end,
        function(val) changeTranslateTable(val,craftKey,numProfile) end)
    end

I was hoping to convert it to 2.0 like this:

Lua Code:

for k, craftKey in pairs(blackSmithingRules) do
        {--[17.x]
            type = "dropdown",
            name = getTranslated(craftKey),
            choices = getTranslateTable(sendingType),
            getFunc = function() return getTranslated(BankManager.Saved[craftKey][numProfile]) end,
            setFunc = function(value) changeTranslateTable(value,craftKey,numProfile) end,
        },
    end

Sadly I get an error saying: unexpected symbol near 'for'.

Any idea how I can fix this?

Sasky · 11/18/14, 12:50 PM

Looping over the block does nothing. You'd need to build-up a table by appending each entry from the loop:

Lua Code:

local settingsTable = {}
for k, craftKey in pairs(blackSmithingRules) do
    local entry = {--[17.x]
        type = "dropdown",
        name = getTranslated(craftKey),
        choices = getTranslateTable(sendingType),
        getFunc = function() return getTranslated(BankManager.Saved[craftKey][numProfile]) end,
        setFunc = function(value) changeTranslateTable(value,craftKey,numProfile) end,
    }
    table.append(settingsTable, entry);
end

Keep in mind that ordering matters in the options table. You can either table.append everything to build it up, or just make the table in the normal manner up to that point then use table.append from then on.

Alternatively, if you want to stick to the function-based style (rather than make the table yourself), you can take a look at:
http://www.esoui.com/downloads/info5...Interface.html
You'd have to extend it for any of the new LAM2 features (like texture), but it is something to consider.

SnowmanDK · 11/18/14, 01:08 PM

Originally Posted by Sasky

Looping over the block does nothing. You'd need to build-up a table by appending each entry from the loop:

Lua Code:

local settingsTable = {}
for k, craftKey in pairs(blackSmithingRules) do
    local entry = {--[17.x]
        type = "dropdown",
        name = getTranslated(craftKey),
        choices = getTranslateTable(sendingType),
        getFunc = function() return getTranslated(BankManager.Saved[craftKey][numProfile]) end,
        setFunc = function(value) changeTranslateTable(value,craftKey,numProfile) end,
    }
    table.append(settingsTable, entry);
end

Keep in mind that ordering matters in the options table. You can either table.append everything to build it up, or just make the table in the normal manner up to that point then use table.append from then on.

Alternatively, if you want to stick to the function-based style (rather than make the table yourself), you can take a look at:
http://www.esoui.com/downloads/info5...Interface.html
You'd have to extend it for any of the new LAM2 features (like texture), but it is something to consider.

I tried using your code, but gets the same error in the "for" line as before.
Guess I am gonna do it the hard way, by adding them one by one instead.
I already converted most of the settings menu, but thanks for the input

SnowmanDK · 11/18/14, 01:38 PM

lol don't know why I wrote "Destinations" in topic.
It IS Bank Manager Revived I am working on at the moment.

merlight · 11/18/14, 02:20 PM

Originally Posted by SnowmanDK

Sadly I get an error saying: unexpected symbol near 'for'.

That likely means you have something evil before the for. When I simply pasted the piece from your initial post into Lua console, I got unexpected symbol near '{' (which was kind of expected

)

edit: probably some unclosed braces...

Sasky · 11/18/14, 03:24 PM

Ah yeah. If you're trying to do something along these lines it'd throw the error at the for statement because you can't have a for statement within a table.

Lua Code:

--BAD STRUCTURE. DO NOT USE
local addonControls = {
    --controls here
   
   --BAD STRUCTURE
   for( .... ) do
      {
          --Data here
      }
   end
}

Might go ahead and throw the full function/file on pastebin or something so can better see what the error is.

SnowmanDK · 11/18/14, 03:48 PM

Originally Posted by merlight

That likely means you have something evil before the for. When I simply pasted the piece from your initial post into Lua console, I got unexpected symbol near '{' (which was kind of expected

)

edit: probably some unclosed braces...

Well if I comment out that entire "for" loop then I get no errors at all, so it is in that loop it goes wrong.
I can see Sasky pointed the problem out

Originally Posted by Sasky

...you can't have a for statement within a table.

On with the job the oldfashion way, I guess

Garkin · 11/18/14, 06:15 PM

Check how it is done in HarvestMap addon.

Lua Code:

local optionsTable = setmetatable({}, { __index = table })
 
optionsTable:insert({
    type = "button",
    name = "Import other Accounts",
    tooltip = "Moves gathered data from other Accounts to this one. This can also restore lost data after an ESO update.",
    warning = "Please create a backup of your data first! Copy the file SavedVariables/HarvestMap.lua to somwhere else.",
    width = "half",
    func = function()
        Harvest.makeGlobal("nodes")
    end
})
--lots of other entries
 
--entries added by for loop
for profession = 1, 8 do
    optionsTable:insert({
        type = "header",
        name = Harvest.localization[ "filter"..profession ] .. " pin Options",
    })
    CreateFilter( profession )
    CreateImportFilter( profession )
    CreateGatherFilter( profession )
    CreateSizeSlider( profession )
    CreateColorPicker( profession )
end
 
--rest of the entries

SnowmanDK · 11/18/14, 07:39 PM

Originally Posted by Garkin

Check how it is done in HarvestMap addon.

Lua Code:

local optionsTable = setmetatable({}, { __index = table })
 
optionsTable:insert({
    type = "button",
    name = "Import other Accounts",
    tooltip = "Moves gathered data from other Accounts to this one. This can also restore lost data after an ESO update.",
    warning = "Please create a backup of your data first! Copy the file SavedVariables/HarvestMap.lua to somwhere else.",
    width = "half",
    func = function()
        Harvest.makeGlobal("nodes")
    end
})
--lots of other entries
 
--entries added by for loop
for profession = 1, 8 do
    optionsTable:insert({
        type = "header",
        name = Harvest.localization[ "filter"..profession ] .. " pin Options",
    })
    CreateFilter( profession )
    CreateImportFilter( profession )
    CreateGatherFilter( profession )
    CreateSizeSlider( profession )
    CreateColorPicker( profession )
end
 
--rest of the entries

I have converted what I had done previously, and it works with your setup

I am seriously scratching my head over this, though, as I can't figure out how to convert it to a format that will be accepted:

Lua Code:

for k, craftKey in pairs(blackSmithingRules) do

blackSmithingRules looks like this:

Lua Code:

blackSmithingRules = {
    "ITEMTYPE_BLACKSMITHING_BOOSTER",
    "ITEMTYPE_BLACKSMITHING_MATERIAL",
    "ITEMTYPE_BLACKSMITHING_RAW_MATERIAL"
}

Garkin · 11/18/14, 09:51 PM

Your original code modified to use table.insert (I assume that your table with options is called "optionsTable"):

Lua Code:

for _, craftKey in pairs(blackSmithingRules) do
    table.insert(optionsTable, {
        type = "dropdown",
        name = getTranslated(craftKey),
        choices = getTranslateTable(sendingType),
        getFunc = function() return getTranslated(BankManager.Saved[craftKey][numProfile]) end,
        setFunc = function(value) changeTranslateTable(value,craftKey,numProfile) end,
    })
end

This code is basically the same as was suggested by Sasky.

Modified code if you use metatable as it is in HarvestMaps addon (again, I assume that you use "optionsTable"):

Lua Code:

for _, craftKey in pairs(blackSmithingRules) do
    optionsTable:insert({
        type = "dropdown",
        name = getTranslated(craftKey),
        choices = getTranslateTable(sendingType),
        getFunc = function() return getTranslated(BankManager.Saved[craftKey][numProfile]) end,
        setFunc = function(val) changeTranslateTable(val, craftKey, numProfile) end,
    })
end

SnowmanDK · 11/19/14, 11:38 AM

Originally Posted by Garkin

Modified code if you use metatable as it is in HarvestMaps addon (again, I assume that you use "optionsTable"):

Lua Code:

for _, craftKey in pairs(blackSmithingRules) do
    optionsTable:insert({
        type = "dropdown",
        name = getTranslated(craftKey),
        choices = getTranslateTable(sendingType),
        getFunc = function() return getTranslated(BankManager.Saved[craftKey][numProfile]) end,
        setFunc = function(val) changeTranslateTable(val, craftKey, numProfile) end,
    })
end

I used HarvestMap as template yes, and my table is called "optionsTable".
This part works fine with no issues:

Lua Code:

optionsTable:insert({ --[16] --> Stacks Rules submenu <--
        type = "submenu",
        name = getTranslated("subMenuStacksRules"),
        tooltip = getTranslated("subMenuStacksRulesTooltip"),
        controls = {
            {--[16.1]
                type = "dropdown",
                name = getTranslated("fillStacks"),
                tooltip = getTranslated("fillStacksTooltip"),
                choices = getTranslateTable(sendingType),
                getFunc = function() return getTranslated(BankManager.Saved["fillStacks"][numProfile]) end,
                setFunc = function(value) changeTranslateTable(value,"fillStacks",numProfile) end,
            },
            {--[16.2]
                type = "checkbox",
                name = getTranslated("stackSizeCheckBox"),
                tooltip = getTranslated("stackSizeCheckBoxTooltip"),
                getFunc = function() return BankManager.Saved["stackSizeCheckBox"][numProfile] end,
                setFunc = function(value) BankManager.Saved["stackSizeCheckBox"][numProfile] = value end,
            },
            {--[16.3]
                type = "slider",
                name = getTranslated("stackSizeSlider"),
                    tooltip = getTranslated("stackSizeSliderTooltip"),
                min = 1,
                    max = 100,
                step = 1,
                getFunc = function() return BankManager.Saved["stackSizeSlider"][numProfile] end,
                setFunc = function(value) BankManager.Saved["stackSizeSlider"][numProfile] = value end,
            },
        },
    })

This one fails:

Lua Code:

optionsTable:insert({ --[17] --> Blacksmithing Rules submenu <--
        type = "submenu",
        name = getTranslated("CRAFTING_TYPE_BLACKSMITHING"),
        controls = {
            {--[17.1]
                    type = "dropdown",
                name = getTranslated("setAllOptions") .."|r",
                tooltip = getTranslated("setAllOptionsTooltip"),
                choices = getTranslateTable(sendingType),
                getFunc = function() return "-" end,
                setFunc = function(value) setAllOptions(value,numProfile,blackSmithingRules) end,
            },
            for _, craftKey in pairs(blackSmithingRules) do  --<-- LINE 351
                optionsTable:insert({
                    type = "dropdown",
                    name = getTranslated(craftKey),
                    choices = getTranslateTable(sendingType),
                    getFunc = function() return getTranslated(BankManager.Saved[craftKey][numProfile]) end,
                    setFunc = function(val) changeTranslateTable(val, craftKey, numProfile) end,
                })
            end
        },
    })

with this error:

Code:

user:/AddOns/BankManagerRevived/UI/BankManagerOpts.lua:351: unexpected symbol near 'for'

Line 351 is line 13 in this cutout. I just don't get it

merlight · 11/19/14, 12:26 PM

You're still failing to understand the basic fact that you cannot put a for loop (or any other non-expression statement, for that matter), into table definition (or any other place where an expression is expected, for that matter).

Lua Code:

optionsTable:insert({ --[17] --> Blacksmithing Rules submenu <--
        type = "submenu",
        name = getTranslated("CRAFTING_TYPE_BLACKSMITHING"),
        controls = {
            {--[17.1]
                    type = "dropdown",
                name = getTranslated("setAllOptions") .."|r",
                tooltip = getTranslated("setAllOptionsTooltip"),
                choices = getTranslateTable(sendingType),
                getFunc = function() return "-" end,
                setFunc = function(value) setAllOptions(value,numProfile,blackSmithingRules) end,
            },
        },
    })
            for _, craftKey in pairs(blackSmithingRules) do
                optionsTable:insert({
                    type = "dropdown",
                    name = getTranslated(craftKey),
                    choices = getTranslateTable(sendingType),
                    getFunc = function() return getTranslated(BankManager.Saved[craftKey][numProfile]) end,
                    setFunc = function(val) changeTranslateTable(val, craftKey, numProfile) end,
                })
            end

SnowmanDK · 11/19/14, 01:12 PM

Originally Posted by merlight

You're still failing to understand the basic fact that you cannot put a for loop (or any other non-expression statement, for that matter), into table definition (or any other place where an expression is expected, for that matter).

Lua Code:

optionsTable:insert({ --[17] --> Blacksmithing Rules submenu <--
        type = "submenu",
        name = getTranslated("CRAFTING_TYPE_BLACKSMITHING"),
        controls = {
            {--[17.1]
                    type = "dropdown",
                name = getTranslated("setAllOptions") .."|r",
                tooltip = getTranslated("setAllOptionsTooltip"),
                choices = getTranslateTable(sendingType),
                getFunc = function() return "-" end,
                setFunc = function(value) setAllOptions(value,numProfile,blackSmithingRules) end,
            },
        },
    })
            for _, craftKey in pairs(blackSmithingRules) do
                optionsTable:insert({
                    type = "dropdown",
                    name = getTranslated(craftKey),
                    choices = getTranslateTable(sendingType),
                    getFunc = function() return getTranslated(BankManager.Saved[craftKey][numProfile]) end,
                    setFunc = function(val) changeTranslateTable(val, craftKey, numProfile) end,
                })
            end

But it works in HarvestMap!?!? That just makes me understand even less

EDIT: you mean I have to move the loop into a function of its own and call that?

merlight · 11/19/14, 03:15 PM

Read carefully. You have to move the for loop out of the table constructor. What works in HarvestMap is valid Lua code, yours isn't.

Sasky showed you what's wrong with your code, Garkin gave you a prefectly valid example, yet you still keep that loop in the table. Just paste what I posted above, with no crap around it. I didn't bother to fix indentation, but the braces are fixed.

Garkin · 11/19/14, 03:16 PM

You can't use for loop in the table definition. You have to close table definition first and then add items to that table.

Lua Code:

optionsTable:insert({ --[17] --> Blacksmithing Rules submenu <--
    type = "submenu",
    name = getTranslated("CRAFTING_TYPE_BLACKSMITHING"),
    controls = setmetatable({}, { __index = table })
})
 
--get reference to the controls table of the last added item (submenu)
local submenuControls = optionsTable[#optionsTable].controls
 
submenuControls:insert({--[17.1]
    type = "dropdown",
    name = getTranslated("setAllOptions") .."|r",
    tooltip = getTranslated("setAllOptionsTooltip"),
    choices = getTranslateTable(sendingType),
    getFunc = function() return "-" end,
    setFunc = function(value) setAllOptions(value,numProfile,blackSmithingRules) end,
})
 
for _, craftKey in pairs(blackSmithingRules) do  --<-- LINE 351
    submenuControls:insert({
        type = "dropdown",
        name = getTranslated(craftKey),
        choices = getTranslateTable(sendingType),
        getFunc = function() return getTranslated(BankManager.Saved[craftKey][numProfile]) end,
        setFunc = function(val) changeTranslateTable(val, craftKey, numProfile) end,
    })
end

SnowmanDK · 11/19/14, 04:13 PM

FINALLY I got it. Thank you guys for all the help

Sorry for being so thickheaded that I didn't understand what you tried to explain earlier.