PreHooking Dialog's OnKeyUp -> Primary + Abort keybinding do not work anymore

[Baertram]

Hey there,

I just tested somethign with a dialog and if I PreHook the OnKeyUp handler for the dialog + set dialog:SetKeyboardEnabled(true) (which is needed so the OnkeyUp method will be recognized at all) the standard keybindings of this dialog won#t work anymore :-(

Any idea to achieve both:
1. Get listener on handler OnKeyUp and execute my own function
2. Get standrd keybindings to work for the accept and abort buttons of this dialog

My idea was:
-Get the keycodes for the primary and abort dialog keys (any function to read this from the settings to get the keycodes in the desired keycode style, e.g. KEY_E for the "e" button?)
-Implement the OnKeyUp function to react on these two keycodes (accept and abort) as well

Only problem is:
If I tried to just execute the "callback" function of the accpet button by my source code I'll get an error because of another addon (Stacked). This is because Stacked already copied the original handler of this dialog's accept button and has implemented an own one. I can't see why the error is thrown but it does

Here is my source code so far:

------------------------------------------------------------------
--FCOGuildBankQuickSelect.lua
--Author: Baertram
--v0.0.1
--[[
Quickly select the guild bank by numbers 1-5 (at an opened guild bank selection)
]]
------------------------------------------------------------------
--Array for all the variables
local locVars = {}
 
--Uncolored "FCOIS" pre chat text for the chat output
locVars.preChatText = "FCOGuildBankQuickSelect"
--Green colored "FCOIS" pre text for the chat output
locVars.preChatTextGreen = "|c22DD22"..locVars.preChatText.."|r "
--Red colored "FCOIS" pre text for the chat output
locVars.preChatTextRed = "|cDD2222"..locVars.preChatText.."|r "
--Blue colored "FCOIS" pre text for the chat output
locVars.preChatTextBlue = "|c2222DD"..locVars.preChatText.."|r "
 
--Addon variables
local addonVars = {}
addonVars.gAddonName                = "FCOGuildBankQuickSelect"
addonVars.addonNameMenu             = "FCO GuildBankQuickSelect"
addonVars.addonNameMenuDisplay      = "|c00FF00FCO |cFFFF00GuildBankQuickSelect|r"
addonVars.addonAuthor               = '|cFFFF00Baertram|r'
addonVars.addonVersion              = 0.01 -- Changing this will reset SavedVariables!
addonVars.addonVersionOptions       = '0.0.1' -- version shown in the settings panel
addonVars.addonSavedVariablesName   = "FCOGuildBankQuickSelect_Settings"
addonVars.gAddonLoaded              = false
 
--Original/Backup avriables
local origVars = {}
origVars.GuildBankSelectorOnKeyDown = nil
origVars.GuildBankSelectorOnKeyUp   = nil
 
--Control names of ZO* standard controls etc.
local GUILDBANK_SELECT_POPUP                = ZO_SelectGuildBankDialog
--local GUILDBANK_SELECT_POPUP_UNDERLAY     = ZO_SelectGuildBankDialogModalUnderlay
local GUILDBANK_SELECT_POPUP_GUILD          = ZO_SelectGuildBankDialogGuild
local GUILDBANK_SELECT_POPUP_GUILD_COMBOBOX = GUILDBANK_SELECT_POPUP_GUILD.m_comboBox
local GUILDBANK_SELECT_POPUP_ACCEPT         = ZO_SelectGuildBankDialogAccept
local GUILDBANK_SELECT_POPUP_ABORT          = ZO_SelectGuildBankDialogCancel
 
--===================== FUNCTIONS ==============================================
 
-- set handlers for keyboard events:
local function FCOGuildBankQuickSelect_HandleKeyboardEvents(self, key, hide)
    if key == KEY_1 or key == KEY_NUMPAD1 then
        if GUILDBANK_SELECT_POPUP_GUILD_COMBOBOX then
            GUILDBANK_SELECT_POPUP_GUILD_COMBOBOX:SelectItemByIndex(1)
        end
    elseif key == KEY_2 or key == KEY_NUMPAD2 then
        if GUILDBANK_SELECT_POPUP_GUILD_COMBOBOX then
            GUILDBANK_SELECT_POPUP_GUILD_COMBOBOX:SelectItemByIndex(2)
        end
    elseif key == KEY_3 or key == KEY_NUMPAD3 then
        if GUILDBANK_SELECT_POPUP_GUILD_COMBOBOX then
            GUILDBANK_SELECT_POPUP_GUILD_COMBOBOX:SelectItemByIndex(3)
        end
    elseif key == KEY_4 or key == KEY_NUMPAD4 then
        if GUILDBANK_SELECT_POPUP_GUILD_COMBOBOX then
            GUILDBANK_SELECT_POPUP_GUILD_COMBOBOX:SelectItemByIndex(4)
        end
    elseif key == KEY_5 or key == KEY_NUMPAD5 then
        if GUILDBANK_SELECT_POPUP_GUILD_COMBOBOX then
            GUILDBANK_SELECT_POPUP_GUILD_COMBOBOX:SelectItemByIndex(5)
        end
    end
    return false
end
 
--un/register guild bank selection popup tweaks
local function registerGuildBankSelectionTweaks(doRegister)
    if doRegister then
        GUILDBANK_SELECT_POPUP:SetKeyboardEnabled(true)
        --Register the OnKeyPressed function for the guild bank select dialog
        ZO_PreHookHandler(GUILDBANK_SELECT_POPUP, 'OnKeyUp', function(self, key, ctrl, alt, shift, command) FCOGuildBankQuickSelect_HandleKeyboardEvents(self, key, true) end)
    else
        --Unregister
        GUILDBANK_SELECT_POPUP_GUILD:SetHandler("OnKeyUp", function(self, key, ctrl, alt, shift, command) origVars.GuildBankSelectorOnKeyUp(self, key, true) end)
    end
end
 
--==============================================================================
--==================== START EVENT CALLBACK FUNCTIONS===========================
--==============================================================================
 
--Event function if guild bank is opened
local function FCOGuildBankQuickSelect_Open_Guild_Bank()
    registerGuildBankSelectionTweaks(true)
end
 
--Event function if guild bank is closed
local function FCOGuildBankQuickSelect_Close_Guild_Bank()
    registerGuildBankSelectionTweaks(false)
end
 
-- Fires each time after addons were loaded and player is ready to move (after each zone change too)
local function FCOGuildBankQuickSelect_Player_Activated(...)
    --Prevent this event to be fired again and again upon each zone change
    EVENT_MANAGER:UnregisterForEvent(addonVars.gAddonName, EVENT_PLAYER_ACTIVATED)
 
    --Backup the original handler
    origVars.GuildBankSelectorOnKeyDown = GUILDBANK_SELECT_POPUP:GetHandler("OnKeyDown")
    origVars.GuildBankSelectorOnKeyUp   = GUILDBANK_SELECT_POPUP:GetHandler("OnKeyUp")
 
    --Set addon loaded = false
    addonVars.gAddonLoaded = false
end
 
--==============================================================================
--===== HOOKS BEGIN ============================================================
--==============================================================================
--Create the hooks & pre-hooks
local function CreateHooks()
--nothing here atm
end
 
--Addon loads up
local function FCOGuildBankQuickSelect_Loaded(eventCode, addOnName)
    --Is this addon found?
    if(addOnName ~= addonVars.gAddonName) then
        return
    end
    --Unregister this event again so it isn't fired again after this addon has beend reckognized
    EVENT_MANAGER:UnregisterForEvent(addonVars.gAddonName, EVENT_ADD_ON_LOADED)
 
    addonVars.gAddonLoaded = true
end
 
-- Register the event "addon loaded" for this addon
local function FCOGuildBankQuickSelect_Initialized()
    EVENT_MANAGER:RegisterForEvent(addonVars.gAddonName, EVENT_ADD_ON_LOADED, FCOGuildBankQuickSelect_Loaded)
    --Register for the zone change/player ready event
    EVENT_MANAGER:RegisterForEvent(addonVars.gAddonName, EVENT_PLAYER_ACTIVATED, FCOGuildBankQuickSelect_Player_Activated)
    --Register for Guild Bank opened & closed
    EVENT_MANAGER:RegisterForEvent(addonVars.gAddonName, EVENT_OPEN_GUILD_BANK, FCOGuildBankQuickSelect_Open_Guild_Bank)
    EVENT_MANAGER:RegisterForEvent(addonVars.gAddonName, EVENT_CLOSE_GUILD_BANK, FCOGuildBankQuickSelect_Close_Guild_Bank)
end
 
 
--------------------------------------------------------------------------------
--- Call the start function for this addon to register events etc.
--------------------------------------------------------------------------------
FCOGuildBankQuickSelect_Initialized()

[Sasky]

Can you register the callback elsewhere or can only one control capture keybinds?

If they all register, use the OnKeyUp event for a different control (either one in scene or add your own to the scene).

[circonian]

There may be a way to avoid the problem entirely, but this would be a simple fix.

Just handle those keys that aren't working yourself:

local function FCOGuildBankQuickSelect_HandleKeyboardEvents(self, key, hide)
...
elseif key == KEY_E then
    ZO_SelectGuildBankDialogAccept:callback()
elseif key == KEY_ALT then
    ZO_SelectGuildBankDialogCancel:callback()
end

[Baertram]

@Circonian Thx. I tried this already (as I've written above) but not everyone is using KEY_E and KEY_ALT as the keybindings for accept or cancel.
Am I able to get the assigned keybindings somehow to react ont eh correct keys? Maybe someone changed it to KEY_G and KEY_CTRL.

And as I said too the addon "stacked" raises an error if I try to call the callback function of the accept button. I'm not sure WHY it does this. It seems to copy the original callback to a backup function, exchange the callback function then with an own one, call the original function and then it's code to refresh some keybindings (so it's a Post-hook).
Maybe I can pre-Hook the callback function of the accept button to avoid the error.

@Sasky
Good idea, I'll see if I can register the keybindings to the scene and then check if the dialog is shown. But I hope it won't disable keybinds of the keybind strip for all teh scene elements this way ^^

[merlight]

Originally Posted by Baertram Am I able to get the assigned keybindings somehow to react ont eh correct keys? Maybe someone changed it to KEY_G and KEY_CTRL.

http://esodata.uesp.net/100010/src/c...ls.lua.html#30

However, I think it'd be better if you got it to work without replacing existing bindings.

[Baertram]

Thx merlight.

I'd love to get this to work but I don't know how? Everytime I enable the SetKeyboardEnabled(true) function the keybindings seem to get disabled :-(
And without this keyboard enabled function I'm not able to react on the keys :-(

Maybe I can get it to work by using the scene somehow.

[circonian]

Oh yeah, my bad. I guess by the time I got done looking at it I forgot you said all of that.

EDIT: Oh yeah, and the reason the buttons stop working when you turn on SetKeyboardEnabled(true) is because if, for example, the chat edit box (to enter chat) had focus & its keyboardEnabled...if it did not block keybind buttons you would start walking & opening all kinds of windows as you typed and those dialog buttons are not keyboardEnabled controls they are called/fired from keybinds.

Here you go:

local DIALOG_PRIMARY
local DIALOG_NEGATIVE
 
 
local function FCOGuildBankQuickSelect_Player_Activated(...)
...
     -- Grabs the key for the binding string name (e, alt, whatever)
    DIALOG_PRIMARY = ZO_Keybindings_GetBindingStringFromAction("DIALOG_PRIMARY")
    DIALOG_NEGATIVE = ZO_Keybindings_GetBindingStringFromAction("DIALOG_NEGATIVE")
...
end
 
 
local function FCOGuildBankQuickSelect_HandleKeyboardEvents(self, key, hide)
...
    -- Convert keycode to actual key so we can compare it to our primary/negative keys
    elseif GetKeyName(key) == DIALOG_PRIMARY then
        ZO_Dialogs_ButtonKeybindPressed("DIALOG_PRIMARY")
    elseif GetKeyName(key) == DIALOG_NEGATIVE then
        ZO_Dialogs_ButtonKeybindPressed("DIALOG_NEGATIVE")
    end
    return false
end

One thing you may (or may not) have thought of (I didn't look at any of the other code) (although unlikely) do you have to worry about if they have changed those primary/negative keybinds to a keypress you are using to switch guilds (KEY_1, KEY_NUMPAD1, exc..)?

PS: I like the easy way of switching guild banks...How about adding scrollWheel support to just scroll the mouse wheel to switch guilds.

[Baertram]

Thanks again. Your method is exactly how I managed to solve it some hours ago ;-)
Oh and I don't think anyone uses the keys 1 to 5 for the keybinds of accept&decline as they are pre-designed to be used for the character's skills. if anyone is using them he/she should report it and I'll start to think about at this time hehe

I was thinking about the scroll wheel too but did not find out how to hook the scroll wheel on that dialog until now. Did not put much effort in it yet, maybe I'll add it in the future.

[circonian]

EDIT: bah, I deleted it. Lets try that again:
You could move the primary/negative key checks to the top, then that way they will get tested first. That way if someone has KEY_NUMPAD1 bound as their primary it would still work and they could still use KEY_1 to change guilds.

local function FCOGuildBankQuickSelect_HandleKeyboardEvents(self, key, hide)
    -- Convert keycode to actual key so we can compare it to our primary/negative keys
    if GetKeyName(key) == DIALOG_PRIMARY then
        ZO_Dialogs_ButtonKeybindPressed("DIALOG_PRIMARY")
    elseif GetKeyName(key) == DIALOG_NEGATIVE then
        ZO_Dialogs_ButtonKeybindPressed("DIALOG_NEGATIVE")
    end
...
end

[Baertram]

Good idea, I'll change this in the next version.
I'm currntly investigating the mouse scrolling but I'm not sure until now how to hook it at the dialog.
Maybe I need to start to listen to all mouse scroll events when then guild select dialog appears (prehook OnShow and set variable to "dialog is active") and then unhook / change variable again if the dialog gets closed.

Ok I got it to work and implemented + released it. You can select your guild by help of the mouse wheel too.

[Baertram]

I got a new problem now. The addon is working so far. Mouse wheel and keyboard keys 1 to 5 will switch the combobox at the guild bank selection popup to the according guild.

The mousewheel is working directly after the 1st time you open the guild bank selector popup.
But the keyboard keys 1 to 5 won#t work at this time?
You'll have to close the dialog and reopen it again. After this the keys are working too.

Currently I hooked the OnShow method of the dialog, prehooked the OnKeyUp function of the dialog and enabled the keyboard then. But it seems that the dialog won't register the OnKeyUp handler's PreHook until you "reload" the dialog (by closing and opening it again)?

Any ideas how to fix this?

Here is the current source code:

------------------------------------------------------------------
--FCOGuildBankQuickSelect.lua
--Author: Baertram
--v0.0.2b
--[[
Quickly select the guild bank by numbers 1-5 (at an opened guild bank selection)
]]
------------------------------------------------------------------
--Array for all the variables
local locVars = {}
 
--Uncolored "FCOIS" pre chat text for the chat output
locVars.preChatText = "FCOGuildBankQuickSelect"
--Green colored "FCOIS" pre text for the chat output
locVars.preChatTextGreen = "|c22DD22"..locVars.preChatText.."|r "
--Red colored "FCOIS" pre text for the chat output
locVars.preChatTextRed = "|cDD2222"..locVars.preChatText.."|r "
--Blue colored "FCOIS" pre text for the chat output
locVars.preChatTextBlue = "|c2222DD"..locVars.preChatText.."|r "
 
--Addon variables
local addonVars = {}
addonVars.gAddonName                 = "FCOGuildBankQuickSelect"
addonVars.addonNameMenu              = "FCO GuildBankQuickSelect"
addonVars.addonNameMenuDisplay       = "|c00FF00FCO |cFFFF00GuildBankQuickSelect|r"
addonVars.addonAuthor                = '|cFFFF00Baertram|r'
addonVars.addonVersion               = 0.01 -- Changing this will reset SavedVariables!
addonVars.addonVersionOptions        = '0.0.2b' -- version shown in the settings panel
addonVars.addonSavedVariablesName    = "FCOGuildBankQuickSelect_Settings"
addonVars.gAddonLoaded               = false
addonVars.hookedGuildSelectDialog    = false
addonVars.currentSelectedGuildNumber = -1
 
--Original/Backup avriables
local origVars = {}
--origVars.GuildBankSelectorOnKeyDown         = nil
origVars.GuildBankSelectorOnKeyUp           = nil
origVars.GuildBankSelectorOnMouseWheelMU    = nil
origVars.GuildBankSelectorOnMouseWheelG     = nil
 
--Control names of ZO* standard controls etc.
local GUILDBANK_SELECT_POPUP                = ZO_SelectGuildBankDialog
local GUILDBANK_SELECT_POPUP_GUILD          = ZO_SelectGuildBankDialogGuild
local GUILDBANK_SELECT_POPUP_GUILD_COMBOBOX = GUILDBANK_SELECT_POPUP_GUILD.m_comboBox
local GUILDBANK_SELECT_POPUP_ACCEPT         = ZO_SelectGuildBankDialogAccept
local GUILDBANK_SELECT_POPUP_ABORT          = ZO_SelectGuildBankDialogCancel
local GUILDBANK_SELECT_POPUP_MODAL_UNDERLAY = ZO_SelectGuildBankDialogModalUnderlay
 
--===================== FUNCTIONS ==============================================
 
--Get the current selected item's index
local function FCOGuildBankQuickSelect_GetCurrentSelectedIndex(comboBoxCtrl)
d("blubb")
    --Check the combobox if the last item is possible in there, otherwise select "All"
    local comboboxItems = comboBoxCtrl.m_sortedItems
    local currentItem   = comboBoxCtrl.m_selectedItemText:GetText()
    if currentItem == nil then return -1 end
    local foundIndex = -1
    if comboboxItems ~= nil then
        for idx, itemTable in pairs(comboboxItems) do
            if itemTable.name == currentItem then
                --item was found, abort here
                foundIndex = idx
                break
            end
        end
    end
    return foundIndex
end
 
--Select the next entry in the guild selection combobox
local function FCOGuildBankQuickSelect_SelectGuildEntry(upDown, newIndex)
    local maxIndex = #GUILDBANK_SELECT_POPUP_GUILD_COMBOBOX.m_sortedItems
    if maxIndex == 0 or maxIndex == nil then return end
    newIndex = newIndex or -1
    if newIndex ~= nil and newIndex ~= -1 and newIndex >= 1 and newIndex <= maxIndex then
        --Set the given new index
        if GUILDBANK_SELECT_POPUP_GUILD_COMBOBOX then
            GUILDBANK_SELECT_POPUP_GUILD_COMBOBOX:SelectItemByIndex(newIndex)
        end
    else
        if upDown == nil then return end
        --Get the next index by help of the upDown variable coming from the mouse wheel capture
        --Get the current selected item index first
        local currentIndex = addonVars.currentSelectedGuildNumber
        if currentIndex == -1 then
            currentIndex = FCOGuildBankQuickSelect_GetCurrentSelectedIndex(GUILDBANK_SELECT_POPUP_GUILD_COMBOBOX)
        end
        if currentIndex == nil or currentIndex == -1 or currentIndex < 1 or currentIndex > maxIndex then return end
        --Scrolled up?
        local newIndexToUse = -1
        if upDown then
            newIndexToUse = currentIndex - 1
        else
        --Scrolled down?
            newIndexToUse = currentIndex + 1
        end
        --Did we scroll to the first index and below, then use maximum index
        if newIndexToUse < 1 then
            newIndexToUse = maxIndex
        end
        --Did we scroll to the last index and above, then use minimum index
        if newIndexToUse > maxIndex then
            newIndexToUse = 1
        end
        if newIndexToUse ~= -1 then
            GUILDBANK_SELECT_POPUP_GUILD_COMBOBOX:SelectItemByIndex(newIndexToUse)
            addonVars.currentSelectedGuildNumber = newIndexToUse
        end
    end
end
 
--Get the information about the pressed key and map it to a keybind
local function FCOGuildBankQuickSelect_GetKeybindByPressedKey(key)
    local actionNameAccept = "DIALOG_PRIMARY"
    local actionNameDecline = "DIALOG_NEGATIVE"
 
    --KEYBIND_TEXT_OPTIONS_ABBREVIATED_NAME = 1
    --KEYBIND_TEXT_OPTIONS_FULL_NAME = 2
    --KEYBIND_TEXT_OPTIONS_FULL_NAME_SEPARATE_MODS = 3
    local textOptions = KEYBIND_TEXT_OPTIONS_ABBREVIATED_NAME
    --KEYBIND_TEXTURE_OPTIONS_NONE = 1
    --KEYBIND_TEXTURE_OPTIONS_EMBED_MARKUP = 2
    local textureOptions = KEYBIND_TEXTURE_OPTIONS_NONE
    local bindingIndexAccept = 1  --1 or 2, primary or secondary binding
    local bindingIndexDecline = 1  --1 or 2, primary or secondary binding
    local bindingStringAccept = ZO_Keybindings_GetBindingStringFromAction(actionNameAccept, textOptions, textureOptions, bindingIndexAccept)
    local bindingStringDecline = ZO_Keybindings_GetBindingStringFromAction(actionNameDecline, textOptions, textureOptions, bindingIndexDecline)
 
--d("bindingStringAccept: " .. tostring(bindingStringAccept))
--d("bindingStringDecline: " .. tostring(bindingStringDecline))
--d("Key: " .. tostring(key) .. "(".. GetKeyName(key) .. ")")
    if GetKeyName(key) == bindingStringAccept then
        return 1
    elseif GetKeyName(key) == bindingStringDecline then
        return 2
    else
        return -1
    end
end
 
-- set handlers for the mouse wheel
local function FCOGuildBankQuickSelect_HandleMouseWheelEvents(doRegister)
    doRegister = doRegister or false
    if doRegister then
        GUILDBANK_SELECT_POPUP_MODAL_UNDERLAY:SetMouseEnabled(true)
        GUILDBANK_SELECT_POPUP_MODAL_UNDERLAY:SetHandler("OnMouseWheel", function(self, delta, ctrl, alt, shift)
            if delta < 0 then
                -- Mouse wheel down
                FCOGuildBankQuickSelect_SelectGuildEntry(false, nil)
            else
                -- Mouse wheel up
                FCOGuildBankQuickSelect_SelectGuildEntry(true, nil)
            end
        end)
        GUILDBANK_SELECT_POPUP_GUILD:SetMouseEnabled(true)
        GUILDBANK_SELECT_POPUP_GUILD:SetHandler("OnMouseWheel", function(self, delta, ctrl, alt, shift)
            if delta < 0 then
                -- Mouse wheel down
                FCOGuildBankQuickSelect_SelectGuildEntry(false, nil)
            else
                -- Mouse wheel up
                FCOGuildBankQuickSelect_SelectGuildEntry(true, nil)
            end
        end)
    else
        if origVars.GuildBankSelectorOnMouseWheelMU and origVars.GuildBankSelectorOnMouseWheelMU ~= nil then
            --Use original handler for the mousewheel again
            GUILDBANK_SELECT_POPUP_MODAL_UNDERLAY:SetHandler("OnMouseWheel", function(self, delta, ctrl, alt, shift)
                origVars.GuildBankSelectorOnMouseWheelMU(self, delta, ctrl, alt, shift)
            end)
        end
        if origVars.GuildBankSelectorOnMouseWheelG and origVars.GuildBankSelectorOnMouseWheelG ~= nil then
            GUILDBANK_SELECT_POPUP_GUILD:SetHandler("OnMouseWheel", function(self, delta, ctrl, alt, shift)
                origVars.GuildBankSelectorOnMouseWheelG(self, delta, ctrl, alt, shift)
            end)
        end
    end
end
 
-- set handlers for keyboard events:
local function FCOGuildBankQuickSelect_HandleKeyboardEvents(self, key, ctrl, alt, shift, command)
    --Check if the keybinding for accept or decline (or key ESCAPE) were pressed
    local pressedKeyMappedToKeybindKey = -1
    if key ~= KEY_ESCAPE then
        pressedKeyMappedToKeybindKey = FCOGuildBankQuickSelect_GetKeybindByPressedKey(key)
    end
    if key == KEY_ESCAPE or pressedKeyMappedToKeybindKey ~= -1 then
        if pressedKeyMappedToKeybindKey == 1 then
            if GUILDBANK_SELECT_POPUP_ACCEPT.clickSound ~= nil then
                PlaySound(GUILDBANK_SELECT_POPUP_ACCEPT.clickSound)
            else
                PlaySound(SOUNDS.DIALOG_ACCEPT)
            end
            GUILDBANK_SELECT_POPUP_ACCEPT:callback()
        elseif key == KEY_ESCAPE or pressedKeyMappedToKeybindKey == 2 then
            if GUILDBANK_SELECT_POPUP_ABORT.clickSound ~= nil then
                PlaySound(GUILDBANK_SELECT_POPUP_ABORT.clickSound)
            else
                PlaySound(SOUNDS.DIALOG_DECLINE)
            end
            GUILDBANK_SELECT_POPUP_ABORT:callback()
        end
    else
        --Check for the pressed key 1 to 5 or numpad 1 to 5 and change the guild accordingly
        if key == KEY_1 or key == KEY_NUMPAD1 then
            FCOGuildBankQuickSelect_SelectGuildEntry(nil, 1)
        elseif key == KEY_2 or key == KEY_NUMPAD2 then
            FCOGuildBankQuickSelect_SelectGuildEntry(nil, 2)
        elseif key == KEY_3 or key == KEY_NUMPAD3 then
            FCOGuildBankQuickSelect_SelectGuildEntry(nil, 3)
        elseif key == KEY_4 or key == KEY_NUMPAD4 then
            FCOGuildBankQuickSelect_SelectGuildEntry(nil, 4)
        elseif key == KEY_5 or key == KEY_NUMPAD5 then
            FCOGuildBankQuickSelect_SelectGuildEntry(nil, 5)
        end
    end
    return false
end
 
--
local function FCOGuildBankQuickSelect_ChangeTweaks(doRegister)
    if doRegister then
        if GUILDBANK_SELECT_POPUP ~= nil then
            --Register the OnKeyUp function for the guild bank select dialog
            ZO_PreHookHandler(GUILDBANK_SELECT_POPUP, 'OnKeyUp', function(self, key, ctrl, alt, shift, command) FCOGuildBankQuickSelect_HandleKeyboardEvents(self, key, ctrl, alt, shift, command) end)
            --GUILDBANK_SELECT_POPUP:SetHandler("OnKeyUp", function(self, key, ctrl, alt, shift, command) FCOGuildBankQuickSelect_HandleKeyboardEvents(self, key, ctrl, alt, shift, command) end)
            FCOGuildBankQuickSelect_HandleMouseWheelEvents(true)
            GUILDBANK_SELECT_POPUP:SetKeyboardEnabled(true)
            addonVars.hookedGuildSelectDialog = true
        end
    else
    if GUILDBANK_SELECT_POPUP ~= nil then
        --Unregister OnKeyUp callback
        if origVars.GuildBankSelectorOnKeyUp and origVars.GuildBankSelectorOnKeyUp ~= nil then
            GUILDBANK_SELECT_POPUP:SetHandler("OnKeyUp", function(self, key, ctrl, alt, shift, command) origVars.GuildBankSelectorOnKeyUp(self, key, ctrl, alt, shift, command) end)
        end
        FCOGuildBankQuickSelect_HandleMouseWheelEvents(false)
        GUILDBANK_SELECT_POPUP:SetKeyboardEnabled(false)
        addonVars.hookedGuildSelectDialog = false
        end
    end
end
 
--un/register guild bank selection popup tweaks
local function registerGuildBankSelectionTweaks(doRegister, doOverride)
    doOverride = doOverride or false
    --If no guilds are given the functions make no sense here, so abort everything
    local maxIndex = -1
    if not doOverride then
        if GUILDBANK_SELECT_POPUP_GUILD_COMBOBOX ~= nil then
            maxIndex = #GUILDBANK_SELECT_POPUP_GUILD_COMBOBOX.m_sortedItems
        end
        if maxIndex == nil or maxIndex < 1 then
            --Unregister existing tweaks now
            FCOGuildBankQuickSelect_ChangeTweaks(false)
            --Abort here as no guilds are enabled
            return false
        end
    end
    --Enable or disable the tweaks now
    FCOGuildBankQuickSelect_ChangeTweaks(doRegister)
end
 
--==============================================================================
--==================== START EVENT CALLBACK FUNCTIONS===========================
--==============================================================================
 
--[[
--Event function if guild bank is opened
local function FCOGuildBankQuickSelect_Open_Guild_Bank()
    if not addonVars.hookedGuildSelectDialog then
        registerGuildBankSelectionTweaks(true, false)
    end
end
]]
 
--Event function if guild bank is closed
local function FCOGuildBankQuickSelect_Close_Guild_Bank()
    if addonVars.hookedGuildSelectDialog then
        registerGuildBankSelectionTweaks(false, false)
    end
end
 
--PreHook the OnShow callback function of the guildbank select dialog
local function FCOGuildBankQuickSelect_PreHookGuildSelectDialogOnShow(self)
    --Reset the variable for the currently selected guild index
    addonVars.currentSelectedGuildNumber = -1
    if not addonVars.hookedGuildSelectDialog then
        registerGuildBankSelectionTweaks(true, false)
    end
end
 
-- Fires each time after addons were loaded and player is ready to move (after each zone change too)
local function FCOGuildBankQuickSelect_Player_Activated(...)
    --Prevent this event to be fired again and again upon each zone change
    EVENT_MANAGER:UnregisterForEvent(addonVars.gAddonName, EVENT_PLAYER_ACTIVATED)
 
    --Backup the original handlers
    --origVars.GuildBankSelectorOnKeyDown      = GUILDBANK_SELECT_POPUP:GetHandler("OnKeyDown")
    origVars.GuildBankSelectorOnKeyUp        = GUILDBANK_SELECT_POPUP:GetHandler("OnKeyUp")
    origVars.GuildBankSelectorOnMouseWheelMU = GUILDBANK_SELECT_POPUP_MODAL_UNDERLAY:GetHandler("OnMouseWheel")
    origVars.GuildBankSelectorOnMouseWheelG  = GUILDBANK_SELECT_POPUP_GUILD:GetHandler("OnMouseWheel")
 
    --PreHook the OnShow handler for the guild bank select dialog
    ZO_PreHookHandler(GUILDBANK_SELECT_POPUP, 'OnShow', function(self) FCOGuildBankQuickSelect_PreHookGuildSelectDialogOnShow(self) end)
 
    --Set addon loaded = false
    addonVars.gAddonLoaded = false
end
 
--==============================================================================
--===== HOOKS BEGIN ============================================================
--==============================================================================
--Create the hooks & pre-hooks
local function CreateHooks()
--nothing here atm
end
 
--Addon loads up
local function FCOGuildBankQuickSelect_Loaded(eventCode, addOnName)
    --Is this addon found?
    if(addOnName ~= addonVars.gAddonName) then
        return
    end
    --Unregister this event again so it isn't fired again after this addon has beend reckognized
    EVENT_MANAGER:UnregisterForEvent(addonVars.gAddonName, EVENT_ADD_ON_LOADED)
 
    --Register for Guild Bank opened & closed
    --EVENT_MANAGER:RegisterForEvent(addonVars.gAddonName, EVENT_OPEN_GUILD_BANK, FCOGuildBankQuickSelect_Open_Guild_Bank)
    EVENT_MANAGER:RegisterForEvent(addonVars.gAddonName, EVENT_CLOSE_GUILD_BANK, FCOGuildBankQuickSelect_Close_Guild_Bank)
 
    addonVars.gAddonLoaded = true
end
 
-- Register the event "addon loaded" for this addon
local function FCOGuildBankQuickSelect_Initialized()
    EVENT_MANAGER:RegisterForEvent(addonVars.gAddonName, EVENT_ADD_ON_LOADED, FCOGuildBankQuickSelect_Loaded)
    --Register for the zone change/player ready event
    EVENT_MANAGER:RegisterForEvent(addonVars.gAddonName, EVENT_PLAYER_ACTIVATED, FCOGuildBankQuickSelect_Player_Activated)
end
 
 
--------------------------------------------------------------------------------
--- Call the start function for this addon to register events etc.
--------------------------------------------------------------------------------
FCOGuildBankQuickSelect_Initialized()

[circonian]

I glanced at the code, don't have much time have to leave for work soon...but will look at it later when I get home.
I only glanced at it and didn't have time to look for the thing you actually asked about....but I can say a couple of things I noticed so far:
I did not test any of this and didn't have much time to look at the code, so I might have overlooked something or made a type-o.

registerGuildBankSelectionTweaks

This entire function seems desgined to determine if there is more than one guild in the popup guild selector drop down box and if so to enable your addons selection tweaks. Correct?

Couldn't this replace that entire function?

GetNumGuilds()

The number of guilds that they are in, will be the number of guilds in that pop-up box right?

This might also make your life easier. I see a lot of manipulation with the combo box & other things to mess with getting/setting the selected guild. You don't need to do any of that, I believe this will allow you to eliminate a LOT of code...you can use:

GetSelectedGuildBankId()
SelectGuildBank(guildId)

Again I only glanced at it, but I think those few things could take place of several functions it looks like. Here are a coupld of examples:

-- Instead of all of the code in: registerGuildBankSelectionTweaks
-- Notice this code does so little it may (or may not i didn't look where its called from) not even be necessary:
-- also note:
-- I used < 2, because if there is only 1 guild to select from, theres no need to scroll or select anything
-- The 1 & ONLY guild your in will already be selected and there is no other guild to select so there is
-- no need for your code to be running
-- I left out the doOverride, because I didn't see it get called anywhere with doOverride == true
-- and I didn't have enough time to look at it further.
local function registerGuildBankSelectionTweaks(doRegister)
   if GetNumGuilds() < 2 then 
       FCOGuildBankQuickSelect_ChangeTweaks(false)
   return false 
   end
 
   --Enable or disable the tweaks now
   FCOGuildBankQuickSelect_ChangeTweaks(true)
end

I see a lot of code dealing with the last index of the combo box. I'm guessing that allows the user to scroll from the last guild in the list to the first. You could probably get rid of that function entirely...and replace it with something like this:

-- I would just pass the scroll wheels delta directly to this function (or just get rid of it entirely).
-- Note: For keypresses you can just call SelectGuildBank(guildId) inside of  FCOGuildBankQuickSelect_HandleKeyboardEvents
--    Where the guildId's are the order they appear in, the same numbers your grabbing anyhow: 1, 2, 3, 4
-- GetSelectedGuildBankId() gives us the currently selected guild bank id. They are numberd 1 to GetNumGuilds()
-- GetSelectedGuildBankId-1 changes the table indices to start at 0 (to match the modulus results)
-- The delta, can just be added to that selected guild id
-- the % is the modulus symbol:   a % b, divides a by b and then gives us the remainder.
-- It would handle scrolling from the end of the list to the beginning of the list, and vice-versa, for you.
-- the +1 on the end switches it back to base 1, giving us a range from 1 to numGuilds
local function FCOGuildBankQuickSelect_SelectGuildEntry(delta)
    local numGuilds = GetNumGuilds() 
    local newIndex = (GetSelectedGuildBankId() - 1  + delta) % numGuilds + 1
 
    SelectGuildBank(newIndex)
end

[Baertram]

Thx for the info about GetNumGuilds() and the other functions.

One question:
SelectGuildBank(guild id)

Will this change the guild bank directly or do I have to accept the selected guild before it changes it?

[circonian]

Originally Posted by Baertram Thx for the info about GetNumGuilds() and the other functions. One question: SelectGuildBank(guild id) Will this change the guild bank directly or do I have to accept the selected guild before it changes it?

EDIT: My bad I thought i tested this earlier.....SelectGuildBank(..) does apparently automatically change the guild bank. I just tried it again & it does.

Also I don't think you need these. They return nil, so I don't think they have those handlers by default, so I don't think theres anything to restore later.

origVars.GuildBankSelectorOnKeyUp        = GUILDBANK_SELECT_POPUP:GetHandler("OnKeyUp")
origVars.GuildBankSelectorOnMouseWheelG  = GUILDBANK_SELECT_POPUP_GUILD:GetHandler("OnMouseWheel")

[circonian]

Originally Posted by Baertram Thx for the info about GetNumGuilds() and the other functions. One question: SelectGuildBank(guild id) Will this change the guild bank directly or do I have to accept the selected guild before it changes it?

When I got home and had a better chance to look at everything I decided that these:

GetSelectedGuildBankId()
SelectGuildBank(guildId)

Are not the best solution. I sent you a PM about it.

[Baertram]

I've just added them so they will be compatible in the future with other addons playing around with these functions. But as I replace them with mine they shouldn't be necessary I guess, you are right

Originally Posted by circonian EDIT: My bad I thought i tested this earlier.....SelectGuildBank(..) does apparently automatically change the guild bank. I just tried it again & it does. Also I don't think you need these. They return nil, so I don't think they have those handlers by default, so I don't think theres anything to restore later. origVars.GuildBankSelectorOnKeyUp        = GUILDBANK_SELECT_POPUP:GetHandler("OnKeyUp") origVars.GuildBankSelectorOnMouseWheelG  = GUILDBANK_SELECT_POPUP_GUILD:GetHandler("OnMouseWheel")