Request: Identify crafted potions.

[Jhenox]

I'd like to request an add on that will add a marker of some sort or tooltip note to differentiate crafted (and/or my crafted potions_ potions from looted potions. I think Zenimax should have added this long ago but I keep crafting potions for writs then they get mixed in with looted ones. Normally I can tell with a little effort by looking for the effects but the Wrothgar pots seem close to my crafted potions. Thank you.

[Ayantir]

I will write something quick as we already found how to detect a crafted pot

hmm I did this which works.. but..
as long as inventory don't use thoses functions to get quality, but SHARED_INVENTORY.bagcache[bagId][slotId].quality (and PLAYER_INVENTORY), we could rewrite the tooltips itself.. If someone else wants do something. it shouldn't be hard.

just rewrite a bit GetItemLinkTraitOnUseAbilityInfo() maybe. But it should be better to try to continue to modify the quality I guess.

local original_GetItemQuality = GetItemQuality
GetItemQuality = function(bagId, slotId)
    if GetItemType(bagId, slotId) == ITEMTYPE_POTION then
        local itemLink = GetItemLink(bagId, slotId)
        if select(24, ZO_LinkHandler_ParseLink(itemLink)) ~= "0" then
            
            local quality = ITEM_QUALITY_NORMAL
            for i = 1, GetMaxTraits() do
                
                local hasTraitAbility = GetItemLinkTraitOnUseAbilityInfo(itemLink, i)
                
                if(hasTraitAbility) then
                    quality = quality + 1
                end
                
            end
            
            if quality == ITEM_QUALITY_NORMAL then
                quality = ITEM_QUALITY_MAGIC
            end
            
            return quality
        
        end
    end
    return original_GetItemQuality(bagId, slotId)
end
 
local original_GetItemLinkQuality = GetItemLinkQuality
GetItemLinkQuality = function(itemLink)
    if GetItemLinkItemType(itemLink) == ITEMTYPE_POTION then
        if select(24, ZO_LinkHandler_ParseLink(itemLink)) ~= "0" then
            
            local quality = ITEM_QUALITY_NORMAL
            for i = 1, GetMaxTraits() do
                
                local hasTraitAbility = GetItemLinkTraitOnUseAbilityInfo(itemLink, i)
                
                if(hasTraitAbility) then
                    quality = quality + 1
                end
                
            end
            
            if quality == ITEM_QUALITY_NORMAL then
                quality = ITEM_QUALITY_MAGIC
            end
            
            return quality
        
        end
    end
    return original_GetItemLinkQuality(itemLink)
end

[merlight]

There was a request on eso forums to differentiate crafted potions in inventory. I have something thrown in my "misc tweaks and dirty hacks add-on" ... not sure when I'll force myself to push it out

[Ayantir]

http://www.esoui.com/downloads/info1...edPotions.html

I still need to :

• Force quality on tooltip
• Force quality in trading house

But it's a good begening

[Baertram]

And force quality at quickslot too please! This would be great.

[merlight]

I looked around and couldn't find a way to override quality on tooltip. It doesn't seem to use GetItemInfo or GetItemLinkQuality, and the title child control is inaccessible.

[Ayantir]

Yes keyboard tooltips only parse itemlink and there is no way to modify it, we should add an item into the db, that's not possible.

I'll look a bit deeply to tooltip control, last time I didn't succeeded to access to whole part of tooltip (same as you I guess, found the sellprice. it must be somewhere, but still don't know.



I need to recheck but think Keyboard use esoui\ingame\tooltip\tooltip.xml (and ItemTooltipBase). there is some function to play with here.

[Ayantir]

I've rechecked, that's nearly impossible to do. Keyboard tooltips come from an hidden place that we cannot access.

To build a keyboard tooltip, game just do a TooltipControl:method(), control can be ItemTooltip, PopupTooltip, etc

Methods are thoses of the object type "TooltipControl" (CT_TOOLTIP)

And controls are defined in the c++ side of the game.

Just try by doing a :

/script PopupTooltip:ClearLines();PopupTooltip:SetLink("|H1:item:56490:370:50:26841:370:50:0:0:0:0:0:0:0:0:0:28:1:1:0:464:0|h|h");PopupTooltip:SetHidden(false)

It will show you my sword

Inside SetLink() is used the equivalent of the Lua function we use to get info, ~ same as Lua but in C++.

The other way to do it is to change itemlink passed as argument by another one. I should need an itemlink builder and hope that ZOS added something in their intemlink engine builder to change quality of potions.
, but changing the itemlink will broke a lot of things, quantity displayed in bags, bank, addons which look at the itemlink, maybe values of the potions, etc. It's a hard work for maybe nothing relevant and too much modification for a so little tweak that ZOS could do easily.

The last possibility will be to rebuild ItemTooltip & PopupTooltip themselves by another thing, like GamepadUI does.
That's a lot of work for just a tweak, even, if I already rewrited complete tooltips (ability ones) in another addon, rewriting ItemTootip and PopupTooltip will need me to rewrite entirely the equivalent of esoui\ingame\tooltip folder which is for 90% of its code devoted to GamepadUI and needed for this modification

idk

in better glyph tooltip for example we have this:

SafeAddString(SI_ITEM_FORMAT_STR_DERIVED_STAT,
zo_strjoin(nil, " |u32:0::|u", prefix, value, suffix, " |t100:25:BetterGlyphTooltip/Assets/Head_Chest_Legs_Shield.dds|t\n", " |u32:0::|u", prefix, math.floor(value * 0.405), suffix, " |t100:25:BetterGlyphTooltip/Assets/Feet_Hands_Shoulders_Waist.dds|t"),

thats working to edit the content

have you tried the same with SI_TOOLTIP_ITEM_NAME and "|c"..yourcolorpack:ToHex()..GetItemLinkName(itemLink).."|r" in a tooltip hook ?

Edit : tests peinture rose with a copy pasta of Better Glyph Tooltip (based on crit% de Garkin) code and a few modifs

Warning: Spoiler

local colorpack = ZO_ColorDef:New(1,0,.33,1)  
 
local function ModifyTooltip(self, itemLink)
    if GetItemLinkItemType(itemLink) ~= ITEMTYPE_POTION then return end
    if select(24, ZO_LinkHandler_ParseLink(itemLink)) ~= "0" then
        local newname = "|c"..colorpack:ToHex()..zo_strformat(SI_TOOLTIP_ITEM_NAME,GetItemLinkName(itemLink)).."|r"
        SafeAddString(SI_TOOLTIP_ITEM_NAME, newname)
    end
end
     
    local function TooltipHook(tooltipControl, method, linkFunc)
      local origMethod = tooltipControl[method]     
      tooltipControl[method] = function(self, ...)
        local orgText = GetString(SI_TOOLTIP_ITEM_NAME)
        local itemLink = linkFunc(...)
        ModifyTooltip(tooltipControl, itemLink)
        origMethod(self, ...)
        SafeAddString(SI_TOOLTIP_ITEM_NAME, orgText)
      end
    end
     
    local function ReturnItemLink(itemLink)
      return itemLink
    end
     
    local function OnAddOnLoaded(eventCode, addonName)
      if addonName ~= "PinkPots" then return end
      EVENT_MANAGER:UnregisterForEvent("PinkPots", eventCode)
     local function DelayHooks()
          TooltipHook(ItemTooltip, "SetBagItem", GetItemLink)
          TooltipHook(ItemTooltip, "SetTradeItem", GetTradeItemLink)
          TooltipHook(ItemTooltip, "SetBuybackItem", GetBuybackItemLink)
          TooltipHook(ItemTooltip, "SetStoreItem", GetStoreItemLink)
          TooltipHook(ItemTooltip, "SetAttachedMailItem", GetAttachedItemLink)
          TooltipHook(ItemTooltip, "SetLootItem", GetLootItemLink)
          TooltipHook(ItemTooltip, "SetTradingHouseItem", GetTradingHouseSearchResultItemLink)
          TooltipHook(ItemTooltip, "SetTradingHouseListing", GetTradingHouseListingItemLink)
          TooltipHook(ItemTooltip, "SetLink", ReturnItemLink)        
          TooltipHook(PopupTooltip, "SetLink", ReturnItemLink)       
          -- bla bla probably alchi station too
     end
     zo_callLater(DelayHooks,15000)
    end
    EVENT_MANAGER:RegisterForEvent("PinkPots", EVENT_ADD_ON_LOADED, OnAddOnLoaded)

I've delayed to write the tooltip the last, not sure if it is useful. the change should be included in tooltips modified after this one. I was afraid they would use the non Hi-jacked SI_TOOLTIP_ITEM_NAME during the process but nope, they shouldn't.

[Ayantir]

Hey.. Nice catch. I'll look at it.

[circonian]

For the inventory you could also set an icon to show that it is crafted.


That's easy enough.


For the tooltip, you could add a line to the bottom of the tooltip, although I didn't really like that Idea. As for accessing the tooltip information I couldn't find a way either. But I did manage to come up with this very hacky method to do what I wanted (it could be used to replace or add to "some" of the other information on the tooltip as well).



EDIT: Localized the word "Potion" & Fixed a bug.

Warning: Spoiler

local ORIGINAL_SI_ITEMTYPE7 = SI_ITEMTYPE7
 
local potionString = zo_strformat("|t32:32:<<1>>|t <<2>>", "/esoui/art/crafting/alchemy_tabicon_solvent_up.dds", GetString("SI_ITEMTYPE", ITEMTYPE_POTION))
 
ZO_CreateStringId("CRAFTED_SI_ITEMTYPE7", potionString)
 
local function SetPotionSI(toolTip, bagId, slotIdOrTradingHouseSlotIndex)
    local itemLink
    if bagId then
        itemLink = GetItemLink(bagId, slotIdOrTradingHouseSlotIndex)
    elseif TRADING_HOUSE:IsAtTradingHouse() then
        if TRADING_HOUSE.m_searchResultsList and TRADING_HOUSE.m_searchResultsList.data and TRADING_HOUSE.m_searchResultsList.data[slotIdOrTradingHouseSlotIndex] then
            itemLink = GetTradingHouseSearchResultItemLink(slotIdOrTradingHouseSlotIndex)
        end
    end
    
    if GetItemLinkItemType(itemLink) ~= ITEMTYPE_POTION then return end
    
    if select(24, ZO_LinkHandler_ParseLink(itemLink)) ~= "0" then
        SI_ITEMTYPE7 = CRAFTED_SI_ITEMTYPE7
        return true
    end
end
 
local function ResetPotionSI(wasChanged)
    if not wasChanged then return end
    
    SI_ITEMTYPE7 = ORIGINAL_SI_ITEMTYPE7
end
 
local function SetItemTooltipCallbacks()
    local hSetBagItem = ItemTooltip.SetBagItem
    ItemTooltip.SetBagItem = function(control, bagId, slotIndex, ...)
        local wasChanged = SetPotionSI(control, bagId, slotIndex)
        hSetBagItem(control, bagId, slotIndex, ...)
        ResetPotionSI(wasChanged)
    end
    
    local hSetTradingHouseBagItem = ItemTooltip.SetTradingHouseItem
    ItemTooltip.SetTradingHouseItem = function(control, tradingHouseSlotIndex, ...)
        local wasChanged = SetPotionSI(control, nil, tradingHouseSlotIndex)
        hSetTradingHouseBagItem(control, tradingHouseSlotIndex, ...)
        ResetPotionSI(wasChanged)
    end
end
 
-------------------------------------------------------------------
--  On Player Activation  --
-------------------------------------------------------------------
local function OnPlayerActivated()  
    SetItemTooltipCallbacks()
end

[Ayantir]

So I succesfully rewrited all tooltips, except (I think) one :

The one displayed when you're in Quickslot Inventory and hover a potion in the Quickslot wheel.
It should be ItemTooltip, but seems, it's not this one.


If I /zgoo the potion, it's ZO_QuickSlotXButton (ex: ZO_QuickSlot9Button)
which have a sub key .activeTooltip = ItemTooltip

If I do a ItemTooltip:SetHidden(true), the tooltip is well hidden/displayed, but any of the functions used is setting the tooltip.

It shouldbe something like ItemTooltip:SetSlotItem(slotIndex), but it doesn't seems to exists.

[merlight]

Originally Posted by Ayantir It shouldbe something like ItemTooltip:SetSlotItem(slotIndex), but it doesn't seems to exists.

Went through ZO_QuickslotManager and got here: http://esodata.uesp.net/current/src/...ip.lua.html#44

you probably already got this now, but in case

TooltipHook(ItemTooltip, "SetAction", GetSlotItemLink) with same model as previous post


or

orgfunc = ItemTooltip.SetAction
ItemTooltip.SetAction = function(control,...)
   itemLink = GetSlotItemLink(...)
   doyourstuff(itemLink)
   orgfunc (...)
   undoyourstuff()
end

works for the selected A quicklot too.

[Jhenox]

You guys are awesome! Thank you!