Problem with Destinations

SnowmanDK · 11/13/14, 12:16 PM

I am stuck on a problem trying to make Destinations compatible with MiniMap by Fyrakin.
My "Semi-Real" pins was made in a very dirty way earlier.
Now I want to add them correctly like this (short example):

Lua Code:

LMP:AddPinType(PINS_REALUNKNOWNQUESTHUB, MapCallback_unknown, nil, pinLayout_RealUnknownQuestHub, pinTooltipCreator)
    local pinLayout_RealUnknownCrafting = {
        level = pinTextureLevelUnknown,
        texture = pinTextures.unknownrealpins[9],
        size = pinTextureSizeUnknown,
    }
    LMP:AddPinType(PINS_REALUNKNOWNCRAFTING, MapCallback_unknown, nil, pinLayout_RealUnknownCrafting, pinTooltipCreator)
    local pinLayout_RealUnknownSoloDungeon = {
        level = pinTextureLevelUnknown,
        texture = pinTextures.unknownrealpins[10],
        size = pinTextureSizeUnknown,
    }

The poiTypeId sets the pin type used below, ending with creating the pins.

Lua Code:

if poiTypeId == 1 then
                        pinType = PINS_REALUNKNOWNWAYSHRINE
                        local data = GuildTraderDataStore[GetCurrentMapZoneIndex()]
                        if not data then return end
                        for _, pinData in ipairs(data) do
                            local ID = pinData[GuildTraderDataIndex.ID]
                            if ID == 1 then
                                local WAYSHRINE = pinData[GuildTraderDataIndex.WAYSHRINE]
                                if WAYSHRINE == objectiveName then
                                    table.insert(pinTag, 3, zo_strformat("|c666666<<t:1>>|r", GetString(POITYPE_GUILDTRADERS)))
                                    pinType = PINS_REALUNKNOWNWAYSHRINETRADER
                                end
                            end
                        end
                    elseif poiTypeId == 2 then
                        pinType = PINS_REALUNKNOWNAOI
                    elseif poiTypeId == 3 and zoneIndex ~= 353 then
                        pinType = PINS_REALUNKNOWNPUBLICDUNGEON
                    elseif poiTypeId == 3 and zoneIndex == 353 then
                        pinType = PINS_REALUNKNOWNPUBLICDUNGEON2
                    elseif poiTypeId == 4 then
                        pinType = PINS_REALUNKNOWNMUNDUS
                    elseif poiTypeId == 5 then
                        pinType = PINS_REALUNKNOWNDOLMEN
                    elseif poiTypeId == 6 then
                        pinType = PINS_REALUNKNOWNGROUPBOSS
                    elseif poiTypeId == 7 then
                        pinType = PINS_REALUNKNOWNGROUPDUNGEON
                    elseif poiTypeId == 8 then
                        pinType = PINS_REALUNKNOWNQUESTHUB
                    elseif poiTypeId == 9 then
                        pinType = PINS_REALUNKNOWNCRAFTING
                    elseif poiTypeId == 10 then
                        pinType = PINS_REALUNKNOWNSOLODUNGEON
                    elseif poiTypeId == 11 then
                        pinType = PINS_REALUNKNOWNGROUPEVENT
                    elseif poiTypeId == 12 then
                        pinType = PINS_REALUNKNOWNGROUPDELVE
                    elseif poiTypeId == 13 then
                        pinType = PINS_REALUNKNOWNTRIAL
                    elseif poiTypeId == 14 then
                        pinType = PINS_REALUNKNOWNGUILDTRADER
                    elseif poiTypeId == 22 then
                        pinType = PINS_REALUNKNOWN
                    end
                end
                LMP:CreatePin(pinType, pinTag, normalizedX, normalizedY)

The pins are shown correctly , but (I assume) as they all use the same pinTooltipCreator, then I get the tag on each pin shown multiple times, like this:

It is ONLY the unknown pins that do this and ONLY those using my "Semi_Real" pins.
Any help will be appreciated

Garkin · 11/13/14, 02:48 PM

Destinations addon uses pinTag for tooltips - pinTag contains table (array) of strings, each string is one text line on the tooltip. In your code is nothing what adds text to the tooltip. Can you post whole function?

SnowmanDK · 11/13/14, 02:52 PM

Originally Posted by Garkin

Destinations addon uses pinTag for tooltips - pinTag contains table (array) of strings, each string is one text line on the tooltip. In your code is nothing what adds text to the tooltip. Can you post whole function?

Sorry

Here is the entire function:

Lua Code:

local function CreateMapPins(pinType, known)
    if not LMP:IsEnabled(pinType) or (GetMapType() > MAPTYPE_ZONE) then return end
    local zoneIndex = GetCurrentMapZoneIndex()
    local data = MapDataStore[GetCurrentMapZoneIndex()]
    for i = 1, GetNumPOIs(zoneIndex) do
        local normalizedX, normalizedY, poiType, icon = GetPOIMapInfo(zoneIndex, i)
        local unknown = (poiType == MAP_PIN_TYPE_INVALID)
        local objectiveName = GetPOIInfo(zoneIndex, i)
        local poiTypeId = 22
        local poiTypeName
        local pinTag
        if data then
            for _, pinLookup in ipairs(data) do
                if pinLookup[1] == objectiveName then
                    poiTypeId = pinLookup[2]
                    break
                end
            end
        end
        poiTypeName = GetPoiTypeName(poiTypeId)
        if unknown then
            if not known then
                pinTag = {zo_strformat("|c0099CC<<t:1>>|r", objectiveName), zo_strformat("[<<t:1>>]", poiTypeName)}
                if localLanguage ~= "en" and savedVariables.filters[PINS_ADD_ENGLISH] == true then
                    if englishPOINames[zoneIndex] and englishPOINames[zoneIndex][i] then 
                        table.insert(pinTag, 2, zo_strformat("|c006688<<t:1>>|r", englishPOINames[zoneIndex][i])) --insert english name as a second tooltip line
                    end
                end
                local index = savedVariables.pinTextureUnknown.type
                if index == 7 then
                    if poiTypeId == 1 then
                        pinType = PINS_REALUNKNOWNWAYSHRINE
                        local data = GuildTraderDataStore[GetCurrentMapZoneIndex()]
                        if not data then return end
                        for _, pinData in ipairs(data) do
                            local ID = pinData[GuildTraderDataIndex.ID]
                            if ID == 1 then
                                local WAYSHRINE = pinData[GuildTraderDataIndex.WAYSHRINE]
                                if WAYSHRINE == objectiveName then
                                    table.insert(pinTag, 3, zo_strformat("|c666666<<t:1>>|r", GetString(POITYPE_GUILDTRADERS)))
                                    pinType = PINS_REALUNKNOWNWAYSHRINETRADER
                                end
                            end
                        end
                    elseif poiTypeId == 2 then
                        pinType = PINS_REALUNKNOWNAOI
                    elseif poiTypeId == 3 and zoneIndex ~= 353 then
                        pinType = PINS_REALUNKNOWNPUBLICDUNGEON
                    elseif poiTypeId == 3 and zoneIndex == 353 then
                        pinType = PINS_REALUNKNOWNPUBLICDUNGEON2
                    elseif poiTypeId == 4 then
                        pinType = PINS_REALUNKNOWNMUNDUS
                    elseif poiTypeId == 5 then
                        pinType = PINS_REALUNKNOWNDOLMEN
                    elseif poiTypeId == 6 then
                        pinType = PINS_REALUNKNOWNGROUPBOSS
                    elseif poiTypeId == 7 then
                        pinType = PINS_REALUNKNOWNGROUPDUNGEON
                    elseif poiTypeId == 8 then
                        pinType = PINS_REALUNKNOWNQUESTHUB
                    elseif poiTypeId == 9 then
                        pinType = PINS_REALUNKNOWNCRAFTING
                    elseif poiTypeId == 10 then
                        pinType = PINS_REALUNKNOWNSOLODUNGEON
                    elseif poiTypeId == 11 then
                        pinType = PINS_REALUNKNOWNGROUPEVENT
                    elseif poiTypeId == 12 then
                        pinType = PINS_REALUNKNOWNGROUPDELVE
                    elseif poiTypeId == 13 then
                        pinType = PINS_REALUNKNOWNTRIAL
                    elseif poiTypeId == 14 then
                        pinType = PINS_REALUNKNOWNGUILDTRADER
                    elseif poiTypeId == 22 then
                        pinType = PINS_REALUNKNOWN
                    end
                end
                LMP:CreatePin(pinType, pinTag, normalizedX, normalizedY)
                if index == 7 then
                    pinType = PINS_UNKNOWN
                end
            end
        else
            if known then
                if GetMapType() ~= 1 then
                    pinTag = {zo_strformat("<<t:1>>", objectiveName), zo_strformat("[<<t:1>>]", poiTypeName)}
                    if localLanguage ~= "en" and savedVariables.filters[PINS_ADD_ENGLISH] == true then
                        if englishPOINames[zoneIndex] and englishPOINames[zoneIndex][i] then
                            if poiTypeName == "Oratoire" or poiTypeName == "Wegschrein" then
                                pinTag = {zo_strformat("|c777755<<t:1>>|r", englishPOINames[zoneIndex][i]), zo_strformat("[<<t:1>>]", poiTypeName)}
                            else
                                table.insert(pinTag, 2, zo_strformat("|c777755<<t:1>>|r", englishPOINames[zoneIndex][i])) --insert english name as a second tooltip line
                            end
                        end
                    end
                    if poiTypeName ~= "Wayshrine" then
                        LMP:CreatePin(pinType, pinTag, normalizedX, normalizedY)
                    end
                end
            end
        end
    end
end

Garkin · 11/13/14, 03:05 PM

I do not see anything what can add multiple lines to the tooltip. Are you sure that CreateMapPins function is called only once per zone? If you call CreateMapPins function multiple times, you will have lots of pins at the same place. In this case tooltip shows text for all pins under the mouse cursor.

SnowmanDK · 11/13/14, 03:26 PM

Originally Posted by Garkin

I do not see anything what can add multiple lines to the tooltip. Are you sure that CreateMapPins function is called only once per zone? If you call CreateMapPins function multiple times, you will have lots of pins at the same place. In this case tooltip shows text for all pins under the mouse cursor.

I guess the cause is that it makes a call for every LMP:AddPinType I do during OnLoad, but I don't know another way of adding the pintypes:

Lua Code:

local pinLayout_RealUnknownWayshrine = {
        level = pinTextureLevelUnknown,
        texture = pinTextures.unknownrealpins[1],
        size = pinTextureSizeUnknown,
    }
    LMP:AddPinType(PINS_REALUNKNOWNWAYSHRINE, MapCallback_unknown, nil, pinLayout_RealUnknownWayshrine, pinTooltipCreator)
    local pinLayout_RealUnknownAOI = {
        level = pinTextureLevelUnknown,
        texture = pinTextures.unknownrealpins[2],
        size = pinTextureSizeUnknown,
    }
    LMP:AddPinType(PINS_REALUNKNOWNAOI, MapCallback_unknown, nil, pinLayout_RealUnknownAOI, pinTooltipCreator)
    local pinLayout_RealUnknownPublicDungeon = {
        level = pinTextureLevelUnknown,
        texture = pinTextures.unknownrealpins[3],
        size = pinTextureSizeUnknown,
    }
    LMP:AddPinType(PINS_REALUNKNOWNPUBLICDUNGEON, MapCallback_unknown, nil, pinLayout_RealUnknownPublicDungeon, pinTooltipCreator)
    local pinLayout_RealUnknownMundus = {
        level = pinTextureLevelUnknown,
        texture = pinTextures.unknownrealpins[4],
        size = pinTextureSizeUnknown,
    }
    LMP:AddPinType(PINS_REALUNKNOWNMUNDUS, MapCallback_unknown, nil, pinLayout_RealUnknownMundus, pinTooltipCreator)
    local pinLayout_RealUnknownDolmen = {
        level = pinTextureLevelUnknown,
        texture = pinTextures.unknownrealpins[5],
        size = pinTextureSizeUnknown,
    }
    LMP:AddPinType(PINS_REALUNKNOWNDOLMEN, MapCallback_unknown, nil, pinLayout_RealUnknownDolmen, pinTooltipCreator)
    local pinLayout_RealUnknownGroupBoss = {
        level = pinTextureLevelUnknown,
        texture = pinTextures.unknownrealpins[6],
        size = pinTextureSizeUnknown,
    }
    LMP:AddPinType(PINS_REALUNKNOWNGROUPBOSS, MapCallback_unknown, nil, pinLayout_RealUnknownGroupBoss, pinTooltipCreator)
    local pinLayout_RealUnknownGroupDungeon = {
        level = pinTextureLevelUnknown,
        texture = pinTextures.unknownrealpins[7],
        size = pinTextureSizeUnknown,
    }
    LMP:AddPinType(PINS_REALUNKNOWNGROUPDUNGEON, MapCallback_unknown, nil, pinLayout_RealUnknownGroupDungeon, pinTooltipCreator)
    local pinLayout_RealUnknownQuestHub = {
        level = pinTextureLevelUnknown,
        texture = pinTextures.unknownrealpins[8],
        size = pinTextureSizeUnknown,
    }
    LMP:AddPinType(PINS_REALUNKNOWNQUESTHUB, MapCallback_unknown, nil, pinLayout_RealUnknownQuestHub, pinTooltipCreator)
    local pinLayout_RealUnknownCrafting = {
        level = pinTextureLevelUnknown,
        texture = pinTextures.unknownrealpins[9],
        size = pinTextureSizeUnknown,
    }
    LMP:AddPinType(PINS_REALUNKNOWNCRAFTING, MapCallback_unknown, nil, pinLayout_RealUnknownCrafting, pinTooltipCreator)
    local pinLayout_RealUnknownSoloDungeon = {
        level = pinTextureLevelUnknown,
        texture = pinTextures.unknownrealpins[10],
        size = pinTextureSizeUnknown,
    }
    LMP:AddPinType(PINS_REALUNKNOWNSOLODUNGEON, MapCallback_unknown, nil, pinLayout_RealUnknownSoloDungeon, pinTooltipCreator)
    local pinLayout_RealUnknownGroupEvent = {
        level = pinTextureLevelUnknown,
        texture = pinTextures.unknownrealpins[11],
        size = pinTextureSizeUnknown,
    }
    LMP:AddPinType(PINS_REALUNKNOWNGROUPEVENT, MapCallback_unknown, nil, pinLayout_RealUnknownGroupEvent, pinTooltipCreator)
 
    local pinLayout_RealUnknownGroupDelve = {
        level = pinTextureLevelUnknown,
        texture = pinTextures.unknownrealpins[12],
        size = pinTextureSizeUnknown,
    }
    LMP:AddPinType(PINS_REALUNKNOWNGROUPDELVE, MapCallback_unknown, nil, pinLayout_RealUnknownGroupDelve, pinTooltipCreator)
    local pinLayout_RealUnknownTrial = {
        level = pinTextureLevelUnknown,
        texture = pinTextures.unknownrealpins[13],
        size = pinTextureSizeUnknown,
    }
    LMP:AddPinType(PINS_REALUNKNOWNTRIAL, MapCallback_unknown, nil, pinLayout_RealUnknownTrial, pinTooltipCreator)
    local pinLayout_RealUnknownGuildTrader = {
        level = pinTextureLevelUnknown,
        texture = pinTextures.unknownrealpins[14],
        size = pinTextureSizeUnknown,
    }
    LMP:AddPinType(PINS_REALUNKNOWNGUILDTRADER, MapCallback_unknown, nil, pinLayout_RealUnknownGuildTrader, pinTooltipCreator)
    local pinLayout_RealUnknownWayshrineTrader = {
        level = pinTextureLevelUnknown,
        texture = pinTextures.unknownrealpins[15],
        size = pinTextureSizeUnknown,
    }
    LMP:AddPinType(PINS_REALUNKNOWNWAYSHRINETRADER, MapCallback_unknown, nil, pinLayout_RealUnknownWayshrineTrader, pinTooltipCreator)
    local pinLayout_RealUnknownPublicDungeon2 = {
        level = pinTextureLevelUnknown,
        texture = pinTextures.unknownrealpins[16],
        size = pinTextureSizeUnknown,
    }
    LMP:AddPinType(PINS_REALUNKNOWNPUBLICDUNGEON2, MapCallback_unknown, nil, pinLayout_RealUnknownPublicDungeon2, pinTooltipCreator)
    local pinLayout_RealUnknown = {
        level = pinTextureLevelUnknown,
        texture = pinTextures.unknownrealpins[22],
        size = pinTextureSizeUnknown,
    }
    LMP:AddPinType(PINS_REALUNKNOWN, MapCallback_unknown, nil, pinLayout_RealUnknown, pinTooltipCreator)

If I change "pinTooltipCreator" in each line to "nil" then nothing is written, so my guess is that it's all the calls to that one?

Garkin · 11/13/14, 04:14 PM

Ah, you are right. All pin types has the same creator function, so the same function is called for each pin type. Not only when you register pins using the AddPinType, but every time when you change zone.

There are several ways how to fix the issue, for example:
- the same way as I have it done in SkyShards, call create function with some delay and make sure that you will call it just once. Simple function (I have a bit more complex function in SkyShards):

Lua Code:

local updating = false
local function QueueCreatePins()
    if not updating then
        updating = true
        zo_callLater(CreateMapPins, 50) --do not forget to set updating to false at the end of CreateMapPins function
    end
end

- add some conditions to the CreateMapPins function, so pin will be created only once. This is inefficient, it will be slow because you will need to go through your data table for each pintype.
- make different function for each pintype. Again, this will be inefficient as you will need to go through your data table more times.

SnowmanDK · 11/13/14, 04:59 PM

Originally Posted by Garkin

Ah, you are right. All pin types has the same creator function, so the same function is called for each pin type. Not only when you register pins using the AddPinType, but every time when you change zone.

There are several ways how to fix the issue, for example:
- the same way as I have it done in SkyShards, call create function with some delay and make sure that you will call it just once. Simple function (I have a bit more complex function in SkyShards):

Lua Code:

local updating = false
local function QueueCreatePins()
    if not updating then
        updating = true
        zo_callLater(CreateMapPins, 50) --do not forget to set updating to false at the end of CreateMapPins function
    end
end

- add some conditions to the CreateMapPins function, so pin will be created only once. This is inefficient, it will be slow because you will need to go through your data table for each pintype.
- make different function for each pintype. Again, this will be inefficient as you will need to go through your data table more times.

That delay sounds like a solution, but how can I get that to work with this?:

Lua Code:

local function MapCallback_unknown(pinManager)
    CreateMapPins(PINS_UNKNOWN, false)
end

Garkin · 11/13/14, 05:23 PM

Originally Posted by SnowmanDK

That delay sounds like a solution, but how can I get that to work with this?:

Lua Code:

local function MapCallback_unknown(pinManager)
    CreateMapPins(PINS_UNKNOWN, false)
end

It should be something like the folowing code. Take a look to the SkyShards code for better reference.

Lua Code:

local updating = false
 
local function CreateMapPins(pinType, known)
    local zoneIndex = GetCurrentMapZoneIndex()
    local data = MapDataStore[GetCurrentMapZoneIndex()]
    for i = 1, GetNumPOIs(zoneIndex) do
        local normalizedX, normalizedY, poiType, icon = GetPOIMapInfo(zoneIndex, i)
        local unknown = (poiType == MAP_PIN_TYPE_INVALID)
        local objectiveName = GetPOIInfo(zoneIndex, i)
        local poiTypeId = 22
        local poiTypeName
        local pinTag
        if data then
            for _, pinLookup in ipairs(data) do
                if pinLookup[1] == objectiveName then
                    poiTypeId = pinLookup[2]
                    break
                end
            end
        end
        poiTypeName = GetPoiTypeName(poiTypeId)
        if unknown then
            if not known then
                pinTag = {zo_strformat("|c0099CC<<t:1>>|r", objectiveName), zo_strformat("[<<t:1>>]", poiTypeName)}
                if localLanguage ~= "en" and savedVariables.filters[PINS_ADD_ENGLISH] == true then
                    if englishPOINames[zoneIndex] and englishPOINames[zoneIndex][i] then
                        table.insert(pinTag, 2, zo_strformat("|c006688<<t:1>>|r", englishPOINames[zoneIndex][i])) --insert english name as a second tooltip line
                    end
                end
                local index = savedVariables.pinTextureUnknown.type
                if index == 7 then
                    if poiTypeId == 1 then
                        pinType = PINS_REALUNKNOWNWAYSHRINE
                        local data = GuildTraderDataStore[GetCurrentMapZoneIndex()]
                        if not data then return end
                        for _, pinData in ipairs(data) do
                            local ID = pinData[GuildTraderDataIndex.ID]
                            if ID == 1 then
                                local WAYSHRINE = pinData[GuildTraderDataIndex.WAYSHRINE]
                                if WAYSHRINE == objectiveName then
                                    table.insert(pinTag, 3, zo_strformat("|c666666<<t:1>>|r", GetString(POITYPE_GUILDTRADERS)))
                                    pinType = PINS_REALUNKNOWNWAYSHRINETRADER
                                end
                            end
                        end
                    elseif poiTypeId == 2 then
                        pinType = PINS_REALUNKNOWNAOI
                    elseif poiTypeId == 3 and zoneIndex ~= 353 then
                        pinType = PINS_REALUNKNOWNPUBLICDUNGEON
                    elseif poiTypeId == 3 and zoneIndex == 353 then
                        pinType = PINS_REALUNKNOWNPUBLICDUNGEON2
                    elseif poiTypeId == 4 then
                        pinType = PINS_REALUNKNOWNMUNDUS
                    elseif poiTypeId == 5 then
                        pinType = PINS_REALUNKNOWNDOLMEN
                    elseif poiTypeId == 6 then
                        pinType = PINS_REALUNKNOWNGROUPBOSS
                    elseif poiTypeId == 7 then
                        pinType = PINS_REALUNKNOWNGROUPDUNGEON
                    elseif poiTypeId == 8 then
                        pinType = PINS_REALUNKNOWNQUESTHUB
                    elseif poiTypeId == 9 then
                        pinType = PINS_REALUNKNOWNCRAFTING
                    elseif poiTypeId == 10 then
                        pinType = PINS_REALUNKNOWNSOLODUNGEON
                    elseif poiTypeId == 11 then
                        pinType = PINS_REALUNKNOWNGROUPEVENT
                    elseif poiTypeId == 12 then
                        pinType = PINS_REALUNKNOWNGROUPDELVE
                    elseif poiTypeId == 13 then
                        pinType = PINS_REALUNKNOWNTRIAL
                    elseif poiTypeId == 14 then
                        pinType = PINS_REALUNKNOWNGUILDTRADER
                    else
                        pinType = PINS_REALUNKNOWN
                    end
                end
                LMP:CreatePin(pinType, pinTag, normalizedX, normalizedY)
            end
        else
            if known then
                if GetMapType() ~= 1 then
                    pinTag = {zo_strformat("<<t:1>>", objectiveName), zo_strformat("[<<t:1>>]", poiTypeName)}
                    if localLanguage ~= "en" and savedVariables.filters[PINS_ADD_ENGLISH] == true then
                        if englishPOINames[zoneIndex] and englishPOINames[zoneIndex][i] then
                            if poiTypeName == "Oratoire" or poiTypeName == "Wegschrein" then
                                pinTag = {zo_strformat("|c777755<<t:1>>|r", englishPOINames[zoneIndex][i]), zo_strformat("[<<t:1>>]", poiTypeName)}
                            else
                                table.insert(pinTag, 2, zo_strformat("|c777755<<t:1>>|r", englishPOINames[zoneIndex][i]))
                            end
                        end
                    end
                    if poiTypeName ~= "Wayshrine" then
                        LMP:CreatePin(pinType, pinTag, normalizedX, normalizedY)
                    end
                end
            end
        end
    end
    updating = false
end
 
local function QueueCreatePins(pinType, known)
    if not updating then
        updating = true
        zo_callLater(function() CreateMapPins(pinType, known) end, 50)
    end
end
 
local function MapCallback_unknown(pinManager)
    if not LMP:IsEnabled(PINS_UNKNOWN) or (GetMapType() > MAPTYPE_ZONE) then return end
    QueueCreatePins(PINS_UNKNOWN, false)
end

SnowmanDK · 11/13/14, 06:27 PM

Originally Posted by Garkin

It should be something like the folowing code. Take a look to the SkyShards code for better reference.

Lua Code:

local updating = false
 
local function CreateMapPins(pinType, known)
    local zoneIndex = GetCurrentMapZoneIndex()
    local data = MapDataStore[GetCurrentMapZoneIndex()]
    for i = 1, GetNumPOIs(zoneIndex) do
        local normalizedX, normalizedY, poiType, icon = GetPOIMapInfo(zoneIndex, i)
        local unknown = (poiType == MAP_PIN_TYPE_INVALID)
        local objectiveName = GetPOIInfo(zoneIndex, i)
        local poiTypeId = 22
        local poiTypeName
        local pinTag
        if data then
            for _, pinLookup in ipairs(data) do
                if pinLookup[1] == objectiveName then
                    poiTypeId = pinLookup[2]
                    break
                end
            end
        end
        poiTypeName = GetPoiTypeName(poiTypeId)
        if unknown then
            if not known then
                pinTag = {zo_strformat("|c0099CC<<t:1>>|r", objectiveName), zo_strformat("[<<t:1>>]", poiTypeName)}
                if localLanguage ~= "en" and savedVariables.filters[PINS_ADD_ENGLISH] == true then
                    if englishPOINames[zoneIndex] and englishPOINames[zoneIndex][i] then
                        table.insert(pinTag, 2, zo_strformat("|c006688<<t:1>>|r", englishPOINames[zoneIndex][i])) --insert english name as a second tooltip line
                    end
                end
                local index = savedVariables.pinTextureUnknown.type
                if index == 7 then
                    if poiTypeId == 1 then
                        pinType = PINS_REALUNKNOWNWAYSHRINE
                        local data = GuildTraderDataStore[GetCurrentMapZoneIndex()]
                        if not data then return end
                        for _, pinData in ipairs(data) do
                            local ID = pinData[GuildTraderDataIndex.ID]
                            if ID == 1 then
                                local WAYSHRINE = pinData[GuildTraderDataIndex.WAYSHRINE]
                                if WAYSHRINE == objectiveName then
                                    table.insert(pinTag, 3, zo_strformat("|c666666<<t:1>>|r", GetString(POITYPE_GUILDTRADERS)))
                                    pinType = PINS_REALUNKNOWNWAYSHRINETRADER
                                end
                            end
                        end
                    elseif poiTypeId == 2 then
                        pinType = PINS_REALUNKNOWNAOI
                    elseif poiTypeId == 3 and zoneIndex ~= 353 then
                        pinType = PINS_REALUNKNOWNPUBLICDUNGEON
                    elseif poiTypeId == 3 and zoneIndex == 353 then
                        pinType = PINS_REALUNKNOWNPUBLICDUNGEON2
                    elseif poiTypeId == 4 then
                        pinType = PINS_REALUNKNOWNMUNDUS
                    elseif poiTypeId == 5 then
                        pinType = PINS_REALUNKNOWNDOLMEN
                    elseif poiTypeId == 6 then
                        pinType = PINS_REALUNKNOWNGROUPBOSS
                    elseif poiTypeId == 7 then
                        pinType = PINS_REALUNKNOWNGROUPDUNGEON
                    elseif poiTypeId == 8 then
                        pinType = PINS_REALUNKNOWNQUESTHUB
                    elseif poiTypeId == 9 then
                        pinType = PINS_REALUNKNOWNCRAFTING
                    elseif poiTypeId == 10 then
                        pinType = PINS_REALUNKNOWNSOLODUNGEON
                    elseif poiTypeId == 11 then
                        pinType = PINS_REALUNKNOWNGROUPEVENT
                    elseif poiTypeId == 12 then
                        pinType = PINS_REALUNKNOWNGROUPDELVE
                    elseif poiTypeId == 13 then
                        pinType = PINS_REALUNKNOWNTRIAL
                    elseif poiTypeId == 14 then
                        pinType = PINS_REALUNKNOWNGUILDTRADER
                    else
                        pinType = PINS_REALUNKNOWN
                    end
                end
                LMP:CreatePin(pinType, pinTag, normalizedX, normalizedY)
            end
        else
            if known then
                if GetMapType() ~= 1 then
                    pinTag = {zo_strformat("<<t:1>>", objectiveName), zo_strformat("[<<t:1>>]", poiTypeName)}
                    if localLanguage ~= "en" and savedVariables.filters[PINS_ADD_ENGLISH] == true then
                        if englishPOINames[zoneIndex] and englishPOINames[zoneIndex][i] then
                            if poiTypeName == "Oratoire" or poiTypeName == "Wegschrein" then
                                pinTag = {zo_strformat("|c777755<<t:1>>|r", englishPOINames[zoneIndex][i]), zo_strformat("[<<t:1>>]", poiTypeName)}
                            else
                                table.insert(pinTag, 2, zo_strformat("|c777755<<t:1>>|r", englishPOINames[zoneIndex][i]))
                            end
                        end
                    end
                    if poiTypeName ~= "Wayshrine" then
                        LMP:CreatePin(pinType, pinTag, normalizedX, normalizedY)
                    end
                end
            end
        end
    end
    updating = false
end
 
local function QueueCreatePins(pinType, known)
    if not updating then
        updating = true
        zo_callLater(function() CreateMapPins(pinType, known) end, 50)
    end
end
 
local function MapCallback_unknown(pinManager)
    if not LMP:IsEnabled(PINS_UNKNOWN) or (GetMapType() > MAPTYPE_ZONE) then return end
    QueueCreatePins(PINS_UNKNOWN, false)
end

That is very close to what I tried. Sadly both mine and your code gives me these errors:

Line 2406:

Lua Code:

QueueCreatePins(PINS_UNKNOWN, false)

Line 3488:

Lua Code:

LMP:AddPinType(PINS_UNKNOWN, MapCallback_unknown, nil, pinLayout_unknown, pinTooltipCreator)

SnowmanDK · 11/13/14, 07:26 PM

Not sure this is the final solution, but it seems to work.
I did this directly, bypassing a loop through "QueueCreatePins".

Lua Code:

local function MapCallback_unknown(pinManager)
    if not LMP:IsEnabled(PINS_UNKNOWN) or (GetMapType() > MAPTYPE_ZONE) then return end
    if not updating then
        updating = true
        zo_callLater(function() CreateMapPins(PINS_UNKNOWN, false) end, 50)
    end
end

SnowmanDK · 11/13/14, 07:58 PM

After adding a function to toggle the RealPins on/off, and adding a call to that depending on switches in settings then it seems to work perfectly.

Once again you saved me Master Garkin

Only one issue left, but that's minor thing. It's even present in the current release.
Maybe you have an idea about what is going on with it.
When RealPins are selected then only Quest Hubs are shown in Coldharbour and The Rift.
It ONLY goes wrong in those 2 zones and ONLY when using "Semi-Real" pins.
I must admit I am beginning to suspect a problem in the API, as I can't find the reason.