Collectible_item_type_trophy ??

dopiate · 01/08/15, 03:42 AM

I thought I had posted this before but I didn't see it show up?

I am writing an addon that will need to scan the users backpack and get back the name and index of the trophy (and then eventually) it will do the same with costumes.

This is the code - it works - but it just gives me (what looks like) the first 20 items in the backpack.

What am I missing here - I know it's got to be something simple.

Lua Code:

function RandomTrophy.trophies()
 
    local backpackItem
    local backpackSlots = GetBagSize and GetBagSize(bag) or select(2, GetBagInfo(bag))
    
    for i=1, backpackSlots do 
        backpackItem = GetItemLink(BAG_BACKPACK, i, LINK_ITEM_TYPE)
        if string.match(backpackItem, COLLECTIBLE_ITEM_TYPE_TROPHY) then 
            d(i)
            d(backpackItem)
        end
    end
    
end

Any help greatly appreciated !

Thanks,

-d

Garkin · 01/08/15, 07:53 AM

Lua Code:
```
local backpackSlots = GetBagSize and GetBagSize(bag) or select(2, GetBagInfo(bag))
```
Is no longer needed. It was compatibility function to make addon work with both API 100007 and 100008 (because of PTS). Just use:
Lua Code:
```
local backpackSlots = GetBagSize(bag)
```
Lua Code:
```
for i=1, backpackSlots do
```
Inventory slots are the only index value in ESO which starts with zero. So the correct code is:
Lua Code:
```
for i = 0, backpackSlots - 1 do
```
Lua Code:
```
backpackItem = GetItemLink(BAG_BACKPACK, i, LINK_ITEM_TYPE)
```
I have no idea how you have defined LINK_ITEM_TYPE, but you should use LINK_STYLE_DEFAULT or LINK_STYLE_BRACKETS.
Lua Code:
```
backpackItem = GetItemLink(BAG_BACKPACK, i, LINK_STYLE_BRACKETS)
```
Lua Code:
```
if string.match(backpackItem, COLLECTIBLE_ITEM_TYPE_TROPHY) then
```
Global constant COLLECTIBLE_ITEM_TYPE_TROPHY is not what you are looking for. Value of COLLECTIBLE_ITEM_TYPE_TROPHY is number 2, so your function returns all itemlinks which contains number 2.
You should use item type instead, something like:
Lua Code:
```
if GetItemLinkItemType(backpackItem) == ITEMTYPE_TROPHY then --if you want collectibles, use ITEMTYPE_COLLECTIBLE
```

Anyway, try this code:

Lua Code:

local bagCache = SHARED_INVENTORY:GenerateFullSlotData(nil, BAG_BACKPACK)
for slotIndex, slotData in pairs(bagCache) do
    if slotData.itemType == ITEMTYPE_TROPHY then
       d(zo_strformat("<<1>> (<<2>>)", slotData.name, slotIndex))
    end
end

dopiate · 01/08/15, 08:22 AM

Thank you Garkin,

That was incredibly helpful!

I am now getting the information I need.

As always thank you for not only giving me the answer but helping me to understand why.

-d