Anyone else gets an ZOs error message upon guild note change?

[Baertram]

Hey there,

just tried to change my guild note and got the following error message:

2015-03-07T14:58:19.221+01:00 |cff0000Lua Error: EsoUI/Ingame/Contacts/SocialDialogs.lua:79: function expected instead of nil
stack traceback:
    EsoUI/Ingame/Contacts/SocialDialogs.lua:79: in function 'm_callback'
    EsoUI/Libraries/ZO_Dialog/ZO_Dialog.lua:68: in function 'HandleCallback'
    EsoUI/Libraries/ZO_KeybindButton/ZO_KeybindButton.lua:140: in function 'ZO_KeybindButtonMixin:OnClicked'
    EsoUI/Libraries/ZO_KeybindButton/ZO_KeybindButton.lua:149: in function 'ZO_KeybindButtonTemplate_OnMouseUp'
    9245264028729672156:3: in function '(main chunk)'|r

The only keybind I have seen ont he sript was "Add guild member" at this point.

The only addons active that interfere with the guilds roster should be:
-Thurisaz GuildInfo

I've disabled it to see if this was the reason. But the error is still there.

I can also see that MailBuddy is adding a control anchored to the guild stuff and it seems to add a keybind too to copy the name of a guild member below the mouse cursor. But I still get this error message with both addons disabled.

Any ideas where this might come from?

[merlight]

ingame/guild/keyboard/guildroster_keyboard.lua +228

ZO_Dialogs_ShowDialog("EDIT_NOTE", {
 displayName = data.displayName, note = data.note,
 changedCallback = GUILD_ROSTER_MANAGER:GetNoteEditedFunction()})

I'd look for GetNoteEditedFunction / noteEditedFunction

[malacoda]

i am also getting this error as well anyone got any ideas i have deleted all my addons and i am still getting this error i have no idea when it comes to lua/xml would really like to get it fixed

[Baertram]

Got no time so far to look into it but I'll have a look this evening if I'll get this error message with all addons turned off too.

[circonian]

Originally Posted by merlight ingame/guild/keyboard/guildroster_keyboard.lua +228 ZO_Dialogs_ShowDialog("EDIT_NOTE", {  displayName = data.displayName, note = data.note,  changedCallback = GUILD_ROSTER_MANAGER:GetNoteEditedFunction()}) I'd look for GetNoteEditedFunction / noteEditedFunction

What he said. I'de look for anything messing with the EDIT_NOTE dialog or the GUILD_ROSTER_MANAGER and its noteEditedFunction.

[ZOS_ChipHilseberg]

I haven't been able to repro this on live. Does it happen on the first note you try to edit or are there specific circumstances involved?

[Ayantir]

Just tested :


/reloadui
Press G
Go on my guild
Edit My note (was previously set to some text)
Add a single "."
Press save button :



2015-03-10T15:52:53.351+01:00 |cff0000Lua Error: EsoUI/Ingame/Contacts/SocialDialogs.lua:79: function expected instead of nil
stack traceback:
EsoUI/Ingame/Contacts/SocialDialogs.lua:79: in function 'm_callback'
EsoUI/Libraries/ZO_Dialog/ZO_Dialog.lua:68: in function 'HandleCallback'
EsoUI/Libraries/ZO_KeybindButton/ZO_KeybindButton.lua:140: in function 'ZO_KeybindButtonMixin:OnClicked'
EsoUI/Libraries/ZO_KeybindButton/ZO_KeybindButton.lua:149: in function 'ZO_KeybindButtonTemplate_OnMouseUp'
9245264028729672156:3: in function '(main chunk)'|r

[circonian]

I tried last night & again this morning following the steps Ayantir posted. I can still can't reproduce this.

[Ayantir]

Originally Posted by circonian I tried last night & again this morning following the steps Ayantir posted. I can still can't reproduce this.

Strange,
Without any addons, just tested now with another Guildmate, same issue.

[malacoda]

yep same try to edit my guild note and it gives the Error

[circonian]

Oh I was doing it wrong, I was able to reproduce it.
I was right clicking on my name & clicking "Edit Note" I didn't realize there was a note button to click on.
If I click on the note button next to my name & do what you said I do get the error.

It looks like this is the problem here:
When you click on the row note button, it calls:

<OnClicked>
   ZO_KeyboardGuildRosterRowNote_OnClicked(self)
</OnClicked>

function ZO_KeyboardGuildRosterRowNote_OnClicked(control)
    -- Which calls this:
    GUILD_ROSTER_KEYBOARD:Note_OnClicked(control)
end

and GUILD_ROSTER_KEYBOARD is defined/created here:

function ZO_KeyboardGuildRoster_OnInitialized(control)
    GUILD_ROSTER_KEYBOARD = ZO_KeyboardGuildRosterManager:New(control)
end

and ZO_KeyboardGuildRosterManager is a subclass of ZO_SocialListKeyboard:

local ZO_KeyboardGuildRosterManager = ZO_SocialListKeyboard:Subclass()

So its actually calling this function:

function ZO_SocialListKeyboard:Note_OnClicked(control)
    local data = ZO_ScrollList_GetData(control:GetParent())
    ZO_Dialogs_ShowDialog("EDIT_NOTE", {displayName = data.displayName, note = data.note, changedCallback = self.noteEditedFunction})
end

Which means its trying to set:

changedCallback = GUILD_ROSTER_KEYBOARD.noteEditedFunction
-- because self = GUILD_ROSTER_KEYBOARD

but GUILD_ROSTER_KEYBOARD doesn't have a noteEditedFunction
The noteEditedFunction is in: GUILD_ROSTER_MANAGER

Somewhere it needs to set the noteEditedFunction. Cant do it in the ZO_SocialListKeyboard:Note_OnClicked(control), because its shared with the friends list note edit, (maybe others too).
The easiest solution would probably be to just set it right here, right before it calls the function to show the dialog:

function ZO_KeyboardGuildRosterRowNote_OnClicked(control)
    GUILD_ROSTER_KEYBOARD.noteEditedFunction = GUILD_ROSTER_MANAGER:GetNoteEditedFunction()
    GUILD_ROSTER_KEYBOARD:Note_OnClicked(control)
end

Or give it its own function to show the dialog, like they did with the ignore list:

function ZO_KeyboardIgnoreListManager:IgnoreListPanelRowNote_OnClicked(control)
    local data = ZO_ScrollList_GetData(control:GetParent())
    if data then
        local displayName, note = GetIgnoredInfo(data.index)
        ZO_Dialogs_ShowDialog("EDIT_NOTE", {displayName = displayName, note = note, changedCallback = IGNORE_LIST_MANAGER:GetNoteEditedFunction()})
    end
end

By the way: The Friends list has the same bug

[circonian]

Oh, I wasn't thinking. I guess I could post a temporary fix for you guys to use until they fix it.

Edit Note Bug Fix

That fixes both the guild note & friends note bugs.

[ZOS_ChipHilseberg]

Ah, that's the trick. I was also using the right-click menu. Thanks for the detailed breakdown Circonian! We'll get a fix in ASAP.

[Baertram]

Thx doods for the anaylsis and the for the fix workaround!

[malacoda]

yeh thanks alot for the workaround