[Request] Remove Action Button Borders

[blakbird]

Garkin as been kind enough to help me out with a couple things I have been working on for my flat, minimalist UI. He gave me this snippet of code that removes the borders on the action buttons:

for slotNum = 3, 9 do
        local button = ZO_ActionBar_GetButton(slotNum).button
        button:SetNormalTexture("")
        button:SetPressedTexture("")
        button:SetDisabledTexture("")
        end

If I run it as a script in the game, it works. Unfortunately, I am unable to figure out how to turn that script into a addon. I was able to put that code into Luminary Action Bar at line 292 and it works. But, the problem I am having with both the script and the addon is that when I swap bars or get a loading screen, the buttons go back to having borders. I have to reload the UI or run the script every time to get those borders to disappear. I don't want to keep bugging Garkin with all my issues, so hopefully someone here is able to assist me with this.

[Baertram]

I think you need to put it into the callback function of the event_player_activated so it gets called everytime a zonechage/reloadui takes place:

local function Callback_Player_Activated(...)
--remove borders at action buttons
for slotNum = 3, 9 do
        local button = ZO_ActionBar_GetButton(slotNum).button
        button:SetNormalTexture("")
        button:SetPressedTexture("")
        button:SetDisabledTexture("")
        end
end
 
--Put this somewhere where your addon gets initialized, e.g. inside callback function of EVENT_ADDON_ON_LOAD or just at the bottom of your addon    
--Register for the zone change/player ready event
    EVENT_MANAGER:RegisterForEvent("MyAddonName", EVENT_PLAYER_ACTIVATED, Callback_Player_Activated)

Like written in the code the addon should load some function as it loads up, by event EVENT_ADDON_ON_LOAD. Replace MyAddonName with the name of your addon, like the lua filename is.

local function Addon_Loaded(eventCode, addOnName)
--Is this addon found? Put your addon's name here!!!
    if(addOnName ~= "MyAddonName") then
        return
    end
    --Unregister this event again so it isn't fired again after this addon has beend reckognized
    EVENT_MANAGER:UnregisterForEvent("MyAddonName", EVENT_ADD_ON_LOADED)
 
    --Register for the zone change/player ready event
    EVENT_MANAGER:RegisterForEvent("MyAddonName", EVENT_PLAYER_ACTIVATED, Callback_Player_Activated)
 
end

At the bottom of your addon's lua file put this then to register the event on addon load callback function:

EVENT_MANAGER:RegisterForEvent("MyAddonName", EVENT_ADD_ON_LOADED, Addon_Loaded)

About the weapon bar change:
I do not know how to check on this but I'll have a look.

EDIT:

There is an event for this too. So put this into the ON ADDOn LOAD event callback function:

EVENT_MANAGER:RegisterForEvent("YourAddonName", EVENT_ACTIVE_WEAPON_PAIR_CHANGED, WeaponSwapped)

And this somewhere above:

local function WeaponSwapped(...)
--remove borders at action buttons
for slotNum = 3, 9 do
        local button = ZO_ActionBar_GetButton(slotNum).button
        button:SetNormalTexture("")
        button:SetPressedTexture("")
        button:SetDisabledTexture("")
        end
end
end

As the code is duplicate now try to put it in a nother local function and then call the function inside the Weapon swapped callback function AND the player activated function instead.

[blakbird]

Thanks for the help! I am very new to learning lua. I mostly dissect code and make changes to see how it works. Is there more to this code than what you have showed me? I tried to put that code together as you instructed(and a few other ways), but I keep getting errors (due to me not having the skills to deduce why the errors are happening). If you have the time, can you please show me what this code looks like all together? I didn't intend to have someone write this addon for me, but I can see that it is way beyond my current coding skillset.

[Baertram]

A better way to learn from each other is you post us your code and we can tell you what you could do better/another way.

My example code from above would look like this, where your new addon's name would be "NoActionbarBorders" (filename would be the same + .lua, and the manifest file + .txt at the end, and create a new folder with the addon#s name and put the lua and txt file in there, and this folder then as a subfolder into the "Addons" folder):

--Just a function to reduce redundant code
local function RemoveActionbarBorders()
    --remove borders at action buttons
    for slotNum = 3, 9 do
            local button = ZO_ActionBar_GetButton(slotNum).button
            button:SetNormalTexture("")
            button:SetPressedTexture("")
            button:SetDisabledTexture("")
    end
end
 
--Callback function for the player activated event (upon zone change or logging in new)
local function Callback_Player_Activated(...)
    RemoveActionbarBorders()
end
 
--Callback function for the weapon swap event
local function Weapon_Swapped(...)
    RemoveActionbarBorders()
end
 
--Put this somewhere where your addon gets initialized, e.g. inside callback function of EVENT_ADDON_ON_LOAD or just at the bottom of your addon
--Register for the zone change/player ready event
    EVENT_MANAGER:RegisterForEvent("NoActionbarBorders", EVENT_PLAYER_ACTIVATED, Callback_Player_Activated)
 
--Callback function for the addon loaded event (executes for EVERY addon that loads!)
local function Addon_Loaded(eventCode, addOnName)
    --Is THIS addon HERE found?
    if(addOnName ~= "NoActionbarBorders") then
        return
    end
    --If you got here your addon is found so execute the following code lines:
    --Unregister this event again so it isn't fired again after this addon has beend loaded
    EVENT_MANAGER:UnregisterForEvent("NoActionbarBorders", EVENT_ADD_ON_LOADED)
    --Register for the zone change/player ready event
    EVENT_MANAGER:RegisterForEvent("NoActionbarBorders", EVENT_PLAYER_ACTIVATED, Callback_Player_Activated)
    --Register the callback function for the weapon bar switch
    EVENT_MANAGER:RegisterForEvent("NoActionbarBorders", EVENT_ACTIVE_WEAPON_PAIR_CHANGED, Weapon_Swapped)
end
 
--Register the event ADD_ON_LOADED to get started with your addon. As this event will be called for EVERY addon you need to
--check your addon#s name inside the cllback function so it won't execute your code for EVERY addon!
EVENT_MANAGER:RegisterForEvent("NoActionbarBorders", EVENT_ADD_ON_LOADED, Addon_Loaded)

I did not test this so it might contain errors. But I hope you get the point and it helps you!

EDIT:
I did test it now and it is working fine. You notice a small flickering of the borders at a weapon change but I think you won't be able to change this without replacing the textures for the borders with some other textures, or NO textures.
There is some command for lua to exchange/replace existing textures but I do not know if you are able to do this with these action bar textures as well.
search the forum for "replace texture" or "exchange texture" and use the addon "TextureIt" to find the textures for the action bars and then you might get it to work.

[Baertram]

The .txt manifest file would look like this, for example:

## Title: NoActionbarBorders
## APIVersion: 100011
## SavedVariables: NoActionbarBorders_SavedVariables
## Description: This addon will remove the borders around the action bar skills
## Version: 0.0.1
## Author: blakbird

NoActionbarBorders.lua

SavedVariables name, author name, description and version is up 2 you.
APIversion should be the most current one so the addon is not listed as outdated inside the ESO game addon manager.

[Baertram]

Found the thread with that replace texture function. It's name is
"RedirectTexture(string oldTexturefilename, string newTextureFileName)"

http://www.esoui.com/forums/showthre...eplace+texture

[blakbird]

I copied the lua code and saved it as NoActionbarBorders.lua. I copied the text file info and saved it as NoActionbarBorders.txt. I can see the addon is loaded in game, but it does nothing. I'm not completely new to programming as I used to be a web designer, but looking at lua, I can only see why working code works. I just can't see why code doesn't work.

I will check out that thread you linked now about replacing the textures.