CLS needs a patch (and I can't do it)

[zgrssd]

On the main Forum someone said that CLS "crafting inspisration tracking" element was not working properly. Specifically it told totally irational values for "precentage till next level" (like -7 billion percent). I checked that and it indeed does (even on a clean install):
http://forums.elderscrollsonline.com...tistics#latest

The author has not logged in esoui for about 1 month.

I took a look at the code but cannot make heads or tail out of the code at my current level. Could anybody who understand the area of Inpsiration tracking a bit better take a look at it?

[Garkin]

It's not fully tested, but it seems to be working so far.

Replace function FCL.NewSkill in Combat Log Statistic.lua with:

function FCL.NewSkill(eventCode, Category, Type, MinXP, MaxXP, CurrentXP)
    local diff = 0
    local inLevel = 0
    local display = ""
 
    if (FCL.SkillsXP[Category][Type][3] >= CurrentXP) or (FCL.SkillsXP[Category][Type][3] == nil) then return end
    if (FCL.CText.Skills[Category][Type] == false) then return end
 
    diff = CurrentXP - FCL.SkillsXP[Category][Type][3]
    if FCL.SkillsXP[Category][Type][2] < CurrentXP then
        FCL.SkillsXP[Category][Type] = {GetSkillLineXPInfo(Category, Type)}
    else  
        FCL.SkillsXP[Category][Type][3] = CurrentXP
    end
    inLevel = FCL.SkillsXP[Category][Type][2] - FCL.SkillsXP[Category][Type][1] 
    percent = string.format( "%.2f" , ((CurrentXP - FCL.SkillsXP[Category][Type][1])/inLevel)*100)
    display = "|cc8ff3a+" .. diff .. " " .. FCL.SkillXPNames[Category][Type] ..  " (" .. percent .. "%)"
 
    if (FCL.CText.Time == true) then
        table.insert(FCL.CText.You, 1, "[" ..GetTimeString() .. "]" .. display)
    else    
        table.insert(FCL.CText.You, 1, display)
    end
 
    if FCL.CText.Chat == true then
        d(FCL.CText.You[1])
    end
 
    if FCL.Hiden == "You" then
        FCL.FadeTime = GetGameTimeMilliseconds()
        for i = 1, FCL.CText.MaxLines do
            if FCL.CText.You[FCL.Value + i] ~= nil then
                _G["CombatLog_Textbox"..i]:SetText(FCL.CText.You[FCL.Value + i])
            end
        end     
    end
 
end

And in function FCL.NewExp replace XP_REASON_FINESSE with PROGRESS_REASON_FINESSE.

[d2allgr]

Based on the documentation on the wiki for EVENT_SKILL_XP_UPDATE I would suggest changing FCL.NewSkill to:

function FCL.NewSkill(eventCode, Category, Type, reason, rank, previousXP, CurrentXP)
    local diff = 0
    local display = ""
    
    --d(Category .. "//" .. Type .. "//" .. CurrentXP .. "//" .. MaxXP .. "//" .. FCL.SkillsXP[Category][Type][3])
    
    if (FCL.SkillsXP[Category][Type][3] == CurrentXP) or (FCL.SkillsXP[Category][Type][3] > CurrentXP) or (FCL.SkillsXP[Category][Type][3] == nil) then return end
    if (FCL.CText.Skills[Category][Type] == false) then return end
    
 
    diff = CurrentXP - previousXP
    lastRankXp, nextRankXP  = GetSkillLineXPInfo(8,Type)
    cLevelXP = nextRankXP - lastRankXp
    percent = string.format( "%.2f" , (CurrentXP/cLevelXP)*100)
    SkillName   = GetSkillLineInfo(8,Type)
    display = "|cc8ff3a+" .. diff .. " " .. SkillName ..  " (" .. percent .. "%)"
 
    FCL.SkillsXP[Category][Type][3] = CurrentXP
 
    
    if (FCL.CText.Time == true) then
        table.insert(FCL.CText.You, 1, "[" ..GetTimeString() .. "]" .. display)
    else    
        table.insert(FCL.CText.You, 1, display)
    end
    
    if FCL.CText.Chat == true then
        d(FCL.CText.You[1])
    end
    
    if FCL.Hiden == "You" then
        FCL.FadeTime = GetGameTimeMilliseconds()
        for i = 1, FCL.CText.MaxLines do
            if FCL.CText.You[FCL.Value + i] ~= nil then
                _G["CombatLog_Textbox"..i]:SetText(FCL.CText.You[FCL.Value + i])
            end
        end     
    end
    
end

although I would trust Garkin to know better than me in the subject

Only standard notation on the actual parameters to the event seem to be for the first three only (as used in the ESOUI official module inside game0000.dat). The rest/number of parameters seem to vary from module to module.

[katkat42]

Okay, I fixed a few things and posted a patch, here.