Thread Tools Display Modes
06/26/14, 10:32 AM   #21
CrazyDutchGuy
 
CrazyDutchGuy's Avatar
AddOn Author - Click to view addons
Join Date: Apr 2014
Posts: 89
Originally Posted by Garkin View Post
If I use d(zo_strformat("text <<t:1>>", itemLink), it will print "textitemlink" - all spaces in front of the itemlink are removed. Is there any way how to get it working correctly?
Lua Code:
  1. d(text .. " " .. zo_strformat("<<t:1>>", itemLink))
would be my guess
  Reply With Quote
06/26/14, 11:31 AM   #22
Garkin
 
Garkin's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2014
Posts: 832
Originally Posted by CrazyDutchGuy View Post
Lua Code:
  1. d(text .. " " .. zo_strformat("<<t:1>>", itemLink))
would be my guess
What is strange, it seems that original game texts does not suffer from this bug. That was the reason why I have asked if I'm doing something wrong.
So once again I will have to use workaround... *sigh*
  Reply With Quote
06/26/14, 01:43 PM   #23
CrazyDutchGuy
 
CrazyDutchGuy's Avatar
AddOn Author - Click to view addons
Join Date: Apr 2014
Posts: 89
I noticed more issues with the zo_strformat routine. It seems buggy, but there is nothing changed in the routine itself afaik...

Anyways the itemlink changes completely annoys me and breaks too much of my addons ...

Major issue is that i can't extract quality of the item, unless i own it in my bags ...
  Reply With Quote
06/26/14, 02:38 PM   #24
SkOODaT
 
SkOODaT's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2014
Posts: 58
http://forums.elderscrollsonline.com...nown-issues/p1

Finally but WOW Massive list
and at the bottom

UI

On-Screen Notifications Not Working: We’ve seen reports that you may no longer be getting on-screen notifications for things such as picking up a new Skyshard, getting a dungeon boss achievement, etc.
STATUS: Currently investigating
Names Dropping From UI: Loading into new zones and logging out sometimes causes group member names to drop out of the group UI.
STATUS: Currently investigating.


----->>>>> Addon Settings: The add-on settings currently are not working as intended.
STATUS: Currently investigating.
  Reply With Quote
06/26/14, 02:45 PM   #25
Xrystal
caritas omnia vincit
 
Xrystal's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Feb 2014
Posts: 369
I grabbed a new skyshard early this morning before I went to work and it displayed a message on the screen.
  Reply With Quote
06/26/14, 02:47 PM   #26
SkOODaT
 
SkOODaT's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2014
Posts: 58
Originally Posted by Xrystal View Post
I grabbed a new skyshard early this morning before I went to work and it displayed a message on the screen.
its a mess no one knows whats going on lol, i havent really played played ive been dealing with my UI and addons
  Reply With Quote
06/26/14, 04:30 PM   #27
Sasky
AddOn Author - Click to view addons
Join Date: Apr 2014
Posts: 231
Originally Posted by Deome View Post
I spent about 6 hours with Zgoo, /script, and /reloadui last night, and I have come to the conclusion that ZO is using some function NOT in the API to read the link's itemId, quality, and/or enchtId to generate a name. I would suspect that this is whatever they were using to do so before, when the name was included in the link, and some ZO developer just thought, "Why are we wasting bytes on this name when the client can parse it directly? Screw developers, we'll just do it that way."
One possible reason is I did start seeing some people messing with links to force coloring -- perhaps to get around the color filtering most people use. For example, a guild invite would pick a link to a random item and change the color and text. Sure, you wouldn't get anything by clicking it, but it makes it visually stand out.
  Reply With Quote
06/26/14, 11:09 PM   #28
Deome
 
Deome's Avatar
AddOn Author - Click to view addons
Join Date: Apr 2014
Posts: 29
Thumbs up

Originally Posted by Sasky View Post
One possible reason is I did start seeing some people messing with links to force coloring -- perhaps to get around the color filtering most people use. For example, a guild invite would pick a link to a random item and change the color and text. Sure, you wouldn't get anything by clicking it, but it makes it visually stand out.
That's another excellent reason. I've already switched to using itemId as an identifier, only had to update five or six lines of code. I've spent more time fiddling with tooltip colors.
  Reply With Quote
06/27/14, 04:00 AM   #29
sirinsidiator
 
sirinsidiator's Avatar
AddOn Author - Click to view addons
Join Date: Apr 2014
Posts: 1,568
Originally Posted by Deome View Post
That's another excellent reason. I've already switched to using itemId as an identifier, only had to update five or six lines of code. I've spent more time fiddling with tooltip colors.
Now they also show the link text in the receivers language which is exactly what everybody wished for all along, so please don't complain about it
  Reply With Quote
06/27/14, 04:15 AM   #30
farangkao
 
farangkao's Avatar
AddOn Author - Click to view addons
Join Date: May 2014
Posts: 59
If you are an Addon Developer (and hosting your addon on ESOUI) ,send me a PM for instructions how to check out ,how they use the API. I won't post anything public.
  Reply With Quote
06/27/14, 04:50 AM   #31
CrazyDutchGuy
 
CrazyDutchGuy's Avatar
AddOn Author - Click to view addons
Join Date: Apr 2014
Posts: 89
Originally Posted by sirinsidiator View Post
Now they also show the link text in the receivers language which is exactly what everybody wished for all along, so please don't complain about it
Actually I am complaining, as by the itemlink changes i can't determine the quality anymore based on the itemlink. Neither can i determine the itemname anymore from the itemlink. Also it has quite an impact if you use custom links.
  Reply With Quote
06/27/14, 07:40 AM   #32
Deome
 
Deome's Avatar
AddOn Author - Click to view addons
Join Date: Apr 2014
Posts: 29
Thumbs up

Originally Posted by sirinsidiator View Post
Now they also show the link text in the receivers language which is exactly what everybody wished for all along, so please don't complain about it
Actually, I'm not complaining. It may have added a week to the release of my addon, but as it already relies almost exclusively on item links to avoid building those huge nasty historic item info tables, it really was a quick switch. I'm a little grumpy that I can no longer search my SavedVars for a particular item by name, but I'm already making good use of those new trading house link functions so I'm happy.
  Reply With Quote
06/27/14, 08:05 AM   #33
Seerah
Fishing Trainer
 
Seerah's Avatar
WoWInterface Super Mod
AddOn Author - Click to view addons
Join Date: Feb 2014
Posts: 648
Originally Posted by CrazyDutchGuy View Post
Actually I am complaining, as by the itemlink changes i can't determine the quality anymore based on the itemlink. Neither can i determine the itemname anymore from the itemlink. Also it has quite an impact if you use custom links.
Instead, you should request that GetItemInfo takes an item link.
  Reply With Quote
06/27/14, 01:19 PM   #34
Xrystal
caritas omnia vincit
 
Xrystal's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Feb 2014
Posts: 369
Originally Posted by Seerah View Post
Instead, you should request that GetItemInfo takes an item link.
+ 2 to that request rofl ...
  Reply With Quote
06/27/14, 01:21 PM   #35
Xrystal
caritas omnia vincit
 
Xrystal's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Feb 2014
Posts: 369
Originally Posted by SkOODaT View Post
its a mess no one knows whats going on lol, i havent really played played ive been dealing with my UI and addons
Rofl, I haven't *played* in ages. Still working on my database site .. I just jump in now and then for a bit of light relief.
  Reply With Quote
06/27/14, 02:26 PM   #36
Harven
 
Harven's Avatar
AddOn Author - Click to view addons
Join Date: Apr 2014
Posts: 135
  • EVENT_SKILL_XP_UPDATE parameters are changed:

    EVENT_SKILL_XP_UPDATE(integer eventCode, integer skillType, luaindex skillIndex, integer unknown, integer skillCurrentRank, integer lastUpdateXP, integer currentXP)

    where:
    currentXP - lastUpdateXP = XP gained with this update,
    unknown - not sure what is this, was 0 when I tested.
  Reply With Quote
06/27/14, 02:56 PM   #37
Garkin
 
Garkin's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2014
Posts: 832
Originally Posted by Harven View Post
  • EVENT_SKILL_XP_UPDATE parameters are changed:

    EVENT_SKILL_XP_UPDATE(integer eventCode, integer skillType, luaindex skillIndex, integer unknown, integer skillCurrentRank, integer lastUpdateXP, integer currentXP)

    where:
    currentXP - lastUpdateXP = XP gained with this update,
    unknown - not sure what is this, was 0 when I tested.
the unknown should be a reason (source: EsoUI\Ingame\CenterScreenAnnounce\CenterScreenAnnounceHandlers.lua)
PROGRESS_REASON_ACHIEVEMENT
PROGRESS_REASON_ACTION
PROGRESS_REASON_ALLIANCE_POINTS
PROGRESS_REASON_AVA
PROGRESS_REASON_BATTLEGROUND
PROGRESS_REASON_BOOK_COLLECTION_COMPLETE
PROGRESS_REASON_BOSS_KILL
PROGRESS_REASON_COLLECT_BOOK
PROGRESS_REASON_COMMAND
PROGRESS_REASON_COMPLETE_POI
PROGRESS_REASON_DARK_ANCHOR_CLOSED
PROGRESS_REASON_DARK_FISSURE_CLOSED
PROGRESS_REASON_DISCOVER_POI
PROGRESS_REASON_DUNGEON_CHALLENGE
PROGRESS_REASON_EVENT
PROGRESS_REASON_FINESSE
PROGRESS_REASON_GRANT_REPUTATION
PROGRESS_REASON_GUILD_REP
PROGRESS_REASON_KEEP_REWARD
PROGRESS_REASON_KILL
PROGRESS_REASON_LOCK_PICK
PROGRESS_REASON_MEDAL
PROGRESS_REASON_NONE
PROGRESS_REASON_OTHER
PROGRESS_REASON_OVERLAND_BOSS_KILL
PROGRESS_REASON_PVP_EMPEROR
PROGRESS_REASON_QUEST
PROGRESS_REASON_REWARD
PROGRESS_REASON_SCRIPTED_EVENT
PROGRESS_REASON_SKILL_BOOK
PROGRESS_REASON_TRADESKILL
PROGRESS_REASON_TRADESKILL_ACHIEVEMENT
PROGRESS_REASON_TRADESKILL_CONSUME
PROGRESS_REASON_TRADESKILL_HARVEST
PROGRESS_REASON_TRADESKILL_QUEST
PROGRESS_REASON_TRADESKILL_RECIPE
PROGRESS_REASON_TRADESKILL_TRAIT

Last edited by Garkin : 06/27/14 at 02:59 PM.
  Reply With Quote
06/27/14, 06:19 PM   #38
Garkin
 
Garkin's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2014
Posts: 832
Originally Posted by Garkin View Post
If I use d(zo_strformat("text <<t:1>>", itemLink)), it will print "textitemlink" - all spaces in front of the itemlink are removed. Is there any way how to get it working correctly?
If itemLink does not contain text all spaces between text and link will be removed. However if link contain text, it works correctly.

My solution (my workaround ):
Lua Code:
  1. local function GetBetterItemLink(bagId, slotId, linkStyle)
  2.    local link = GetItemLink(bagId, slotId, linkStyle)
  3.    if link == "" then return end
  4.  
  5.    local name = GetItemName(bagId, slotId)
  6.    local data = link:match("|H.-:(.-)|h")
  7.  
  8.    if linkStyle == LINK_STYLE_BRACKETS then
  9.       return ("|H%s:%s|h[%s]|h"):format(LINK_STYLE_BRACKETS, data, name)
  10.    else
  11.       return ("|H%s:%s|h%s|h"):format(LINK_STYLE_DEFAULT, data, name)
  12.    end
  13. end
  14.  
  15. local itemLink = GetBetterItemLink(bagId, slotId)
  16. d(zo_strformat("text <<t:1>>", itemLink))
  Reply With Quote
06/28/14, 03:00 AM   #39
CrazyDutchGuy
 
CrazyDutchGuy's Avatar
AddOn Author - Click to view addons
Join Date: Apr 2014
Posts: 89
Originally Posted by Seerah View Post
Instead, you should request that GetItemInfo takes an item link.
I should, but it might be better to consolidate a list with bugs and changes perhaps ?
  Reply With Quote
06/30/14, 02:58 AM   #40
Flagrick
 
Flagrick's Avatar
AddOn Author - Click to view addons
Join Date: Apr 2014
Posts: 24
Originally Posted by Garkin View Post
Itemlinks are now different. This is how itemlink looks like on PTS:
Code:
|H0:item:54513:3:9:45870:3:9:0:0:0:0:0:0:0:0:0:5:0:0:0:0|h|h
|H0:item:793:1:5:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0|h|h
|H0:item:45024:19:12:26848:19:12:0:0:0:0:0:0:0:0:0:9:0:0:124:0|h|h
New format is:
Lua Code:
  1. "|H" .. linkStyle .. ":" .. linkType .. ":" .. data .. "|h" .. text .. "|h"
Variable "text" is usualy empty string, at least in links generated using the GetItemLink(bagIndex, slotIndex) and links which you get from events (tested with EVENT_LOOT_RECEIVED and EVENT_INVENTORY_SINGLE_SLOT_UPDATE).

New CreateLink and ParseLink functions:
Lua Code:
  1. function ZO_LinkHandler_CreateLink(text, color, linkType, ...) --where ... is the data to encode
  2.     if linkType then
  3.         return ("|H%d:%s|h[%s]|h"):format(LINK_STYLE_BRACKETS, zo_strjoin(':', linkType, ...), text)
  4.     end
  5. end
  6.      
  7. function ZO_LinkHandler_ParseLink(link)
  8.     if type(link) == "string" then
  9.         local linkStyle, data, text = link:match("|H(.-):(.-)|h(.-)|h")
  10.         return text, linkStyle, zo_strsplit(':', data)
  11.     end
  12. end
In LootDrop, i was using itemlink's texts from EVENT_LOOT_RECEIVED to obtain QuestTool's icons by associations. Now, i 've got no text in itemlinks.

Someone know how to obtain plein text from this itemlinks ? is there an API function fro that ?
  Reply With Quote

ESOUI » Developer Discussions » General Authoring Discussion » Changes on PTS 1.2.2

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off