My code is acting up

zireko · 10/26/14, 11:59 AM

Here is the thing I got my code working however it's not working at the entry of a new zone. The addon I'm working on is pretty simple. When you go to a zone it just pulls up a little info that lets you know how many quest that are there. I added the quest list myself using esohead and a little typing magic lol. But to give you an idea of what is happining when I go from one zone to another the addon doesn't update when you get to the new zone. I had to type /reloadui to get it to load the zone. I'll leave my code below so you can have a better look at it.

lua

Lua Code:

QuestVars = {}
 
QuestVars.Defaults = {
    ["hideQuest"] = false,
    ["Quest"] = {
        ["offsetx"] = 0,
        ["offsety"] = 0,
        ["point"] = TOPLEFT,
        ["relPoint"] = TOPLEFT,
        },
}
 
local quests ={
--Aldmeri Dominion
    ["Auridon"] = 51, 
    ["Khenarthi's Roost"] = 11,
    ["Grahtwood"] = 44,
    ["Greenshade"] = 50,
    ["Malabal Tor"]= 45, 
    ["Reaper's March"] = 60,
    ["Coldharbour"] = 32,
 
--Daggerfall Covenant
    ["Stros M'Kai"] = 15,
    ["Betnikh"] = 9,
    ["Glenumbra"] = 67,
    ["Stormhaven"] = 70,
    ["Rivenspir"] = 48,
    ["Alik'r Desert"] = 53,
    ["Bangkorai"] = 47,
    
--Ebonheart Pact
    ["Bleakrock Isle"] = 12,
    ["Bal Foyen"] = 9,
    ["Stonefalls"] = 76,
    ["Deshaan"] = 67,
    ["Shadowfen"] = 64,
    ["Eastmarch"] = 52,
    ["The Rift"] = 73, 
 
--Quest For All Factions
    ["Coldharbour"] = 32,
    
--Guild Quest 
    --["Fighters Guild"] = 5, 
    --["Mages Guild"] = 8,
}
 
--Function for pulling up zone and how many quests, QuestZone will be the name of the function connecting to line 26 
 
 
local function ZoneQuest()
        local myZone = GetUnitZone("player")
        local numQuests = quests[myZone]
        QuestLurkerQuest:SetText(myZone..": "..numQuests)
end
 
local function OnMoveStopQuest()
    _, QuestVars.SV.Quest.point, _, QuestVars.SV.Quest.relPoint, QuestVars.SV.Quest.offsetx, QuestVars.SV.Quest.offsety = QuestLurker:GetAnchor(0)
end
 
local function LoadSavedVars()
    QuestLurker:SetAnchor(QuestVars.SV.Quest.point, nil, QuestVars.SV.Quest.relPoint, QuestVars.SV.Quest.offsetx, QuestVars.SV.Quest.offsety)
end
 
local function OnAddOnLoaded(eventCode, addon)
    if addon == "QuestLurker" then
        QuestVars.SV = ZO_SavedVars:New( "Que_Variables" , 2 , nil , QuestVars.Defaults , nil )
        if (QuestVars.SV ~= nil) then
               LoadSavedVars()
        end
        QuestLurker:SetHandler("OnMoveStop", OnMoveStopQuest)
        --QuestLurker:SetHandler("OnMouseDown", MyAddonQuestZone)
        EVENT_MANAGER:RegisterForEvent("QuestLurkerZone", EVENT_ZONE_CHANGED, ZoneQuest)
        ZoneQuest()
    end
end
 
 
EVENT_MANAGER:RegisterForEvent("QuestLurker", EVENT_ADD_ON_LOADED, OnAddOnLoaded)

xml

Lua Code:

<GuiXml>
    <Controls>
        <TopLevelControl name="QuestLurker" mouseEnabled="true" movable="true" hidden="false" resizeToFitDescendents="true">        
                <Controls>
                <Backdrop name="$(parent)BG" inherits="ZO_ThinBackdrop" excludeFromResizeToFitExtents="true">
                    <AnchorFill />
                </Backdrop>
                
                <Label name="$(parent)Quest" font="ZoFontWindowTitle" color="CFDCBD" wrapMode="ELLIPSIS" verticalAlignment="CENTER" horizontalAlignment="CENTER">
                    <Anchor point="CENTER" realtiveTo="$(parent)" realtivePoint="CENTER" offsetX="0" offsetY="0" />
                </Label>
            </Controls>
        </TopLevelControl>
    </Controls>
</GuiXml>

txt

Lua Code:

## Title: |cFFFFB0QuestLurker|r 1.0 by - |c00C000Zireko & KatKat42|r
## APIVersion: 100009
## Description: QuestLurker lets you know how many quest are in the current zone you are in. This Addon will work great with other addons that let you know what quests you have finished.
## Version: 1.0
## SavedVariables: Que_Variables
 
QuestLurker.xml
QuestLurker.lua

If you see what is wrong try and explain in the simplest way possible. I'm still new to coding and explanations help me a lot.

circonian · 10/27/14, 12:13 AM

Here is what I see:

you have

Lua Code:

local function OnAddOnLoaded(eventCode, addon)
...
-- Specifically refering to the line below,
ZoneQuest()
...

If your wanting that to fire, to print the zoneName when the user logs in you need to do it after the player Activated event by adding:

Lua Code:

-- Add this to make it print the zone when the char activates:
local function OnPlayerActivated()
        ZoneQuest()
end
local function OnAddOnLoaded(eventCode, addon)
   if addon == "QuestLurker" then
   ....
   -- Add this to make it print the zone when the char activates:
   EVENT_MANAGER:RegisterForEvent("QuestLurker", EVENT_PLAYER_ACTIVATED, OnPlayerActivated) 
   ...

You might want to add clampedToScreen to the control so it can't go off of the screen
and give your window a starting dimension & anchor point in your xml file

Lua Code:

<TopLevelControl name="QuestLurker" clampedToScreen="true"  mouseEnabled="true" movable="true" hidden="false" resizeToFitDescendents="true">  
   <Dimensions x="150" y="150" />
   <Anchor point="TOPLEFT" relativeTo="GuiRoot" relativePoint="TOPLEFT" offsetX="50" offsetY="50"/>   
   ...

Make this local, It only holds the defaults, no reason for it to be accessible globally

Lua Code:

local QuestVars.Defaults = { ....}

And there are a couple of small errors here too:

Lua Code:

local function OnMoveStopQuest()
    -- Change This: 
    -- _, QuestVars.SV.Quest.point, _, QuestVars.SV.Quest.relPoint, QuestVars.SV.Quest.offsetx, QuestVars.SV.Quest.offsety = QuestLurker:GetAnchor(0)
    
    -- To This:
    -- Even if you dont want those values that are returned, define them so they are local
    -- You don't want to leave the _'s open to the global namespace)
    local bIsValid, relativeTo
    bIsValid, QuestVars.SV.Quest.point, relativeTo, QuestVars.SV.Quest.relPoint, QuestVars.SV.Quest.offsetx, QuestVars.SV.Quest.offsety = QuestLurker:GetAnchor(0)
end
 
local function LoadSavedVars()
    -- Always clear anchors before setting them
    QuestLurker:ClearAnchors()
    
    QuestLurker:SetAnchor(QuestVars.SV.Quest.point, nil, QuestVars.SV.Quest.relPoint, QuestVars.SV.Quest.offsetx,QuestVars.SV.Quest.offsety)
end

Lua Code:

local function OnAddOnLoaded(eventCode, addon)
    if addon == "QuestLurker" then
        QuestVars.SV = ZO_SavedVars:New( "Que_Variables" , 2 , nil , QuestVars.Defaults , nil )
        if (QuestVars.SV ~= nil) then
            LoadSavedVars()
        end
        QuestLurker:SetHandler("OnMoveStop", OnMoveStopQuest)
        QuestLurker:SetHandler("OnMouseDown", MyAddonQuestZone)
        
        -- Add this to make it print the zone when the char activates:
        EVENT_MANAGER:RegisterForEvent("QuestLurker", EVENT_PLAYER_ACTIVATED, OnPlayerActivated) 
        -- Change this line:
        EVENT_MANAGER:RegisterForEvent("QuestLurker", EVENT_ZONE_CHANGED, ZoneQuest)
        
        -- Add this to unregister your OnAddOnLoaded (it only needs to load once):
        EVENT_MANAGER:UnregisterForEvent("QuestLurker", EVENT_ADD_ON_LOADED)
        end
end

Garkin · 10/27/14, 04:48 AM

Originally Posted by circonian

Here is what I see:

You have the wrong addon name in your register for event:

Lua Code:

EVENT_MANAGER:RegisterForEvent("QuestLurkerZone", EVENT_ZONE_CHANGED, ZoneQuest)
 
-- The first parameter is supposed to be the name of your addon, which is QuestLurker so it should be this:
EVENT_MANAGER:RegisterForEvent("QuestLurker", EVENT_ZONE_CHANGED, ZoneQuest)

The first argument is unique name for event handler (single event can't have two handlers with the same name). Handler name doesn't have to be addon name, you can use "QuestLurkerZone" or whatever else.

Originally Posted by circonian

Lua Code:

local function LoadSavedVars()
    -- Always clear anchors before setting them
    QuestLurker:ClearAnchors()
   
    -- You also need to specify what you are anchoring to, GuiRoot is the main window
    QuestLurker:SetAnchor(QuestVars.SV.Quest.point, GuiRoot, QuestVars.SV.Quest.relPoint, QuestVars.SV.Quest.offsetx,QuestVars.SV.Quest.offsety)
end

If you leave second argument (anchorTargetControl) nil, control will be automatically anchored to its parent - in this case to GuiRoot. There's no need to change code.

My comments:

Your code won't work in zones which are not in the quests table. You will get an error ".. is not supported for string .. nil". Either check if numQuest is not nil or use local numQuests = quests[zoneIndex] or "".
It could be a good idea to use zone index instead of zone name (because of localized zone names).

Example:

Lua Code:

local quests ={
--Aldmeri Dominion
    [179] = 51, --Auridon
    [295] = 11, --Khenarthi's Roost
    [181] = 44, --Grahtwood
    [19]  = 50, --Greenshade
    [12]  = 45, --Malabal Tor
    [180] = 60, --Reaper's March
    [155] = 32, --Coldharbour
 
    --rest of the table
    --Full list of zoneIndex codes is here: [url]http://www.esoui.com/forums/showpost.php?p=12693[/url]
}
 
local function ZoneQuest()
    local myZone = GetUnitZone("player")
    local zoneIndex = GetCurrentMapZoneIndex()
    local numQuests = quests[zoneIndex]
    if numQuests ~= nil then
        QuestLurkerQuest:SetText(myZone..": "..numQuests)
        QuestLurker:SetHidden(false)
    else
        QuestLurker:SetHidden(true)
    end
end

circonian · 10/27/14, 05:13 AM

I knew it had to be unique, but I also thought it had to be the addon name.
I didn't know if you left it nil it would use GuiRoot either.

I edited my post to remove those comments to avoid confusion.
Nice to know, thanks for the info.

merlight · 10/27/14, 06:10 AM

Originally Posted by Garkin

If you leave second argument (anchorTargetControl) nil, control will be automatically anchored to GuiRoot.

Control's parent, actually. Which in this case happens to be GuiRoot

Garkin · 10/27/14, 07:43 AM

Originally Posted by merlight

Control's parent, actually. Which in this case happens to be GuiRoot

You're right, I have corrected it in my answer.

zireko · 10/27/14, 03:40 PM

I cleaned up a lot of this code from looking at all your suggestions. Only thing I haven't done yet is used Garkins suggestion for the zone index. However I think I want to do this and this is going to take a while to get all zones in lol I think it showed near 400 something zones or more. I want to add something that can track a little better like in if you done all the quest in the area or not. If any suggestions let me know. I will probably need help with the code. However you all are making me a lot better at this. Thank you all for the info and help.

Garkin · 10/27/14, 04:00 PM

You can use achievements to check how many quests you have finished. You will need this function (copied from the documentation):

GetAchievementCriterion(achievementId, criterionIndex)
Returns: description, numCompleted, numRequired

Achievement is for example Auridon Adventurer, achievement ID 604 (number in url), this achievement has just one criteria, so criterionIndex will be 1 and you want to know how many quests you have already finished (numCompleted).

Lua Code:

local _, numCompleted = GetAchievementCriterion(604, 1)
d("You have finished " .. numCompleted .. " quests in Auridon.")

zireko · 10/27/14, 04:21 PM

I'm trying to understand how that works. If the achievement is only 37 quest and there are 51 quest in Auridon wouldn't it just say your finished after you do 37 quest instead of the actual 51 quest?

If I use this I want it to be a constant reminder for the user of questlurker. Would I have to make another window like the current one that says the zone name and quest number in it.

I just finished adding the zone index you suggested Garkin. Thank you it seems to work a lot better when you go to areas that are not in the list. So now it's not poping an error every time someone goes to a place I haven't added yet.

Garkin · 10/27/14, 05:47 PM

Originally Posted by zireko

I'm trying to understand how that works. If the achievement is only 37 quest and there are 51 quest in Auridon wouldn't it just say your finished after you do 37 quest instead of the actual 51 quest?

Also if you could where do I find the achievementid like you said 604 was Auridon so how do I find that number for each achivment?

I'm not sure how it actually works, you will have to try it by yourself. But for example main quests have their own achievements, so they are not counted to the zone achievement.

Achievement IDs can be found:
- Esohead (I gave you link in previous post, number in URL is achievement ID)
- this post: http://www.esoui.com/forums/showthread.php?t=2117
- using the Zgoo addon (place mouse over achievement in Journal and type /zgoo mouse, in Zgoo window find table achievement and its key achievementId)
- using the script which can be run from addon code or from ZAM Notebook, something like this:

Lua Code:

for i = 1, GetNumAchievementCategories() do
    local _, numSubCategories, numAchievements = GetAchievementCategoryInfo(i)
    for k = 1, numAchievements do
        local achievementId = GetAchievementId(i, nil, k)
        local name = GetAchievementInfo(achievementId)
        d( ("%04d: %s"):format(achievementId, name) )
    end
    if numSubCategories > 0 then
        for j = 1, numSubCategories do
            local _, numAchievements = GetAchievementSubCategoryInfo(i, j)
            for k = 1, numAchievements do
                local achievementId = GetAchievementId(i, j, k)
                local name = GetAchievementInfo(achievementId)
                d( ("%04d: %s"):format(achievementId, name) )
            end
        end
    end
end