Double output

[Balver]

I'm trying to modify an outdated addon (El Chivato) for myself and there's a bug I can't fix with my limited coding knowledge.
When I complete a quest the XP appear twice.


The code I use is:

local function PrintXP(color, text)
    -- convert text to string to prevent passing nil arguments to d
    d(color .. tostring(text))
end
 
 
-- Finish a Quest
local function OnQuestCompleteXP(event, questName, level, prevXP, newXP, rank, prevVP, newVP)
        PrintXP(colors.Quest, "Completed Quest: " .. questName ..". +" .. newXP - prevXP .. " XP")
end
 
-- Finish a Quest
EVENT_MANAGER:RegisterForEvent(Chivato.name, EVENT_QUEST_COMPLETE, OnQuestCompleteXP)

In the Wiki I read "- For some quests, can triggers twice " for EVENT_QUEST_COMPLETE so it seems to be an API problem.
Is there a way to prevent a double output?

And when I'm here already, how do I get rid of the suffixes in German names? I've seen that other addons managed to do this.



Thanks in advance!

[Garkin]

1) I'd try to save previous experience and compare if experience was changed.
2) I recommend using zo_strformat to remove suffixes.

[Baertram]

About the format you could use this snippet:

local formattedText = zo_strformat('<<C:1>>', unformatedText)

unformatedText is your variable with the german names, containing e.g. "Sturmhang-Krypta^fd,in".
formatedText should be the new variable without the extra stuff, like "Die Sturmhang-Krypta".


For the double output Garkin is right. You could realize it like this:

--local variable array in your addon, outside OnQuestCompleteXP
local helperVars = {}
helperVars.lastXPGainedQuestName = ""
helperVars.lastXPGainedXP = 0
 
-- Finish a Quest
local function OnQuestCompleteXP(event, questName, level, prevXP, newXP, rank, prevVP, newVP)
    local xpGained = newXP - prevXP
    if helperVars.lastXPGainedQuestName ~= questName and helperVars.lastXPGainedXP ~= xpGained then
        PrintXP(colors.Quest, "Completed Quest: " .. questName ..". +" .. xpGained .. " XP")
        helperVars.lastXPGainedQuestName = questName
        helperVars.lastXPGainedXP = xpGained
    end
end

Wenn du noch Fragen hast schreib mir 'ne PM

[Garkin]

local previousXP = 0
 
local function PrintXP(color, text)
    -- convert text to string to prevent passing nil arguments to d
    d(color .. tostring(text))
end
 
-- Finish a Quest
local function OnQuestCompleteXP(event, questName, level, prevXP, newXP, rank, prevVP, newVP)
    local currentXP = GetUnitXP("player")
    local gain = currentXP - previousXP
 
    if gain > 0 then
        PrintXP(colors.Quest, zo_strformat("Completed Quest: <<t:1>>. +<<2>> XP", questName, gain))
        previousXP = currentXP
    end
end
 
-- Finish a Quest
EVENT_MANAGER:RegisterForEvent(Chivato.name, EVENT_QUEST_COMPLETE, OnQuestCompleteXP)
 
--get initial XP value
local function OnUnitCreated(event, unitTag)
    if unitTag == "player" then
        previousXP = GetUnitXP("player")
    end
end
 
EVENT_MANAGER:RegisterForEvent(Chivato.name, EVENT_UNIT_CREATED, OnUnitCreated)

[circonian]

I was typing something up, but I'm to slow.
Although if they gain xp from some form other than a quest (discovery or something) and then complete a quest that will show the wrong xp gain because its printing currentXP - previousXP and previousXP is only set when completing a quest, so:

-- Finish a Quest
local function OnQuestCompleteXP(event, questName, level, prevXP, newXP, rank, prevVP, newVP)
    --local currentXP = GetUnitXP("player")
   -- local gain = currentXP - previousXP
 
   -- if gain > 0 then
    if newXP > previousXP then
        local xpGain = newXP - prevXP
        --PrintXP(colors.Quest, zo_strformat("Completed Quest: <<t:1>>. +<<2>> XP", questName, gain))
        PrintXP(colors.Quest, zo_strformat("Completed Quest: <<t:1>>. +<<2>> XP", questName, xpGain))
        --previousXP = currentXP
        previousXP = newXP 
    end
end

[Ayantir]

I had reported this bug since months, because for some quests, EVENT_QUEST_COMPLETE can fires twice.

I've personally set an internal cooldown of 2 seconds
(you can check questname with parameter given by the event

[Garkin]

Originally Posted by circonian I was typing something up, but I'm to slow. Although if they gain xp from some form other than a quest (discovery or something) and then complete a quest that will show the wrong xp gain because its printing currentXP - previousXP and previousXP is only set when completing a quest, so:

True, I didn't think about it. I was always using EVENT_EXPERIENCE_UPDATE where are all XP gains.

[Baertram]

Thats why I had used the questName + newXP for the comparison, and not the total gained XP (player current - prevXP).

[Balver]

Thanks for the help guys.
I fiddled the code together and it worked at first, but after a /reloadui I got an error

2015-03-13T04:12:29.501+01:00 |cff0000Lua Error: user:/AddOns/Chivato/Chivato.lua:78: operator < is not supported for nil < number
stack traceback:
	user:/AddOns/Chivato/Chivato.lua:78: in function 'OnQuestCompleteXP'|r

Could it be, that EVENT_UNIT_CREATED only fires at login? I replaced it with EVENT_ADD_ON_LOADED and now it works fine.
German suffixes are gone too, thanks again.