Attempt to index a nil value confusion

[Randactyl]

Hi all.

I'm trying to access an variable with a value from my saved variables, but ESO is complaining that the variable is nil.

This is the line in question:

if(Imperialization.savedVariables.ConvertOnEquip == true) then

This is executed by a function fired by EVENT_INVENTORY_SINGLE_SLOT_UPDATE.

If this line is not present, references just a few lines down in the same function to other items in my saved variables are picked up just fine. The error also only comes up at login, but not after a ui reload.

I've tried deleting the saved variables .lua file and starting from scratch, but still this issue persists.

Any help would be greatly appreciated!

[Sasky]

Is the variable for your SavedVars properly initialized before this?

The error is happening because either Imperialization is nil or Imperialization.savedVariables is nil.

(Also check for typo in those two. Always happens when you least expect it...)

[farangkao]

And remember you can safeguard your code

if Imperialization.savedVariables then
if Imperialization.savedVariables.ConvertOnEquip then
-- do your stuff
end

else
d("Error No Saved Variables here")
end



When you do a test like "if <variable> then" ,the code will only run if the variable is not nil or not false (nil = means not initialized)

[Garkin]

The easiest way to fix this issue is to register event after you have saved variables available - i.e. move event registration to the Initialize function:

function Imperialization:Initialize()
    Imperialization.savedVariables = ZO_SavedVars:New("ImperializationVariables", Imperialization.version, nil, Imperialization.Default)
    LAM2:RegisterAddonPanel("ImperializationSettings", panelData)
    LAM2:RegisterOptionControls("ImperializationSettings", optionsData)
    EVENT_MANAGER:RegisterForEvent(Imperialization.name, EVENT_INVENTORY_SINGLE_SLOT_UPDATE, Imperialization.OnInventorySlotUpdate)
    EVENT_MANAGER:UnregisterForEvent(Imperialization.name, EVENT_ADD_ON_LOADED)
end
 
EVENT_MANAGER:RegisterForEvent(Imperialization.name, EVENT_ADD_ON_LOADED, Imperialization.OnAddOnLoaded)

By the way I think it's not a good idea to use addon version as a version of your saved variables. It will reset everything to the defaults with each new addon version.

EDIT:
Another suggestion - Conditions you use looks rather complicated. If you use itemSyle as a key in your saved variables, you can use much easier condition:

local itemStyle = select(7, GetItemInfo(bagID, slotID))
if Imperialization.savedVariables[itemStyle] == true then
    if(Imperialization.savedVariables.DisplayResults) then
        d(zo_strformat("<<t:1>> converted from the <<2>> style!", GetItemLink(bagID, slotID, LINK_STYLE_BRACKETS), GetString("SI_ITEMSTYLE", itemStyle)))
    end
end

[Randactyl]

Originally Posted by Garkin The easiest way to fix this issue is to register event after you have saved variables available - i.e. move event registration to the Initialize function: function Imperialization:Initialize()     Imperialization.savedVariables = ZO_SavedVars:New("ImperializationVariables", Imperialization.version, nil, Imperialization.Default)     LAM2:RegisterAddonPanel("ImperializationSettings", panelData)     LAM2:RegisterOptionControls("ImperializationSettings", optionsData)     EVENT_MANAGER:RegisterForEvent(Imperialization.name, EVENT_INVENTORY_SINGLE_SLOT_UPDATE, Imperialization.OnInventorySlotUpdate)     EVENT_MANAGER:UnregisterForEvent(Imperialization.name, EVENT_ADD_ON_LOADED) end   EVENT_MANAGER:RegisterForEvent(Imperialization.name, EVENT_ADD_ON_LOADED, Imperialization.OnAddOnLoaded) By the way I think it's not a good idea to use addon version as a version of your saved variables. It will reset everything to the defaults with each new addon version. EDIT: Another suggestion - Conditions you use looks rather complicated. If you use itemSyle as a key in your saved variables, you can use much easier condition: local itemStyle = select(7, GetItemInfo(bagID, slotID)) if Imperialization.savedVariables[itemStyle] == true then     if(Imperialization.savedVariables.DisplayResults) then         d(zo_strformat("<<t:1>> converted from the <<2>> style!", GetItemLink(bagID, slotID, LINK_STYLE_BRACKETS), GetString("SI_ITEMSTYLE", itemStyle)))     end end

Wow, Garkin you really went above and beyond! Thank you, and everyone else, so much for the help!
Now that it has been pointed out the mistake seems silly. And yes, my conditions quickly got out of hand
Now seems like the best time to reign all of this stuff back in.