Quantcast EVENT_PLAYER_COMBAT_STATE timing incorrect? - ESOUI
Thread Tools Display Modes
07/29/14, 05:04 PM   #1
mattmillus
AddOn Author - Click to view addons
Join Date: May 2014
Posts: 13
EVENT_PLAYER_COMBAT_STATE timing incorrect?

Hi guys, something strange came up while coding my new combat logging addon..

It seems that EVENT_PLAYER_COMBAT_STATE events come in before EVENT_COMBAT_EVENT -> ACTION_RESULT_DIED (and the associated damage events for the final killing blow)

The picture should pretty much say it all:


Has anyone else noticed such things? Does the game not have some sort of event queue that guarantees ordering? Advice appreciated on this, I am considering using an asynchronous timer to delay my HandleLeaveCombat() function until like 0.1 seconds after EVENT_PLAYER_COMBAT_STATE comes in, but this seems like a **** hack.
  Reply With Quote
07/29/14, 05:57 PM   #2
Xrystal
caritas omnia vincit
 
Xrystal's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Feb 2014
Posts: 369
I'm not sure how it would affect things but you could have it so that it only tracks normal state after player state has been processed, then once normal state has been checked it stops tracking it until the next player state.

Theoretically it should then have your player state reports before the normal state reports.

EG.

Lua Code:
  1. function CombatEvent(eventID,...)
  2.     -- Process Regular Combat Events
  3.     UnregisterEvent(blah,eventID)
  4. end
  5.  
  6. function PlayerCombatState(eventID,...)
  7.     -- Process Player Combat Events
  8.     RegisterEvent(blah,EVENT_COMBAT_EVENT,CombatEvent)
  9. end
  10.  
  11. RegisterEvent(blah,EVENT_PLAYER_COMBAT_STATE,playerCombatState)

Of course, memory recalls that event buffering is a suggestion, so it might be worth checking out http://wiki.esoui.com/Event_%26_Update_Buffering to see how it can be done in your situation. It might prove to be the better choice with stopping event tracking possibly missing events needed.

Of course I am falling asleep so I may be totally wrong in both suggestions
  Reply With Quote
07/30/14, 10:30 AM   #3
Iyanga
AddOn Author - Click to view addons
Join Date: Apr 2014
Posts: 185
Originally Posted by mattmillus View Post
Has anyone else noticed such things?
Yes.
Been there, done that.

Lua Code:
  1. function Battlelog.CombatStateChange(eventCode, inCombat)
  2.   if inCombat == true then
  3.     EVENT_MANAGER:RegisterForEvent("Battlelog", EVENT_COMBAT_EVENT, Battlelog.ProcessEvent)
  4.   else
  5.     zo_callLater(Battlelog.UnregisterCombat, 500)
  6.   end    
  7. end
  Reply With Quote
07/30/14, 02:28 PM   #4
mattmillus
AddOn Author - Click to view addons
Join Date: May 2014
Posts: 13
Thank you for that.

Out of curiousity I also had a check how the 'Recount' addon handling this whacky behavior. Lo and behold, its the exact same thing you do:

Code:
function Recount.playerExitCombat()
	if (Recount.inCombat == true) and (Recount.onExitCombat == false) then	
		Recount.onExitCombat = true;
		zo_callLater(Recount.doPlayerExitCombat, 1000)
	end
end
Only difference is the 1second vs 500ms delay. I am going to implement this the same way, with zo_callLater(), at least until ZO fixes the event triggering!

EDIT: Testing and this is working great, even with a 1ms delay - no need for 500ms

Last edited by mattmillus : 07/30/14 at 02:47 PM.
  Reply With Quote

ESOUI » Developer Discussions » General Authoring Discussion » EVENT_PLAYER_COMBAT_STATE timing incorrect?

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off