How to detect when I have used some bait

Originally Posted by SnowmanDK I can say that what you wrote above returns worldMap no matter what map I have showing. I tried while showing Tamriel, Coldharbour, Craglorn and Davon's Watch. Edit: Now I am slow again From your edit, then I assume I should make something like this on addon load?: ZO_PreHookHandler("worldMap", "OnShow", myfunctiononshow) or did I miss something?

no I missed something, i was looking for an example with a scene-manager function (which would have used "worldMap" ) when I found my PreHookHandler that need the control name, not the scene name

maybe /zgoo mouse or /zgoo SCENE while on a map and browse around to find that map "panel" name that begins with ZO_

it's a bit frustrating to not be able to load a char... circonian? help? OK this time I go to bed for real. gn8

[SnowmanDK]

Originally Posted by Wandamey no I missed something, i was looking for an example with a scene-manager function (which would have used "worldMap" ) when I found my PreHookHandler that need the control name, not the scene name maybe /zgoo mouse or /zgoo SCENE while on a map and browse around to find that map "panel" name that begins with ZO_ it's a bit frustrating to not be able to load a char... circonian? help? OK this time I go to bed for real. gn8

Well have a good night
I can tell that
/zgoo mouse
returned
GetName()= "ZO_WorldMapContainer"
GetOwningWindow()= "ZO_WorldMap"
GetParent()= "ZO_WorldMapScroll"

I lied, i looked into a map mod instead of going to bed and found ZO_WorldMap too

try

ZO_PreHookHandler(ZO_WorldMap, "OnShow", UpdateBaitsCount)

and if it works it will be the one line function that does all of what you dreamt
and now i think i can sleep

[merlight]

Originally Posted by SnowmanDK For now I have ended up with this (a kind of a mix): --             if     string.find(icon, "centipede") then  --Crawlers                 ...

Just a little tip to make that part more concise with just two string matches (using a table for counts instead of individual local vars):

-- at file scope
local bait_to_water = {
  centipede="Foul", fish_roe="Foul",
  torchbug="River", shad="River",
  worms="Ocean", fish_tail="?",
  guts="Lake", river_betty="Lake"
}
 
-- in func
  local counts = {}
 
-- in loop
  local k = icon:match("centipede|fish_roe|torchbug|shad|worms|fish_tail|guts|river_betty")
  local water = bait_to_water[k]
  if water == "?" then
    if name:find("simple|einfacher|appât") then --Simle Bait
        water = "General"
    else    --Chub
        water = "Ocean"
    end
  end
  if water then
    counts[water] = (counts[water] or 0) + stack
  end

[SnowmanDK]

First, merry christmas, happy hanuka, or whatever

With the great help from all you guys, then I ended with what I think is my final code.
I may no have used what you all suggested, but you still inspired me
function:

local function UpdateBaitAmount()
    if DestinationsSV.filters[PINS_FISHING_SHOW_BAIT_LEFT] then
        local numLures = GetNumFishingLures()
        local oldBaitCount = defaults.data.FoulBaitLeft + defaults.data.FoulSBaitLeft + defaults.data.RiverBaitLeft + defaults.data.RiverSBaitLeft + defaults.data.OceanBaitLeft + defaults.data.OceanSBaitLeft + defaults.data.LakeBaitLeft + defaults.data.LakeSBaitLeft + defaults.data.GeneralBait
        local baitCount = 0
        for lureIndex=1, numLures do
            if stack then
                baitCount = baitCount + stack
            end
        end
        if baitCount ~= oldBaitCount then
            LMP:RefreshPins(PINS_FISHING)
        end
    end
end

call:

ZO_PreHookHandler(ZO_WorldMap, "OnShow", UpdateBaitAmount)

I know I COULD have chosen to just fire the LMP:RefreshPins(PINS_FISHING) every time the map opens to skip the comparison of stacks, but I think this will have a smaller impact on the game.

don't forget this
local name, icon, stack, sellPrice, quality = GetFishingLureInfo(lureIndex)
before using the stack variable.


And idk what happens in refresh pins, if you refresh your data there or not, but in case, as the call is already done to count the stacks in this loop, you might as well update your saved variables right away (with the name and icon check) for the next check.
You'll have to do it at some point and the call is done so... Beside these are very small loops and in UI mode it's not like you're looting zombies in the middle of a swarm.

also, if i lose 2 worms and find 2 minows, it wont update.

but i'm not sure what you are displaying though : the total number of baits? or the total for this water type? or each type amout for the water?

[SnowmanDK]

Originally Posted by Wandamey don't forget this local name, icon, stack, sellPrice, quality = GetFishingLureInfo(lureIndex) before using the stack variable. And idk what happens in refresh pins, if you refresh your data there or not, but in case, as the call is already done to count the stacks in this loop, you might as well update your saved variables right away (with the name and icon check) for the next check. You'll have to do it at some point and the call is done so... Beside these are very small loops and in UI mode it's not like you're looting zombies in the middle of a swarm. also, if i lose 2 worms and find 2 minows, it wont update. but i'm not sure what you are displaying though : the total number of baits? or the total for this water type? or each type amout for the water?

Ooops deleted that part by accident: "GetFishingLureInfo(lureIndex)"
It always does it's initial count on player load, so that part is covered.
In regards to the chance of getting 2 of one bait and loosing 2 of another, then you are right. The chance of that happening is small, but I guess I should count them individually.
Thanks for the tips

My pins show this (example, depending on settings in Destinations. They can all be toggled)
achievement name
rare fish name (the fish names can be only the ones missing, OR all for the acheivement)
rare fish name
rare fish name
water type (foul, ocean etc.)
optimal primary bait name/optimal rare bait name
primary bait left/rare bait left/simple bait left (if any)

[votan]

Originally Posted by SnowmanDK I can say that what you wrote above returns worldMap no matter what map I have showing. I tried while showing Tamriel, Coldharbour, Craglorn and Davon's Watch. Edit: Now I am slow again From your edit, then I assume I should make something like this on addon load?: ZO_PreHookHandler("worldMap", "OnShow", myfunctiononshow) or did I miss something?

Although I still don't understand, why not doing the count upon first tooltip, checking if the world map is shown or about to be shown can be done this way:

local function WorldMapStateChanged(oldState, newState)
        if (newState == SCENE_FRAGMENT_SHOWING) then
        elseif (newState == SCENE_FRAGMENT_SHOWN) then
        end
end
WORLD_MAP_SCENE:RegisterCallback("StateChange", WorldMapStateChanged)

[SnowmanDK]

Originally Posted by votan Although I still don't understand, why not doing the count upon first tooltip, checking if the world map is shown or about to be shown can be done this way: local function WorldMapStateChanged(oldState, newState)         if (newState == SCENE_FRAGMENT_SHOWING) then         elseif (newState == SCENE_FRAGMENT_SHOWN) then         end end WORLD_MAP_SCENE:RegisterCallback("StateChange", WorldMapStateChanged)

I tried that but it only triggered when I changed to another map. Not when I just pressed "M".
Don't know if I did something wrong. Maybe it is because I had already previously opened the map in that zone?

[votan]

Originally Posted by SnowmanDK I tried that but it only triggered when I changed to another map. Not when I just pressed "M". Don't know if I did something wrong. Maybe it is because I had already previously opened the map in that zone?

Are you sure? From what you telling here, it sounds more like the callback "OnWorldMapChanged", which is not the same.
It would be very odd, if the scene state would not change, if you press 'M'.

hi guys, merry Christmas!

and yup that should have worked, but maybe the issue wasn't the callback when you tried last page, Snowman, but the value you are using to update your pins :

last of your (posted) code, you say your count is updated on player activated (and probably map changed too?), but when you check if the count has changed in what you wrote, nowhere you are updating the new value to use it on the refreshed pins
As I said idk what happens on refresh pins, but as it seems to be from a lib I assume the new value is not calculated there.

maybe that was what prevented the update on state change and made you have to change the shown map to update your values.

[SnowmanDK]

Originally Posted by Wandamey hi guys, merry Christmas! and yup that should have worked, but maybe the issue wasn't the callback when you tried last page, Snowman, but the value you are using to update your pins : last of your (posted) code, you say your count is updated on player activated (and probably map changed too?), but when you check if the count has changed in what you wrote, nowhere you are updating the new value to use it on the refreshed pins As I said idk what happens on refresh pins, but as it seems to be from a lib I assume the new value is not calculated there. maybe that was what prevented the update on state change and made you have to change the shown map to update your values.

It was refreshing fishing pins in lines 11-13 of my last code
The code for re-reading the bait amounts are included in that part (as I have had issues with too many functions before, then I try to include them in existing ones).

[circonian]

Originally Posted by Wandamey re edit : you are using local lureIndex = GetFishingLure() at first? It probably just return the index of the current lure on the rod? not sure. but anyway you are using it as the indice 2 lines later. Doesn't seem needed at all.

Oops, your right that's pointless. It was supposed to be

local lureIndex = lureIndex or GetFishingLure()

I wrote the function one way & then changed it and missed that and yes it returns the index of the lure on the rod which was part of some code I sent him to check the counts after fishing so only the index of the lure on the rod was needed for that code.

As for the map change talk...it seems like you only need this info for the map pin tooltip so why not just do it in the creator?
Map pin tooltips are re-created everytime they are shown, so your bait count update code would only have to run when a tooltip is shown, which sounds like the only time you need the updated count.
Also that way you would not have to re-check the counts for all of the types of baits. Since you would know which map pin the tooltip is for, you know which baits you are wanting to display and you only have to update those bait counts.


Add a lures table to your pin tag to hold the usable lureIndices:

-- approx. line 3177
local tooltipText = {
   -- add this table
   lures = {},
}

Then instead of creating the string {3/1/71} for counts in FishpinTypeCallback, just determine which lureIndex is usable in that water and put those lure indices in the lures table in the tag.

elseif TYPE == 43 then
--[[
    fishingBaitLeft = tostring(LakeBaitLeft).."/"..tostring(LakeSBaitLeft)
    if GeneralBait >= 1 then
        fishingBaitLeft = fishingBaitLeft.."/"..tostring(GeneralBait)
    table.insert(tooltipText.lures, 0)
    end
    textLine = textLine + 1
    table.insert(tooltipText, textLine, ZO_ColorDef:New(unpack(DestinationsSV.pins.pinTextureFish.textcolorBait)):Colorize(zo_strformat("<<1>>", "{"..fishingBaitLeft.."}")))
--]]
    -- Decide which lureIndices should be used & add them to the table
        -- 5 = just an example of some lure Index usable in this water
    table.insert(tooltipText.lures, 5)
    -- add as many lure indices as needed, insert them in the order
    -- you want them displayed in

Do the lure counts in the tooltip creator

local pinTooltipCreator = {
    creator = function(pin)
        local pinType, pinTag = pin:GetPinTypeAndTag()
        
        -- do it here
        -- You may need some check to make sure its a fishing map pin
        -- if pinType == xxxxx then
            local lures = pinTag.lures
            local tooltipLureCountText
            
            for _, lureIndex in pairs(lures) do
                -- updates bait count
                local name, icon, stack, sellPrice, quality  = GetFishingLureInfo(lureIndex)    
            
                -- If you need something more complex than just the
                -- lure counts in the backpack call a custom function instead
                -- to do that work 
                --local stack = UpdateLureCount(lureIndex)
 
                -- if you need to save counts for use in other places besides the tooltip save it here
                -- someTable.whatever[lureIndex] = stack
 
                -- build the tooltip text line for lure counts as you go
                if tooltipLureCountText then
                    tooltipLureCountText = zo_strformat("<<1>>/<<2>>", tooltipLureCountText, stack)
                else
                    tooltipLureCountText = stack
                end
            end
            -- add your { }
            tooltipLureCountText = zo_strformat("{<<1>>}", tooltipLureCountText)
            
            -- Update the new string in your tag:
            pinTag[4] = tooltipLureCountText
        --end
        
        
        for _, lineData in ipairs(pinTag) do
            SetTooltipText(InformationTooltip, lineData)
        end
    end,
    tooltip = 1,
}