Crafting Station Bug

[circonian]

Ug, I spent an hour trying to find a bug in an addon I'm working on & its not in my addon. Looks like a game bug, can anyone confirm?

1. Go to a clothier crafting station
2. Reload your UI to reset all of the games variables
3. Open the crafting station
4. Click on the creation tab (nothing else)
5. Go to blacksmithing crafting station and open it.
6. Click on the deconstruction tab (nothing else)
7. Go back to the clothier crafting station & open it.
8. Click on the Creation tab

It seems to happen no matter which stations you do it at as long as you only click those buttons in that order.

[Garkin]

In my opinion this is a bug on ZOS side which was introduced in patch 1.5.6 because of changes in crafting UI.

Unfortunately this error occurs in local function, so it will be a bit difficult to fix by addon.

I'd probably try to redefine GetMaterialQuantity function, something like:

function ZO_SharedSmithingCreation:GetMaterialQuantity(patternIndex, materialIndex)
    local quantity
    if self.selectedMaterialCountCache[patternIndex] then
        quantity = self.selectedMaterialCountCache[patternIndex][materialIndex]
    end
    if quantity == nil then
        local _, _, stack = GetSmithingPatternMaterialItemInfo(patternIndex, materialIndex)
        self:SetMaterialQuantity(patternIndex, materialIndex, stack)
        quantity = stack
    end
    return quantity or 0
end

Or if you want to redefine just instance of this class, you are looking for function:

SMITHING.creationPanel:GetMaterialQuantity(patternIndex, materialIndex)

[QuadroTony]

i cant reproduce it without any addons! you sure about it?

US client? i use liveeu

P.S. - the same with all my addons, i have 112
no errors so far

[Ayantir]

Hello,

Your order list isn't good

The bug is

- Go on a smithing station (wood/blacksmith/clothier)
- Open creation tab
- leave
- Go on another smithing station of same type
- Go on creation tab
- bug

It will be reproduced with any smithing station
and yes as garkin said, we can't do anything at all

let's zos fix their bugs ?

[ZOS_ChipHilseberg]

I'll take a look at it today to see if I can reproduce it.

[Garkin]

Originally Posted by ZOS_ChipHilseberg I'll take a look at it today to see if I can reproduce it.

Everywhere, where are you using method :GetMaterialQuantity is a check if return value exists. But in the SetupFunction in :InitializeMaterialList is this check missing. There should probably be something like this:

local function SetupFunction(control, data, selected, selectedDuringRebuild, enabled)
 
    --original code here
 
    local currentSelectedQuantity = self:GetMaterialQuantity(data.patternIndex, data.materialIndex)
    --added check if return value exists:
    if not currentSelectedQuantity then
        self:SetMaterialQuantity(data.patternIndex, data.materialIndex, data.min)
        currentSelectedQuantity = data.min
    end
 
   --rest of the original code
 
end

[ZOS_ChipHilseberg]

We were able to reproduce it. A fix will likely be in the next patch.

[circonian]

Originally Posted by Ayantir Hello, Your order list isn't good The bug is - Go on a smithing station (wood/blacksmith/clothier) - Open creation tab - leave - Go on another smithing station of same type - Go on creation tab - bug It will be reproduced with any smithing station and yes as garkin said, we can't do anything at all let's zos fix their bugs ?

Strange if the order I listed didn't work for you, it works for me every time. That was just the sequence of events that I managed to figure out would reproduce it every time. I don't doubt there is more than one way to reproduce it. I tried to find out where it was being caused in the code, but it 'might' be in something not available to use (or I may have missed it, I couldn't find it).

[circonian]

Originally Posted by QuadroTony i cant reproduce it without any addons! you sure about it? US client? i use liveeu P.S. - the same with all my addons, i have 112 no errors so far

Strange, I removed all addons, reloadedUI, logged completely out & back in, restarted my computer (all in case something was somehow remaining between reloadUI's). It happens every time.

[circonian]

Originally Posted by Garkin In my opinion this is a bug on ZOS side which was introduced in patch 1.5.6 because of changes in crafting UI. Unfortunately this error occurs in local function, so it will be a bit difficult to fix by addon. I'd probably try to redefine GetMaterialQuantity function, something like: function ZO_SharedSmithingCreation:GetMaterialQuantity(patternIndex, materialIndex)     local quantity     if self.selectedMaterialCountCache[patternIndex] then         quantity = self.selectedMaterialCountCache[patternIndex][materialIndex]     end     if quantity == nil then         local _, _, stack = GetSmithingPatternMaterialItemInfo(patternIndex, materialIndex)         self:SetMaterialQuantity(patternIndex, materialIndex, stack)         quantity = stack     end     return quantity or 0 end Or if you want to redefine just instance of this class, you are looking for function: SMITHING.creationPanel:GetMaterialQuantity(patternIndex, materialIndex)

Thanks for looking into it Garkin. Even though I removed all addons, logged out & back in, its nice to know its not just me.

[circonian]

Originally Posted by ZOS_ChipHilseberg We were able to reproduce it. A fix will likely be in the next patch.

Thanks for looking into it Chip !

[Garkin]

Originally Posted by Garkin Everywhere, where are you using method :GetMaterialQuantity is a check if return value exists. But in the SetupFunction in :InitializeMaterialList is this check missing. There should probably be something like this: local function SetupFunction(control, data, selected, selectedDuringRebuild, enabled)       --original code here       local currentSelectedQuantity = self:GetMaterialQuantity(data.patternIndex, data.materialIndex)     --added check if return value exists:     if not currentSelectedQuantity then         self:SetMaterialQuantity(data.patternIndex, data.materialIndex, data.min)         currentSelectedQuantity = data.min     end      --rest of the original code   end

This code was added to EsoUI source in patch 1.5.8. ;-)

[Baertram]

You can call yourself official unoffical ZOS developer now ^^

[ZOS_ChipHilseberg]

With the amount of effort Garkin puts into add-ons and the add-on community he was already an unofficial ZOS developer =P.

[Baertram]

True, skip the "now" from my last post then ;-)

[Garkin]

By the way do you know what causes current crafting staions bug (material quantity resets to its default value)? It's a typo in this added code ("currentSelectedQuality" instead of "currentSelectedQuantity"):

local currentSelectedQuantity = self:GetMaterialQuantity(data.patternIndex, data.materialIndex)
 
if currentSelectedQuality == nil then --here
    self:SetMaterialQuantity(data.patternIndex, data.materialIndex, data.min)
    currentSelectedQuantity = data.min
end

Easy solution for this issue is creating global variable currentSelectedQuality and update it every time when you call GetMaterialQuantity method:

local originalGetMaterialQuantity = ZO_SharedSmithingCreation.GetMaterialQuantity
function ZO_SharedSmithingCreation:GetMaterialQuantity(...)
    currentSelectedQuality = originalGetMaterialQuantity(self, ...)
    return currentSelectedQuality
end

[ZOS_ChipHilseberg]

This typo will be fixed in the next patch.

[QuadroTony]

btw Garkin mby you know it MultiCraft addon bug, or related not only to multicraft, but some errors in the game itself?

- this bug happends every time - its because i hit Cancel while process previous crafting alchemy routine - or because of MultiCraft addon - look at the glowing around reagents, looks like it stuck from previous routine, when ingredients glowing one by one to make one potion - reloadui helps i can change the combinations, but i cannot craft it. also i cannot craft by hotkey too. And if i close the addon, original UI locked with gray colors Happends after one craft route, im using MultiCraft addon

[Baertram]

The gray color means that the item is locked by the game's UI. Probaly MultiCraft called the function to craft a potion and if you cancel it the items won't get unlocked again. It's the same as dragging an item from your iventory somwhere else but you would never drop it. The item will be grayed out as long as you drag it.
You need to relog (/reloadui alone won't help).

To test if it is MultiCraft:
Try to disable MultiCraft and do the same to craft your potions, and hit cancel then. Are the items still grayed out?

[QuadroTony]

we figure out it already)) need some additional fixes to multicraft

The "craft completed" animation and sound is still running/playing while the next potion is crafted. If you interrupt it, the animation is stucked and the buttons are hidden. The solution is to call this in the EVENT_CRAFTING_STATION_INTERACT.