Inventory search boxes & guild store sell tab filters

[merlight]

I've done some tests combining libCommonInventoryFilters with the following:

• AF ... no problem
• AGS ... after leaving guild store, search box in inventory overlaps with sort headers
• AGS + AF ... same problem as AGS alone, only worse because now it overlaps with AF sub-filters
• FilterIt ... no problem
• AGS + FilterIt ... no problem

Here's what I changed in AwesomeGuildStore:

diff -ru autoupdate/unpacked/AwesomeGuildStore/SalesCategorySelector.lua modified/AwesomeGuildStore/SalesCategorySelector.lua
--- autoupdate/unpacked/AwesomeGuildStore/SalesCategorySelector.lua 2015-07-05 14:25:22.000000000 +0200
+++ modified/AwesomeGuildStore/SalesCategorySelector.lua    2015-07-24 02:28:17.000000000 +0200
@@ -70,20 +70,13 @@
        selector:CreateSubcategory(name, category, preset)
    end
 
-   local searchBoxControl = ZO_PlayerInventorySearchBox
-   searchBoxControl:SetDrawLayer(3) -- make sure the text box is above the sort by name field
    local filterDividerControl = ZO_PlayerInventoryFilterDivider
-   local sortByControl = ZO_PlayerInventorySortBy
    local wasFilterDividerHidden
    local function Activate()
-       searchBoxControl:ClearAnchors()
-       searchBoxControl:SetAnchor(TOPLEFT, sortByControl, TOPLEFT, 220, 3)
        wasFilterDividerHidden = filterDividerControl:IsHidden()
        filterDividerControl:SetHidden(true)
    end
    local function Deactivate()
-       searchBoxControl:ClearAnchors()
-       searchBoxControl:SetAnchor(TOPRIGHT, searchBoxControl:GetParent(), TOPRIGHT, -26, 68)
        filterDividerControl:SetHidden(wasFilterDividerHidden)
    end
    RegisterForEvent(EVENT_OPEN_TRADING_HOUSE, Activate)
@@ -221,8 +214,9 @@
 local BACKPACK_TRADING_HOUSE_LAYOUT_FRAGMENT_BASIC = ZO_BackpackLayoutFragment:New(
    {
        width = 670,
-       backpackOffsetY = 145,
-       sortByOffsetY = 114,
+       inventoryTopOffsetY = -20 + 65,
+       backpackOffsetY = 145 - 65,
+       sortByOffsetY = 114 - 65,
        sortByHeaderWidth = 670,
        sortByNameWidth = 352,
        hideAlliancePoints = true,
@@ -232,8 +226,9 @@
 local BACKPACK_TRADING_HOUSE_LAYOUT_FRAGMENT_ADVANCED = ZO_BackpackLayoutFragment:New(
    {
        width = 670,
-       backpackOffsetY = 181,
-       sortByOffsetY = 149,
+       inventoryTopOffsetY = -20 + 65,
+       backpackOffsetY = 181 - 65,
+       sortByOffsetY = 149 - 65,
        sortByHeaderWidth = 670,
        sortByNameWidth = 352,
        hideAlliancePoints = true,

diff -ru autoupdate/unpacked/AwesomeGuildStore/wrappers/TradingHouseWrapper.lua modified/AwesomeGuildStore/wrappers/TradingHouseWrapper.lua
--- autoupdate/unpacked/AwesomeGuildStore/wrappers/TradingHouseWrapper.lua  2015-07-05 14:25:22.000000000 +0200
+++ modified/AwesomeGuildStore/wrappers/TradingHouseWrapper.lua 2015-07-24 02:36:33.000000000 +0200
@@ -10,6 +10,11 @@
 end
 
 function TradingHouseWrapper:Initialize(saveData)
+    local libCIF = LibStub:GetLibrary("libCommonInventoryFilters", "SILENT")
+    if libCIF then
+        libCIF:disableGuildStoreSellFilters()
+    end
+
    self.saveData = saveData
    local tradingHouse = TRADING_HOUSE
    self.tradingHouse = tradingHouse

And here's what I changed in FilterIt:

diff -ru autoupdate/unpacked/FilterIt/Layout/FilterIt_InvLayout.lua modified/FilterIt/Layout/FilterIt_InvLayout.lua
--- autoupdate/unpacked/FilterIt/Layout/FilterIt_InvLayout.lua  2015-03-08 21:31:18.000000000 +0100
+++ modified/FilterIt/Layout/FilterIt_InvLayout.lua 2015-07-22 19:42:39.000000000 +0200
@@ -8,22 +8,28 @@
 local function LayoutBackpack()
    ZO_PlayerInventorySearchBox:SetDimensions(SEARCH_BOX_WIDTH, SEARCH_BOX_HEIGHT)
    
-   local tBackpackLayouts = {
-   [1] = BACKPACK_BANK_LAYOUT_FRAGMENT.layoutData,
-   [2] = BACKPACK_MENU_BAR_LAYOUT_FRAGMENT.layoutData,
-   [3] = BACKPACK_MAIL_LAYOUT_FRAGMENT.layoutData,
-   [4] = BACKPACK_PLAYER_TRADE_LAYOUT_FRAGMENT.layoutData,
-   [5] = BACKPACK_STORE_LAYOUT_FRAGMENT.layoutData,
-   [6] = BACKPACK_FENCE_LAYOUT_FRAGMENT.layoutData,
-   [7] = BACKPACK_LAUNDER_LAYOUT_FRAGMENT.layoutData,
-   --[5] = BACKPACK_TRADING_HOUSE_LAYOUT_FRAGMENT.layoutData,
-   }
-   for k,v in pairs(tBackpackLayouts) do
-       v.backpackOffsetY = 136
-       v.sortByOffsetY = 103
-   end
+    local libCIF = LibStub:GetLibrary("libCommonInventoryFilters", "SILENT")
+    if libCIF then
+        libCIF:addBackpackLayoutShiftY(40)
+        libCIF:disableSearchBoxes()
+    else
+        local tBackpackLayouts = {
+        [1] = BACKPACK_BANK_LAYOUT_FRAGMENT.layoutData,
+        [2] = BACKPACK_MENU_BAR_LAYOUT_FRAGMENT.layoutData,
+        [3] = BACKPACK_MAIL_LAYOUT_FRAGMENT.layoutData,
+        [4] = BACKPACK_PLAYER_TRADE_LAYOUT_FRAGMENT.layoutData,
+        [5] = BACKPACK_STORE_LAYOUT_FRAGMENT.layoutData,
+        [6] = BACKPACK_FENCE_LAYOUT_FRAGMENT.layoutData,
+        [7] = BACKPACK_LAUNDER_LAYOUT_FRAGMENT.layoutData,
+        --[5] = BACKPACK_TRADING_HOUSE_LAYOUT_FRAGMENT.layoutData,
+        }
+        for k,v in pairs(tBackpackLayouts) do
+            v.backpackOffsetY = 136
+            v.sortByOffsetY = 103
+        end
+    end
    
-   local FilterItInventoryDivider = CreateControlFromVirtual("FilterIt_InventoryDivider", ZO_PlayerInventory, "ZO_InventoryFilterDivider")
+   local FilterItInventoryDivider = CreateControlFromVirtual("FilterIt_InventoryDivider", ZO_PlayerInventoryTabs, "ZO_InventoryFilterDivider")
    local isValidAnchor, point3, relativeTo3, relativePoint3, offsetX3, offsetY3 = ZO_PlayerInventoryBackpack:GetAnchor(0)
    FilterItInventoryDivider:SetAnchor(point3, relativeTo3, relativePoint3, offsetX3, offsetY3+5)
 end

Note: changing the divider's parent to ZO_PlayerInventoryTabs prevents it from showing in the guild store sell tab when it shouldn't (i.e. with AGS enabled).

[circonian]

This code is unnecessary:

Warning: Spoiler

local tradingHouseHiddenColumns = { statValue = true, age = true }
local zorgGetTabFilterInfo = PLAYER_INVENTORY.GetTabFilterInfo
 
function PLAYER_INVENTORY:GetTabFilterInfo(inventoryType, tabControl)
    if libCIF._tradingHouseModeEnabled then
        local filterType, activeTabText = zorgGetTabFilterInfo(self, inventoryType, tabControl)
        return filterType, activeTabText, tradingHouseHiddenColumns
    else
        return zorgGetTabFilterInfo(self, inventoryType, tabControl)
    end
end

Those columns are already hidden. If your seeing them then some other addon is messing it up:

Warning: Spoiler

-- These are already defined:
local tradingHouseHiddenColumns =
{
    ["statValue"] = true,
    ["age"] = true,
}
-- this gets called:
CreateNewTabFilterData(TradingHouseFilter, INVENTORY_BACKPACK, "", "", "", tradingHouseHiddenColumns),
 
local function CreateNewTabFilterData(filterType, inventoryType, normal, pressed, highlight, hiddenColumns)  
   ...
    local tabData = 
    {
        -- Custom data
        filterType = filterType,
        inventoryType = inventoryType,
        hiddenColumns = hiddenColumns,
-- which sets the hidden columns there
   ...
end

Bug? Or are you only counting on me to call this function in FilterIt?

-- What if multiple addons call this:
function libCIF:addBackpackLayoutShiftY(shiftY)
    libCIF._backpackLayoutShiftY = (libCIF._backpackLayoutShiftY or 0) + shiftY
end
libCIF._backpackLayoutShiftY = nil 
libCIF:addBackpackLayoutShiftY(40) -- now its 40
libCIF:addBackpackLayoutShiftY(40) -- now 80
libCIF:addBackpackLayoutShiftY(40) -- now 120

Are we sure these items you left out aren't needed anywhere else?
I know that currentFilter = TradingHouseFilter is used in ShouldAddSlotToList(..) to filter out bound items...although we are breaking that by allowing the menu bar to be shown & buttons to be clicked (yes we also fixed it by adding to the additional filter to hide bound items), but are we sure its not also needed somewhere else? What about code we don't have access to?

Warning: Spoiler

function ZO_InventoryManager:SetTradingHouseModeEnabled(enabled)
    local inventory = self.inventories[INVENTORY_BACKPACK]
 
    if(enabled) then    
        inventory.previousFilter = inventory.currentFilter
        inventory.currentFilter = TradingHouseFilter
    else
        inventory.currentFilter = inventory.previousFilter or ITEMFILTERTYPE_ALL
        inventory.previousFilter = nil
    end
 
    ZO_PlayerInventorySearchBox:SetHidden(not enabled)
    ZO_PlayerInventoryTabs:SetHidden(enabled)
    ZO_MenuBar_SelectDescriptor(inventory.filterBar, inventory.currentFilter)
end

This may be trivial, but by leaving those out it prevents code from knowing which btn was previously selected & returning to it. By saving the current filter, then reloading it, & then calling ZO_MenuBar_SelectDescriptor(inventory.filterBar, inventory.currentFilter) It returns the menu bar to its previously selected descriptor.

[circonian]

Originally Posted by circonian This may be trivial, but by leaving those out it prevents code from knowing which btn was previously selected & returning to it. By saving the current filter, then reloading it, & then calling ZO_MenuBar_SelectDescriptor(inventory.filterBar, inventory.currentFilter) It returns the menu bar to its previously selected descriptor.

Well nevermind on that one, I guess that really doesn't matter because it gets reset in the apply layout

function ZO_InventoryManager:ApplyBackpackLayout(layoutData)
   ...
    ZO_MenuBar_SelectDescriptor(self.inventories[INVENTORY_BACKPACK].filterBar, ITEMFILTERTYPE_ALL)

[merlight]

Hiding those columns is necessary, because this line in inventory.lua

CreateNewTabFilterData(TradingHouseFilter, INVENTORY_BACKPACK, "", "", "", tradingHouseHiddenColumns),

is essentially a hack. It adds a filter with no button texture, so you can't click it. This filter is only activated from SetTradingHouseModeEnabled, and you can't "escape" that filter because the buttons are hidden.

My override of SetTradingHouseModeEnabled doesn't switch to TradingHouseFilter, it leaves the buttons shown (that's also why I had to add not IsBound to additionalFilter, because that was done by the now-unused TradingHouseFilter). After I did this, those columns showed up, because hiddenColumns are tied to buttons. I wasn't sure about the "statValue" column, but the "age" column really doesn't fit in the SELL tab, that's why I've overridden GetTabFilterInfo.

---

libCIF._backpackLayoutShiftY -- since I haven't initialized it explicitly, and calling addBackpackLayoutShiftY is not required, it could be nil. It was a not-so-important choice where to apply laziness.

---

ZO_MenuBar_SelectDescriptor -- yes you're right. I too was wondering why swapping previousFilter/currentFilter in the original SetTradingHouseModeEnabled doesn't seem to work, I put some debug output in and found the filter was being reset before it had a hance to be remembered

---

Anyway, I forgot to add that if you guys decide to use the library, please wait until AGS is ready for it. The search box location must be sorted out first. Perhaps it would suffice if AGS didn't move the search box and just let the lib do it. I'm going to test, but tonight we've got troube with electricity due to a windstorm, can't run ESO on battery

[circonian]

Originally Posted by merlight My override of SetTradingHouseModeEnabled doesn't switch to TradingHouseFilter...

Oh, duh. My bad your right. Why don't you want to show the statValue column though?

Originally Posted by merlight libCIF._backpackLayoutShiftY -- since I haven't initialized it explicitly, and calling addBackpackLayoutShiftY is not required, it could be nil. It was a not-so-important choice where to apply laziness.

Yes, a while later I realized I was wrong & removed that one from the post.

[sirinsidiator]

I don't mind if the library handles the searchbox.
The only reason I put it into that place was because some time ago the text filter on the searchtab was also in a similar location. Since I put that one into the filter bar like all the others, there is not really a reason to keep it there.
I will try to implement the necessary changes tomorrow.

[merlight]

Originally Posted by circonian Oh, duh. My bad your right. Why don't you want to show the statValue column though?

Now I suspect myself of choosing the easy way out. That column is only valid for weapons and armor, so the function would need to be smarter than it is But yea, it it's desired, it could be added. Although personally I wouldn't miss that column if it disappeared from all inventories, I never read it. Weapon damage/armor rating are arguably the least important properties of gear, maybe after vendor value in gold.

[sirinsidiator]

I removed the code that reanchors the search box from AGS, but the library does not move it when I call the disable call. Can you change that, or should I look into it myself?

[merlight]

You probably have another add-on moving it then. For me the search box is right beneath the top-most horizontal divider by default, I checked the anchor in Zgoo and it's the one from xml <Anchor point="TOPRIGHT" offsetX="-26" offsetY="68" />

Anyway, don't call libCIF:disableSearchBoxes() from AGS. It's there for FilterIt, which has its own handling.


edit: Ah ok, now I'm staring at my instance of your picture. Ok I need to figure out how it got there

edit2: I think it's the layout offsets. I just need to crunch some numbers.

[merlight]

I edited the diff for AGS above. The original BACKPACK_TRADING_HOUSE_LAYOUT_FRAGMENT had inventoryTopOffsetY == -20, the default. In libCIF it is set to 45, the value other layouts use. So I added that to your BASIC and ADVANCED layouts, and moved the other two offsets (which are relative to the Top), 65 units up.

There's still an issue with AGS+FilterIt, where the search box remains in "FilterIt location".

[circonian]

Originally Posted by merlight Fun comment from ingame/inventory/inventory.xml <!-- not dead, but dreaming... --> <EditBox name="$(parent)SearchBox"

lol hadn't seen this one before: libraries/globals/debugutils.lua

-- Because typing is painful.
e = ZO_Debug_EventNotification

[merlight]

Originally Posted by merlight Anyway, I forgot to add that if you guys decide to use the library, please wait until AGS is ready for it. The search box location must be sorted out first. Perhaps it would suffice if AGS didn't move the search box and just let the lib do it. I'm going to test, but tonight we've got troube with electricity due to a windstorm, can't run ESO on battery

I should've emphasized that more

[circonian]

I didn't add it yet. I was waiting for this discussion to finish. Just post here when everything is straightened out & I'll add it to FilterIt.

[circonian]

Originally Posted by merlight Anyway, I forgot to add that if you guys decide to use the library, please wait until AGS is ready for it. The search box location must be sorted out first. Perhaps it would suffice if AGS didn't move the search box and just let the lib do it. I'm going to test, but tonight we've got troube with electricity due to a windstorm, can't run ESO on battery

It looks like it has been added to AGS, but the search box location problem looks like it still exists.


It looks like we need something like this to move the search box anchor for AGS and move it back when the trading house (AGS) is done with it:

Warning: Spoiler

-- Save/Initialize the default anchor for PlayerInventorySearchBox
libCIF.searchBoxAnchor = {
    point           = TOPRIGHT,
    relativeTo      = nil,
    relativePoint   = TOPRIGHT,
    offsetX         = -26,
    offsetY         = 68,
}
 
-- Saves the current search box anchor, before moving it for AGS
-- This is done in case AGS is used in combination with another addon that 
-- moves the search box in any other layout
local function SaveSearchBoxAnchor()
    local isValidAnchor, point, relativeTo, relativePoint, offsetX, offsetY = ZO_PlayerInventorySearchBox:GetAnchor(0)
    libCIF.searchBoxAnchor = {
        point           = point,
        relativeTo      = relativeTo,
        relativePoint   = relativePoint,
        offsetX         = offsetX,
        offsetY         = offsetY,
    }
end
 
-- Restore the search box anchor after trading house is done with it
local function RestoreSearchBoxAnchor()
    local anchor = libCIF.searchBoxAnchor
    
    ZO_PlayerInventorySearchBox:ClearAnchors()
    ZO_PlayerInventorySearchBox:SetAnchor(anchor.point, anchor.relativeTo, anchor.relativePoint, anchor.offsetX, anchor.offsetY)
end
 
function PLAYER_INVENTORY:SetTradingHouseModeEnabled(enabled)
    libCIF._tradingHouseModeEnabled = enabled   
    ZO_PlayerInventorySearchBox:SetHidden(not enabled and libCIF._searchBoxesDisabled)
    ZO_PlayerInventoryTabs:SetHidden(enabled and libCIF._guildStoreSellFiltersDisabled)
 
    -- This is only used by AGS right?
    if libCIF._guildStoreSellFiltersDisabled then
        if enabled then
            -- Reanchor for AGS
            SaveSearchBoxAnchor()
            ZO_PlayerInventorySearchBox:ClearAnchors()
            ZO_PlayerInventorySearchBox:SetAnchor(BOTTOMLEFT, nil, TOPLEFT, 36, -8)
        else
            -- Restore position when AGS is done with it
            RestoreSearchBoxAnchor()
        end
    end
end

Does the search box need to be hidden when AGS is done with it & the trading house closes? Is it supposed to remain visible on other layouts if the user is only using AGS & not FilterIt or Advanced Filters?

[merlight]

Originally Posted by circonian Does the search box need to be hidden when AGS is done with it & the trading house closes? Is it supposed to remain visible on other layouts if the user is only using AGS & not FilterIt or Advanced Filters?

I've just updated AGS, will test it ingame shortly.

FilterIt has added filters to the sell tab after libCIF was conceived, and that might actually solve everything. Basically if the user disables AGS custom sell filters in its settings, and you make the change to FilterIt I posted earlier (addBackpackLayoutShiftY and disableSearchBoxes; edit: and disableGuildStoreSellFilters, because you want FilterIt there, right?), it should be ok. I think you don't even have to include the lib in FilterIt, just try to get it with LibStub.SILENT, and only call those functions if it's there; but perhaps it'll be less error-prone if you include it.

[merlight]

Here's my current diff against FilterIt 2.9

diff -ru autoupdate/unpacked/FilterIt/FilterIt.lua modified/FilterIt/FilterIt.lua
--- autoupdate/unpacked/FilterIt/FilterIt.lua   2015-08-10 05:24:30.000000000 +0200
+++ modified/FilterIt/FilterIt.lua  2015-08-25 13:28:05.000000000 +0200
@@ -77,10 +77,6 @@
    FilterIt.SetFilterActivation(ZO_PlayerBankTabs.m_object.m_currentSubMenuBar)
    FilterIt.SetFilterActivation(ZO_GuildBankTabs.m_object.m_currentSubMenuBar)
    
-   -- Changes the layouts for the inventories: Trading House
-   -- Moved to player activation to watch & see if AGS gets loaded
-   FilterIt.LayoutTradingHouse()
-   
    -- Unregister here to catch loaded addons
    EVENT_MANAGER:UnregisterForEvent(FilterIt.name, EVENT_ADD_ON_LOADED)
    
@@ -164,7 +160,6 @@
    FilterIt.HookInvButtons()
    
    -- Changes the layouts for the inventories: backpack, bank, & guild bank, mail, exc..
-   -- Trading House layout is called in player Activation for AGS compatability
    FilterIt.SetLayouts()
    
    FilterIt.BuildImprovementPanelTabMenu()

diff -ru autoupdate/unpacked/FilterIt/Layout/FilterIt_InvLayout.lua modified/FilterIt/Layout/FilterIt_InvLayout.lua
--- autoupdate/unpacked/FilterIt/Layout/FilterIt_InvLayout.lua  2015-07-22 20:27:20.000000000 +0200
+++ modified/FilterIt/Layout/FilterIt_InvLayout.lua 2015-08-25 13:41:47.000000000 +0200
@@ -7,22 +7,10 @@
 local function LayoutBackpack()
    ZO_PlayerInventorySearchBox:SetDimensions(SEARCH_BOX_WIDTH, SEARCH_BOX_HEIGHT)
    
-   -- Trading house is handled in a separate function due to other checks
-   -- that need to be made for AGS & other code that needs to be run.
-   local tBackpackLayouts = {
-   [1] = BACKPACK_BANK_LAYOUT_FRAGMENT.layoutData,
-   [2] = BACKPACK_MENU_BAR_LAYOUT_FRAGMENT.layoutData,
-   [3] = BACKPACK_MAIL_LAYOUT_FRAGMENT.layoutData,
-   [4] = BACKPACK_PLAYER_TRADE_LAYOUT_FRAGMENT.layoutData,
-   [5] = BACKPACK_STORE_LAYOUT_FRAGMENT.layoutData,
-   [6] = BACKPACK_FENCE_LAYOUT_FRAGMENT.layoutData,
-   [7] = BACKPACK_LAUNDER_LAYOUT_FRAGMENT.layoutData,
-   --[5] = BACKPACK_TRADING_HOUSE_LAYOUT_FRAGMENT.layoutData,
-   }
-   for k,v in pairs(tBackpackLayouts) do
-       v.backpackOffsetY = 136
-       v.sortByOffsetY = 103
-   end
+    -- this enables filters on guild store SELL tab
+    local libCIF = LibStub:GetLibrary("libCommonInventoryFilters")
+    libCIF:addBackpackLayoutShiftY(40)
+    libCIF:disableSearchBoxes()
    
    --local FilterItInventoryDivider = CreateControlFromVirtual("FilterIt_InventoryDivider", ZO_PlayerInventory, "ZO_InventoryFilterDivider")
    -- Changed Parent for AGS
@@ -75,45 +63,10 @@
    FilterItBankDivider:SetAnchor(point0, relativeTo0, relativePoint0, offsetX0, offsetY0+5)
 end
 
-function FilterIt.LayoutTradingHouse()
-   if FilterIt.loadedAddons["AwesomeGuildStore"] then return end
-   
-   local layoutData = BACKPACK_TRADING_HOUSE_LAYOUT_FRAGMENT.layoutData
-   local sellFiltersEnabled = layoutData.sellFiltersEnabled
-   -- Check if someone has already enabled it:
-   if sellFiltersEnabled then return end
-   
-   -- Check if its turned on in my addon:
-   --if not MY_ADDON_SETTING_ON then return end
-   
-   -- Set flag:
-   layoutData.sellFiltersEnabled = true
-   
-   -- Set the new layoutData:
-   layoutData.inventoryTopOffsetY = 43
-   layoutData.hiddenFilters = { [ITEMFILTERTYPE_QUEST] = true }  
-   local origAdditionalFilter = layoutData.additionalFilter 
-   layoutData.additionalFilter = function (slot)
-               return origAdditionalFilter(slot) and (not IsItemBound(slot.bagId, slot.slotIndex))
-           end
-   
-   -- Prehook HandleTabSwitch for sell mode:
-   local function OnHandleTabSwitch(self, tabData)
-       local mode = tabData.descriptor
-       
-       if mode == ZO_TRADING_HOUSE_MODE_SELL then
-           ZO_PlayerInventoryTabs:SetHidden(false)
-       end
-       return false
-   end
-   ZO_PreHook(TRADING_HOUSE, "HandleTabSwitch", OnHandleTabSwitch)
-end
 
 function FilterIt.SetLayouts()
    LayoutBackpack()
    LayoutBank()
    LayoutGuildBank()
-   -- Changed, this is now called in player Activation for AGS compatability
-   --LayoutTradingHouse()
 end

It works regardless of AGS setting "disable custom selltab filter". Although with that setting OFF, the search box slightly overlaps subfilters or items, because it's at FilterIt position. But once you turn it ON, FilterIt shows up on the sell tab, and it looks good.

[circonian]

Originally Posted by merlight I've just updated AGS, will test it ingame shortly. FilterIt has added filters to the sell tab after libCIF was conceived, and that might actually solve everything. Basically if the user disables AGS custom sell filters in its settings, and you make the change to FilterIt I posted earlier (addBackpackLayoutShiftY and disableSearchBoxes; edit: and disableGuildStoreSellFilters, because you want FilterIt there, right?), it should be ok.

Yes, I made those changes as a temporary measure until this was finished.
Yes it is OK for me, I'm thinking of the problem it is causing AGS when both addons are turned on the search box location is wrong for AGS in the trading house.

Originally Posted by merlight Here's my current diff against FilterIt 2.9

Yes, I had made those code changes (its not posted, I was just testing on my own).

Originally Posted by merlight It works regardless of AGS setting "disable custom selltab filter". Although with that setting OFF, the search box slightly overlaps subfilters or items, because it's at FilterIt position. But once you turn it ON FilterIt shows up on the sell tab, and it looks good.

I think your ON/OFF are backwards, but yes that is the problem I was referring to When both settings are ON disableGuildStoreSellFilters & disableSearchBoxes

Originally Posted by merlight the search box slightly overlaps subfilters or items, because it's at FilterIt position.

The code I posted was an idea to fix that problem by moving the search box for AGS when the trading house is enabled and the disableGuildStoreSellFilters is ON (because that means AGS is going to handle the trading house filters).

Then restore the original search box position when the trading house becomes disabled and the disableGuildStoreSellFilters is ON (because that means we previously moved the search box for AGS when the trading house became enabled).

That way the search box would be in the correct position at all times for everyone.

[merlight]

Originally Posted by circonian I think your ON/OFF are backwards, but yes that is the problem I was referring to When both settings are ON disableGuildStoreSellFilters & disableSearchBoxes

That's kind of a naming confusion -- AGS["disable custom selltab filter"] is inverse to libCIF["disableGuildStoreSellFilters"] because AGS talks about its custom filters, libCIF talks about the default UI filters

Originally Posted by circonian The code I posted was an idea to fix that problem by moving the search box for AGS when the trading house is enabled and the disableGuildStoreSellFilters is ON (because that means AGS is going to handle the trading house filters). Then restore the original search box position when the trading house becomes disabled and the disableGuildStoreSellFilters is ON (because that means we previously moved the search box for AGS when the trading house became enabled). That way the search box would be in the correct position at all times for everyone.

I see, seems to be the best way to fix it without touching AGS itself.

[merlight]

Yet another issue with the search box. I added saving/restoring the anchor, enabled AGS custom filters and FilterIt -- and everytime I click an AGS (sub)filter, the search box is cleared. It's all so intertwined

[circonian]

Originally Posted by merlight Yet another issue with the search box. I added saving/restoring the anchor, enabled AGS custom filters and FilterIt -- and everytime I click an AGS (sub)filter, the search box is cleared. It's all so intertwined

Eew, yeah that's FilterIt clearing the searchBox. Since it only displays the search box on the All tab it has to clear the search box whenever you click a different filter or else the search text would still apply, you would not see everything, & there would be no way to remove it since the search box is hidden on other tabs.

I'm actually surprised the search box isn't getting hidden when using AGS and switching off of the "ALL" tab because FilterIt hides the searchBox. He must have code somewhere else un-hiding it.