IGV causing generic UI bug

[Randactyl]

Have a problem with Inventory Grid View causing withdraw/deposit to fail with this message:



It's because of this code:

--postHook function for "ZO_InventorySlot_OnMouseEnter"
--Sets the ItemTooltip owner and offset so that tooltips always appear at the 
--beginning of a gridded row.
local function ReinitializeTooltip(inventorySlot)
    local isGrid = inventorySlot.isGrid
    if isGrid == true then
        local gridSize = InventoryGridViewSettings:GetGridSize()
        local col = ((inventorySlot:GetLeft() - 1432) / gridSize) + 1
        local offsetX = -(gridSize * col - gridSize)
 
        ItemTooltip:SetOwner(inventorySlot, RIGHT, offsetX, 0)
    end
end
 
--implementation of general postHook found on ESOUI specific to IGV's purposes
local function IGV_OnMouseEnter_postHook(funcName, callback)
    --"ZO_InventorySlot_OnMouseEnter" is being hooked
    local tmp = _G[funcName]
    _G[funcName] = function(...)
        --ZO_InventorySlot_OnMouseEnter returns true if a tooltip was 
        --successfully shown, false if a tooltip was hidded.
        local returnValue = tmp(...)
        if(returnValue == true) then
            --make ZO_InventorySlot_OnMouseEnter's arguments availible to
            --my function.
            callback(...)
        end
        return returnValue
    end
end
 
IGV_OnMouseEnter_postHook("ZO_InventorySlot_OnMouseEnter", ReinitializeTooltip)

But I'm not sure why. Any ideas?
I need to head to class, but this is all I'll be thinking about

[merlight]

/reloadui
I've been getting this message for months now, 3 out of 10 logins. And I never even used IGV.

[Randactyl]

Yeah, I've gotten it plenty of times before this code was written. However this for some reason causes the error 100% of the time :/

[merlight]

Ok now I actually read the code. I'm sure this error has something to do with right-click menu actions and keybind actions (they're implemented by the same class). This IGV_OnMouseEnter_postHook looks like it wraps the original handler, so that the original - which generates the list of actions - is now being called from add-on code (and those actions are mostly anonymous functions with add-on code in their closure now), making it ineligible to call protected functions directly.

Since this hook only needs to adjust tooltip placement, it should probably be done via customTooltipAnchor:

-- from ZO_InventorySlot_OnMouseEnter
            if buttonPart.customTooltipAnchor then
                buttonPart.customTooltipAnchor(tooltipUsed, buttonPart, ComparativeTooltip1, ComparativeTooltip2)
            else
                ZO_Tooltips_SetupDynamicTooltipAnchors(tooltipUsed, buttonPart.tooltipAnchor or buttonPart, ComparativeTooltip1, ComparativeTooltip2)
            end

Here's a possible replacement, untested (I still haven't bothered to get IGV):

local function igvTooltipAnchor(tooltip, inventorySlot, comparativeTooltip1, comparativeTooltip2)
    -- call the regular one, not ideal but probably better than copying most of the code here :)
    ZO_Tooltips_SetupDynamicTooltipAnchors(tooltip, inventorySlot, comparativeTooltip1, comparativeTooltip2)
    -- custom setup
    if inventorySlot.isGrid then
        local gridSize = InventoryGridViewSettings:GetGridSize()
        local col = ((inventorySlot:GetLeft() - 1432) / gridSize) + 1
        local offsetX = -(gridSize * col - gridSize)
        tooltip:SetOwner(inventorySlot, RIGHT, offsetX, 0)
    end
end
 
-- I guess there's some place all inventory slots get that isGrid flag,
-- so add the custom placement handler there:
inventorySlot.customTooltipAnchor = igvTooltipAnchor

[Randactyl]

Thanks, merlight I'll test it out.

That tooltip anchor edit was the first to work in a long line of ideas. I just went with it when it started working

Edit:

It looks like what you cooked up should work. Though, it seems like offsetX is always -4 which ultimately defeats the purpose of having a varying offset so that the tooltip always shows at the end of the row.

I'm too tired to mess with this now. I'll get back to it tomorrow.
Thanks again for the help!