[outdated] ZO_PostHook and ZO_PostHookHandler

[Randactyl]

Would be nice to have a pair of companions for ZO_PreHook and ZO_PreHookHandler which perform their hook function after the original function.

Without these, manually performing a post-hook such as:

local oldUpdateList = PLAYER_INVENTORY.UpdateList
PLAYER_INVENTORY.UpdateList = function(PLAYER_INVENTORY, inventoryType, updateEvenIfHidden)
    oldUpdateList(PLAYER_INVENTORY, inventoryType, updateEvenIfHidden)
    myUpdateList()
end

is prone to cause insecure calls to functions which demand a secure context such as "UseItem" and "PickupInventoryItem"; as is the case in this example since those may be called through the keybind strip which is set up in the (now insecure) call to oldUpdateList.

Thanks.

[ZOS_ChipHilseberg]

So to be clear you're looking for a post hook that can call secure code first and then follow on with insecure code in the same call chain?

[Randactyl]

That's correct.

[QuadroTony]

connected with this?

when trying to E container



only reloadui helps

[sirinsidiator]

Would it be possible to allow the PreHook and PostHook function to return arguments from the hook function?
Right now it does only accept a return true which prevents the original from running.

Something like this: (untested)

local newFn = function(...)
  local ret = {hookFunction(...)}
  if(not ret[1]) then
    return existingFn(...)
  else
    table.remove(ret, 1)
    return unpack(ret)
  end
end

It would also be cool if the post hook function could receive the return values from the hooked function.
e.g.: (untested)

local newFn = function(...)
  local ret1 = {existingFn(...)}
  local ret2 = {hookFunction(ret1, ...)}
  if(ret2[1]) then
    table.remove(ret2, 1)
    return unpack(ret2)
  end
  return unpack(ret1)
end