Inventory search boxes & guild store sell tab filters

[circonian]

The only thing I can think of is you could add something like this so I know when AGS has taken over & my filters are not going to be used in the Trading House:

function libCIF:IsGuildStoreSellFiltersDisabled()
    return libCIF._guildStoreSellFiltersDisabled
end

and then I could add this in FilterIt_MenuBars.lua:

-- I could add this check before performing clear or SetHidden:
if not (GetInteractionType() == INTERACTION_TRADINGHOUSE and libCIF:IsGuildStoreSellFiltersDisabled()) then
    if currentInvFilter ~= ITEMFILTERTYPE_ALL then
        PLAYER_INVENTORY.inventories[iInventory].searchBox:SetHidden(true)
        PLAYER_INVENTORY.inventories[iInventory].searchBox:Clear()
    else
        -- no submenu or Show ALL filter tab so show the search box.
        PLAYER_INVENTORY.inventories[iInventory].searchBox:SetHidden(false)
        PLAYER_INVENTORY.inventories[iInventory].searchBox:Clear()
    end
end

and that should solve that problem

[merlight]

It appears that InvTabSwitch in FilterIt_MenuBars.lua gets called twice per click on AGS filter, always with ITEMFILTERTYPE_ALL. How about removing the :Clear from the else (filter==ALL) branch? I think clearing is only necessary when you're hiding the box.

[circonian]

Originally Posted by merlight It appears that InvTabSwitch in FilterIt_MenuBars.lua gets called twice per click on AGS filter, always with ITEMFILTERTYPE_ALL.

Yeah I noticed that. That function is fired from the games menu bar button callbacks. Since AGS has its own custom menu bar I was actually confused as to why it was firing at all. AGS must be forcing button clicks on the hidden menu bar to do the sorting and clicking it more than once?

Originally Posted by merlight How about removing the :Clear from the else (filter==ALL) branch? I think clearing is only necessary when you're hiding the box.

That looks like it would work. It looks like the extra :Clear() call is something left over from earlier code when it functioned differently & I was checking to see if a subMenuBar (newMenuBar) existed. I must have just not noticed & moved it up into the else statement when I rewrote it.

[merlight]

I've pushed libCIF version 1.1 on github

Originally Posted by circonian Does the search box need to be hidden when AGS is done with it & the trading house closes? Is it supposed to remain visible on other layouts if the user is only using AGS & not FilterIt or Advanced Filters?

Forgot to reply to this one. I don't use the search box myself. ZOS UI gives you either filter buttons or search box. I prefer consistency.

[QuadroTony]

thing is i like AGS search box ar the Trade house
but they must be disabled at the other scenes like inventory, and we will see FilterIt search box there, etc

[merlight]

Originally Posted by QuadroTony thing is i like AGS search box ar the Trade house but they must be disabled at the other scenes like inventory, and we will see FilterIt search box there, etc

Have you even tried? AGS has a setting now that lets you choose whether you want AGS filters or not (in which case you'll have basic or AdvancedFilters or FilterIt, depending on what you have enabled).

[QuadroTony]

Originally Posted by merlight Have you even tried? AGS has a setting now that lets you choose whether you want AGS filters or not (in which case you'll have basic or AdvancedFilters or FilterIt, depending on what you have enabled).

you think i am newb with 140 addons?
ofc i tried
there is no way to change AGS search field from inventory/bank etc for search field from FilterIt without disabling AGS completely

[merlight]

Originally Posted by QuadroTony you think i am newb with 140 addons? ofc i tried there is no way to change AGS search field from inventory/bank etc for search field from FilterIt without disabling AGS completely

Ah, you mean the wrong placement. That'll be fixed, just be patient. But the search itself works, yes?

[QuadroTony]

Originally Posted by merlight Have you even tried? AGS has a setting now that lets you choose whether you want AGS filters or not (in which case you'll have basic or AdvancedFilters or FilterIt, depending on what you have enabled).

search function woring ofc
also in the guildbank too, thanks to the Circonian fix addon