2.1 and SetHandler

i'm not sure of the protocole here... do I have to sacrifice a Virgin or something to have my questions looked at?
I'm starting to feel a little butthurt tbh.

yeah top post of a second page. ok. nvm. forget it.

[QuadroTony]

/offtop

Originally Posted by Wandamey do I have to sacrifice a Virgin or something

Originally Posted by Wandamey nothing that you can buy, i'm not your *****.

Originally Posted by votan Question: What if like this: Bad? local function DoSomeWhat()         --Code end   --This is run often function SetupTexture(texture, width, height)     texture:SetHandler("OnMouseEnter", DoSomeWhat)     texture:SetDimensions(width, height) end

i suppose

onload : CreateControl + 
texture:SetHandler("OnMouseEnter", DoSomeWhat) -- we got that now i think


local function DoSomeWhat(addon.a,addon.b,addon.c...)
    use addon.a
    use addon.b
    if addon.c then  
       blabla
   else
      blob
   end
end

--This is run often
function SetupTexture(a, b, c)
     texture:SetDimensions(a, c)
     addon.a = a
     addon.b = f(b)
     addon.c = constant  -- whatever
end

would that be the expected solution?


i repeat my question about "removing" a Handler (seems we got 2 different answers with baertram, maybe it would be a good thing to clear it)

is niling a handler as bad as overwrite it?

[merlight]

Originally Posted by Wandamey Edit: btw, how to "remove" a Handler? Setting it on nil will delete the previous "closure" too?

That's exactly how you do it. If there's no other reference to it, it'll be garbage collected eventually.

so basically, i could patch anything very easily if the same function is called all the programm long by doing this (or just tweak the function with conditions if this has to change):

if control:GetHandler("OnThisaction") == nil then  control:SetHandler("OnThisaction", definedfunction) end

?

[merlight]

You just need to avoid creating a thousand closures. Once you do that, you will notice that your code doesn't need to call SetHandler a thousand times, because all the calls would be identical. Aim for removing unnecessary closures. Set the handler once after constructing the control.

If you need something more complex, like switching an OnUpdate handler on when resizing and off when it's done, you naturally do have to call SetHandler multiple times, but chances are you don't need to create multiple closures.

Originally Posted by merlight You just need to avoid creating a thousand closures. Once you do that, you will notice that your code doesn't need to call SetHandler a thousand times, because all the calls would be identical. Aim for removing unnecessary closures. Set the handler once after constructing the control. If you need something more complex, like switching an OnUpdate handler on when resizing and off when it's done, you naturally do have to call SetHandler multiple times, but chances are you don't need to create multiple closures.

thing is i get it overall, but when i look at my plugin for someone else's addon, there are a lot of things I can't control. But i'll figure out something. Just hoping it won't be worse after from another point of view than this particular problem.

[Fyrakin]

OK, I just changed texture handlers in My add-on using pre-declared functions and setting handlers only when new controls are created. I expected to see much better results, though performance improvement is visible but not as I hoped .

[Randactyl]

My question is, what changed in the IC update that made this so much more of a problem than it was previously? Of course we should not be creating unnecessary closures, but it seems like the game is handling the issue with less grace than it should (or at least less than it was previously).

Originally Posted by Fyrakin OK, I just changed texture handlers in My add-on using pre-declared functions and setting handlers only when new controls are created. I expected to see much better results, though performance improvement is visible but not as I hoped .

wait, i'm almost done with mine... it'll make the tv shows pretending that it takes only one blondine to shut down the internet look ridiculous.

(yeah I feel guilty for last week-end now)

[Fyrakin]

Originally Posted by Randactyl My question is, what changed in the IC update that made this so much more of a problem than it was previously? Of course we should not be creating unnecessary closures, but it seems like the game is handling the issue with less grace than it should (or at least less than it was previously).

Introduction of OnTextureLodead? I suspectį it also led to memory leak of sorts.

[Baertram]

haha, I like "OnTextureLodead". This explains in short why the peaks happen

[Fyrakin]

Originally Posted by Baertram haha, I like "OnTextureLodead". This explains in short why the peaks happen

I was starting to think no one will see that.

[@AlphaLemming]

Is there any example for designing a UI with XML and using it in LUA with my Addon ?
I never was happy to create this all in LUA.

[Fyrakin]

Originally Posted by @AlphaLemming Is there any example for designing a UI with XML and using it in LUA with my Addon ? I never was happy to create this all in LUA.

I have some controls like buttons with handlers configured in XML, you can look at MiniMap.xml

[@AlphaLemming]

Thanks, that will help. Is there a possibilty to use array names for XML elements?

[ZOS_ChipHilseberg]

Originally Posted by Fyrakin Introduction of OnTextureLodead? I suspectį it also led to memory leak of sorts.

Internally we haven't experienced any noticable change in performance of the stock UI (which runs as an addon the same as the custom addons). So any information on what in particular is triggering the performance problems you are seeing is helpful. Why do you think OnTextureLoaded is involved?

[Fyrakin]

Originally Posted by ZOS_ChipHilseberg Internally we haven't experienced any noticable change in performance of the stock UI (which runs as an addon the same as the custom addons). So any information on what in particular is triggering the performance problems you are seeing is helpful. Why do you think OnTextureLoaded is involved?

Because after update, while on PTS I was experiencing severe performance degrade compared to what was on-live. Its just my theory, suspicion, superstition, etc. Well, to be honest we have very limited profiling means/tools. Just a game client and strong will to do something. We have no luxury to monitor which process utilizes most resources so we have to do it on try and error basis. So, based on /script d(collectgarbage("count")) output I observed a very fast lua memory usage increase I was comparing it to how it ran on live and pts, these figures haven't changed.

So, as you suggested I changed sethandler setting during add-on init for most of the texture add-on would use (handlers mostly for tooltips). I even moved anonymous functions to predeclared ones. I didn't see any change in resource consumption and I haven't noticed any signifficant performance improvement. SO, what else you would suggest us to do? I as many others would like to have minimap functionality, but at current state it is to say the least is not usable.

Follow up.
I managed to address the performance issues. Even though I no longer use my own tables to store and manage custom pin data I still observed fast collectgarbage("count") build up.

[Fyrakin]

Originally Posted by Wandamey I hope you can make it 3 lines with pictures the big picture i see here is : store your functions first. but how do i pass a variable to it without using an Anonymous func again to call it? -- maybe the table?

What about self.your variable?

[Lodur]

Originally Posted by Wandamey probably a stupid question but i suppose someone has to ask it... what is a closure? an example would be nice too.

A closure is a combination of context and code...