Attribute visuals (shields) bug

Garkin · 04/13/15, 09:39 AM

Did you notice that Unit Attrribute Visualizer for shields doesn't work correctly?

You can easily reproduce this bug if you renew two or more shields multiple times - old shields aren't crrectly removed, so your health bar looks like you have permanently applied shield. (Tested with Blazing Shield I + Healing Ward III)

If you take a look into values in PLAYER_ATTRIBUTE_BARS.attributeVisualizer.visualModules, shield value never gets to zero, there are artificial numbers like:
lastValue = 52151
maxValue = -15213
statusMax = 8114 (probably correct)
statusValue = 8114 (probably correct)
value = 52151

I have tried to track shield strength on my own (ShieldInfo addon), but it seems that this is not an UI bug, because event EVENT_UNIT_ATTRIBUTE_VISUAL_UPDATED returns invalid numbers. And also because of invalid shield value events EVENT_UNIT_ATTRIBUTE_VISUAL_ADDED and EVENT_UNIT_ATTRIBUTE_VISUAL_REMOVED are almost never fired (for ATTRIBUTE_VISUAL_POWER_SHIELDING).

Is it really game bug or did I miss something?

Garkin · 04/13/15, 09:51 AM

Debug info from this code:

Lua Code:

local function UnitAttributeVisual(evt, unitTag, unitAttributeVisual, statType, attributeType, powerType, value1, value2, value3, value4)
   if unitTag == "player" and unitAttributeVisual == ATTRIBUTE_VISUAL_POWER_SHIELDING and attributeType == ATTRIBUTE_HEALTH then
      if evt == EVENT_UNIT_ATTRIBUTE_VISUAL_UPDATED then
         d(zo_strformat("Shield Updated: <<1>>, <<2>>, <<3>>, <<4>>", value1, value2, value3, value4))
      elseif evt == EVENT_UNIT_ATTRIBUTE_VISUAL_ADDED then
         d(zo_strformat("Shield Added: <<1>>, <<2>>", value1, value2))
      elseif evt == EVENT_UNIT_ATTRIBUTE_VISUAL_REMOVED then
         d(zo_strformat("Shield Removed: <<1>>, <<2>>", value1, value2))
      end
   end
end
 
EVENT_MANAGER:RegisterForEvent(EVENT_UNIT_ATTRIBUTE_VISUAL_ADDED, UnitAttributeVisual)
EVENT_MANAGER:RegisterForEvent(EVENT_UNIT_ATTRIBUTE_VISUAL_REMOVED, UnitAttributeVisual)
EVENT_MANAGER:RegisterForEvent(EVENT_UNIT_ATTRIBUTE_VISUAL_UPDATED, UnitAttributeVisual)

Used events:

Code:

* EVENT_UNIT_ATTRIBUTE_VISUAL_ADDED (*string* _unitTag_, *integer* _unitAttributeVisual_, *integer* _statType_, *integer* _attributeType_, *integer* _powerType_, *number* _value_, *number* _maxValue_)
* EVENT_UNIT_ATTRIBUTE_VISUAL_REMOVED (*string* _unitTag_, *integer* _unitAttributeVisual_, *integer* _statType_, *integer* _attributeType_, *integer* _powerType_, *number* _value_, *number* _maxValue_)
* EVENT_UNIT_ATTRIBUTE_VISUAL_UPDATED (*string* _unitTag_, *integer* _unitAttributeVisual_, *integer* _statType_, *integer* _attributeType_, *integer* _powerType_, *number* _oldValue_, *number* _newValue_, *number* _oldMaxValue_, *number* _newMaxValue_)

Output:

Code:

Shield Updated: 91789, 94453, -36461, -33797
Shield Updated: 94453, 99707, -33797, -28543
Shield Updated: 99707, 99398, -28543, -34007
Shield Updated: 99398, 102062, -34007, -31343
Shield Updated: 102062, 101753, -31343, -36807
Shield Updated: 101753, 107007, -36807, -31553
Shield Updated: 107007, 106698, -31553, -37017
Shield Updated: 106698, 109362, -37017, -34353
Shield Updated: 109362, 109053, -34353, -39817
Shield Updated: 109053, 114307, -39817, -34563
Shield Updated: 114307, 113998, -34563, -40027
Shield Updated: 113998, 116662, -40027, -37363
Shield Updated: 116662, 116353, -37363, -42827
Shield Updated: 116353, 121607, -42827, -37573
Shield Updated: 121607, 121298, -37573, -43037
Shield Updated: 121298, 123962, -43037, -40373
Shield Updated: 123962, 121298, -40373, -43037
Shield Updated: 121298, 123962, -43037, -40373
Shield Updated: 123962, 123653, -40373, -45837
Shield Updated: 123653, 128907, -45837, -40583
Shield Updated: 128907, 128598, -40583, -46047
Shield Updated: 128598, 131262, -46047, -43383
Shield Updated: 131262, 130953, -43383, -48847
Shield Updated: 130953, 136207, -48847, -43593
Shield Updated: 136207, 135898, -43593, -49057
Shield Updated: 135898, 130644, -49057, -54311

I have started with no shield active, it was after reload UI, so some values could be present somewhere.
What I did? Activate Blazing Shield, switch weapon set, activate Healing Ward, switch weapon set, renew Blazing Shield, switch weapons etc. until I run out of magicka.

As you can see, EVENT_UNIT_ATTRIBUTE_VISUAL_ADDED and EVENT_UNIT_ATTRIBUTE_VISUAL_REMOVED wasn't fired even once and shield values in EVENT_UNIT_ATTRIBUTE_VISUAL_UPDATED are, ...hm let's say odd. Max value is negative number?

ZOS_ChipHilseberg · 04/14/15, 08:24 AM

This definitely sounds like a bug.

sirinsidiator · 04/14/15, 09:23 AM

I also have this problem from time to time. Usually happens in Cyrodiil for me. Only goes away after I relog or crash (which happens a lot more often

).

XEVENEX · 05/27/15, 08:37 AM

Confirming this is a bug that I have been dealing with for a long time. The only thing you can do is log out and log back in again. Reloadui will not fix it. Please fix this ZOS!

EDIT:
Champion passives, abilities, and weapon enchants that provide small shields will also trigger this bug.

sirinsidiator · 06/09/15, 03:55 PM

I added a workaround to my new addon sidWarTools. When you enter /resetshields in chat, it will take the current shield values and subtract them from whatever is returned by the API afterwards.

**Baertram** · 06/09/15, 04:09 PM

Could this fix be implemented into another "bugfix addon", like existing ones of merlight http://www.esoui.com/downloads/info9...O-UIFixes.html or Circonian's http://www.esoui.com/downloads/info9...nsTweakIt.html, or even Garkin's http://www.esoui.com/downloads/info865-Nothankyou.html?

No offense, but I'm not using your addon here because I don't need the other stuff it provides, but I'm interested into that shield bug fix

Thanks

sirinsidiator · 06/09/15, 04:14 PM

You can disable every single other thing it is doing completely. But I won't stop others form adding a similar fix to their addons

**Baertram** · 06/10/15, 11:29 AM

Ah, well...
If everything else can be disabled I'm good

I didn't install it so far. Thanks for the information, will try it later on.

ZOS_ChipHilseberg · 06/10/15, 12:07 PM

I'll take a shot a reproducing this today.

ZOS_ChipHilseberg · 06/10/15, 01:01 PM

This is now fixed internally.

sirinsidiator · 06/10/15, 02:46 PM

This is great to hear.

Will it be part of the (tenative) update on monday, or delayed until 2.1? Depending on the answer I might improve the workaround in my addon so it resets the shields automatically.

ZOS_ChipHilseberg · 06/11/15, 07:53 AM

We're aiming for the Monday patch. No promises.

ZOS_ChipHilseberg · 06/12/15, 08:24 AM

Looks like it won't make Monday. It should be in for the incremental patch after that though.

sirinsidiator · 06/12/15, 09:10 AM

Okay, thanks for the heads up. I will concentrate on other features that want to be implemented then.

sirinsidiator · 07/03/15, 04:34 PM

Seems this bug is still around and the latest patch changed the return value of GetUnitAttributeVisualizerEffectInfo so that it becomes nil when no shields are applied.

merlight · 08/17/15, 04:40 PM

Bump, still present on live. Every day, after a couple fights my health bar looks like this:

Note that I use a lot of shields, so it gets bugged quickly: Igneous Shield, Shield Assault, Ferocious Leap, Hardening weapon enchantment. Plus other players' shields I get.

Edit: forgot Whitestrake's Retribution

sirinsidiator · 08/18/15, 02:45 AM

Can confirm. Get that every few days in pvp and also hear a lot of people in the Arena guild complain about it.
My workaround in sidWarTools is still around

ZOS_ChipHilseberg · 08/18/15, 07:40 AM

The original bug was caused by some uninitialized memory being used. Let me check to make sure the fix is actually on live. It would be strange that two overlapping bugs were causing the same thing, but not impossible.

ZOS_ChipHilseberg · 08/18/15, 08:01 AM

Yes the fix is definitely on live. Is the repro the same? Just use several shields at once?