move item from bag to bank

[Motokosworld]

Hi!
I a new to this forum here, i hope i got the right tread to ask a question. I am from Germany so sorry for any wrong English sentences/words.
I wanna make some Addons for TESO.
On the first hand to get better in coding on the other hand to have some to fit my needs.
I learn java at university and I am new to lua.
I tried to move an item from the bagpack to the bank but it do not work.
I used the "my first addon" help out of the wiki from esoui. And looked into other persons code. But still not working.

I want to move all items of a special kind to the bank, for example all food. I also wanted to use the "y" key function to stack if you can use it. ATM i do not find that function.

Hope someone can give me an example or some tipps. Also some webseites with more tutorials or code explanation would be helpful.
AT my programming its always a little problem /wrong thinking that stops all. >.<""!


My code atm: move 1 item and then crash game >.<



function FooAddon.OnOpenBank(eventcode)
for num = 1, GetBagSize(1), 1 do
firstFreeSlot = FindFirstEmptySlotInBag(2)
icon, istack, sellPrice, meetsUsageRequirement, locked, equipType, itemStyle, quality = GetItemInfo(1, num)
if 0 ~= GetNumBagFreeSlots(2) then
if IsProtectedFunction("RequestMoveItem") then
CallSecureProtected("RequestMoveItem", 1, num, 2, firstFreeSlot, istack)
else
RequestMoveItem(1, num, 2, firstFreeSlot, istack)
end
end
end
end

[sirinsidiator]

Hello and welcome to EsoUI, Motokosworld!

You found the right place for asking this kind of question.

What you want to do can be broken down into four parts:
1, Offer a way to trigger your function
2. Detect when you are at a bank
3. Find all instances of the item in your inventory and move them to the bank
4. Use the 'y' stack function to stack them

I will offer you a basic example that you can use as a starting point.
ad 1)
There are many ways how this can happen.
You can offer a chat command, automatically trigger it whenever the user visits a bank, add a keybind or show some GUI elements that can be clicked.
The first two are comparatively simple while the others require quite some code, so we will stick to a chat command for now.

SLASH_COMMANDS["/dumpall"] = function()
MyAddon.DumpItemsToBank()
end

ad 2)
This is necessary because you cannot access BAG_BANK unless you are at a banker and chose the bank dialog.
For now we will add a function to prevent DumpItemsToBank from doing anything while we are not at a bank.

local function IsAtBank()
  return GetInteractionType() == INTERACTION_BANK
end
 
function MyAddon.DumpItemsToBank()
  if not IsAtBank() then return end
end

ad 3)
Now we get to the interesting part. First we have to iterate over all our items and test if they are of the type we want to dump.
You mentioned that you want to move all food to bank, so we stick to that for now.
You already found the necessary methods so everything we need to do is combine it like this:

for slotIndex = 1, GetBagSize(BAG_BACKPACK) do
  if GetItemType(BAG_BACKPACK, slotIndex) == ITEMTYPE_FOOD then
    MoveItemToBank(slotIndex)
  end
end

GetFirstFreeValidSlotForItem seems to work on the same bag only as it requires a slotIndex to specify an item. FindFirstEmptySlotInBag(integer Bag bagId) is more likely to do what we want so we will try it.
We also need to get the stack size in order to move the correct amount. This can be done with GetSlotStackSize(integer bagId, integer slotIndex).
Once we have the slot we can move request to move it there with the function you already have found.

local function MoveItemToBank(slotIndex)
  local stackCount = GetSlotStackSize(BAG_BACKPACK, slotIndex)
  local destSlot = FindFirstEmptySlotInBag(BAG_BANK)
  CallSecureProtected("RequestMoveItem", BAG_BACKPACK, slotIndex, BAG_BANK, destSlot, stackCount)
end

ad 4)
All that is left now is to find out how the key bind to stack items is working. For this we need to have a look at the UI source code which can be found here.
The bank is simply another inventory so we take a look at ingame/inventory/inventory.lua and by looking for the keyword "stack" we find StackBag(BAG_BANK).
So after we put everything together in DumpItemsToBank we arrive at:

function MyAddon.DumpItemsToBank()
  if not IsAtBank() then return end
 
  for slotIndex = 0, GetBagSize(BAG_BACKPACK)-1 do
    if GetItemType(BAG_BACKPACK, slotIndex) == ITEMTYPE_FOOD then
      MoveItemToBank(slotIndex)
    end
  end
 
  StackBag(BAG_BANK)
end

This is completely untested so it might not work right away, but it should give you a general idea how it can be done.

EDIT: Just saw that you updated your post. Instead of adding a chat command you can just call MyAddon.DumpItemsToBank() from your event handler too and of course it will be necessary to check if the bank has enough space left before trying to move the item.
EDIT2: corrected code in response to votan

[Motokosworld]

Thank you very much for your answer!
I will work now with the things you wrote and will write later how far i came with it!

[votan]

slot-indexes are (the only) zero-based indexes.

for slotIndex = 0, GetBagSize(BAG_BACKPACK)-1 do ...

Und Willkommen, Motokosworld.

[Motokosworld]

Thx votan for your advice. About that i was also thinking, because out of java i know that everything start at 0 and then max-1 so i correct that now.

The problem is, it work 1 time if i open the bank and then again if i open the bank again. SO i think the loop do not work, but why? If i try out some thinks like quote out the if that i only move food, it works once and then if i talk to the banker the second time my game crash.
Maybe there is a problem with that function(RequestMoveItem) or the inventory do not update correctly? i will try out...


My code now much more clean and nice written code with a lot of comments^^, some are still from the tutorial, but i leave them there to learn the functions of all the lua code parts:

-- First, we create a namespace for our addon by declaring a top-level table that will hold everything else.
BankService = {}
 
-- This isn't strictly necessary, but we'll use this string later when registering events.
-- Better to define it in a single place rather than retyping the same string.
BankService.name = "BankService"
 
-- if the bank is open start this
function BankService.OnOpenBank()
 
    --Run through all slots of the bag
    for slotInBag = 0, GetBagSize(BAG_BACKPACK)-1, 1 do
    
        --check if there is still space in bank and the slot is not empty
        if 0 ~= GetNumBagFreeSlots(BAG_BANK) and GetItemName(BAG_BACKPACK, slotInBag) ~= "" then
    
            -- check if the itemtype is food
            if GetItemType(BAG_BACKPACK, slotInBag) == ITEMTYPE_FOOD then
            
                -- find a free bankslot
                local freeBankSlot = FindFirstEmptySlotInBag(BAG_BANK)
                
                -- read out the stackSize of that item
                local stackSize = GetSlotStackSize(BAG_BACKPACK, slotInBag)
                
                --use the protected function to move the item to the bank
                if IsProtectedFunction("RequestMoveItem") then
                    CallSecureProtected("RequestMoveItem", BAG_BACKPACK, slotInBag, BAG_BANK, freeBankSlot, stackSize)
                else
                    RequestMoveItem(BAG_BACKPACK, slotInBag, BAG_BANK, freeBankSlot, stackSize)
                -- close if checkProtectedFunction
                end
                
                --use the integrated stack function to stack all in bank
                StackBag(BAG_BANK)
                
            -- close if checkItemtype
            end
        -- close if checkSpace and notEmpty
        end 
    --close loop        
    end
--close function    
end
 
 
-- initialze function
function BankService:Initialize()
    --Register our event
    EVENT_MANAGER:RegisterForEvent(self.name,  EVENT_OPEN_BANK, self.OnOpenBank)        
end
 
 
-- Event handler function, check if the loaded addon is mine
-- Initialize our addon after all of its resources are fully loaded.
function BankService.OnAddOnLoaded(event, addonName)
  -- The event fires each time *any* addon loads - but we only care about when our own addon loads.
  if addonName == BankService.name then
    BankService:Initialize()
  end
end
 
-- Finally, we'll register our event handler function to be called when the proper event occurs.
EVENT_MANAGER:RegisterForEvent(BankService.name, EVENT_ADD_ON_LOADED, BankService.OnAddOnLoaded)

[sirinsidiator]

Originally Posted by Motokosworld The problem is, it work 1 time if i open the bank and then again if i open the bank again. SO i think the loop do not work, but why?

That's what you are doing with your code. You react to EVENT_OPEN_BANK which is fired once when the bank opens, so it only runs one time when you open the bank and again when you open the bank another time.
If you want it to run again while you are still at the bank you need to provide a different way to trigger the function.

[Motokosworld]

But I wrote a loop around that all, why it do not go through the loop? Normaly a loop means go through it until you checked all values inside the loop...

Or do I only need to write the loop into another subfunction?

[merlight]

Because items are not moved immediately, the actual transfer is done later, not from Lua code. GetNumBagFreeSlots, FindFirstEmptySlotInBag will keep returning the same value during the whole frame. We've had the exact same issue some time ago http://www.esoui.com/forums/showthre...EmptySlotInBag

[sirinsidiator]

Oh. I didn't know that. I have never used these functions myself to move items around but it sounds reasonable. I guess you could listen to EVENT_INVENTORY_SINGLE_SLOT_UPDATE and wait until the move happened before doing the next one.
Just make sure to only register to it when you start the movement process and unregister again afterwards, because there are already some performance problems with that event.

[Motokosworld]

So if i understand it correctly you move the item in imaging and if all your addon on progresses are run through the moving task will be sent to server and then the server will do it?

A bit difficult to understand, but i think its some of the problems you have with addons, because its not real coding. But implementing in an already running progress.

Now i rewrote a lot of my code, but my game freeze. I looked through the link you gave me and made these changes because of that. But i guess ther is still something wrong. So i will post my code here and also will work later or tomorrow on it.

I know that i can still improve a lot on my code, but i want at first a really working programm after that i optimize it.

I use Notepad++ maybe you have another codeeditor where i an jump to functions? And test for code errors. ATM i only test at teso.

So i am happy for some hints where the problem is.

-- First, we create a namespace for our addon by declaring a top-level table that will hold everything else.
BankService = {}
 
-- This isn't strictly necessary, but we'll use this string later when registering events.
-- Better to define it in a single place rather than retyping the same string.
BankService.name = "BankService"
 
-- if the bank is open start this
function BankService.OnOpenBank()
    BankService.moveMyItems()
end
 
function BankService.moveMyItems()
        -- find a free slot in bank
    local emptyIndex = findEmptySlotInBag(BAG_BANK, nil, GetBagSize(BAG_BANK) - 1)
        -- start at the first slot in my backpack
    local slotInBag = 0
 
    ----check if emptyINdex is not nil and the slotInBag is still inside my Bag limit only then run the loop (again)
    while emptyIndex ~= nil and slotinBag ~= GetBagSize(BAG_BACKPACK) do
    
        --check if the slot is not empty or the item is stolen
        if GetItemType(bagId, slotIndex) ~= ITEMTYPE_NONE and IsItemStolen(BAG_BACKPACK, slotInBag) == false then   
        
            -- check if the itemtype is food
            if GetItemType(BAG_BACKPACK, slotInBag) == ITEMTYPE_FOOD then
                    
                -- read out the stackSize of that item
                local stackSize = GetSlotStackSize(BAG_BACKPACK, slotInBag)
                    
                --use the protected function to move the item to the bank
                if IsProtectedFunction("RequestMoveItem") then
                    CallSecureProtected("RequestMoveItem", BAG_BACKPACK, slotInBag, BAG_BANK, emptyIndex, stackSize)
                else
                    RequestMoveItem(BAG_BACKPACK, slotInBag, BAG_BANK, emptyIndex, stackSize)
                -- close if checkProtectedFunction
                end
                -- we now used our empty space so start looking one slot after the used one for a new one
                emptyIndex = findEmptySlotInBag(BAG_BANK, emptyIndex+1, GetBagSize(BAG_BANK)-1)                     
            -- close if checkItemtype
            end
        -- close if checkSpace and notEmpty
        end
        -- we checked the slot so move on to the next one
        slotInBag = slotInBag+1     
    --close loop            
    end
    -- Sort the bank
    -- StackBag(BAG_BANK)
--close function    
end
 
function findEmptySlotInBag(bagId, prevIndex, lastIndex)
    local slotIndex = prevIndex or -1
    while slotIndex < lastIndex do
        slotIndex = slotIndex + 1
        if GetItemType(bagId, slotIndex) == ITEMTYPE_NONE then
            return slotIndex
        end
    end
    return nil
end
 
------------------------------------------------------------------------------------------------------------------------
-- initialze function
------------------------------------------------------------------------------------------------------------------------
function BankService:Initialize()
    --Register our event
    EVENT_MANAGER:RegisterForEvent(self.name,  EVENT_OPEN_BANK, self.OnOpenBank)        
end
 
 
-- Event handler function, check if the loaded addon is mine
-- Initialize our addon after all of its resources are fully loaded.
function BankService.OnAddOnLoaded(event, addonName)
  -- The event fires each time *any* addon loads - but we only care about when our own addon loads.
  if addonName == BankService.name then
    BankService:Initialize()
  end
end
 
-- Finally, we'll register our event handler function to be called when the proper event occurs.
EVENT_MANAGER:RegisterForEvent(BankService.name, EVENT_ADD_ON_LOADED, BankService.OnAddOnLoaded)

[merlight]

Originally Posted by sirinsidiator Oh. I didn't know that. I have never used these functions myself to move items around but it sounds reasonable. I guess you could listen to EVENT_INVENTORY_SINGLE_SLOT_UPDATE and wait until the move happened before doing the next one. Just make sure to only register to it when you start the movement process and unregister again afterwards, because there are already some performance problems with that event.

You can request multiple at once, but you need to find the next free slot yourself (i.e. remember where you already tried to put something).

[merlight]

You have a couple typos in that code.

slotinBag ~= GetBagSize(BAG_BACKPACK) -- always true => freeze

GetItemType(bagId, slotIndex) -- undefined vars

Also don't make the function findEmptySlotInBag global. Define it local before use, or place it in your namespace.

[Motokosworld]

I do not now how to make the change you wrote.
if i write local in front of the function the other do not find it. I corrected the 2 wrong variables.


Now its working! THX!!!!!!!

my code look now like this:

-- First, we create a namespace for our addon by declaring a top-level table that will hold everything else.
BankService = {}
 
-- This isn't strictly necessary, but we'll use this string later when registering events.
-- Better to define it in a single place rather than retyping the same string.
BankService.name = "BankService"
 
-- if the bank is open start this
function BankService.OnOpenBank()
    BankService.moveMyItems()
end
 
function BankService.moveMyItems()
    -- find a free slot in bank
    local emptyIndex = findEmptySlotInBag(BAG_BANK, nil, GetBagSize(BAG_BANK) - 1)
    -- start at the first slot in my backpack
    local slotInBag = 1
    --check if emptyINdex is not nil and the slotInBag is still inside my Bag limit only then run the loop (again)
    while (emptyIndex ~= nil) and (slotInBag <= GetBagSize(BAG_BACKPACK)) do
    
        --check if the slot is not empty or the item is stolen
        if GetItemType(bagId, slotInBag) ~= ITEMTYPE_NONE and IsItemStolen(BAG_BACKPACK, slotInBag) == false then   
        
            -- check if the itemtype is food
            if GetItemType(BAG_BACKPACK, slotInBag) == ITEMTYPE_FOOD then
                    
                -- read out the stackSize of that item
                local stackSize = GetSlotStackSize(BAG_BACKPACK, slotInBag)
                    
                --use the protected function to move the item to the bank
                if IsProtectedFunction("RequestMoveItem") then
                    CallSecureProtected("RequestMoveItem", BAG_BACKPACK, slotInBag, BAG_BANK, emptyIndex, stackSize)
                else
                    RequestMoveItem(BAG_BACKPACK, slotInBag, BAG_BANK, emptyIndex, stackSize)
                -- close if checkProtectedFunction
                end
                -- we now used our empty space so start looking one slot after the used one for a new one
                emptyIndex = findEmptySlotInBag(BAG_BANK, emptyIndex+1, GetBagSize(BAG_BANK) - 1)                       
            -- close if checkItemtype
            end
        -- close if checkSpace and notEmpty
        end
        -- we checked the slot so move on to the next one
        slotInBag = slotInBag+1     
    --close loop            
    end
    -- Sort the bank
    -- StackBag(BAG_BANK)
--close function    
end
 
function findEmptySlotInBag(bagId, prevIndex, lastIndex)
    local slotIndex = prevIndex or -1
    while slotIndex < lastIndex do
        slotIndex = slotIndex + 1
        if GetItemType(bagId, slotIndex) == ITEMTYPE_NONE then
            return slotIndex
        end
    end
    return nil
end
 
------------------------------------------------------------------------------------------------------------------------
-- initialze function
------------------------------------------------------------------------------------------------------------------------
function BankService:Initialize()
    --Register our event
    EVENT_MANAGER:RegisterForEvent(self.name,  EVENT_OPEN_BANK, self.OnOpenBank)        
end
 
 
-- Event handler function, check if the loaded addon is mine
-- Initialize our addon after all of its resources are fully loaded.
function BankService.OnAddOnLoaded(event, addonName)
  -- The event fires each time *any* addon loads - but we only care about when our own addon loads.
  if addonName == BankService.name then
    BankService:Initialize()
  end
end
 
-- Finally, we'll register our event handler function to be called when the proper event occurs.
EVENT_MANAGER:RegisterForEvent(BankService.name, EVENT_ADD_ON_LOADED, BankService.OnAddOnLoaded)

[merlight]

If it's local, it must be defined (lexically) before use, i.e. move the definition above BankService.moveMyItems. Or make it BankService.findEmptySlotInBag. Global namespace is shared among all ZOS and add-on code, it's best to put as few things in there as possible.

Btw you're skipping slots with findEmptySlotInBag(BAG_BANK, emptyIndex+1, ...); drop the +1, it's added in the function.

[CrazyDutchGuy]

Or just take a peek in http://www.esoui.com/downloads/info4...nkStacker.html which does most of the stuff you want allready