Pb with zo_strformat or itemlink and icon

[Flagrick]

Hello,

in lootdrop i have added a debug log to see exactly what we loot with more informations,
but I encounter a problem in that code :

-------------------------------------------------------------------------------
function LootDrop:dbgDrop(iconFilename, c, quantity, text, tag)
 
    if (not self.db.DbgLog) then return end
 
    if ( not iconFilename or iconFilename == '' )then
        iconFilename = [[/esoui/art/icons/icon_missing.dds]]
    end
 
    if (quantity ~= 0) then
        local color = ZO_ColorDef:New( c )
        local dbgText1='[' .. GetTimeString() .. ']:'
 
        if not self.db.DbgLogTime then
            dbgText1 = ''
        end
        
        local icon = CreateIcon(iconFilename)
 
        local dbgText2=zo_strformat( '<<1[//$dx]>> <<2>>', quantity, text)
        --d(dbgText2) --> label OK
        
        if ((tag=='INV') or (tag=='JUNK') or (tag=='MAIL')) then
            dbgText2=zo_strformat( '<<1[//$dx]>> <<2>> |c736F6E(<<3>>)|r', quantity, text, self.ItemToPrint.nb)
        end
 
        local dbgText3='.'
        if tag~='' then dbgText3=' (' .. tag .. ').' end
 
        local finaldbgtext=zo_strformat( '<<1>> <<2>> <<3>><<4>>', dbgText1, icon, dbgText2, dbgText3)
        d(finaldbgtext)
    end
end

d(dbgText2) gives me that :
but in final with finaldbgtext it prints that :
where could come the 'rh', any idea ?

item with tag INV, MAIL or JUNK are correctly print :

I have made a lot of tests but I have no idea to correct it.
I think I do a mistake with itemlink or zo_strformat but I don't know which one.
if someone could help ...

[merlight]

Those images are not from the exact code you posted. In the code, dbgText1 has a colon at the end, and dbgText2 comprises of quantity, text, without time.

My guess is that quantity=="rh" in some calls, who knows why.

local dbgText2=zo_strformat( '<<1[//$dx]>> <<2>>', quantity, text)

I have no idea what zo_strformat would do if quantity wasn't a number, so I'd d(type(quantity) .. ": " .. tostring(quantity)) to see.

[Flagrick]

hello Merlight,

time is given by an other addon (pchat), for this example dbgText1 = ''.
i assume that quantity is a number because the function call is :

--d(dbglabel)--> label ok
self:dbgDrop(icon, color, 1, dbglabel, tag)

and then in

local dbgText2=zo_strformat( '<<1[//$dx]>> <<2>>', quantity, text)

text = dbglabel, quantity = 1, and tag ='CRAFT'

here the code of CreateIconfunction:

-------------------------------------------------------------------------------
function CreateIcon(filename, width, height)
    return zo_iconFormat(filename, width or 16, height or 16)
end
-------------------------------------------------------------------------------

I will add in code

d(type(quantity) .. ": " .. tostring(quantity))

to see if there is something wrong with quantity.

[Flagrick]

done tests :

local dbgText2=zo_strformat( '<<1[//$dx]>> <<2>>', quantity, text)
        d(dbgText2) --> label OK
        d(type(dbgText2) .. ": " .. tostring(dbgText2)) 
        d(type(quantity) .. ": " .. tostring(quantity))  --> Quantity OK, it's a number 
        d(type(icon) .. ": " ..  tostring(icon))

there the results :


so, it seems that the tostring(dbgText2) gives the 'rh', but why (the type is string) ?

[Flagrick]

FOUND IT !

--local pctexts = zo_strformat( '|c736F6E(<<1>>%)|r', pccurrent ) --> error
local pctexts = zo_strformat( '(<<1>>%)', pccurrent ) --> OK

and then i use this code in

local finaldbgtext=zo_strformat( '|c6BB5FF<<1>>|r  |c736F6E-> <<2>> / <<3>>  <<4>>|r |cFFFFFF[<<t:5>>]|r', self:FormatAmount(RealGain), self:FormatAmount(SkillXp), self:FormatAmount(SkillXpTotal), pctexts, skillName )

So, i think that use coloration two times on the same text gives an error with zo_strformat().
it's now corrected.

thx merlight for help.