Quantcast
Librarian - Page 6 - ESOUI
Thread Tools Display Modes
01/17/18, 09:25 AM   #101
Baertram
Super Moderator
 
Baertram's Avatar
WoWInterface Super Mod
AddOn Author - Click to view addons
Join Date: Mar 2014
Posts: 4,162
As written before, do tis to fix the bug:
Replace "LoreReader" with "LORE_READER" on the line mentioned in the error message, ie in the file <your-addons-folder>/Librarian/Librarian.lua line 516.

Then run /reloadui if you are already inside the game.
  Reply With Quote
01/17/18, 10:44 AM   #102
Ashnarug
Join Date: Jan 2018
Posts: 3
this only allowed me to open the book at the top of the list

then the following error appeared:

EsoUI/Ingame/LoreReader/LoreReader.lua:386: attempt to index a nil value
stack traceback:
EsoUI/Ingame/LoreReader/LoreReader.lua:386: in function 'LoreReader:ApplyMedium'
EsoUI/Ingame/LoreReader/LoreReader.lua:166: in function 'LoreReader:SetupBook'
user:/AddOns/Librarian/Librarian.lua:516: in function 'Librarian:ReadBook'
user:/AddOns/Librarian/Librarian.lua:563: in function 'LibrarianRow_OnMouseUp'
LibrarianFrameList1Row1_MouseUp:3: in function '(main chunk)'

where is EsoUI/Ingame/LoreReader/LoreReader.lua ? cannot find it anywhere !

Last edited by Ashnarug : 01/17/18 at 11:16 AM. Reason: adding info
  Reply With Quote
01/18/18, 04:19 AM   #103
Baertram
Super Moderator
 
Baertram's Avatar
WoWInterface Super Mod
AddOn Author - Click to view addons
Join Date: Mar 2014
Posts: 4,162
It's the base sourcecode of the game which you won't find in your addons.
But you need to check the lowest lines to see how the error occured and moves into the base code then:
->/AddOns/Librarian/Librarian.lua:563

Something is not correct in the code where the pressed mouse button is released above a row of the Librarian list.


Code:
user:/AddOns/Librarian/Librarian.lua:516: in function 'Librarian:ReadBook'
user:/AddOns/Librarian/Librarian.lua:563: in function 'LibrarianRow_OnMouseUp'
LibrarianFrameList1Row1_MouseUp:3: in function '(main chunk)'
  Reply With Quote
01/18/18, 06:50 AM   #104
Ashnarug
Join Date: Jan 2018
Posts: 3
lines 562 to 564 read:

function LibrarianRow_OnMouseUp(control, button, upInside)
LIBRARIAN:ReadBook(control.data.title)
end
  Reply With Quote
01/18/18, 08:40 AM   #105
Baertram
Super Moderator
 
Baertram's Avatar
WoWInterface Super Mod
AddOn Author - Click to view addons
Join Date: Mar 2014
Posts: 4,162
This function gives data to the ESO code function "EsoUI/Ingame/LoreReader/LoreReader.lua:386: in function 'LoreReader:ApplyMedium'" and some value is not compatible here.
So one would need to check the code in file EsoUI/Ingame/LoreReader/LoreReader.lua:386 to see which variable could be nil, then go back to the librarian code and check which value is used there.

Then check which value is needed and change the value in the addon, passed to the eso code, so it fits again.
  Reply With Quote
02/04/18, 11:44 PM   #106
calia1120
 
calia1120's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2014
Posts: 62
Apologies all, I'll be updating and pushing this in a day or so. Moved and started a new job so things have been absolutely insane.
__________________
Calia | @Calia1120 | NA Server
GM, Iron Bank of Bravos | Council of Nirn | Elder Scrolls Alliance
My Addons
  Reply With Quote
03/14/18, 09:45 AM   #107
BellaCarmela
Join Date: Mar 2018
Posts: 1
Librarian - still problems (some books won't open; others are just blank)

Any update on a timeline for a fix? I understand if still busy with real life, of course - just wanted to inquire since it's been more than a month.

OR...Is it working for everyone else now?


I uninstalled the mod entirely, cleaned out the savedvariables, and reinstalled - and it's still having problems...

I'm having 2 problems:

1.) the problem where books won't open and they throw the error messages listed above - but only for *some* books (Primarily those that seem to be particular to abah's landing/hew's bane/the thieves guild DLC for me so far? Weird).

* NOTE:
Yes, I *HAVE* checked the .lua and the items that people have said to change are already what they should be - so please don't re-direct me to those posts again as though that's a fix - I've already checked/done it


2.) I'm also having another problem with some books where it will save the books and tell me "684 words" or something and then I open it to read it and it's just the title of the book and the pages are otherwise empty.



Really appreciate any help you could offer in getting the mod working again - it's indispensable! Thank you so much!
  Reply With Quote
02/23/19, 01:57 PM   #108
Zuilin
Join Date: Nov 2018
Posts: 1
Any chance this is ever going to get updated for Mirkmire+?

Thanks!
  Reply With Quote
01/29/21, 01:26 PM   #109
AstroCat
 
AstroCat's Avatar
Join Date: Feb 2014
Posts: 18
I assume this mod is dead and broke forever? I'm getting a ton of errors with LibMainMenu-2.0 when using this and other mods.

Is there any kind of other mod that has similar functionality?
  Reply With Quote
01/29/21, 02:08 PM   #110
Flamage
 
Flamage's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2014
Posts: 60
Actually no, I'm working on getting a much-needed updated out soon
  Reply With Quote
01/29/21, 02:12 PM   #111
AstroCat
 
AstroCat's Avatar
Join Date: Feb 2014
Posts: 18
Originally Posted by Flamage View Post
Actually no, I'm working on getting a much-needed updated out soon
That's kind of amazing! I used this mod when I played 6+ years ago when the game came out. Now after all these years, I jump back in and an update is incoming.

Thanks!!!
  Reply With Quote
01/30/21, 08:40 AM   #112
Baertram
Super Moderator
 
Baertram's Avatar
WoWInterface Super Mod
AddOn Author - Click to view addons
Join Date: Mar 2014
Posts: 4,162
I've added some comments to this addon, how to remove the embedded old libraries, call tehm without LibStub and make the addon correctly dependend on the Library LAM 2.0 + a fix to the center screen announce and another improvement idea for the event_book_*
  Reply With Quote
05/31/22, 03:01 PM   #113
Orionik
Join Date: May 2022
Posts: 1
New version

Hello,

I found this addon interesting and as it has not been updated for a long time, I did some changes on my side. I have added a few features (the main one is adding some icons in ESO's lore library to know from there which book you have read and which you haven't) and fixed several bugs (the way the data was stored, some book could never appear in Librarian).
So now I would like to share what I have done with everyone, but to do that I need the write access to this addon
I tried to contact Flamage and calia1120 by e-mail last week but so far I didn't get an answer. I guess they haven't been playing ESO for a while now...

So, I was wondering if someone else could give me the write acces to this addon ? I could create a new addon which would be an updated version of this one but it is always annoying for players to have to uninstall the previous one and install another and it could easily lead to save corruption

If it is possible, don't hesitate to send me an e-mail so we can chat and I can show you what I have done.

Thanks
  Reply With Quote
05/31/22, 04:13 PM   #114
Calamath
AddOn Author - Click to view addons
Join Date: Aug 2019
Posts: 24
Hi Orionik,
I have provided some maintenance for another add-on by Calia.
It took me a very long time to get in touch with her, but you may be able to contact her via her Discord channel.
After that, I would suggest you talk to the administrator of this site.

The original author's GitHub repository is following.
https://github.com/Flamage82/Librarian
But it does not seem to reflect any version since Calia provided maintenance.
It might be best you fork this repository and update it sequentially to the latest release version and commit your patches from there.

- Calamath
  Reply With Quote
06/04/22, 02:48 PM   #115
Baertram
Super Moderator
 
Baertram's Avatar
WoWInterface Super Mod
AddOn Author - Click to view addons
Join Date: Mar 2014
Posts: 4,162
https://www.esoui.com/forums/showthread.php?p=44591
  Reply With Quote

ESOUI » AddOns » Released AddOns » Librarian

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off