Quantcast
OdySupportIcons updated what do i do - ESOUI
Thread Tools Display Modes
06/12/22, 12:48 AM   #1
Anceane
 
Anceane's Avatar
AddOn Author - Click to view addons
Join Date: Feb 2014
Posts: 286
. deleted to avoid problems
__________________

Last edited by Anceane : 06/15/22 at 07:39 AM. Reason: .
  Reply With Quote
06/12/22, 06:34 AM   #2
Baertram
Super Moderator
 
Baertram's Avatar
WoWInterface Super Mod
AddOn Author - Click to view addons
Join Date: Mar 2014
Posts: 4,166
https://www.esoui.com/forums/showthread.php?t=9865

Provides info about how to request updates of addons.
In short:
Pm author
Wait
Post content at the addon comments and provide the author the files you have changed there.

If he does not respond within 2 weeks:
create your own patched version and release it like described at the thread linked above.
Use the original addons website, click on other files, click on upload patch/addon (only shows there if the author enabled it! So if it's missing there the author dislikes patches and you should not upload any).

Or if you do not want to do this as you do not want to be an addon author: just provide the patched version files as a zip archive download link at the addon comments of the original addon so others can use it if they like to, and the dev can use and incoporate it later on as he gets back and sees it.

Always check in advance if the addon uses a license and if your are allowed to create patches and distribute it.
If the license disallows changes of the files please respect it and do not populate your changed files, just use it locally for yourself then. But feel free to send the pm to the author asking if he is interested in your code changes.

Last edited by Baertram : 06/12/22 at 06:40 AM.
  Reply With Quote
06/13/22, 01:30 AM   #3
ExoY
 
ExoY's Avatar
AddOn Author - Click to view addons
Join Date: Feb 2020
Posts: 44
I was in contact with ody about continue to support his addon.

Still waiting for his last responds on discord to make me co-author.

Once that has happend I will reach out to you @Anceane.
  Reply With Quote
06/13/22, 04:52 AM   #4
ExoY
 
ExoY's Avatar
AddOn Author - Click to view addons
Join Date: Feb 2020
Posts: 44
Originally Posted by Anceane View Post
https://www.esoui.com/downloads/file...p?id=2834#info

Ok i am not an author, nore a specialist, but i managed to update this addon by adding Ember and Isobel.

i tested for a week, and never encountered an issue, so i guess it could help those who use it

But ... what do i need to do to have it updated on the site ?



Thank you


Why did you ask in the forum if you just publish it anyways the next day here:

https://www.esoui.com/downloads/fileinfo.php?id=3385


I am not an admin, but I dont think that is what was meant with Beatrams comment as you reuploaded the entire addon. It also didnt respect the "2 weeks time to respond" after the initial comment.
  Reply With Quote
06/13/22, 06:59 AM   #5
Baertram
Super Moderator
 
Baertram's Avatar
WoWInterface Super Mod
AddOn Author - Click to view addons
Join Date: Mar 2014
Posts: 4,166
The 2 weeks are not mandatory but common sense.
But you are right, its better to wait for feedback of the dev as you never know if he/she implemented the same (and other features) already locally and just did not release it yet.

I did not check any licensensing at the addon files but assume there is none prohibiting patches?
As patches at the addon were enabled and the patch was uploaded with connection to the addon it is okay to upload it that way. Else the devs need to disable patches please.

But in total you should wait for feedback by the dev, or at least 2 weeks after writing them, Anceane
  Reply With Quote
06/15/22, 07:36 AM   #6
Anceane
 
Anceane's Avatar
AddOn Author - Click to view addons
Join Date: Feb 2014
Posts: 286
I just did what i understood :

Or if you do not want to do this as you do not want to be an addon author: just provide the patched version files as a zip archive download link at the addon comments of the original addon so others can use it if they like to, and the dev can use and incorporate it later on as he gets back and sees it.

As i did not want to be in any way an author and just wanted to help someone, i thought that for the patch as writen above, the delay was not necessary but i guess i am stupid and with no common sense

Also you can have post on the the addon comment, that soon you will be the co-author, i would not have done it either.

But this is the first time and the last time i did this. As for the modifications i did i posted those clearly under your message. Though it was not necessary to quasi insult me. And you could simply have compared the patch and the actual version to find easily what i changed. But it seems you really wanted to get on me.

What i did was simply a copy/paste of the existing code modele done by the author. Of course i did the search to find the collectibles ID, as without that nothing would have worked.

Now, dont answer me. Its enough to be treated like this at 70.

Originally Posted by Baertram View Post
The 2 weeks are not mandatory but common sense.
But you are right, its better to wait for feedback of the dev as you never know if he/she implemented the same (and other features) already locally and just did not release it yet.

I did not check any licensensing at the addon files but assume there is none prohibiting patches?
As patches at the addon were enabled and the patch was uploaded with connection to the addon it is okay to upload it that way. Else the devs need to disable patches please.

But in total you should wait for feedback by the dev, or at least 2 weeks after writing them, Anceane
__________________

Last edited by Anceane : 06/15/22 at 08:32 AM.
  Reply With Quote
06/15/22, 11:39 AM   #7
ExoY
 
ExoY's Avatar
AddOn Author - Click to view addons
Join Date: Feb 2020
Posts: 44
I am gonna responds regardless as it was not my intention of insulting you.

I was just confused because you asked in the forum how you should procede.
The answer was the suggestion to try to contact the author and give some time to respond and
I told you that i probably will become co author for the addon and then you did the patch.


About why I asked about the changes you made.
You did point out somewhere (dont remember where I read it) that you had to change things in multiple files.
Yes I can run a comparision but already got a few privately updated OSI version send to me, so to avoid missing anything the easiest way is to ask the people who did the changes.
Again it was not meant to be any insult.

This is important because of the different versions of the addon i currently have lying around, i can not just copy/past the different adjustments together. I have to at least check that they are compatible.


It is always appreciated if somebody else helps out and provides patches or fixes.
And this was definitelty a unique situation because of me becoming co author happend at the same time.
  Reply With Quote

ESOUI » AddOns » AddOn Help/Support » OdySupportIcons updated what do i do

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off