I love MM. I love AGS. I love the integration between them, so much! But there's a slight problem. Simply put, I never use "search green deals" simply because I have to visually filter out all of the unknown, 0% items, and so miss out on some good deals.
This is caused by line 81 of MasterMerchant_DealCalc.lua, where "No sales seen" sets deal = 2.
The result, at least with AGS integration, means that white has items up to, say, 30%, then green has items that are above 30%, as well as all unknown items at 0%. This has bugged me for forever, because, while they're unknown and thus potentially good deals, they are likely just another level variant of the Healer helm, for instance, that I haven't seen a sale for.
I'm not sure the reasoning of classifying these as 2 deals, and therefore I'm not sure if this is really classified as a bug rather than an annoyance.
There are two potential solutions:
1. Simply change line 81 to "deal = 0", which means that unknown items no longer show up under the green and only under the white.
2. Extend the deal system to return a special value denoting "unknown item", and create a new filter on the deal range for "unknown deals".
I was working on option 2 to some success, until I had a bio break flash of insight that I could simply do option 1 and collapse them into white deals instead, which is how I'll be running MM from now on.
Thanks again for such an amazing, awesome add-on though, and for providing excellent integration with AGS. |
»
Deal calculation for unknown items causes AGS integration issues
2
3,447,515
1,775