Help for new addon programer

[laiqalasse]

Hi guys,

I'm totally new in lua and addon programming. I'm trying to make my first addon but getting an ui error 'checking type on argument callback failed in ScriptEventManagerRegisterforEventlua stack traceback: [C]:addons/.... .lua 53 in function 'Initialize'. I googled it but couldn't find anything do u know why i am getting this error.

Thanks.

[merlight]

EVENT_MANAGER:RegisterForEvent("SomeGloballyUniqueString_PrefereablyYourAddonName", EVENT_CODE, callback)

callback must be a function, you're passing something else. Can't tell you more atm, error message is not enough, you'll need to give us the code that leads to it

[laiqalasse]

oh sorry,but it is shame to share this bad algorithm and codes as i told this is my first addon and i did it for myself

local junker = {
	
	name = "junker"
}


local junk_types =
{
	"ITEMTYPE_ADDITIVE",
	"ITEMTYPE_ALCHEMY_BASE",
	"ITEMTYPE_AVA_REPAIR",
	"ITEMTYPE_CLOTHIER_BOOSTER",
	"ITEMTYPE_CLOTHIER_MATERIAL",
	"ITEMTYPE_CLOTHIER_RAW_MATERIAL",
	"ITEMTYPE_COLLECTIBLE",
	"ITEMTYPE_CONTAINER",
	"ITEMTYPE_DISGUISE",
	"ITEMTYPE_ENCHANTING_RUNE",
	"ITEMTYPE_ENCHANTMENT_BOOSTER",
	"ITEMTYPE_FLAVORING",
	"ITEMTYPE_FOOD",
	"ITEMTYPE_GLYPH_ARMOR",
	"ITEMTYPE_GLYPH_JEWELRY",
	"ITEMTYPE_GLYPH_WEAPON",
	"ITEMTYPE_INGREDIENT",
	"ITEMTYPE_LURE",
	"ITEMTYPE_NONE",
	"ITEMTYPE_PLUG",
	"ITEMTYPE_RAW_MATERIAL",
	"ITEMTYPE_STYLE_MATERIAL",
	"ITEMTYPE_TRASH"

}


local junkarmor_types ={

"ARMORTYPE_LIGHT",
"ARMORTYPE_MEDIUM",
"ARMORTYPE_NONE"

}




local name = "junker"

local function Initialize()


EVENT_MANAGER:RegisterForEvent(name,EVENT_INVENTORY_SINGLE_SLOT_UPDATE,junkJunk)
end


local function  OnAddOnLoaded(event,addonName)
if addonName == "junker" then

	Initialize()

	end
end

local function junkJunk(eventCode,bagId,slotId,isNewItem,itemSoundCategory, updateReason)

local armor_type = nil
item_type = GetItemType(bagId,slotId)
local item_link = GetItemLink(bagId,slotId)

	if item_type == "ITEMTYPE_ARMOR" then
	
		local armor_type= GetItemLinkArmorType(item_link)
	
	end
	if contains(junk_types,item_type) or contains(junkarmor_types,armor_type) then
		
		SetItemIsJunk(bagId,slotId)
		
		d("junked")
	end
	
end


local function contains(junk_types, element)

  for _, value in pairs(junk_types) do

    if value == element then

      return true
    end

  end

  return false
end


EVENT_MANAGER:RegisterForEvent("junker",EVENT_ADD_ON_LOADED,OnAddOnLoaded)

[Garkin]

Local function "junkJunk" must be defined before line where it is called. Fixed code:

local junker = {
    name = "junker"
}
 
local junk_types = {
    "ITEMTYPE_ADDITIVE",
    "ITEMTYPE_ALCHEMY_BASE",
    "ITEMTYPE_AVA_REPAIR",
    "ITEMTYPE_CLOTHIER_BOOSTER",
    "ITEMTYPE_CLOTHIER_MATERIAL",
    "ITEMTYPE_CLOTHIER_RAW_MATERIAL",
    "ITEMTYPE_COLLECTIBLE",
    "ITEMTYPE_CONTAINER",
    "ITEMTYPE_DISGUISE",
    "ITEMTYPE_ENCHANTING_RUNE",
    "ITEMTYPE_ENCHANTMENT_BOOSTER",
    "ITEMTYPE_FLAVORING",
    "ITEMTYPE_FOOD",
    "ITEMTYPE_GLYPH_ARMOR",
    "ITEMTYPE_GLYPH_JEWELRY",
    "ITEMTYPE_GLYPH_WEAPON",
    "ITEMTYPE_INGREDIENT",
    "ITEMTYPE_LURE",
    "ITEMTYPE_NONE",
    "ITEMTYPE_PLUG",
    "ITEMTYPE_RAW_MATERIAL",
    "ITEMTYPE_STYLE_MATERIAL",
    "ITEMTYPE_TRASH"
}
 
 
local junkarmor_types ={
    "ARMORTYPE_LIGHT",
    "ARMORTYPE_MEDIUM",
    "ARMORTYPE_NONE"
}
 
local function contains(junk_types, element)
    for _, value in pairs(junk_types) do
        if value == element then
            return true
        end
    end
    return false
end
 
local function junkJunk(eventCode,bagId,slotId,isNewItem,itemSoundCategory, updateReason)
    local armor_type = nil
    local item_type = GetItemType(bagId,slotId)
    local item_link = GetItemLink(bagId,slotId)
 
    if item_type == "ITEMTYPE_ARMOR" then
        armor_type= GetItemLinkArmorType(item_link)
    end
 
    if contains(junk_types,item_type) or contains(junkarmor_types,armor_type) then
        SetItemIsJunk(bagId,slotId)
        d("junked")
    end
end
 
local function Initialize()
    EVENT_MANAGER:RegisterForEvent(junker.name, EVENT_INVENTORY_SINGLE_SLOT_UPDATE, junkJunk)
end
 
 
local function  OnAddOnLoaded(event,addonName)
    if addonName == "junker" then
        Initialize()
    end
end
 
EVENT_MANAGER:RegisterForEvent(junker.name, EVENT_ADD_ON_LOADED, OnAddOnLoaded)

I have just changed order when functions are defined.

If you want also make this code a bit faster, do not use function "contains", but define your tables as follows and just check if table keys exists:

local junk_types = {
    "ITEMTYPE_ADDITIVE" = true,
    "ITEMTYPE_ALCHEMY_BASE" = true,
    "ITEMTYPE_AVA_REPAIR" = true,
    "ITEMTYPE_CLOTHIER_BOOSTER" = true,
    "ITEMTYPE_CLOTHIER_MATERIAL" = true,
    "ITEMTYPE_CLOTHIER_RAW_MATERIAL" = true,
    "ITEMTYPE_COLLECTIBLE" = true,
    "ITEMTYPE_CONTAINER" = true,
    "ITEMTYPE_DISGUISE" = true,
    "ITEMTYPE_ENCHANTING_RUNE" = true,
    "ITEMTYPE_ENCHANTMENT_BOOSTER" = true,
    "ITEMTYPE_FLAVORING" = true,
    "ITEMTYPE_FOOD" = true,
    "ITEMTYPE_GLYPH_ARMOR" = true,
    "ITEMTYPE_GLYPH_JEWELRY" = true,
    "ITEMTYPE_GLYPH_WEAPON" = true,
    "ITEMTYPE_INGREDIENT" = true,
    "ITEMTYPE_LURE" = true,
    "ITEMTYPE_NONE" = true,
    "ITEMTYPE_PLUG" = true,
    "ITEMTYPE_RAW_MATERIAL" = true,
    "ITEMTYPE_STYLE_MATERIAL" = true,
    "ITEMTYPE_TRASH" = true
}
 
 
local junkarmor_types ={
    "ARMORTYPE_LIGHT" = true,
    "ARMORTYPE_MEDIUM" = true,
    "ARMORTYPE_NONE" = true
}
 
--modified function without "contains"
local function junkJunk(eventCode,bagId,slotId,isNewItem,itemSoundCategory, updateReason)
    local armor_type = nil
    local item_type = GetItemType(bagId,slotId)
    local item_link = GetItemLink(bagId,slotId)
 
    if item_type == "ITEMTYPE_ARMOR" then
        armor_type= GetItemLinkArmorType(item_link)
    end
 
    if junk_types[item_type] or (armor_type and junkarmor_types[armor_type]) then --make sure that armor_type is not nil before you use it as an index of the table
        SetItemIsJunk(bagId,slotId)
        d("junked")
    end
end
 
local function Initialize()
    EVENT_MANAGER:RegisterForEvent("junker", EVENT_INVENTORY_SINGLE_SLOT_UPDATE, junkJunk)
end
 
 
local function  OnAddOnLoaded(event,addonName)
    if addonName == "junker" then
        Initialize()
    end
end
 
EVENT_MANAGER:RegisterForEvent(junker.name, EVENT_ADD_ON_LOADED, OnAddOnLoaded)

[merlight]

local junk_types = {
    ITEMTYPE_ADDITIVE = true, -- like this
    ["ITEMTYPE_ALCHEMY_BASE"] = true, -- or this, it's the same
    "ITEMTYPE_AVA_REPAIR" = true, -- not this, that's wrong syntax :)
        ...
}

edit: but neither will do what you need, see below, circonian has it right

[circonian]

In this code:

item_type = GetItemType(bagId,slotId)
if item_type == "ITEMTYPE_ARMOR" then
--...--

GetItemType(bagId,slotId) could return ITEMTYPE_ARMOR if the item is a piece of armor, but ITEMTYPE_ARMOR is actually an integer, so you can't compare it to a string with:

if item_type == "ITEMTYPE_ARMOR" then
-- that wont work

You might want to change your tables to something like this:

local junk_types =
{
    [ITEMTYPE_ADDITIVE]             = true,
    [ITEMTYPE_ALCHEMY_BASE]         = true,
    [ITEMTYPE_AVA_REPAIR]           = true,
    [ITEMTYPE_CLOTHIER_BOOSTER]     = true,
    [ITEMTYPE_CLOTHIER_MATERIAL]    = true,
    [ITEMTYPE_CLOTHIER_RAW_MATERIAL] = true,
    [ITEMTYPE_COLLECTIBLE]          = true,
    [ITEMTYPE_CONTAINER]            = true,
    [ITEMTYPE_DISGUISE]             = true,
    [ITEMTYPE_ENCHANTING_RUNE]      = true,
    [ITEMTYPE_ENCHANTMENT_BOOSTER]  = true,
    [ITEMTYPE_FLAVORING]            = true,
    [ITEMTYPE_FOOD]             = true,
    [ITEMTYPE_GLYPH_ARMOR]      = true,
    [ITEMTYPE_GLYPH_JEWELRY]    = true,
    [ITEMTYPE_GLYPH_WEAPON]     = true,
    [ITEMTYPE_INGREDIENT]       = true,
    [ITEMTYPE_LURE]             = true,
    [ITEMTYPE_NONE]             = true,
    [ITEMTYPE_PLUG]             = true,
    [ITEMTYPE_RAW_MATERIAL]     = true,
    [ITEMTYPE_STYLE_MATERIAL]   = true,
    [ITEMTYPE_TRASH]            = true,
}

Since ItemTypes are all unique integers thier keys in the table will be unique. Set each of their values to true or false, based on whether or not the itemType is supposed to be junk.

Then when your trying to determine if something is junk or not you don't need to call an extra contains(...) function. you can just check that table to see if it is true/false (junk or not junk)

item_type = GetItemType(bagId,slotId)
if junk_types[item_type] then
   -- item is junk
end

Oh and so the other part of your code would have to be changed to:

-- notice, no quotes around ITEMTYPE_ARMOR
if item_type == ITEMTYPE_ARMOR then
   local armor_type= GetItemLinkArmorType(item_link)
end

[Garkin]

Ah, circonian is right. I didn't think about what should be in the table. Tables should be defined as circonian said.

Originally Posted by circonian Oh and so the other part of your code would have to be changed to: -- notice, no quotes around ITEMTYPE_ARMOR if item_type == ITEMTYPE_ARMOR then    local armor_type= GetItemLinkArmorType(item_link) end

Just one comment - if you write it like this, armor_type won't be visible outside of the if ... end code block.

local armor_type
if item_type == ITEMTYPE_ARMOR then
    armor_type= GetItemLinkArmorType(item_link)
end

[circonian]

Originally Posted by Garkin Just one comment - if you write it like this, armor_type won't be visible outside of the if ... end code block.

Oh yeah, I didn't catch that one, I just copied what he had and took the ""s off

Hes right, if you do

if item_type == ITEMTYPE_ARMOR then
    local armor_type= GetItemLinkArmorType(item_link)
end
-- Then armor_type wont be available out here

Depending upon what your going to do with it, you may or may not need it outside of that if statement. If you do then you'll have to do what he said.

local armor_type
if item_type == ITEMTYPE_ARMOR then
    armor_type= GetItemLinkArmorType(item_link)
end
-- Now you can use armor_type out here

[laiqalasse]

guys i m realy gratefull for your interest, thanks it was really helpfull and instructive. now thanks to u i have my own addon