[Need help pls] Find slowdown bug at Advanced Filters & FCOItemSaver addons

[Baertram]

Ok, thanks again, I'll give it a try this way.

After my tries:
I'm not able to prehook the function SetMode of ZO_Smithing or SMITHING.

I've tried it in several ways, searched for aliases to use. But there are none as it seems.
The way I know it should work does nothing:

ZO_PreHook("ZO_Smithing", "SetMode", function(mode)
...
end)

Ok, my fault. Or let's say another feature
I forgot to remove the "" around ZO_Smithing :-(
And the function needs another parameter before mode (holding the SMITHING object).


Correct call:

--Prehook the smithing function SetMode() which gets executed as the smithing tabs are changed
    ZO_PreHook(ZO_Smithing, "SetMode", function(smithing_obj, mode)
 
        d("[ZO_Smithing:SetMode] Mode: " .. tostring(mode), true)
        if     mode == SMITHING_MODE_REFINMENT then
            d("REFINEMENT")
        elseif mode == SMITHING_MODE_CREATION then
            d("CREATION")
        elseif mode == SMITHING_MODE_IMPROVEMENT then
            d("IMPROVEMENT")
        elseif mode == SMITHING_MODE_DECONSTRUCTION then
            d("DECONSTRUCTION")
        elseif mode == SMITHING_MODE_RESEARCH then
            d("RESEARCH")
        else
            d("SMITHING")
        end
        return false
    end)

[Randactyl]

Originally Posted by merlight @Randactyl I'm running out of ideas. Tried to reproduce what BigM wrote about Sell in comments, but for me it works (now). It'll be some stupid obvious bug, obvious bugs are hard to find, they look like features

I am too. Obvious things are the worst :P

Originally Posted by merlight Repeated, only instead of Zgoo I dumped the values to debug window. (summary: everything looks ok to me) I see correct values there. For me AF now works in bank, sell, mail. The only issue I'm aware of now is that when I switch the top filter from e.g. Weapons to All and back to Weapons, subfilter dropdown doesn't appear.

Okay, so this is the latest available release of AF that works along with libFilters 11.2 (which will be 12 moving forward) that was included? No modifications?

And yeah, I've been wrestling with that Houdini dropdown for a while but no one has really reported it.

[merlight]

Originally Posted by merlight ... obvious bugs are hard to find, they look like features

What I said, a LibStub feature we were not aware of got us

[circonian]

Originally Posted by merlight Yes and no. Advanced Filters change filters when the tab changes, in which case the inventory list is rebuilt anyway, so in AF this step could be avoided. But Item Saver has icons in the bottom of the inventory, which when toggled change the rules, and so they need to force inventory refresh.

Ah i see now. I didn't think of that.

[Baertram]

Originally Posted by merlight What I said, a LibStub feature we were not aware of got us

Stupid and too simple to catch by eye

[Baertram]

Originally Posted by Randactyl And yeah, I've been wrestling with that Houdini dropdown for a while but no one has really reported it.

The dropdownbox seems only to hide if you:
I've tested the following at a vendor's sell panel:

1. Click on any of the inventory buttons, e.g. "Weapons" (the "All" subfilter button of AdvancedFilters will be automatically selected) except the "All" inventory button
2. Click on the "All" inventory button
3. Click again on the SAME inventory button you have been at 1. (in my example "Weapons")

or

1. Click on any of the inventory buttons, e.g. "Weapons" (the "All" subfilter button of AdvancedFilters will be automatically selected) except the "All" inventory button
2. Close the vendor
3. Talk to the same vendor again -> The sell panel will be opened automatically at the last inventory button you have chosen at 1. (in my example "Weapons")

Checking your source code the dropdown is created and made invisible.
As someone clicks the button of a subfilter the dropdown will change the content and will be made visible.
But only if the button is not the last pressed button from before and some other stuff applies.

I modified your function AdvancedFilterGroup:AddSubfilter a bit:

function AdvancedFilterGroup:AddSubfilter( name, icon, callback, dropdownCallbacks, dropdownWidth )
...
 
    subfilter.dropdown = nil
 
--Dropdown will be created and made invisible here
    if(dropdownCallbacks) then
        dropdown = self:AddDropdownFilter( subfilter, dropdownCallbacks, dropdownWidth )
    end
 
    local button = WINDOW_MANAGER:CreateControl( subfilter:GetName() .. "Button", subfilter, CT_BUTTON )
    button:SetAnchor(TOPLEFT, subfilter, TOPLEFT)
    button:SetDimensions(ICON_SIZE, ICON_SIZE)
 
--I modified the handler callback function. The dropdown SetHidden(false) was moved before the
--check against "innerSelf == currentSelected", and was asked to only show if hidden
    button:SetHandler("OnClicked", function(innerSelf)
            if(not subfilter.isActive) then return end
--Moved up and enhanced by IsHidden() check here            
if(subfilter.dropdown and subfilter.dropdown:IsHidden()) then
                subfilter.dropdown:SetHidden(false)
            end
            if(innerSelf == currentSelected) then return end
            self:ChangeLabel(tooltipSet[name])
            MoveHighlightToMe(innerSelf)
            OnClickedCallback(innerSelf)
        end)
    button.filterCallback = callback

It seems to work now. The dropdownbox is shown properly for the subfilters in both scenarios i've tested above. But it was not tested everywhere!
Maybe it helps you find the bug.

[Randactyl]

Originally Posted by Baertram I modified your function AdvancedFilterGroup:AddSubfilter a bit

Hey thanks, I'll check this out.

edit: seems to work

[Baertram]

Originally Posted by Randactyl Hey thanks, I'll check this out. edit: seems to work

Good, glad I could help.

[BornDownUnder]

So I've been following the thread since it was first posted, until today & yesterday most of it was flying over my head due to lack of understanding in lua. You guys however have helped immensely in that respect just from this discussion!

Out of curiosity, more to make sure I haven't missed anything, what is the current state of the performance issue in which this thread was created?

[Randactyl]

Originally Posted by BornDownUnder So I've been following the thread since it was first posted, until today & yesterday most of it was flying over my head due to lack of understanding in lua. You guys however have helped immensely in that respect just from this discussion! Out of curiosity, more to make sure I haven't missed anything, what is the current state of the performance issue in which this thread was created?

Glad it helped!

To my knowledge, the issue is more or less resolved. Advanced Filters and FCO ItemSaver are no longer at odds - credit for which goes to those who helped me fix things in libFilters, the full rewrite of FCO, and other fixes in Advanced Filters.

[BornDownUnder]

Originally Posted by Randactyl Glad it helped! To my knowledge, the issue is more or less resolved. Advanced Filters and FCO ItemSaver are no longer at odds - credit for which goes to those who helped me fix things in libFilters, the full rewrite of FCO, and other fixes in Advanced Filters.

That is great to hear! And glad that my thoughts were pretty much spot on in regards to the state of the issue.

[Baertram]

Hey BornDownUnder,

glad to read it helped you too somwhow.

I copy Randactyl: The performance issues were solved after a rewrite of libFilters and changes to AdvancedFilters + FCOItemSaver.

There might be still some smaller issues with the addons sometimes but as far as I know they run stable and much faster then they did some weeks ago.

Happy new year :-)

[BornDownUnder]

Originally Posted by Baertram ... they run stable and much faster then they did some weeks ago.

I have noticed with AF and Randactyls ItemSaver (I haven't bothered porting to FCO yet as am playing around with current group addon maintenance in preperation for a stand-alone creation) that the switch between filters whilst it wasn't bad during fast multiple switches there was a slight hitching when there were alot of items. That hitching is no longer present at all though I haven't really pushed the code...

Originally Posted by Baertram glad to read it helped you too somwhow.

Been trying to stretch my neurons to work with lua and this particular api, haven't done anything like this for years and back then was on a really really small scale.

It has helped immensely as I've been reading code instead of trying to implement code, with the constant updating of this thread whilst you guys were working it out... Especially with the posting of code and changes.