Circonians SetSwap : Discontinued & Outdated : Elder Scrolls Online AddOns

(102 Kb)

Download

Updated: 12/05/15 11:56 PM

Add Favorite

Install Help

Portal

Bugs

Features

Pictures

File Info

Compatibility:	Orsinium (2.2.4)
Updated:	12/05/15 11:56 PM
Created:	10/30/15 07:36 PM
Monthly downloads:	61
Total downloads:	9,572
Favorites:	16
MD5:
Categories:	Discontinued & Outdated, Casting Bars, Cooldowns

Circonians SetSwap Popular! (More than 5000 hits)

Version: 1.20

by: circonian, prasoc

What does it do? (See Pictures)

Allows you to quickly save/load skill sets, equipment sets, & full sets (skills & equipment).

Open the skills window to view the SetSwap panel.

To save sets (See Pictures):
In the SetSwap panel click the menu bar button for the type of set you wish to save and click the "Save xxx Set" button.

Or set a keybind to Save a skill set, equipment set, or full set.

To load sets (See Pictures):
In the SetSwap panel click the menu bar button for the type of set you wish to load and then left click a set from the list.

Or set a keybind to load a preset. Then in the SetSwap panel assign that preset to any of the sets by right clicking on it and selecting "Assign Preset".

Other (See Pictures): (Right click on any set for other options)
Assign Preset: Assign a preset keybind to load the selected set.
Clear Preset: Clear the preset keybind for the selected set.
Rename Set: Rename the selected set.
Update Set: Update the selected set with your current skills/equipment.
Delete Set: Deletes the selected set.

Slash Commands

Typing:

/clearsetswap

in chat will reset SetSwap deleting all of your sets.

Future Plans?

None

Version 1.20 -- Added Requested Feature

Toggle Rapid Maneuver Added a keybind to toggle the current ability in a slot between the current ability and rapid maneuver. You can choose which slot to use in the settngs menu.

Version 1.9 --

API Update No changes, just an API update

Version 1.18 --

Bug Fix Fixed a bug where loading a set that contained a weapon you already had equipped, but in a different hand/slot, the weapon would not get loaded.

Version 1.17 --

Unfortunately due to an error I made in the code it was causing some corrupted saved variable data which caused duplicate entries in the scroll list for some users. In order to ensure that the corrupted data is wiped out your saved settings will be wiped.
Bug Fix Fixed a bug where some of the scrollList data was not being cleared out properly.
Duplicate Entries The duplicate entry problem should now be fixed.

Version 1.15 --

Bug Fix Fixed a bug when renaming sets could sometimes cause an nil error.

Version 1.14 --

/clearsetswap Added the slash command /clearsetswap
Typing /clearsetswap in the chat window will reset SetSwap, clear all sets, and force the ui to reload to clear out all necessary data.

Version 1.13 --

Bug Fix Fixed a bug introduced in 1.12 where skill textures were not showing up in the preview bar.

Version 1.12 --

Bug Fix Fixed a bug where zoning would cause multiple buttons to appear in the menu SetSwap menu bar.

Archived Files (10)

File Name	Version	Size	Uploader	Date
Circonians SetSwap	1.19	65kB	circonian	11/03/15 03:20 PM
Circonians SetSwap	1.18	66kB	circonian	11/01/15 06:47 PM
Circonians SetSwap	1.17	65kB	circonian	11/01/15 12:38 PM
Circonians SetSwap	1.15	65kB	circonian	11/01/15 12:15 AM
Circonians SetSwap	1.14	65kB	circonian	10/31/15 09:29 PM
Circonians SetSwap	1.13	65kB	circonian	10/31/15 07:33 PM
Circonians SetSwap	1.12	65kB	circonian	10/30/15 11:09 PM
Circonians SetSwap	1.11	65kB	circonian	10/30/15 11:07 PM
Circonians SetSwap	1.1	65kB	circonian	10/30/15 10:57 PM
Circonians SetSwap	1.0	65kB	circonian	10/30/15 07:36 PM

Comment Options

Page 2 of 4

10/31/15, 10:49 PM

AkeGamer

Forum posts: 1

File comments: 59

Uploads: 0

Originally Posted by AkeGamer

Originally Posted by circonian

Originally Posted by AkeGamer

Originally Posted by circonian

I modified the /clearsetswap command and posted a new version of SetSwap. This way you can know if you type it right so you know its working. With version 1.14 when you type /clearsetswap in the chat window you will get a message that the ui will reload in 5 seconds to clear out all necessary data. After 5 seconds the ui will reload and all of the sets will be gone.

Posted Version 1.14

All of those error messages you were getting were caused by the bad saved data from the duplicate entries. This WILL fix that.
As for how you got the duplicate entries begin with and will that happen again...I hate to say I have no idea. You'll have to just try it and find out. I can find nothing wrong with the code to cause duplicate entries and I even went back and retested the previous versions that were posted & can't produce duplicate entries on any of those versions either.

Thank you. I got to the point of disabling all addons, reloading the UI, loading SetSwap and testing. None of the errors I was experiencing were occurring. There is a conflict with SetSwap and another add-on. I'm going to try to pin that down next.

I went ahead and loaded up my addons A through L. When I went to save a Full Set....as soon as I moused over the "Full Set 4" I got this UI error. Doesn't tell me much as no other addon name is listed, but part of the base ZOS/Library UI code is now conflicted.
EsoUI/Libraries/ZO_Templates/ScrollTemplates.lua:1306: attempt to index a nil value
stack traceback:
EsoUI/Libraries/ZO_Templates/ScrollTemplates.lua:1306: in function 'ZO_ScrollList_UpdateScroll'
(tail call): ?
EsoUI/Libraries/ZO_Templates/ScrollTemplates.lua:1109: in function 'ZO_ScrollList_Commit'
user:/AddOns/SetSwap/libs/LibSharedSkillsPanel/LibSharedSkillsPanel.lua:71: in function 'UpdateScrollListCategory'
user:/AddOns/SetSwap/SetSwap.lua:246: in function 'SetSwap:UpdateScrollList'
user:/AddOns/SetSwap/SetSwap.lua:590: in function 'SetSwap_OnSetNameChange'
15386374001144465911:5: in function '(main chunk)'
[C]: in function 'LoseFocus'
13527052679223938811:3: in function '(main chunk)'

I'll next narrow it down to which addon's when loaded gen that conflict.

Oh and I'm still using 1.13.

Thank you that tells me a lot. I actually managed to find a bug where when renaming items on rare occasions I get a similar error. I've tracked it as far as knowing that the error is being caused by the rowControls dataEntry table is just disappearing for some reason. As to why & what deleted it I have no idea. The rename code could not do it.

The error you posted is not exactly the same, but tracking it leads to the same result, the dataEntry table of the rowControl is missing causing that nil error.

I've now narrowed it down to a conflict in one of:
Destinations
ESO Theatre
FCO Ultimate Sound
FCO Item Saver

I get this UI error when I try to create a new Skill Set:
EsoUI/Libraries/ZO_Templates/ScrollTemplates.lua:909: attempt to index a nil value
stack traceback:
EsoUI/Libraries/ZO_Templates/ScrollTemplates.lua:909: in function 'FreeActiveScrollListControl'
EsoUI/Libraries/ZO_Templates/ScrollTemplates.lua:1101: in function 'ZO_ScrollList_Commit'
user:/AddOns/SetSwap/libs/LibSharedSkillsPanel/LibSharedSkillsPanel.lua:71: in function 'UpdateScrollListCategory'
user:/AddOns/SetSwap/SetSwap.lua:246: in function 'SetSwap:UpdateScrollList'
user:/AddOns/SetSwap/SetSwap.lua:590: in function 'SetSwap_OnSetNameChange'
15386374001144465911:5: in function '(main chunk)'
[C]: in function 'LoseFocus'
13527052679223938811:3: in function '(main chunk)'
Which I believe is pretty close to the prior error but different "line" in the Scrolltemplates.lua file. In this case 909 vs 1306. The other set of "lines" differs too.

Next will isolate which one or more of these 4 generates the conflict.

With only Destinations loaded, I gen this when attempting to rename a Full Set:
EsoUI/Libraries/ZO_Templates/ScrollTemplates.lua:1306: attempt to index a nil value
stack traceback:
EsoUI/Libraries/ZO_Templates/ScrollTemplates.lua:1306: in function 'ZO_ScrollList_UpdateScroll'
EsoUI/Libraries/ZO_Templates/ScrollTemplates.lua:1109: in function 'ZO_ScrollList_Commit'
user:/AddOns/SetSwap/libs/LibSharedSkillsPanel/LibSharedSkillsPanel.lua:71: in function 'UpdateScrollListCategory'
user:/AddOns/SetSwap/SetSwap.lua:246: in function 'SetSwap:UpdateScrollList'
user:/AddOns/SetSwap/SetSwap.lua:590: in function 'SetSwap_OnSetNameChange'
15386374001144465911:5: in function '(main chunk)'
[C]: in function 'LoseFocus'
13527052679223938811:3: in function '(main chunk)'

AND this when attempting to rename a Skill set:
EsoUI/Libraries/ZO_Templates/ScrollTemplates.lua:909: attempt to index a nil value
stack traceback:
EsoUI/Libraries/ZO_Templates/ScrollTemplates.lua:909: in function 'FreeActiveScrollListControl'
EsoUI/Libraries/ZO_Templates/ScrollTemplates.lua:1101: in function 'ZO_ScrollList_Commit'
user:/AddOns/SetSwap/libs/LibSharedSkillsPanel/LibSharedSkillsPanel.lua:71: in function 'UpdateScrollListCategory'
user:/AddOns/SetSwap/SetSwap.lua:246: in function 'SetSwap:UpdateScrollList'
user:/AddOns/SetSwap/SetSwap.lua:590: in function 'SetSwap_OnSetNameChange'
15386374001144465911:5: in function '(main chunk)'
[C]: in function 'LoseFocus'
13527052679223938811:3: in function '(main chunk)'

I am also now noticing, as I have more than 5 Full Sets built now, that when swapping from e.g. Destro/Resto to DW/Destro, a single click of either the Equipment Set or the Full Set does not completely swap weapons. In this example I ended up with DW/Resto on the first click. A second example is DW/Destro to Destro/Resto. I end up with one of the 1H swords/Resto. So the code for the swapping of 3 weapons seems to need to be looked at.

10/31/15, 10:52 PM
AkeGamer Forum posts: 1 File comments: 59 Uploads: 0	And btw, that testing would have been a lot more difficult without your Addon Selector addon. Great tool. Thanks again!

11/01/15, 12:21 AM
circonian Forum posts: 613 File comments: 804 Uploads: 27	I finally tracked it down. It was nothing in the code. Apparently it was a timing issue. The renaming thing should be fixed now. As for the other you mentioned about swapping three weapons I could not reproduce it either...its going to have to wait until tomorrow. Notes on what the problem was (for me...just in case): Even though I called LoseFocus() on the name control first and then cleared the control objects the LoseFocus() function had not yet finished firing so it was getting fired a second time (automatically, due to still having focus & the controls reset behavior) when the control was released from the pool. Last edited by circonian : 11/01/15 at 12:22 AM.

11/01/15, 05:13 AM
Madlark Forum posts: 2 File comments: 80 Uploads: 0	I still keep getting both errors, even after the update. Unfortunately, the error pops up even when I try to swap to the saved set using your addon, so it's currently unusable for me =/

11/01/15, 09:26 AM

votan

Forum posts: 578

File comments: 1678

Uploads: 40

Code:

local function UpdateScrollListCategory(scrollList, dataTable, rowTypeId)
	if not SCENE_MANAGER.scenes["skills"]:IsShowing() then return end
	local selectedCategoryId = GetSelectedCategory()
	if selectedCategoryId ~= rowTypeId then return end
	
	local dataTableCopy = ZO_DeepTableCopy(dataTable)
	local dataList 		= ZO_ScrollList_GetDataList(scrollList)
	
	-- do NOT use ZO_ScrollList_Clear, were sharing this scrollList with
	-- other addons, calling Clear would also clear the dataTypes & categories
	-- we only want to clear the current data items.
	for dataIndex=#dataList, 1, -1 do
		local dataItem = dataList[dataIndex]
		table.remove(dataList, k)
	end
	
	-- Add data items to the list
	for k, dataItem in ipairs(dataTableCopy) do
		--local entry = ZO_ScrollList_CreateDataEntry(rowTypeId, dataItem, rowTypeId)
		local entry = ZO_ScrollList_CreateDataEntry(rowTypeId, dataItem)
		table.insert(dataList, entry)
	end
	
	local function SortList(item1, item2)
		if item1.data.name < item2.data.name then return true end
		return false
	end
	table.sort(dataList, SortList)
	
	ZO_ScrollList_Commit(scrollList) -- line 71
end

And I found this in your manifest file:
[WARN] File not found. "z:\liveeu\AddOns\SetSwap\sharedCode\Shared_Skills_Panel.lua"

And awesome addon, as always

11/01/15, 12:14 PM

circonian

Forum posts: 613

File comments: 804

Uploads: 27

Originally Posted by votan

Hi circonian,

I don't know, if it has something to do with that, but there is a k in SetSwap\libs\LibSharedSkillsPanel\LibSharedSkillsPanel.lua, that does not make sense. And it belongs to line 71 of the error:

[code]
for dataIndex=#dataList, 1, -1 do
local dataItem = dataList[dataIndex]
table.remove(dataList, k)
end

ah thanks for letting me know I thought I fixed that

11/01/15, 12:40 PM

circonian

Forum posts: 613

File comments: 804

Uploads: 27

Originally Posted by Madlark

I still keep getting both errors, even after the update. Unfortunately, the error pops up even when I try to swap to the saved set using your addon, so it's currently unusable for me =/

The one I fixed last night was an error caused by renaming sets. I'm 100% confident that is fixed. The other errors that were posted below were caused by duplicate entries which was apparently something else. It should be fixed now.

11/01/15, 12:45 PM
circonian Forum posts: 613 File comments: 804 Uploads: 27	A big thanks to Votan for pointing out something I overlooked in the scrollList code that clears the scrollList. Even though I could not reproduce the duplicate entry problem I'm confident that this is what was causing it. It should be fixed now, but if it happens again or you have any other problems please let me know. Even if you try it out for a while and don't have problems anymore, since I couldn't reproduce the problem myself so I can't be 100% sure that was the only problem...please let me know its working for you so I know everything is ok now. This version should solve all problems: Posted Version 1.17 Last edited by circonian : 11/01/15 at 12:47 PM.

11/01/15, 01:08 PM

AkeGamer

Forum posts: 1

File comments: 59

Uploads: 0

Originally Posted by circonian

A big thanks to Votan for pointing out something I overlooked in the scrollList code that clears the scrollList. Even though I could not reproduce the duplicate entry problem I'm confident that this is what was causing it. It should be fixed now, but if it happens again or you have any other problems please let me know.

Even if you try it out for a while and don't have problems anymore, since I couldn't reproduce the problem myself so I can't be 100% sure that was the only problem...please let me know its working for you so I know everything is ok now.

This version should solve all problems:
Posted Version 1.17

I plan on wiping my sets today generated in 1.13 using the /clearsetswap command and then rebuilding all 14 Full sets from scratch. {edit: the patch notes say 1.17 does the clear automatically, so ignore this first point.} I'll be sure to let you know how it goes, regardless.

Curious if anyone else has issues with the 3 weapon swap. It's not a fatal issue as you can just click twice on the Equipment Set or Full Set.

Last edited by AkeGamer : 11/01/15 at 01:11 PM.

11/01/15, 01:18 PM

circonian

Forum posts: 613

File comments: 804

Uploads: 27

Originally Posted by AkeGamer

Curious if anyone else has issues with the 3 weapon swap. It's not a fatal issue as you can just click twice on the Equipment Set or Full Set.

arrrg I forgot about that, I've slept since then...that actually might not be fixed

unless it was being caused by the corrupted data problem (that should be fixed now).
I'll take a look at it again now.

Edit: Sleep does wonders for your ability to think....I found it already. Apparently if the weapon is equipped in one slot, say the main hand, and the set you load includes that weapon but in a different slot, the off hand, it does not get loaded because when it looks for the item its not in your inventory...its in your main hand (which is a separate inventory to the game).

I'll have a fix up for that soon.

Edit Edit:
I've fixed the swap problem you mentioned. I'm just waiting to here if the other problems have been fixed for everyone before I make another version post.

Last edited by circonian : 11/01/15 at 03:36 PM.

11/01/15, 05:10 PM

AkeGamer

Forum posts: 1

File comments: 59

Uploads: 0

Originally Posted by circonian

Originally Posted by AkeGamer

Curious if anyone else has issues with the 3 weapon swap. It's not a fatal issue as you can just click twice on the Equipment Set or Full Set.

arrrg I forgot about that, I've slept since then...that actually might not be fixed

We all really appreciate the work that goes into this. For me even more so after all of the testing. So thanks again.

I'm running 1.17 and everything except the weapon swap issue appears to have been resolved. Nicely done.

11/01/15, 05:56 PM

AkeGamer

Forum posts: 1

File comments: 59

Uploads: 0

Originally Posted by AkeGamer

Originally Posted by circonian

Originally Posted by AkeGamer

Curious if anyone else has issues with the 3 weapon swap. It's not a fatal issue as you can just click twice on the Equipment Set or Full Set.

arrrg I forgot about that, I've slept since then...that actually might not be fixed

So after completely rebuilding all of my sets, I'm beginning to see some behavior I didn't see before.

Set A:
Set A bar 1
Set A bar 2
Gear 1
Gear 2

So let's say I just activated the above set and everything looks perfect. I switch bars and make sure bar 2 looks good and then stay there. Now I decide to activate Set B...

Set B:
Set B bar 1
Set B bar 2
Gear 1
Gear 2

I'm on my second bar and yet here is what the result is:

Result Set:
Set A bar 1
Set B bar 1
Gear 1
Gear 2

If I then switch bars to bar 1 and hit the Full Set again, I get

Result Set:
Set B bar 1
Set B bar 1
Gear 1
Gear 2

Now I thought there could be a misunderstanding on my part and that each Skill Set only stored skills for the bar in focus when saved/updated. But I tried that and it didn't work either. So I believe the intention and my initial understanding were that a Skill Set consists of the 2 bars and a Full Set consists of a Skill Set and Equipment Set.

Another thing coming to mind is that on some of the swaps where I have a 3 piece weapon swap, I'm forcing the swap by clicking on the set more than once. I'm not sure if that is the problem or not, but now my sets are a mess, lol. I think I'll hold off on more testing until the next update is available.

I hope I'm helping here cause I'm not quite sure I totally even understand what's going on...but the above behavior is what I experienced and reproduced with 2 totally different sets. It doesn't seem to matter if the set in question has 2 or 3 weapons.

11/01/15, 06:01 PM
AkeGamer Forum posts: 1 File comments: 59 Uploads: 0	This might also help. If you are on your second bar and save a skill or full set, the icons to the right depict the 2nd bar and that is what gets written to the bar (even the first bar) in focus when you activate the swap.

11/01/15, 06:06 PM

circonian

Forum posts: 613

File comments: 804

Uploads: 27

Originally Posted by AkeGamer

Another thing coming to mind is that on some of the swaps where I have a 3 piece weapon swap, I'm forcing the swap by clicking on the set more than once. I'm not sure if that is the problem or not, but now my sets are a mess, lol. I think I'll hold off on more testing until the next update is available.

The skill sets & full set only save/load the skill bar in focus, which if I understood what you posted correctly is exactly what it looks like it was doing. After everything calms down....if people want I could add an option for two bars.

What do you mean "now your sets are a mess" ? Do you mean from testing or did something else go wrong? Swapping sets, even hitting the button multiple times should not change the sets in any way.

I have a fix for the weapon swap problem you mentioned, I just wanted to wait and see if anyone reported any other problems and yes you've been a big help. If people didn't report these things they would not get fixed.

I will post the fix shortly, I'm just trying to double check everything.

Last edited by circonian : 11/01/15 at 06:06 PM.

11/01/15, 06:47 PM

AkeGamer

Forum posts: 1

File comments: 59

Uploads: 0

Originally Posted by circonian

Originally Posted by AkeGamer

Great thanks. I made a mess of my sets by testing, but they can easily be set up again.

I need some help in understanding how this works then:

Bar 1
Bar 2
Weapon 1
Weapon 2

So I first create 2 skills sets, 1 for each bar, calling them Skill1 and Skill2.
Then I create 1 equipment set for the weapons I have slotted, both active/inactive, calling it Gear 1.

Now what? How do I save a Full Set, which I believe should consist of {Skill1, Skill2, Gear1}?

If each Set consisted of the 2 elements either skill bars or equipment, then intuitively I'd create a New Full Set and know that it contained {Skill1,Skill2,Gear1}. Now I'm not clear on how this should work since a Full Set only saves the active bar in focus. Right? *dizzy*

Page 2 of 4

Report this File