Quantcast
Download
(117 Kb)
Download
Updated: 12/05/21 09:39 AM
Patch for:
Bank Manager Revived.
Pictures
File Info
Compatibility:
Deadlands (7.2.5)
Waking Flame (7.1.5)
Updated:12/05/21 09:39 AM
Created:04/23/19 05:03 PM
Monthly downloads:956
Total downloads:26,014
Favorites:44
MD5:
Categories:Plug-Ins & Patches, Bags, Bank, Inventory
7.2.5
Bank Manager Revived - Slim Edition  Popular! (More than 5000 hits)
Version: 14.85
by: Gamer1986PAN, @DeadSoon
Bank Manager Revived - Slim Edition

Depends on this Librarys:
LibResearch
LibAddonMenu2.0

Make sure to install this librarys for a working addon

The new Version can be used as Slim and as Full version with the "Global Addon Profile" feature. This is especially to help the non ESO+ Users. But keep in mind with this slim versions you only got 10 profiles in total (for now) - instead of 10 profiles for each char like in the non slim versions.


I only commented some features of the orignal "Bank Manager Revived" or rather from the "Jewelry Crafting Fix of Bank Manager Revived" out in order to have less features but smaller saved variables and related to this smaller saved varibles -better performance.

To benefit from the smaller saved variables, the original ones must be deleted/renamed and new files + profiles must be created. (don't forget to backup your saved variables, so you are able to go back to the original version if you are not satisfied with the slim edition. If you want to reactivate one special option you had in the last version but missing here - i can try to help you make it work again (minor code tweaks and leads again to bigger saved variables)

All credits goes to the original Authors. Ayantir, SnowmanDK, Eldrni and (not original team, but he also did some bugfixes that version depends on) Lexynide


If you found a bug you have here but not in the "Jewelry Crafting Fix Version" let me know and i try to find a solution. If the bug also exists in "Jewelry Crafting Fix Version" i can not guarantee that i can fix that, because i don't master LUA and i only be able to modify small things. If there is a real bug i just can hope some real author is willing to help me out there.


*Notice*: I know that some items - e.g. trophys don't work 100% properly - like they also don't work in original version. When i have some time i try to find a fix for that problem.


If you want to help with this addon just let me know in the comment section and i add you to the team. If you master LUA and want to get some practice in finding and removing bugs you are very welcome.


Bank Manager Revived will help you manage your bank & your guild bank (at guild bank - deposit only)

BMR will automatically deposit the preset items from your current character inventory to the bank or withdraw them from your bank to your inventory.


Features:

Global features
  • bank & guild bank support
  • auto move when opening bank (item/currencies)
  • display a detail of each move and/or summary
  • don't move items protected by ItemSaver / FCO Item Filter addon
  • don't move items moved by other addons while interacting
  • import setting between characters
  • auto restack bank / bag /guild bank after completion
  • fully localized (English, French, Deutsch and Russian)
  • pull your writs items needed for quests

Global Addon Profile

There are 4 global addon profiles predefined:
  1. ESO+ no crafting
  2. ESO+ with crafting
  3. no ESO+ no crafting
  4. no ESO+ with crafting
with the "ESO+" profiles material that can be deposited in the crafting bag can no longer be selected in the options
"with crafting" profiles also shows e.g. intricate armor/weapons as options


Profile support

You can have 9 accountwide profiles defined with their own rules. If 2+ profiles are defined or the current profile is not set to automatically transfer items, an UI will appear at bank to let you switch between profiles. You can easily set a name, and reset a profile.

Currencies (Gold / Tel Var Stones / Alliance Points / Writ Vouchers)

2 individual sliders to choose how much to keep in bag (e.g enough to feed your horse the next 10 days) or how much to grab from bank if you don't have enough. (0 to disable the 2nd function). Gold sliders are 0 up to 200K, Tel Var up to 10K, Alliance Points up to 200k and Writ Vouchers up to 5k.
You can also use the option "Don't keep any ..." to deposit the full amount of this currency to the bank or activate additional to that the option "Keep in Bank instead of Bag" to withdraw everything of that specific currency.



Provisioning
  • Choose to push/pull known recipes
  • Choose to push/pull unknown recipes

Enchanting (up to 50) of the same type
  • Choose to push/pull glyphs

Trophies (up to 50 stacks) of the same type
  • Choose to push/pull treasure maps
  • Choose to push/pull survey maps
  • Choose to push/pull style motif fragments
  • Choose to push/pull recipe fragments
  • Choose to push/pull imperial city trophies

Housing
  • Choose to push/pull known recipes
  • Choose to push/pull unknown recipes
  • Choose to push/pull Furnishing

Misc
  • Choose to push/pull AvA repair
  • Choose to push/pull disguises
  • Choose to push/pull lockpics
  • Choose to push/pull potions
  • Choose to push/pull racial motif books
  • Choose to push/pull containers (does not work with containers you also can not move manually)
  • Choose to push/pull (crown) repair kits
  • Choose to push/pull soul gems, empty or charged

Crafting
  • Choose to push/pull 1 or + (up to 50) stacks of any material <- had to bundle potency runes at all levels with the changes from 14.2
  • Choose to push/pull weapons/armor/jewelry
  • Choose to push/pull intricate weapons/armor/jewelry (set excluded)
  • Choose to push/pull researchable weapons/armor/jewelry (set excluded) <- CraftStore addon support inside

Known Bugs
  • Runes not working (only Ta and Glyphs) Fixed with 14.2
  • Identical Intricate (Jewelry) Items can not be moved together to target (if you have e.g. 4 identical rings BMR will only move 1 of them - no matter what settings you made) - fixed with 14.4
  • Intricate Items can not be pushed to guildbank - working for Jewelry and Woodworking with 14.4
  • If you interact with a storage box (furnishing item) all items you push automatically to bank will be deposited in the bank (even if you do not have the banker NPC), if you want to place that items in the storage box, you have to change your profile or change the options in your current profile to not auto push in bank in order to keep them in your inventory and deposit them manually


Upcoming changes
  • Choose to push/pull intricate jewelry items Done with 14.3 - provided by LordKor -> thank you
  • Change to global saved varibles instead of different profiles for every character - Done with 13.0
  • Optional Setting to switch back to Full Version (if you are not ESO+) - Done with 14.0
  • Find a way that invisible options are also not performing any action
  • Find a way to move intricate items into guildbank - working for Jewelry and Woodworking with 14.4
since 13.0:
- Change to use accountwide profiles
Please Backup your data first if you want to keep them especially if you are new to the slim version and maybe want to switch back to the non slim version


___________________________________________________________________________
___________________________________________________________________________
Start of most recent changelog:

14.85:
- API Bump for next DLC (not yet announced)
- bugfix with FCO Itemsaver provided from Baertram (big thanks as always)


14.84:
- API Bump
- raised max transfered gold from 200000 to 1000000 (request from Lexynide)
- raised max transfered alliance points from 200000 to 1000000
- raised max transfered telvar stones from 10000 to 100000

14.83:
- API Bump to 100034 to work with Flames of Ambition


14.82:
- API Bump to 100033 to work with Markarth

14.81:
- changed max stack to 500 from 50 (you could now deposit e.g. 500 identical glyphs in your guild bank if you want to)

14.8:
- only API Bump to 100032 to work with Stonethorn
- more changes and fixes are on the to-do-list but we did not find the time yet

14.7:
- API Bump to 100031 to work with Greymoor

14.6:
- removed libs from the bundle, please make sure to install them seperatly:
https://www.esoui.com/downloads/info517-LibResearch.html
https://www.esoui.com/downloads/info7-LibAddonMenu.html
to be honest i let them remove by Baertram, because he knows how to do it without breaking the addon, thanks for it

14.5:
- moved MasterWrits to it's final destination tab "Quests: Crafting"

14.4:
- you can now move identical intricate jewelry and woodworking items into the bank AND/OR guildbank by using its own max stack slider - coming for smithing and clothier in later updates hopefully
- temporary moved MasterWrits to trophys and forgot to move it where i really wanted it -> will be moved in 14.5 again (Quest Tab)

14.3:
- Added changes to Jewelry handling provided by LordKor -> thank you
-> you can now move intricate jewelry to/from bank not working for guild banks for now


14.2:
- Added changes to Poison/Poison Solvent handling provided by LordKor -> thank you
- Reworked Runes and Glyphs handling and sorting (works now for guild bank as well)
- API Bump to 100030 for the upcoming DLC
- minor changes i can't remember


14.1:
- Associated Guild Bank for smith, clothier and woodworker reactivated (still no movement for intricate items into guildbank)
- API bump to 100029 Dragonhold (its working with both Live and PTS)


14.0:
- API bump to 100028 Scalebreaker
- Global Addon Profiles added (this hides some options but if you did not deactivate one option before you change the profile - BMR will still perform an action - i am trying to fix this in future updates)
- saved variables will grow a bit, but it should not affect your performance really bad - however i will try to reduce it even more or at least back to the size you had with 13.0


13.0:
- Change to use accountwide profiles
Please Backup your data first if you want to keep them - because the first reload/logout with the new version will reset the current char. Because of that login/logout trough the chars for the first time, the size of the saved variables will be smaller with every character logging out.

If you want to make extra space delete the saved variables and create them new from the scratch (highly recommended)
- Some Minor Changes (outcommenting of some unneeded elements)

- in the comment section is a zip-archive with all functions of BMR Jewelry Crafting version reactivated but with accountwide profiles. This is especially to help the non ESO+ Users - but we will have a look if we can combine them into one version and switch between slimmed ESO+ and non ESO+ version. But first we want to take a look for remake of "intricate items".



12.2:
- Commented the furnishing material out (e.g. Bast, Regulus, Heartwood)

Next steps will be:
- change the saved variables to global/accountwide
(should reduce the size again for better performance, if needed i can think about implementing more profiles instead - let me know in the comments if you would need them but i don't really think they are needed) and you have to make future changes in one profile on one character only instead of importing the same profile to every other char or make the same changes)

- bring back the intricate item movement back - goal is for each individual profession and intricate items in general - all optional



12.1:
- Release
Archived Files (15)
File Name
Version
Size
Uploader
Date
14.84
117kB
Gamer1986PAN
09/19/21 09:22 AM
14.83
117kB
Gamer1986PAN
02/22/21 09:12 AM
14.82
117kB
Gamer1986PAN
11/01/20 05:50 PM
14.81
117kB
Gamer1986PAN
08/12/20 01:38 PM
14.8
117kB
Gamer1986PAN
05/17/20 05:34 AM
14.6
117kB
Gamer1986PAN
02/09/20 03:56 PM
14.5
170kB
Gamer1986PAN
01/18/20 11:49 PM
14.4
170kB
Gamer1986PAN
01/18/20 10:20 PM
14.3
170kB
Gamer1986PAN
01/07/20 05:33 PM
14.2
169kB
Gamer1986PAN
01/06/20 06:00 PM
14.1
169kB
Gamer1986PAN
08/14/19 12:29 PM
14.0
169kB
Gamer1986PAN
08/13/19 02:50 PM
13.0
169kB
Gamer1986PAN
05/18/19 10:59 AM
12.2
169kB
Gamer1986PAN
05/17/19 12:22 PM
12.1
169kB
Gamer1986PAN
04/23/19 05:03 PM


Post A Reply Comment Options
Unread 01/18/22, 03:52 PM  
Gamer1986PAN
AddOn Author - Click to view AddOns

Forum posts: 84
File comments: 518
Uploads: 2
Originally Posted by GnatB
Code:
	-- Researchable Armor (medium)
	ruleName = "armorTypeResearchableWeight" .. ARMORTYPE_MEDIUM
	BankManagerRules.data[ruleName] = {
		params = {
			{func = GetItemLinkItemType, funcArgs = BMR_ITEMLINK, values = {ITEMTYPE_MEDIUM}},
			{func = GetItemLinkArmorType, funcArgs = BMR_ITEMLINK, values = {ARMORTYPE_MEDIUM}},
			{func = GetItemLinkSetInfo, funcArgs = BMR_ITEMLINK, values = {false}},
			{func = IsItemNeededForResearch, funcArgs = BMR_ITEMLINK, values = {true}},
			{func = IsItemJunk, funcArgs = BMR_BAG_AND_SLOT, values = {false}},
		},
		name = zo_strformat("<<1>> : <<2>> (<<3>>)", GetString(SI_ITEM_FORMAT_STR_ARMOR), GetString("SI_ARMORTYPE", ARMORTYPE_MEDIUM), GetString(SI_SMITHING_RESEARCH_RESEARCHABLE)),
		tooltip = zo_strformat("<<1>> : <<2>> (<<3>>)", GetString(SI_ITEM_FORMAT_STR_ARMOR), GetString("SI_ARMORTYPE", ARMORTYPE_MEDIUM), GetString(SI_SMITHING_RESEARCH_RESEARCHABLE)),
	}
Not sure when this error crept into the code, but it should be ITEMTYPE_ARMOR, not ITEMTYPE_MEDIUM

This is related to line 1297-1308 in the Bank ManagerRules.lua where the original authors split light, medium and heavy armor so you can handle every armor type differently via settings as far as i can see and understand it. Correct me if i am wrong but this made the most sense to me almost know nothing about lua.
__________________
Co-Author of the Addon BeamMeUp - feel free to check it out.


BankManagerRevived Slim Edition
- changed profiles to accountwide in order to have better performance with BMR and added 4 different global addon profiles for better overview -
most of the working mechancis are created from the original BMR authors - credits to orignal authors
Report comment to moderator  
Reply With Quote
Unread 01/11/22, 09:46 PM  
GnatB

Forum posts: 0
File comments: 6
Uploads: 0
Code:
	-- Researchable Armor (medium)
	ruleName = "armorTypeResearchableWeight" .. ARMORTYPE_MEDIUM
	BankManagerRules.data[ruleName] = {
		params = {
			{func = GetItemLinkItemType, funcArgs = BMR_ITEMLINK, values = {ITEMTYPE_MEDIUM}},
			{func = GetItemLinkArmorType, funcArgs = BMR_ITEMLINK, values = {ARMORTYPE_MEDIUM}},
			{func = GetItemLinkSetInfo, funcArgs = BMR_ITEMLINK, values = {false}},
			{func = IsItemNeededForResearch, funcArgs = BMR_ITEMLINK, values = {true}},
			{func = IsItemJunk, funcArgs = BMR_BAG_AND_SLOT, values = {false}},
		},
		name = zo_strformat("<<1>> : <<2>> (<<3>>)", GetString(SI_ITEM_FORMAT_STR_ARMOR), GetString("SI_ARMORTYPE", ARMORTYPE_MEDIUM), GetString(SI_SMITHING_RESEARCH_RESEARCHABLE)),
		tooltip = zo_strformat("<<1>> : <<2>> (<<3>>)", GetString(SI_ITEM_FORMAT_STR_ARMOR), GetString("SI_ARMORTYPE", ARMORTYPE_MEDIUM), GetString(SI_SMITHING_RESEARCH_RESEARCHABLE)),
	}
Not sure when this error crept into the code, but it should be ITEMTYPE_ARMOR, not ITEMTYPE_MEDIUM
Report comment to moderator  
Reply With Quote
Unread 01/08/22, 05:46 PM  
GnatB

Forum posts: 0
File comments: 6
Uploads: 0
Re: Re: Excluding sets?

Originally Posted by Gamer1986PAN
Like i said those mechanics are not made by me and some game updates in the past might broke something like it did for multiple similar intricate blacksmith and clothier items that i want to push to guildbank
Nah, the oscillation error has been like that since I first grabbed the addon years ago. I assume it was a bug with the original version. I fixed my version of bankmanager way back when and never bothered making an account to comment about it. The JC stuff is from my old personal JC changes. (Not sure Jewelry was every fully supported in BM?)

Can't speak with total confidence to the guildbank issue as I don't use guildbanks nor have any I trust to test against. I did notice the Jewelry rule was being controlled by the OnlyIfNotFullStack/MaxStacks functionality preventing moving duplicate Jewelry (once I fixed the "Jewelry" rule) into local bank unless I used and bumped up MaxStacks in the options. Doesn't look like blacksmithing/clothing (or researchable woodworking) rules are currently controlled by their version of those options even though they show up. (using ESO+ with crafting profile). However looks like there ARE default values for them that should be causing that issue. Though that would presumably also prevent unknown/known duplicates, as well as transfer to regular bank if that was the issue, which you don't indicate is happening. (Though, from quick test, does seem to be similarly broken, at least duplicate blacksmithing into local bank.). Though that also probably means target guild is just whatever the default is and probably isn't actually being controlled by the guild dropdown (oops)

Personally, as I don't use guild banks or have any interest in preventing duplicates, I'm probably just going to remove those options and hard code it to max stacks of 500 in the rules. Otherwise probably have to redo the name convention for the rules so all the blacksmith rules start with the same string, all the clothing rules start with a same (but different from blacksmithing) string, etc.

edit: Looks like the old version of BM I had backed up basically ignored the only if not full stack functionality if the max stack size was 1 (e.g. equipment that can't stack... maybe that changed?), which is how it USED to work w/o needing to hardcode a stacksize of 500 for these rules. Still leaves the possible guild issue though. Whatever. That's all for somebody who wants to maintain this for a customizable experience, and not hard code it to work for themselves.
Last edited by GnatB : 01/08/22 at 06:14 PM.
Report comment to moderator  
Reply With Quote
Unread 01/08/22, 07:58 AM  
Gamer1986PAN
AddOn Author - Click to view AddOns

Forum posts: 84
File comments: 518
Uploads: 2
Re: Excluding sets?

Originally Posted by GnatB
Choose to push/pull weapons/armor/jewelry

(Also excludes sets, although it isn't mentioned.. Speaking of, WHY?)

Also, AFAIK, Jewelry =
Code:
			{func = GetItemLinkItemType, funcArgs = BMR_ITEMLINK, values = {ITEMTYPE_ARMOR}},
			{func = GetItemLinkEquipType, funcArgs = BMR_ITEMLINK, values = {EQUIP_TYPE_NECK, EQUIP_TYPE_RING }},
And, Incidentally, the non researchable armor/weapon/etc. rules should probably have
Code:
			{func = IsItemNeededForResearch, funcArgs = BMR_ITEMLINK, values = {false}},
So any researchable items don't oscillate in/out of the bank each time you talk to banker if researched/unresearched aren't being sent to same place...

(I suspect intricate oscillates too, but not sure how to test for NOT intricate. I put known and intricate same place though, so it's not a problem for me so don't really care to look into it. Probably checking for all traits EXCEPT intricate. Which, ugh.)


Like i said those mechanics are not made by me and some game updates in the past might broke something like it did for multiple similar intricate blacksmith and clothier items that i want to push to guildbank. right now you only can move one similar item instead of all items like you are able to with jewelry and woodworking and i am not able to figure out why. if i would be able to code in lua i think i would start all over because of the past changes the code could definitly use some cleanouts and performance improvements with that.
But because i am not that deep into lua and the addon still does for me what i need it to do, i guess i just have to hope for some more advanced author to take over and fixes everything. i would be fine with all changes as long as there will be a "accountwide" setting and everything is at least working as it is now.
__________________
Co-Author of the Addon BeamMeUp - feel free to check it out.


BankManagerRevived Slim Edition
- changed profiles to accountwide in order to have better performance with BMR and added 4 different global addon profiles for better overview -
most of the working mechancis are created from the original BMR authors - credits to orignal authors
Report comment to moderator  
Reply With Quote
Unread 01/08/22, 06:38 AM  
GnatB

Forum posts: 0
File comments: 6
Uploads: 0
Excluding sets?

Choose to push/pull weapons/armor/jewelry

(Also excludes sets, although it isn't mentioned.. Speaking of, WHY?)

Also, AFAIK, Jewelry =
Code:
			{func = GetItemLinkItemType, funcArgs = BMR_ITEMLINK, values = {ITEMTYPE_ARMOR}},
			{func = GetItemLinkEquipType, funcArgs = BMR_ITEMLINK, values = {EQUIP_TYPE_NECK, EQUIP_TYPE_RING }},
And, Incidentally, the non researchable armor/weapon/etc. rules should probably have
Code:
			{func = IsItemNeededForResearch, funcArgs = BMR_ITEMLINK, values = {false}},
So any researchable items don't oscillate in/out of the bank each time you talk to banker if researched/unresearched aren't being sent to same place...

(I suspect intricate oscillates too, but not sure how to test for NOT intricate. I put known and intricate same place though, so it's not a problem for me so don't really care to look into it. Probably checking for all traits EXCEPT intricate. Which, ugh.)
Report comment to moderator  
Reply With Quote
Unread 12/08/21, 05:46 PM  
Gamer1986PAN
AddOn Author - Click to view AddOns

Forum posts: 84
File comments: 518
Uploads: 2
Originally Posted by SteveCampsOut
I dunno what you did this update, but BMRSlim is finally working again for me after over a year of not wanting to deposit mats to guild banks. Must have been that FCO bug. Anywho, thanks!
Thats great to hear i just wonder why i did not have that problem. But maybe that fixes all the other bugs i found as well, so i will have to give it a try before i search for other solutions to that problems.
__________________
Co-Author of the Addon BeamMeUp - feel free to check it out.


BankManagerRevived Slim Edition
- changed profiles to accountwide in order to have better performance with BMR and added 4 different global addon profiles for better overview -
most of the working mechancis are created from the original BMR authors - credits to orignal authors
Report comment to moderator  
Reply With Quote
Unread 12/06/21, 09:33 PM  
SteveCampsOut
 
SteveCampsOut's Avatar

Forum posts: 31
File comments: 350
Uploads: 0
I dunno what you did this update, but BMRSlim is finally working again for me after over a year of not wanting to deposit mats to guild banks. Must have been that FCO bug. Anywho, thanks!
Last edited by SteveCampsOut : 12/06/21 at 09:34 PM.
Report comment to moderator  
Reply With Quote
Unread 12/05/21, 09:42 AM  
Gamer1986PAN
AddOn Author - Click to view AddOns

Forum posts: 84
File comments: 518
Uploads: 2
Originally Posted by assoui
Thanks for the quick response, it fixed it!

Originally Posted by Baertram
Lua Code:
  1. -- return true if item is protected
  2. local function IsItemProtected(bagId, slotId)
  3.  
  4.     -- ESOUI
  5.     if IsItemPlayerLocked(bagId, slotId) then
  6.         return true
  7.     end
  8.  
  9.     --Item Saver support
  10.     if ItemSaver_IsItemSaved and ItemSaver_IsItemSaved(bagId, slotId) then
  11.         return true
  12.     end
  13.  
  14.     --FCO ItemSaver support
  15.     if FCOIS and FCOIS.IsLocked then
  16.         return FCOIS.IsLocked(bagid, slotindex)
  17.     end

There is an error at the FCOIS checks:

Wrong: return FCOIS.IsLocked(bagid, slotindex)
Correct: return FCOIS.IsLocked(bagId, slotId)

bagid is unknown, check the capital I needed here!
And slotIndex is unknown, you need to use slotId here!

btw: FilterIt is dead since years and should not be used anymore.

thx for confirming, that the fix is working since i dont have any problems i could not confirm it myself. i uploaded the same changes with the next version. Thanks again @Baertram for the fast fix.
__________________
Co-Author of the Addon BeamMeUp - feel free to check it out.


BankManagerRevived Slim Edition
- changed profiles to accountwide in order to have better performance with BMR and added 4 different global addon profiles for better overview -
most of the working mechancis are created from the original BMR authors - credits to orignal authors
Report comment to moderator  
Reply With Quote
Unread 12/05/21, 01:45 AM  
assoui

Forum posts: 0
File comments: 25
Uploads: 0
Thanks for the quick response, it fixed it!

Originally Posted by Baertram
Lua Code:
  1. -- return true if item is protected
  2. local function IsItemProtected(bagId, slotId)
  3.  
  4.     -- ESOUI
  5.     if IsItemPlayerLocked(bagId, slotId) then
  6.         return true
  7.     end
  8.  
  9.     --Item Saver support
  10.     if ItemSaver_IsItemSaved and ItemSaver_IsItemSaved(bagId, slotId) then
  11.         return true
  12.     end
  13.  
  14.     --FCO ItemSaver support
  15.     if FCOIS and FCOIS.IsLocked then
  16.         return FCOIS.IsLocked(bagid, slotindex)
  17.     end

There is an error at the FCOIS checks:

Wrong: return FCOIS.IsLocked(bagid, slotindex)
Correct: return FCOIS.IsLocked(bagId, slotId)

bagid is unknown, check the capital I needed here!
And slotIndex is unknown, you need to use slotId here!

btw: FilterIt is dead since years and should not be used anymore.
Report comment to moderator  
Reply With Quote
Unread 12/04/21, 12:07 PM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 3815
File comments: 4701
Uploads: 69
Lua Code:
  1. -- return true if item is protected
  2. local function IsItemProtected(bagId, slotId)
  3.  
  4.     -- ESOUI
  5.     if IsItemPlayerLocked(bagId, slotId) then
  6.         return true
  7.     end
  8.  
  9.     --Item Saver support
  10.     if ItemSaver_IsItemSaved and ItemSaver_IsItemSaved(bagId, slotId) then
  11.         return true
  12.     end
  13.  
  14.     --FCO ItemSaver support
  15.     if FCOIS and FCOIS.IsLocked then
  16.         return FCOIS.IsLocked(bagid, slotindex)
  17.     end

There is an error at the FCOIS checks:

Wrong: return FCOIS.IsLocked(bagid, slotindex)
Correct: return FCOIS.IsLocked(bagId, slotId)

bagid is unknown, check the capital I needed here!
And slotIndex is unknown, you need to use slotId here!

btw: FilterIt is dead since years and should not be used anymore.
Last edited by Baertram : 12/04/21 at 12:08 PM.
Report comment to moderator  
Reply With Quote
Unread 12/04/21, 08:04 AM  
assoui

Forum posts: 0
File comments: 25
Uploads: 0
Addon does not work with FCO Item Saver

Thanks for the addon. Recently returned to the game and found a problem with this addon. Like the poster below me mentioned, this addon does not work when FCO Item Saver is enabled. I tried disabling all except libraries, FCO Item Saver and BMR and it did not work. Nothing moved in the bank except Writs (did not setup anything beyond provisioning).

After disabling FCO, BMR is working and provisioning items moved into bank.

I saw that you used FCO and it worked for you. So I went and reset FCO in the options. It reloaded and BMR still did not work. Just to make sure, I did a reloadui again and BMR still did not work. (Update: Also tried clearing FCO saved variables via minion while logged out)

Please look into it. Thank you
Last edited by assoui : 12/04/21 at 08:18 AM.
Report comment to moderator  
Reply With Quote
Unread 11/23/21, 07:24 AM  
sora0v0

Forum posts: 0
File comments: 13
Uploads: 0
Hello! thanks for your grate addon, I use it with Game pad UI.
But I have this error with this addon or "PersonalAssistant".
The error happened when I access to bank.
If I got this error, my inventry was so strange.
The icon remains even if I sell or delete it untill reload ui.

Please check it.

UI error :
/EsoUI/Ingame/Inventory/Gamepad/ZO_GamepadParametricScrollList_BagsSearch_Screen.lua:33: function expected instead of nil
stack traceback:
/EsoUI/Ingame/Inventory/Gamepad/ZO_GamepadParametricScrollList_BagsSearch_Screen.lua:33: in function 'ZO_Gamepad_ParametricList_BagsSearch_Screen:OnUpdatedSearchResults'
/EsoUI/Ingame/Inventory/Gamepad/ZO_GamepadParametricScrollList_BagsSearch_Screen.lua:59: in function 'ZO_Gamepad_ParametricList_BagsSearch_Screen:PerformUpdate'
/EsoUI/Common/Gamepad/ZO_GamepadParametricScrollListScreen.lua:533: in function 'ZO_Gamepad_ParametricList_Screen:Update'
/EsoUI/Ingame/Inventory/Gamepad/ZO_GamepadParametricScrollList_BagsSearch_Screen.lua:100: in function 'OnTextSearchResults'
/EsoUI/Libraries/Utility/ZO_CallbackObject.lua:107: in function 'ZO_CallbackObjectMixin:FireCallbacks'
/EsoUI/Ingame/Utility/TextSearchManager.lua:238: in function 'ZO_TextSearchManager:ExecuteSearch'
/EsoUI/Ingame/Utility/TextSearchManager.lua:171: in function 'ZO_TextSearchManager:CleanSearch'
/EsoUI/Ingame/Utility/TextSearchManager.lua:155: in function 'ZO_TextSearchManager:MarkDirtyByFilterTargetAndPrimaryKey'
/EsoUI/Ingame/Inventory/Gamepad/ZO_GamepadParametricScrollList_BagsSearch_Screen.lua:131: in function 'ZO_Gamepad_ParametricList_BagsSearch_Screen:MarkDirtyByBagId'
/EsoUI/Ingame/Banking/Gamepad/Banking_Gamepad.lua:212: in function 'ZO_GamepadBanking:OnInventorySlotUpdated'
/EsoUI/Ingame/Banking/Gamepad/Banking_Gamepad.lua:207: in function 'callback'
/EsoUI/Libraries/Utility/ZO_CallbackObject.lua:107: in function 'ZO_CallbackObjectMixin:FireCallbacks'
/EsoUI/Ingame/Inventory/SharedInventory.lua:118: in function 'OnInventorySlotUpdated
Report comment to moderator  
Reply With Quote
Unread 10/22/21, 06:59 PM  
Gamer1986PAN
AddOn Author - Click to view AddOns

Forum posts: 84
File comments: 518
Uploads: 2
Originally Posted by mercanbabaa
For me, after the last update, only depositing clothing and blacksmith intricate items to guild bank doesnt work. Woodworking and jewel intricate items depositing is working regularly..
That is a bug that already exists for a while now. Currently we try to find a fix for this but ZOS changed someting in the past (over a year i guess) and we have to find out where the problem is first.
__________________
Co-Author of the Addon BeamMeUp - feel free to check it out.


BankManagerRevived Slim Edition
- changed profiles to accountwide in order to have better performance with BMR and added 4 different global addon profiles for better overview -
most of the working mechancis are created from the original BMR authors - credits to orignal authors
Report comment to moderator  
Reply With Quote
Unread 10/20/21, 10:35 AM  
mercanbabaa

Forum posts: 0
File comments: 2
Uploads: 0
For me, after the last update, only depositing clothing and blacksmith intricate items to guild bank doesnt work. Woodworking and jewel intricate items depositing is working regularly..
Report comment to moderator  
Reply With Quote
Unread 10/02/21, 10:44 AM  
Gamer1986PAN
AddOn Author - Click to view AddOns

Forum posts: 84
File comments: 518
Uploads: 2
Re: Re: Re: Re: Re: Nothing except of currencies work

Originally Posted by Amiante
Originally Posted by Amiante
Originally Posted by Gamer1986PAN
Originally Posted by Amiante
Originally Posted by Mayrael
For me only currencies work, no other item is being moved.
Same for me, just since the last update.

in both banks or just in guild bank or normal bank?
Both
It seems to have been a conflict with FCO ItemSaver. Disabling that one let this work. Sorry to worry you needlessly.
Well i use FCO ItemSaver as well and it works for me fine. But i might have some different options in both addons. Maybe try to have a look there.
__________________
Co-Author of the Addon BeamMeUp - feel free to check it out.


BankManagerRevived Slim Edition
- changed profiles to accountwide in order to have better performance with BMR and added 4 different global addon profiles for better overview -
most of the working mechancis are created from the original BMR authors - credits to orignal authors
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: