Go to Page... |
Compatibility: | Necrom (9.0.0) Scribes of Fate (8.3.5) Firesong (8.2.5) |
Updated: | 07/10/23 06:56 AM |
Created: | 05/25/21 09:50 AM |
Monthly downloads: | 607 |
Total downloads: | 29,077 |
Favorites: | 40 |
MD5: |
File Name |
Version |
Size |
Uploader |
Date |
1.5 |
3kB |
Rednas |
06/05/23 05:42 AM |
|
1.4 |
3kB |
Rednas |
11/04/22 10:24 AM |
|
1.3 |
3kB |
Rednas |
06/04/21 06:23 AM |
|
1.2 |
2kB |
Rednas |
05/26/21 09:42 AM |
|
1.1 |
1kB |
Rednas |
05/25/21 10:46 AM |
Comment Options |
05/26/21, 10:47 AM | |||||
|
Thanks, good to know! This eases the checks a lot imo.
|
||||
|
Baertram |
View Public Profile |
Send a private message to Baertram |
Find More Posts by Baertram |
Add Baertram to Your Buddy List |
05/26/21, 10:46 AM | ||||
|
Checked the public dungeons as well before i released it here, they also return 0. Rechecked it today before i submitted v1.2 and the ones i checked returned 0. So i kept this validation intact.
|
|||
|
Rednas |
View Public Profile |
Send a private message to Rednas |
Find More Posts by Rednas |
Add Rednas to Your Buddy List |
05/26/21, 10:32 AM | |||
|
The dungeon can be also checked via IsUnitInDungeon("player") and "IsUnitGrouped("player") == true as you would port out of a real dungeon (non-delve) if you are not grouped (after 2 mins of time I think), or did they change that?
But the GetCurrentZoneDungeonDifficulty() idea should work even better then, if it always returns 1 or 2 for "real group dungeons" and 0 for delves. Need to check if this applies to PubDungeons as well.
Last edited by Baertram : 05/26/21 at 10:35 AM.
|
||
|
Baertram |
View Public Profile |
Send a private message to Baertram |
Find More Posts by Baertram |
Add Baertram to Your Buddy List |
05/26/21, 09:46 AM | ||
|
Thanks to Baertram, i was also able to update the chest detection. I will take a look at your add-on if i find any more difficulties
Last edited by Rednas : 05/26/21 at 09:48 AM.
|
|
|
Rednas |
View Public Profile |
Send a private message to Rednas |
Find More Posts by Rednas |
Add Rednas to Your Buddy List |
05/26/21, 08:37 AM | |
|
Just to add to what Baertram said, IsUnitInDungeon returns true even for a delve and public dungeon.
In my addon I check if the value of GetZoneId(GetUnitZoneIndex("player")) is in a table containing the ids of the dungeon to satisfy the conditional code (you can find the zoneId for dungeons from LibSets datasheet) - should be a language independent implementation I also use the FISHING_MANAGER hack mentioned to correctly identify a chest, perhaps you can get some ideas from my code. Not sure if multiple FISHING_MANAGER calls from different addons will conflict, from my testing it should be fine as long as they are not called with the exact same ms in the RegisterForUpdate registered function |
|
xgoku1 |
View Public Profile |
Send a private message to xgoku1 |
Find More Posts by xgoku1 |
Add xgoku1 to Your Buddy List |
05/26/21, 06:04 AM | |
Forum posts: 0
File comments: 27
Uploads: 0
|
Such A Useful Addon! Thanks So Much!
Thanks so much for this! I run a lot of dungeons and this Addon helps immensely!
|
|
Trinity Is My Name |
View Public Profile |
Send a private message to Trinity Is My Name |
Find More Posts by Trinity Is My Name |
Add Trinity Is My Name to Your Buddy List |
Baertram |
View Public Profile |
Send a private message to Baertram |
Find More Posts by Baertram |
Add Baertram to Your Buddy List |
Rednas |
View Public Profile |
Send a private message to Rednas |
Find More Posts by Rednas |
Add Rednas to Your Buddy List |
05/25/21, 10:08 AM | |
|
Thanks for the addon.
You should Unregister the EVENT_ADD_ON_LOADED after your addon was found again as it else will fire again for each of your addons, and will run your addonName comparison then each time again, for nothing. Lua Code:
Last edited by Baertram : 05/25/21 at 10:16 AM.
|
|
Baertram |
View Public Profile |
Send a private message to Baertram |
Find More Posts by Baertram |
Add Baertram to Your Buddy List |