Quantcast
Download
(8 Kb)
Download
Updated: 06/03/21 12:54 PM
Pictures
File Info
Compatibility:
Blackwood (7.0.5)
Updated:06/03/21 12:54 PM
Created:10/11/20 09:03 PM
Monthly downloads:6,639
Total downloads:35,079
Favorites:59
MD5:
7.0.5
Set Collection Marker (Sticker Book)  Popular! (More than 5000 hits)
Version: 1.2.2
by: Kyzeragon [More]
This addon depends on LibAddonMenu-2.0.

Adds an icon in your inventories next to items that are not in your set collection / sticker book. This allows you to easily see which items you can bind for your collection instead of selling/trading it. The icon works in player inventories, banks, guild banks, crafting stations, transmute stations, guild stores, trading, and selling to merchants. Supports GridList, and minimally InventoryGridView.


Also adds icons for chat messages that contain items not in your set collection. Useful for a quick check of what your group members linked in chat! Different styles of the display: Beginning of the message / End of the message / Before the uncollected item / After the uncollected item


Works with addons that output item links in chat too (also supports pChat/rChat), including:
LuiExtended
Trading Addons
Group Loot Notifier (must use the "First tab" option)
LootDrop
Loot Log



Known Issues
- Some quest rewards in Blackwood apparently don't work with the sticker book, so Set Collection Marker is correct in NOT marking these items. Most likely ZOS neglected to make these items collectible, there's nothing I can do about it
- Icons will still show on system messages such as from Loot Log that already indicate uncollected items - will add settings to change this in a later update
- Does not support Guild Store or trade window for gamepad UI
v1.2.2
- API bump to Blackwood, no code changes
- Note: some quest rewards in Blackwood apparently don't work with the sticker book, so Set Collection Marker is correct in NOT marking these items. Most likely ZOS neglected to make these items collectible, there's nothing I can do about it

v1.2.1
- API bump to Flames of Ambition, no code changes

v1.2.0
- Added icons to trade window (keyboard UI)
- Possibly fixed the chat icons sometimes not working with rChat

v1.1.0
- Added support for gamepad UI inventories except for guild store -- thanks Friday_The13_rus!
- Added icons in the buyback tab for vendors

v1.0.5
- Fixed the chat icons sometimes not working with pChat

v1.0.2
- Fixed the System Message / Chat Message setting toggles not actually working lol

v1.0.1
- Greatly improved checking of which items should be marked - thanks code65536!
- *LibSets is now NO LONGER a dependency*

v1.0.0
- Removed pre-Markarth checks since they're now unnecessary, so slightly better performance
- Fixed potential LUA error if a message is empty
- Fixed icons showing on certain special quest reward / boss drop items that were of crafted sets, such as Prismatic Blade (Orgnum's Scales) from Fighters Guild quests
- Fixed icons showing for the Prophet's set and Broken Soul rings, from levelling rewards
- *LibSets is now a required dependency*

v0.9.5
- Fixed icon showing for craftable set items

v0.9.4
- Fixed /r command to reply to whispers not working, should be hooking the chat formatter correctly now

v0.9.3
- Added icons in both player chat and system messages, check addon description page or addon settings for more info!

v0.9.2
- Added support for transmute station window
- Require minimum version 31 of LibAddonMenu-2.0
- Added support for GridList
- Added minimal support for InventoryGridView
- bank icon does not display in the right spot until user changes tabs
- just use GridList; InventoryGridView is very outdated

v0.9.1
- Initial release
Optional Files (0)


Archived Files (11)
File Name
Version
Size
Uploader
Date
1.2.1
8kB
Kyzeragon
03/10/21 01:53 PM
1.2.0
8kB
Kyzeragon
11/24/20 04:51 AM
1.1.0
8kB
Kyzeragon
11/17/20 01:49 AM
1.0.5
6kB
Kyzeragon
11/11/20 12:48 PM
1.0.2
6kB
Kyzeragon
11/04/20 06:28 PM
1.0.1
6kB
Kyzeragon
11/04/20 12:41 PM
1.0.0
6kB
Kyzeragon
11/03/20 01:49 PM
0.9.5
7kB
Kyzeragon
11/02/20 08:48 AM
0.9.4
6kB
Kyzeragon
11/01/20 03:54 PM
0.9.3
6kB
Kyzeragon
10/26/20 11:16 AM
0.9.2
4kB
Kyzeragon
10/17/20 11:59 PM


Post A Reply Comment Options
Unread 05/09/21, 02:25 PM  
LoneStar2911
Addon Addict
 
LoneStar2911's Avatar
Premium Member

Forum posts: 129
File comments: 569
Uploads: 0
Never mind!
Last edited by LoneStar2911 : 05/09/21 at 02:45 PM.
Report comment to moderator  
Reply With Quote
Unread 02/27/21, 03:23 AM  
Orejana
AddOn Author - Click to view AddOns

Forum posts: 2
File comments: 47
Uploads: 2
This only happens sometimes - sometimes it works perfectly fine, sometimes I don't see any icons in chat. So I guess your thoughts on initialization are correct.
I will try to increase the delay as you suggested, thanks :-)

Originally Posted by Kyzeragon
Originally Posted by Orejana
Thanks for your answer I've been browsing through your code and found CHAT_ROUTER which you seem to be using to call on chat messages? I'm not so good with LUA
Well, anyways, I searched through my addons to see which ones are using this function and I've come up with several:
- LibChatMessage
- Cyrillic Chat Filter
- LibDebugLogger

Everything else I found was disabled last night, so they could not have been the problem.
Any thoughts on any of those or how I might be able to work around that issue?
Hmm I looked through Cyrillic Chat Filter and even tried using it a little but it doesn't do any formatting of the messages, only returns true or false to simply remove the entire message. The two libraries *should* be fine, I also have those on all the time.

I'm not sure what else it could be. Is the icon missing in chat every single time, or only sometimes? And you said that this is when someone else links the item, not in system messages? If the icon is missing when someone else links it, is it also missing in system message (e.g. if you run /script d("[item link here]"))?

If you want to, you can try going to line 113 of SetCollectionMarkerChat.lua and increase the delay from 500 to whatever, like 1000 or more. That would just delay the chat initialization even more so that my addon would be more likely to be the last one to register a chat formatter, though that doesn't figure out what the root cause is.
Report comment to moderator  
Reply With Quote
Unread 02/22/21, 03:10 PM  
Kyzeragon
 
Kyzeragon's Avatar
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 132
Uploads: 4
Originally Posted by Orejana
Thanks for your answer I've been browsing through your code and found CHAT_ROUTER which you seem to be using to call on chat messages? I'm not so good with LUA
Well, anyways, I searched through my addons to see which ones are using this function and I've come up with several:
- LibChatMessage
- Cyrillic Chat Filter
- LibDebugLogger

Everything else I found was disabled last night, so they could not have been the problem.
Any thoughts on any of those or how I might be able to work around that issue?
Hmm I looked through Cyrillic Chat Filter and even tried using it a little but it doesn't do any formatting of the messages, only returns true or false to simply remove the entire message. The two libraries *should* be fine, I also have those on all the time.

I'm not sure what else it could be. Is the icon missing in chat every single time, or only sometimes? And you said that this is when someone else links the item, not in system messages? If the icon is missing when someone else links it, is it also missing in system message (e.g. if you run /script d("[item link here]"))?

If you want to, you can try going to line 113 of SetCollectionMarkerChat.lua and increase the delay from 500 to whatever, like 1000 or more. That would just delay the chat initialization even more so that my addon would be more likely to be the last one to register a chat formatter, though that doesn't figure out what the root cause is.
Report comment to moderator  
Reply With Quote
Unread 02/18/21, 04:36 AM  
Orejana
AddOn Author - Click to view AddOns

Forum posts: 2
File comments: 47
Uploads: 2
Thanks for your answer I've been browsing through your code and found CHAT_ROUTER which you seem to be using to call on chat messages? I'm not so good with LUA
Well, anyways, I searched through my addons to see which ones are using this function and I've come up with several:
- LibChatMessage
- Cyrillic Chat Filter
- LibDebugLogger

Everything else I found was disabled last night, so they could not have been the problem.
Any thoughts on any of those or how I might be able to work around that issue?

Originally Posted by Kyzeragon
Originally Posted by Orejana
This is still happening. In chat, sometimes no green icon, but items are not collected. In trading window and inventory, everything is working fine.

Originally Posted by Orejana
Hi! I love this addon, it is really useful!

For the first time, something did not show as uncollected, though! A group mate dropped a sword and when I clicked on it it said "not collected". There was no green icon in chat, however. In the trading window the green icon showed. I did not have a second, identical sword in inventory and I cannot explain why it didn't show. Maybe you could look into it? Thank you :-)

Edit: I am not using any chat addons like pChat or rChat, but I do use Shissus Guild Tools, which does some things to chat, and I use the Bandits Group Loot Notifier (which showed correctly that the sword was not yet collected)
Man, these email notifications are so inconsistent... doesn't send me emails over half the time when there are comments. Anyway, yeah it sounds like there is another addon conflicting.

The reason Group Loot Notifier would always show it correctly is that the message is generated by Group Loot Notifier, as in it is the addon that knows when your group member has looted something and it's the one that prints the message. What Set Collection Marker does is process the chat messages. I parse all system and player chat messages and when an item link is detected, I check whether you have collected that item and then ADD an icon to the chat format. The problem is some addons also process chat messages like this, but they straight up override the chat format. That is, if Set Collection Marker registers its chat handlers first, before the other addon, then the other addon basically throws what Set Collection Marker is doing away. This isn't deterministic, sometimes you might log in or /reloadui and one addon loads first, so it works some of the time, but not the other half. I tried to work around this with pChat by delaying Set Collection Marker's chat handler registration by half a second.

I stopped using Shissu's long ago so I'm no longer familiar with it, but I took a peek, and on a cursory glance, it seems like Shissu's does still take into account old chat formatters, so that might not be the problem... do you have any other addons that might adjust chat messages in any way?
Report comment to moderator  
Reply With Quote
Unread 02/17/21, 05:17 PM  
Kyzeragon
 
Kyzeragon's Avatar
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 132
Uploads: 4
Originally Posted by Orejana
This is still happening. In chat, sometimes no green icon, but items are not collected. In trading window and inventory, everything is working fine.

Originally Posted by Orejana
Hi! I love this addon, it is really useful!

For the first time, something did not show as uncollected, though! A group mate dropped a sword and when I clicked on it it said "not collected". There was no green icon in chat, however. In the trading window the green icon showed. I did not have a second, identical sword in inventory and I cannot explain why it didn't show. Maybe you could look into it? Thank you :-)

Edit: I am not using any chat addons like pChat or rChat, but I do use Shissus Guild Tools, which does some things to chat, and I use the Bandits Group Loot Notifier (which showed correctly that the sword was not yet collected)
Man, these email notifications are so inconsistent... doesn't send me emails over half the time when there are comments. Anyway, yeah it sounds like there is another addon conflicting.

The reason Group Loot Notifier would always show it correctly is that the message is generated by Group Loot Notifier, as in it is the addon that knows when your group member has looted something and it's the one that prints the message. What Set Collection Marker does is process the chat messages. I parse all system and player chat messages and when an item link is detected, I check whether you have collected that item and then ADD an icon to the chat format. The problem is some addons also process chat messages like this, but they straight up override the chat format. That is, if Set Collection Marker registers its chat handlers first, before the other addon, then the other addon basically throws what Set Collection Marker is doing away. This isn't deterministic, sometimes you might log in or /reloadui and one addon loads first, so it works some of the time, but not the other half. I tried to work around this with pChat by delaying Set Collection Marker's chat handler registration by half a second.

I stopped using Shissu's long ago so I'm no longer familiar with it, but I took a peek, and on a cursory glance, it seems like Shissu's does still take into account old chat formatters, so that might not be the problem... do you have any other addons that might adjust chat messages in any way?
Report comment to moderator  
Reply With Quote
Unread 02/17/21, 04:09 PM  
Orejana
AddOn Author - Click to view AddOns

Forum posts: 2
File comments: 47
Uploads: 2
This is still happening. In chat, sometimes no green icon, but items are not collected. In trading window and inventory, everything is working fine.

Originally Posted by Orejana
Hi! I love this addon, it is really useful!

For the first time, something did not show as uncollected, though! A group mate dropped a sword and when I clicked on it it said "not collected". There was no green icon in chat, however. In the trading window the green icon showed. I did not have a second, identical sword in inventory and I cannot explain why it didn't show. Maybe you could look into it? Thank you :-)

Edit: I am not using any chat addons like pChat or rChat, but I do use Shissus Guild Tools, which does some things to chat, and I use the Bandits Group Loot Notifier (which showed correctly that the sword was not yet collected)
Report comment to moderator  
Reply With Quote
Unread 01/30/21, 04:07 PM  
Orejana
AddOn Author - Click to view AddOns

Forum posts: 2
File comments: 47
Uploads: 2
Hi! I love this addon, it is really useful!

For the first time, something did not show as uncollected, though! A group mate dropped a sword and when I clicked on it it said "not collected". There was no green icon in chat, however. In the trading window the green icon showed. I did not have a second, identical sword in inventory and I cannot explain why it didn't show. Maybe you could look into it? Thank you :-)

Edit: I am not using any chat addons like pChat or rChat, but I do use Shissus Guild Tools, which does some things to chat, and I use the Bandits Group Loot Notifier (which showed correctly that the sword was not yet collected)
Last edited by Orejana : 01/30/21 at 04:09 PM.
Report comment to moderator  
Reply With Quote
Unread 01/30/21, 01:59 AM  
Gerrit

Forum posts: 0
File comments: 8
Uploads: 0
Re: Re: Chatcommand

Originally Posted by Kyzeragon
Originally Posted by Gerrit
I would love to have a chat-command or hotkey that posts my trade-able, unlocked, already collected items to group chat. Hopefully no one asked for this before.
Loot Log already does this and does it well.
Great! Thank you for the suggestion. I switched to Loot Log now.
Report comment to moderator  
Reply With Quote
Unread 01/25/21, 12:11 PM  
Kyzeragon
 
Kyzeragon's Avatar
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 132
Uploads: 4
Re: Chatcommand

Originally Posted by Gerrit
I would love to have a chat-command or hotkey that posts my trade-able, unlocked, already collected items to group chat. Hopefully no one asked for this before.
Loot Log already does this and does it well.
Report comment to moderator  
Reply With Quote
Unread 01/25/21, 10:43 AM  
Gerrit

Forum posts: 0
File comments: 8
Uploads: 0
Chatcommand

I would love to have a chat-command or hotkey that posts my trade-able, unlocked, already collected items to group chat. Hopefully no one asked for this before.
Report comment to moderator  
Reply With Quote
Unread 12/25/20, 12:28 PM  
Kyoma
AddOn Author - Click to view AddOns

Forum posts: 125
File comments: 325
Uploads: 10
Originally Posted by tim99



so... can we talk about the amount of that gold? ^^
Probably simply PTS template screenshot
Report comment to moderator  
Reply With Quote
Unread 12/25/20, 12:09 PM  
tim99
 
tim99's Avatar
AddOn Author - Click to view AddOns

Forum posts: 2
File comments: 82
Uploads: 1



so... can we talk about the amount of that gold? ^^
Last edited by tim99 : 12/25/20 at 12:10 PM.
Report comment to moderator  
Reply With Quote
Unread 12/11/20, 07:41 PM  
countdownical
 
countdownical's Avatar

Forum posts: 0
File comments: 30
Uploads: 0
Hi!
Is it possible for you to add a completion bar somewhere in Set Collections? Tracking your general progress of all the sets in the game. There is another one that does, but I honestly don't like the design and settings of that one. Yours is much better
Report comment to moderator  
Reply With Quote
Unread 11/29/20, 11:45 PM  
Tiara Ra
 
Tiara Ra's Avatar

Forum posts: 0
File comments: 237
Uploads: 0
Re: Re: freature request

Originally Posted by Kyzeragon

Originally Posted by Tiara Ra
But seems RChat still with problem as was before with PChat
Can you try the new update and see if that works for you?
Still not work
__________________
PC EU, co-GM "Lagacy" PvP/AD/No-CP
Report comment to moderator  
Reply With Quote
Unread 11/24/20, 04:58 AM  
Kyzeragon
 
Kyzeragon's Avatar
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 132
Uploads: 4
Originally Posted by mlq88
I'm in a similar boat, but deleting the savevar did not do it for me. Still makes my life easier when it's shared in chat etc, just not when dropped.
Hard to figure out where the issue is with pChat, LUI, grouplootnotifier and this addon, and it's not THAT important.

Thx for the answer though!
Is the setting here enabled?


And is your GroupLootNotifier setting on "First tab" for which tab to send to? When I was testing with GroupLootNotifier, I noticed it uses a different way of displaying to chat when using the other options, so the message doesn't pass through the message formatter that I hook into.

If yes to both questions above and it still doesn't work for you, can you post a screenshot of what the message looks like that you should have icons on?
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: