Quantcast
Download
(14 Kb)
Download
Updated: 01/21/21 04:36 PM
Pictures
File Info
Compatibility:
Markarth (6.2.5)
Stonethorn (6.1.5)
Greymoor (6.0.5)
Updated:01/21/21 04:36 PM
Created:01/17/15 11:42 AM
Monthly downloads:4,882
Total downloads:115,425
Favorites:193
MD5:
6.2.5
FCO Lockpicker  Popular! (More than 5000 hits)
Version: 0.21
by: Baertram [More]
FCO Lockpicker

This addon depends on the following libraries:
LibAddonMenu-2.0
-> Please install this library like a normal addon to your "AddOns" folder (standalone installation), or use the Minion addon manager to install and update the needed library properly.

Do you remember that moment as you find a nice chest somehwere but then you realize that you don't have any lockpicks left in your pocket?
And the next moment some other player appears and loots this chest right in front of you?


This simple addon gives you the possibility to colorize the "lockpicks left" information that you see at the bottom line, if you are lockpicking a chest.
The colors can be changed according to a number of lockpicks that you have left in your inventory (threshold values).


The next chest you will lockpick will give you the visual information now, if you need to get some new lockpicks to your pocket.

In addition the addon is able to show you visual helpers during your lockpicking:
  • A green check icon will be shown each time a chamber of the current lockpick progress was picked and you need to release your mouse button!
  • You are able to colorize the lock's springs green as they get resolved.

Github link:
https://github.com/Baertram/FCOLockpicker
0.21
Fixed gamepad mode remembering the pre-lockpicking chat state properly, and restoring it properly

0.2
-Updated APIversion
-Removed LibStub checks
-Updated library versions
-Updated gamepad support for the correct chat minimized state detection before lockpicking begins
-Changed some code for a betetr speed

0.1
-Updated APIversion
-Updated library calls to support global variables instead of LibStub

0.0.94
Updated API and removed libraries.
You need to install them as standalone versions.
Check the description for infformation what a library is, what a standalone library is, what other addons are helping you to see the dependent libraries of an addon, and how you are able to install them properly as a standalone version.

0.0.93
Fixed bug: Chat will now restore properly to the state it got before the lockpicking started

0.0.92
Updated API and libraries

0.0.9l
Hopefully fixed: Working within gamepad mode now.
-> Thanks to Trent Apple for the fix!

0.0.9k
-Api raise to Morrowind
-Fixed 2 french translation strings that were missing (wrong capitalized variable names ...)

0.0.9j
-Api raise to Homestead
-Updated library LAM

0.0.9i
Added green colorized lock springs option (Thanks to AssemblerManiac for the idea and code!)

0.0.9h
Added Japanese translations.
Added option to use the game client's language.

0.0.9g
Fixed a copy&paste error from previous version

0.0.9f
Fixed settings variable error

0.0.9e
Fixed library path

0.0.9d
Updated library libAddonMenu 2.0 r23

0.0.9c
Fixed bug with languages

0.0.9b
Updated: Russian translation

0.0.9a
Fixed: Lockpick chamber resolved icon showing on top of chest again

0.0.9
Updated API
Updated libraries

0.0.8d
-Updated LAM to 2.0 r25
-Updated API to Shadows of the Hist

0.0.8c
API raised to Dark Brotherhood

0.0.8b
-Updated: Library libAddonMenu 2.0 to version 20

0.0.8a
-Updated: API version to support Thieves guild
-Added: Feature to show a "green check" icon if the current chamber of the lock is picked successfully
Enable this setting in the settings (Standard value: Disabled)
->This will show you a green check icon each time a chamber of the current lockpick progress was picked and you need to release your mouse button

0.0.8
-Updated API version to support patch 2.2
-Added support for FastAPI tool: http://www.esoui.com/downloads/info1220-FastAPI.html

0.0.7b
Updated: API to version 100012

0.0.7b
Updated: LibStub v4

0.0.7
Updated: LibStub v3 & LibAddonMenu 2.0 r18

0.0.6
Fixed a bug where the chat was not restored to the previous state as the lockpicking ended/failed

0.0.5
-Attempt to fix an issue with standard ESO during lockpicking as the mouse is not working (because it focusses on the chat window!)
If the lockpicking starts the chat window will be minimized and after lockpicking it will be set to the state before.

0.0.4a
-Updated french translations. Many thanks to Chou for the help!

0.0.4
-Updated the API version for patch 1.6 (100011)

0.0.3
-Updated libAddonMenu-2.0 to version 17

0.0.2
-Fixed a bug with the minimum threshold value inside the settings
Optional Files (0)


Archived Files (33)
File Name
Version
Size
Uploader
Date
0.2
13kB
Baertram
01/19/21 04:03 PM
0.1
13kB
Baertram
05/03/19 09:14 AM
0.0.94
13kB
Baertram
09/17/18 08:27 AM
0.0.93
56kB
Baertram
03/09/18 03:07 PM
0.0.92
56kB
Baertram
03/04/18 08:07 AM
0.0.9l
53kB
Baertram
05/21/17 04:26 PM
0.0.9k
54kB
Baertram
05/14/17 06:53 AM
0.0.9j
54kB
Baertram
02/06/17 02:31 PM
0.0.9i
54kB
Baertram
12/10/16 02:20 PM
0.0.9h
96kB
Baertram
11/05/16 09:30 AM
0.0.9g
95kB
Baertram
10/31/16 10:06 AM
0.0.9f
95kB
Baertram
10/31/16 07:19 AM
0.0.9e
54kB
Baertram
10/31/16 01:54 AM
0.0.9d
55kB
Baertram
10/30/16 01:23 PM
0.0.9c
50kB
Baertram
10/21/16 07:19 AM
0.0.9b
51kB
Baertram
10/16/16 10:10 AM
0.0.9a
49kB
Baertram
10/09/16 09:55 AM
0.0.9
49kB
Baertram
10/02/16 07:43 PM
0.0.8d
47kB
Baertram
07/17/16 01:12 PM
0.0.8c
49kB
Baertram
05/14/16 03:58 PM
0.0.8b
49kB
Baertram
03/26/16 06:44 PM
0.0.8a
44kB
Baertram
02/19/16 06:09 AM
0.0.8
44kB
Baertram
11/01/15 03:32 PM
0.0.7b
44kB
Baertram
08/31/15 05:12 PM
0.0.7a
44kB
Baertram
08/04/15 01:39 PM
0.0.7
44kB
Baertram
06/14/15 02:15 PM
0.0.6
37kB
Baertram
04/22/15 09:33 AM
0.0.5
37kB
Baertram
04/13/15 06:16 AM
0.0.4a
37kB
Baertram
04/09/15 06:58 PM
0.0.4
37kB
Baertram
03/03/15 06:09 PM
0.0.3
37kB
Baertram
02/23/15 11:53 AM
0.0.2
34kB
Baertram
02/16/15 04:46 AM
0.0.1
34kB
Baertram
01/17/15 11:42 AM


Post A Reply Comment Options
Unread 01/23/21, 03:56 PM  
slickygm

Forum posts: 0
File comments: 6
Uploads: 0
Works great this time. Thanks again.
Report comment to moderator  
Reply With Quote
Unread 01/21/21, 03:41 PM  
Baertram
 
Baertram's Avatar
AddOn Author - Click to view AddOns

Forum posts: 3339
File comments: 4066
Uploads: 65
Okay, will try this myself then. But I think I cannot really handle the cross mode chat states properly for all cases...

Edit:
Well, guess the problem was sitting in front of the PC again this time
SCENE_STATE_SHOWING is unknown and should be SCENE_SCHOWING instead, and all of sudden the "remember the chat state before gamepad lockpicking starts" will be remembered..

Originally Posted by slickygm
Originally Posted by Baertram
hm was this the same if you only tested with 1 mode (only gamepad mode, without switch to keyboard) within 1 reloadui?
You're right. I use both KBM and gamepad modes, so I had it set to auto. Which means when I clicked to minimize chat window, it briefly changed into KBM mode, then when I used controller to start lockpicking, it changed back to gamepad mode.
Last edited by Baertram : 01/21/21 at 04:31 PM.
Report comment to moderator  
Reply With Quote
Unread 01/21/21, 03:04 PM  
slickygm

Forum posts: 0
File comments: 6
Uploads: 0
Originally Posted by Baertram
hm was this the same if you only tested with 1 mode (only gamepad mode, without switch to keyboard) within 1 reloadui?
You're right. I use both KBM and gamepad modes, so I had it set to auto. Which means when I clicked to minimize chat window, it briefly changed into KBM mode, then when I used controller to start lockpicking, it changed back to gamepad mode.
Report comment to moderator  
Reply With Quote
Unread 01/21/21, 06:26 AM  
Baertram
 
Baertram's Avatar
AddOn Author - Click to view AddOns

Forum posts: 3339
File comments: 4066
Uploads: 65
Originally Posted by slickygm
Works partially. When lock-picking is entered while chat window is maximized, it is properly restored to maximized. If I minimize the chat window before lock-picking, it is properly restored as minimized, but... from now on it will always be restored as minimized until relog/reloadui regardless of the actual state.

Mouse and keyboard mode seems to be working fine, though.
hm was this the same if you only tested with 1 mode (only gamepad mode, without switch to keyboard) within 1 reloadui?
Somehow it did not happen to me.
Did you ONLY have FCOLockPicker enabled? Disable all other addons please while testing.

You see, as I said: Unable to test this properly and there are so many different cases the code will run left or right *sigh*
And to be fair: I do not really like to start to support the gamead mode as it will need fixes then if Zos changes something as well
-> Means: Always double work I need to invest with my free time. So unfortunately this is currently all you'll get here, sorry for the half-way-support but at least it works a bit better now (I asume ).

To the dev world:
The addon is at github since 2 years. If any one wants to add full gamepad support please go ahead, fork it and add the code, send a pull request (After testing it properly with keyboard and gamepad mode). Thanks
Last edited by Baertram : 01/21/21 at 06:37 AM.
Report comment to moderator  
Reply With Quote
Unread 01/20/21, 02:17 PM  
slickygm

Forum posts: 0
File comments: 6
Uploads: 0
Works partially. When lock-picking is entered while chat window is maximized, it is properly restored to maximized. If I minimize the chat window before lock-picking, it is properly restored as minimized, but... from now on it will always be restored as minimized until relog/reloadui regardless of the actual state.

Mouse and keyboard mode seems to be working fine, though.
Last edited by slickygm : 01/20/21 at 02:18 PM.
Report comment to moderator  
Reply With Quote
Unread 01/20/21, 02:23 AM  
slickygm

Forum posts: 0
File comments: 6
Uploads: 0
Originally Posted by Baertram
Should be fixed now, found an "more or less" easy way to detect it properly.
Thanks. Will test it later in the evening (Europe).
Report comment to moderator  
Reply With Quote
Unread 01/19/21, 04:09 PM  
Baertram
 
Baertram's Avatar
AddOn Author - Click to view AddOns

Forum posts: 3339
File comments: 4066
Uploads: 65
Should be fixed now, found an "more or less" easy way to detect it properly.
Report comment to moderator  
Reply With Quote
Unread 01/19/21, 01:00 PM  
Baertram
 
Baertram's Avatar
AddOn Author - Click to view AddOns

Forum posts: 3339
File comments: 4066
Uploads: 65
Re: Re: Re: Chat always minimized in gamepad mode

Originally Posted by slickygm
The issue seems to be rather simple. In gamepad mode, the game minimizes chat window on its own, so when EVENT_BEGIN_LOCKPICK event is called, the window is already minimized. So then when you save the state in FCOLockpicker_OnBeginLockpick():

Lua Code:
  1. -Remember chat minimized state
  2. FCOLP.preventerVars.gOnLockpickChatStateIsMinimized = CHAT_SYSTEM:IsMinimized() or false

FCOLP.preventerVars.gOnLockpickChatStateIsMinimized is always set to false, so the window is always restored as minimized in FCOLockpicker_OnEndLockpick().

If not interacted with, in gamepad mode, the game restores chat window state when exiting lockpicking on its own (actually it seems it does it before executing the EVENT_LOCKPICK_SUCCESS or EVENT_LOCKPICK_FAILED events).
Well if the game minimizes the chat automatically in gamepad mode and it IS minimized as you begin the lockpick: How should the addon then know what to do after lockpicks end?

I check at the begin of the lockpick what the current chat state is, as you already described.
I got no other way to determine it, or I'd have to always save the chat state on every change (minimized/maximized) no matter if lockpicking is invloved or not, but just to track the gamepad's current chat state.
This wasn't/isn't necessary in keyboard mode, correct.
And I won't add a general chat minimize/maximize check, sorry. Too much effort.

If in gamepad mode the chat is minimized automatically I might autmatically maximize it after the lockpicking.
But then 50% of the users will complain again that the chat wasn't maximized before they entered the lockpicking...
Well, exactly the example for what ZOs did. Changes between keyboard and gamepad mode, in code, events and whatever. It sucks!

I'll have a look "some day" why the chat is automagically minimized in gamepad mode, what does this, and if i'm able to track this before a lockpick to get the correct state.
Report comment to moderator  
Reply With Quote
Unread 01/19/21, 12:42 PM  
slickygm

Forum posts: 0
File comments: 6
Uploads: 0
Re: Re: Chat always minimized in gamepad mode

Originally Posted by Baertram
Originally Posted by slickygm
Hey I've seen in the changelog that in v0.093 there was a fix to restore chat window to the state it was before the lockpicking started. Is there a chance it was tested only using mouse and keyboard? When using gamepad controls it always ends up minimized after lockpicking is done, regardless of the state before lockpicking (v0.1) and has to be restored manually. Was it an overlook maybe?

Great plugin BTW.
Yes, I'm not owning a gamepad nor am I supporting the gamepad mode with my addons officially as ZOs decided to "duplicate" all stuff between keyboard and gamepad mode. This makes it riddiculously hard to create addons,as you need to duplicateabout 90% of the code, checks, and test everthing duplicated as well. If other addons are compatible in Keyboard mode this does tell nothing about gamepad mode again
-> The effort is too high for my time, sorry.

So if this does not work, I'm unfortunately not able to test and fix this properly.
i'll have a look if I can "imagine" a fix, but no promises.
The issue seems to be rather simple. In gamepad mode, the game minimizes chat window on its own, so when EVENT_BEGIN_LOCKPICK event is called, the window is already minimized. So then when you save the state in FCOLockpicker_OnBeginLockpick():

Lua Code:
  1. -Remember chat minimized state
  2. FCOLP.preventerVars.gOnLockpickChatStateIsMinimized = CHAT_SYSTEM:IsMinimized() or false

FCOLP.preventerVars.gOnLockpickChatStateIsMinimized is always set to false, so the window is always restored as minimized in FCOLockpicker_OnEndLockpick().

If not interacted with, in gamepad mode, the game restores chat window state when exiting lockpicking on its own (actually it seems it does it before executing the EVENT_LOCKPICK_SUCCESS or EVENT_LOCKPICK_FAILED events).
Report comment to moderator  
Reply With Quote
Unread 01/19/21, 08:45 AM  
Baertram
 
Baertram's Avatar
AddOn Author - Click to view AddOns

Forum posts: 3339
File comments: 4066
Uploads: 65
Re: Chat always minimized in gamepad mode

Originally Posted by slickygm
Hey I've seen in the changelog that in v0.093 there was a fix to restore chat window to the state it was before the lockpicking started. Is there a chance it was tested only using mouse and keyboard? When using gamepad controls it always ends up minimized after lockpicking is done, regardless of the state before lockpicking (v0.1) and has to be restored manually. Was it an overlook maybe?

Great plugin BTW.
Yes, I'm not owning a gamepad nor am I supporting the gamepad mode with my addons officially as ZOs decided to "duplicate" all stuff between keyboard and gamepad mode. This makes it riddiculously hard to create addons,as you need to duplicateabout 90% of the code, checks, and test everthing duplicated as well. If other addons are compatible in Keyboard mode this does tell nothing about gamepad mode again
-> The effort is too high for my time, sorry.

So if this does not work, I'm unfortunately not able to test and fix this properly.
i'll have a look if I can "imagine" a fix, but no promises.
Last edited by Baertram : 01/19/21 at 08:46 AM.
Report comment to moderator  
Reply With Quote
Unread 01/19/21, 04:13 AM  
slickygm

Forum posts: 0
File comments: 6
Uploads: 0
Chat always minimized in gamepad mode

Hey I've seen in the changelog that in v0.093 there was a fix to restore chat window to the state it was before the lockpicking started. Is there a chance it was tested only using mouse and keyboard? When using gamepad controls it always ends up minimized after lockpicking is done, regardless of the state before lockpicking (v0.1) and has to be restored manually. Was it an overlook maybe?

Great plugin BTW.
Report comment to moderator  
Reply With Quote
Unread 02/29/20, 05:42 PM  
Baertram
 
Baertram's Avatar
AddOn Author - Click to view AddOns

Forum posts: 3339
File comments: 4066
Uploads: 65
But they can't unless you take the time to do the useless update to a txt file. Where 1 click of the user's fixes this.
So in the end it is useless. IF they would understand the reason and finally ignore the cause, just enable the checkbox, all are fine

ZOs should remove this addon version check, Imo. It does not tell anything about an addons "is it still working" state be only confuses the users.

Originally Posted by Ignis Ferrum
Originally Posted by Baertram
Thanks for the offer but it's useless imo.
The addon users should finally understand this instead of asking for useless updates.
I wouldn't really say it's useless. There's a lot of players who still do not understand that "Out of Date" addons are marked that because of the simple API number change that hasn't been updated and will keep from using the mod, as seen in the comments here where some folks ask why this isn't supported.

IMO, addons should try to avoid this confusion at all costs.
Last edited by Baertram : 02/29/20 at 05:44 PM.
Report comment to moderator  
Reply With Quote
Unread 02/29/20, 02:17 PM  
Ignis Ferrum

Forum posts: 0
File comments: 9
Uploads: 0
Originally Posted by Baertram
Thanks for the offer but it's useless imo.
The addon users should finally understand this instead of asking for useless updates.
I wouldn't really say it's useless. There's a lot of players who still do not understand that "Out of Date" addons are marked that because of the simple API number change that hasn't been updated and will keep from using the mod, as seen in the comments here where some folks ask why this isn't supported.

IMO, addons should try to avoid this confusion at all costs.
Report comment to moderator  
Reply With Quote
Unread 02/28/20, 11:49 AM  
Baertram
 
Baertram's Avatar
AddOn Author - Click to view AddOns

Forum posts: 3339
File comments: 4066
Uploads: 65
Thanks for the offer but it's useless imo.
The addon users should finally understand this instead of asking for useless updates.


Originally Posted by Ignis Ferrum
Originally Posted by Baertram
Thanks but why? I'm still here and there is no update needed at all?
Just enable the checkbox "Allow out of date addons" ingame.

Just because a number comparison ingame says the addon is not updated, which is wrong, does not mean it is broken.


Each major patch the same stupid discussion, sorry, nothing against you, but this sucks!
If you want to show it as updated fix the txt file locally for yourself :-)
Or enable that simple checkbox and ighnore this stupidity of a check without sense...
Gotcha. Thought you would not be against someone offering to do the simple legwork.
Report comment to moderator  
Reply With Quote
Unread 02/28/20, 11:38 AM  
Ignis Ferrum

Forum posts: 0
File comments: 9
Uploads: 0
Originally Posted by Baertram
Thanks but why? I'm still here and there is no update needed at all?
Just enable the checkbox "Allow out of date addons" ingame.

Just because a number comparison ingame says the addon is not updated, which is wrong, does not mean it is broken.


Each major patch the same stupid discussion, sorry, nothing against you, but this sucks!
If you want to show it as updated fix the txt file locally for yourself :-)
Or enable that simple checkbox and ighnore this stupidity of a check without sense...
Gotcha. Thought you would not be against someone offering to do the simple legwork.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: