|
08/30/15, 08:36 PM | #1 |
|
PTS: Stack All Items Bug
The new "Stack All Items" is calling
Lua Code:
If you have, for example (it could be any stackable item in any slot, this is just an example) slotIndex, item, stackSizeand you hit the "Stack All Item" keybind PLAYER_INVENTORY:UpdateList(...) will get called 20 times. Even if that's all you have in that inventory. Each slot/stack attempts to stack with every other slot/stack (of the same type of item), even if they are at max stack size, causing Lua Code:
Lua Code:
Reproduction Steps: 1) Empty the inventory to be tested on (this is just so we can see the exact update count caused by the stacks we add and don't have to worry about other stacks throwing off the count). 2) Place 2 stacks of the same type of item into the inventory. Must have over 200 (max stack size) items of the same type so you still have 2 slot/stacks after it stacks the items. Both stacks can be max stack size it does not matter. 3) Use the following code and watch how many times the UpdateList gets called. It will get called 2 times. Lua Code:
4) Now add a 3rd stack (must have a total of over 400 of the same type of item, 2 slots at max stack size) and run the "Stack All Items" again. This time it will call UpdateList(...) 6 times. 5) With 4 stacks (over 600 of the same type of item) it will call UpdateList(...) 12 times 6) With 5 stacks (over 800 of the same type of item) it will call UpdateList(...) 20 times Exc...exc.... A user was having a problem with my addon crashing & after great help from the users I managed to figure this out. He had a LOT of stacked items & lots of them were full stacks. UpdateList(...) was getting called nearly 200 times in a single use of "Stack All Items" which in turn was causing way to much of my code to run and it was crashing the game. I think I need to optimize something, but StackBag(...) needs some work too. Last edited by circonian : 08/30/15 at 08:39 PM. |
08/30/15, 09:14 PM | #2 |
That's how I do in Roomba to stack in stackable bags, it does exactly the same feature as the function :
Little bit modified for the exemple! Lua Code:
Last edited by Ayantir : 08/30/15 at 09:19 PM. |
|
08/31/15, 01:14 AM | #3 |
we tested it all night, ye
we spent like 1.5m gold on different upgdares and 10k crowns really annoying thing and looks like it need very specific conditions to reproduce i will be fine if some1 just write a code to hide this new Stack All Items feature from my eyes |
|
QuadroTony |
View Public Profile |
Find More Posts by QuadroTony |
08/31/15, 11:30 AM | #4 |
This is now fixed internally.
|
|
08/31/15, 02:26 PM | #5 |
Just to be informed: There will be a "Stack all items" at the banks implemented by ZOs with the next update?
Hope Roomba will get it's credit then |
|
08/31/15, 02:36 PM | #6 |
roomba still nedeed for a guild bank tho
|
|
QuadroTony |
View Public Profile |
Find More Posts by QuadroTony |
ESOUI » Developer Discussions » General Authoring Discussion » PTS: Stack All Items Bug |
«
Previous Thread
|
Next Thread
»
|
Display Modes |
Switch to Linear Mode |
Hybrid Mode |
Switch to Threaded Mode |
|
|