Go to Page... |
Thread Tools | Display Modes |
07/22/15, 12:24 PM | #21 |
|
I've done some tests combining libCommonInventoryFilters with the following:
Here's what I changed in AwesomeGuildStore: diff Code:
diff Code:
And here's what I changed in FilterIt: diff Code:
Note: changing the divider's parent to ZO_PlayerInventoryTabs prevents it from showing in the guild store sell tab when it shouldn't (i.e. with AGS enabled). Last edited by merlight : 07/23/15 at 06:36 PM. |
07/22/15, 03:29 PM | #22 |
|
This code is unnecessary:
Warning: Spoiler
Lua Code:
Those columns are already hidden. If your seeing them then some other addon is messing it up:
Warning: Spoiler
Lua Code:
Bug? Or are you only counting on me to call this function in FilterIt? Lua Code:
Are we sure these items you left out aren't needed anywhere else? I know that currentFilter = TradingHouseFilter is used in ShouldAddSlotToList(..) to filter out bound items...although we are breaking that by allowing the menu bar to be shown & buttons to be clicked (yes we also fixed it by adding to the additional filter to hide bound items), but are we sure its not also needed somewhere else? What about code we don't have access to?
Warning: Spoiler
Lua Code:
This may be trivial, but by leaving those out it prevents code from knowing which btn was previously selected & returning to it. By saving the current filter, then reloading it, & then calling ZO_MenuBar_SelectDescriptor(inventory.filterBar, inventory.currentFilter) It returns the menu bar to its previously selected descriptor. Last edited by circonian : 07/22/15 at 03:58 PM. |
07/22/15, 03:31 PM | #23 | |
|
Lua Code:
|
|
07/22/15, 04:04 PM | #24 |
|
Hiding those columns is necessary, because this line in inventory.lua
Lua Code:
My override of SetTradingHouseModeEnabled doesn't switch to TradingHouseFilter, it leaves the buttons shown (that's also why I had to add not IsBound to additionalFilter, because that was done by the now-unused TradingHouseFilter). After I did this, those columns showed up, because hiddenColumns are tied to buttons. I wasn't sure about the "statValue" column, but the "age" column really doesn't fit in the SELL tab, that's why I've overridden GetTabFilterInfo. --- libCIF._backpackLayoutShiftY -- since I haven't initialized it explicitly, and calling addBackpackLayoutShiftY is not required, it could be nil. It was a not-so-important choice where to apply laziness. --- ZO_MenuBar_SelectDescriptor -- yes you're right. I too was wondering why swapping previousFilter/currentFilter in the original SetTradingHouseModeEnabled doesn't seem to work, I put some debug output in and found the filter was being reset before it had a hance to be remembered --- Anyway, I forgot to add that if you guys decide to use the library, please wait until AGS is ready for it. The search box location must be sorted out first. Perhaps it would suffice if AGS didn't move the search box and just let the lib do it. I'm going to test, but tonight we've got troube with electricity due to a windstorm, can't run ESO on battery Last edited by merlight : 07/22/15 at 04:07 PM. |
07/22/15, 04:25 PM | #25 | |
|
Yes, a while later I realized I was wrong & removed that one from the post. |
|
07/22/15, 04:28 PM | #26 |
I don't mind if the library handles the searchbox.
The only reason I put it into that place was because some time ago the text filter on the searchtab was also in a similar location. Since I put that one into the filter bar like all the others, there is not really a reason to keep it there. I will try to implement the necessary changes tomorrow. |
|
07/22/15, 04:42 PM | #27 |
|
Now I suspect myself of choosing the easy way out. That column is only valid for weapons and armor, so the function would need to be smarter than it is But yea, it it's desired, it could be added. Although personally I wouldn't miss that column if it disappeared from all inventories, I never read it. Weapon damage/armor rating are arguably the least important properties of gear, maybe after vendor value in gold.
|
07/23/15, 12:55 PM | #28 |
I removed the code that reanchors the search box from AGS, but the library does not move it when I call the disable call. Can you change that, or should I look into it myself?
|
|
07/23/15, 06:05 PM | #29 |
|
You probably have another add-on moving it then. For me the search box is right beneath the top-most horizontal divider by default, I checked the anchor in Zgoo and it's the one from xml <Anchor point="TOPRIGHT" offsetX="-26" offsetY="68" />
Anyway, don't call libCIF:disableSearchBoxes() from AGS. It's there for FilterIt, which has its own handling. edit: Ah ok, now I'm staring at my instance of your picture. Ok I need to figure out how it got there edit2: I think it's the layout offsets. I just need to crunch some numbers. Last edited by merlight : 07/23/15 at 06:21 PM. |
07/23/15, 06:45 PM | #30 |
|
I edited the diff for AGS above. The original BACKPACK_TRADING_HOUSE_LAYOUT_FRAGMENT had inventoryTopOffsetY == -20, the default. In libCIF it is set to 45, the value other layouts use. So I added that to your BASIC and ADVANCED layouts, and moved the other two offsets (which are relative to the Top), 65 units up.
There's still an issue with AGS+FilterIt, where the search box remains in "FilterIt location". |
07/28/15, 07:40 PM | #31 |
|
|
08/12/15, 11:10 AM | #32 | |
|
|
|
08/14/15, 04:03 PM | #33 |
|
I didn't add it yet. I was waiting for this discussion to finish. Just post here when everything is straightened out & I'll add it to FilterIt.
|
08/24/15, 07:11 PM | #34 | |
|
It looks like we need something like this to move the search box anchor for AGS and move it back when the trading house (AGS) is done with it:
Warning: Spoiler
Lua Code:
Does the search box need to be hidden when AGS is done with it & the trading house closes? Is it supposed to remain visible on other layouts if the user is only using AGS & not FilterIt or Advanced Filters? Last edited by circonian : 08/24/15 at 07:25 PM. |
|
08/25/15, 02:44 AM | #35 | |
|
FilterIt has added filters to the sell tab after libCIF was conceived, and that might actually solve everything. Basically if the user disables AGS custom sell filters in its settings, and you make the change to FilterIt I posted earlier (addBackpackLayoutShiftY and disableSearchBoxes; edit: and disableGuildStoreSellFilters, because you want FilterIt there, right?), it should be ok. I think you don't even have to include the lib in FilterIt, just try to get it with LibStub.SILENT, and only call those functions if it's there; but perhaps it'll be less error-prone if you include it. Last edited by merlight : 08/25/15 at 03:29 AM. |
|
08/25/15, 05:50 AM | #36 |
|
Here's my current diff against FilterIt 2.9
diff Code:
diff Code:
It works regardless of AGS setting "disable custom selltab filter". Although with that setting OFF, the search box slightly overlaps subfilters or items, because it's at FilterIt position. But once you turn it ON, FilterIt shows up on the sell tab, and it looks good. |
08/25/15, 12:19 PM | #37 | |||
|
Yes it is OK for me, I'm thinking of the problem it is causing AGS when both addons are turned on the search box location is wrong for AGS in the trading house. Yes, I had made those code changes (its not posted, I was just testing on my own).
Then restore the original search box position when the trading house becomes disabled and the disableGuildStoreSellFilters is ON (because that means we previously moved the search box for AGS when the trading house became enabled). That way the search box would be in the correct position at all times for everyone. Last edited by circonian : 08/25/15 at 12:25 PM. |
|||
08/25/15, 02:10 PM | #38 | ||
|
|
||
08/25/15, 03:21 PM | #39 |
|
Yet another issue with the search box. I added saving/restoring the anchor, enabled AGS custom filters and FilterIt -- and everytime I click an AGS (sub)filter, the search box is cleared. It's all so intertwined
|
08/25/15, 05:40 PM | #40 | |
|
I'm actually surprised the search box isn't getting hidden when using AGS and switching off of the "ALL" tab because FilterIt hides the searchBox. He must have code somewhere else un-hiding it. |
|
ESOUI » Developer Discussions » General Authoring Discussion » Inventory search boxes & guild store sell tab filters |
«
Previous Thread
|
Next Thread
»
|
Display Modes |
Linear Mode |
Switch to Hybrid Mode |
Switch to Threaded Mode |
|
|