How to detect when I have used some bait

Originally Posted by votan ... For counting the baits, you could try circonian's idea. /edit: Ok, I'm even more slow

that's nice, I managed to place my post right when I could pretend it was useful

edit cross post with SMDK if you wait 5 mn, i'm sure votan will help with a tested version of bait listing by id and something like this :

local fakeitemLink = zo_strformat(|H0blablabla<<1>>blablabla|h|h, baitId) <---build an ItemLink with no name
zo_strformat(<<1>>,GetItemLinkName(fakeitemLink)) <-- get localized name - format or not depending on the value returned by GetFishingLureInfo or format both the same to compare
(all you need to do this is in fisherman, file Baits.lua btw : all ids, the localized name function too)


but i think you are able to simply make a table lure[itemId] = lureindex, i'm pretty sure these indexes are stable because of the selection wheel.

re edit : you are using local lureIndex = GetFishingLure() at first? It probably just return the index of the current lure on the rod? not sure. but anyway you are using it as the indice 2 lines later. Doesn't seem needed at all.

[SnowmanDK]

Originally Posted by Wandamey that's nice, I managed to place my post right when I could pretend it was useful edit cross post with SMDK if you wait 5 mn, i'm sure votan will help with a tested version of bait listing by id and something like this : local fakeitemLink = zo_strformat(|H0blablabla<<1>>blablabla|h|h, baitId) <---build an ItemLink with no name zo_strformat(<<1>>,GetItemLinkName(fakeitemLink)) <-- get localized name - format or not depending on the value returned by GetFishingLureInfo or format both the same to compare (all you need to do this is in fisherman, file Baits.lua btw : all ids, the localized name function too) but i think you are able to simply make a table lure[itemId] = lureindex, i'm pretty sure these indexes are stable because of the selection wheel. re edit : you are using local lureIndex = GetFishingLure() at first? It probably just return the index of the current lure on the rod? not sure. but anyway you are using it as the indice 2 lines later. Doesn't seem needed at all.

I changed my local variables after last post to

local defaults = {
    data = {
        FoulBaitLeft = 0,
        FoulSBaitLeft = 0,
        RiverBaitLeft = 0,
        RiverSBaitLeft = 0,
        OceanBaitLeft = 0,
        OceanSBaitLeft = 0,
        LakeBaitLeft = 0,
        LakeSBaitLeft = 0,
        GeneralBait = 0,
    },
},

so they became "local" for my entire addon instead of the one function
Edit: You are right about the local lureIndex = GetFishingLure() I just copied from circonian's example lol.

I was thinking you could avoid the loop by using the indexes directly, though it may look cleaner, it would bring nothing since you update all the values at the same time.

your way is more resistant against indexes variations too. Don't mind what i said.

[SnowmanDK]

Originally Posted by Wandamey I was thinking you could avoid the loop by using the indexes directly, though it may look cleaner, it would bring nothing since you update all the values at the same time. your way is more resistant against indexes variations too. Don't mind what i said.

Your input is still valued

Now I just need an event that is fired when I OPEN my map (by pressing 'M').
As it is now, it counts every time there is ANY change in my bag, which causes lag.

I did look into votan's example using

WORLD_MAP_SCENE:RegisterCallback("StateChange", WorldMapStateChanged)
GAMEPAD_WORLD_MAP_SCENE:RegisterCallback("StateChange", WorldMapStateChanged)

but it only fires on map change, not when I open it.

[circonian]

Originally Posted by Wandamey re edit : you are using local lureIndex = GetFishingLure() at first? It probably just return the index of the current lure on the rod? not sure. but anyway you are using it as the indice 2 lines later. Doesn't seem needed at all.

Oops, your right that's pointless. It was supposed to be

local lureIndex = lureIndex or GetFishingLure()

I wrote the function one way & then changed it and missed that and yes it returns the index of the lure on the rod which was part of some code I sent him to check the counts after fishing so only the index of the lure on the rod was needed for that code.

As for the map change talk...it seems like you only need this info for the map pin tooltip so why not just do it in the creator?
Map pin tooltips are re-created everytime they are shown, so your bait count update code would only have to run when a tooltip is shown, which sounds like the only time you need the updated count.
Also that way you would not have to re-check the counts for all of the types of baits. Since you would know which map pin the tooltip is for, you know which baits you are wanting to display and you only have to update those bait counts.


Add a lures table to your pin tag to hold the usable lureIndices:

-- approx. line 3177
local tooltipText = {
   -- add this table
   lures = {},
}

Then instead of creating the string {3/1/71} for counts in FishpinTypeCallback, just determine which lureIndex is usable in that water and put those lure indices in the lures table in the tag.

elseif TYPE == 43 then
--[[
    fishingBaitLeft = tostring(LakeBaitLeft).."/"..tostring(LakeSBaitLeft)
    if GeneralBait >= 1 then
        fishingBaitLeft = fishingBaitLeft.."/"..tostring(GeneralBait)
    table.insert(tooltipText.lures, 0)
    end
    textLine = textLine + 1
    table.insert(tooltipText, textLine, ZO_ColorDef:New(unpack(DestinationsSV.pins.pinTextureFish.textcolorBait)):Colorize(zo_strformat("<<1>>", "{"..fishingBaitLeft.."}")))
--]]
    -- Decide which lureIndices should be used & add them to the table
        -- 5 = just an example of some lure Index usable in this water
    table.insert(tooltipText.lures, 5)
    -- add as many lure indices as needed, insert them in the order
    -- you want them displayed in

Do the lure counts in the tooltip creator

local pinTooltipCreator = {
    creator = function(pin)
        local pinType, pinTag = pin:GetPinTypeAndTag()
        
        -- do it here
        -- You may need some check to make sure its a fishing map pin
        -- if pinType == xxxxx then
            local lures = pinTag.lures
            local tooltipLureCountText
            
            for _, lureIndex in pairs(lures) do
                -- updates bait count
                local name, icon, stack, sellPrice, quality  = GetFishingLureInfo(lureIndex)    
            
                -- If you need something more complex than just the
                -- lure counts in the backpack call a custom function instead
                -- to do that work 
                --local stack = UpdateLureCount(lureIndex)
 
                -- if you need to save counts for use in other places besides the tooltip save it here
                -- someTable.whatever[lureIndex] = stack
 
                -- build the tooltip text line for lure counts as you go
                if tooltipLureCountText then
                    tooltipLureCountText = zo_strformat("<<1>>/<<2>>", tooltipLureCountText, stack)
                else
                    tooltipLureCountText = stack
                end
            end
            -- add your { }
            tooltipLureCountText = zo_strformat("{<<1>>}", tooltipLureCountText)
            
            -- Update the new string in your tag:
            pinTag[4] = tooltipLureCountText
        --end
        
        
        for _, lineData in ipairs(pinTag) do
            SetTooltipText(InformationTooltip, lineData)
        end
    end,
    tooltip = 1,
}