Notification Accept and One-Click-Logout [request]

QuadroTony · 08/20/14, 08:40 AM

Hello, i think we really need the addon(or we already have?) to automatic accept notification about "Your guildmaster finished AA in **** minutes" really got me

Another additional idea, is it possible to make "one key logout" addon? will be usefull for some types of farm, like food/recipes/motifs farm

Randactyl · 08/20/14, 10:41 AM

At the risk of sounding like an ass, the search bar is pretty great

LogOut

and these functions exist

ConfirmCampaignEntry(*integer* _campaignId_, *bool* _queueAsGroup_, *bool* _accept_)

RemoveRaidScoreNotification(*integer* _notificationId_)

among others along the same lines, so looks like something is doable.

QuadroTony · 08/20/14, 12:12 PM

Appreciate this! ty

Garkin · 08/21/14, 06:03 AM

If you want to completely disable raid leaderboard notifications, just unregister notifications provider:

Lua Code:

EVENT_MANAGER:UnregisterForEvent("Notifications", EVENT_RAID_SCORE_NOTIFICATION_ADDED)
EVENT_MANAGER:UnregisterForEvent("Notifications", EVENT_RAID_SCORE_NOTIFICATION_REMOVED)

Right now I'm trying to figure out how to disable notifications just for selected guilds.

Ayantir · 08/21/14, 07:40 AM

I tried those 2 lines of code Garkin, and it seems they doesn't work (Those notifs are really annoying)

https://www.dropbox.com/s/a3zvv16n1n...%20-%200.1.zip

Maybe i make someting wrong

Garkin · 08/21/14, 09:46 AM

Originally Posted by Ayantir

I tried those 2 lines of code Garkin, and it seems they doesn't work (Those notifs are really annoying)

https://www.dropbox.com/s/a3zvv16n1n...%20-%200.1.zip

Maybe i make someting wrong

Try to unregister it later - for example when addon is loaded of when player is activated. It is possible that you are trying to unregister it before it gets registered.

I have tried to update Thurisaz Guild Info to block raid notifications, but I didn't have time to test it yet.
https://www.dropbox.com/s/349xrkiqwb...dInfo-0.57.zip

I'm trying a bit more complex version of this code:

Lua Code:

ZO_PreHook(NOTIFICATIONS.providers[10], "BuildNotificationList", function(self)
    for index = 1, GetNumRaidScoreNotifications() do
        local notificationId = GetRaidScoreNotificationId(index)
        RemoveRaidScoreNotification(notificationId)
    end
end)

CrazyDutchGuy · 08/21/14, 12:45 PM

I have it disabled ages ago, but never made an addon out of it cause it is just in one of my general utility addon.

Anyways packaged it and uploaded, enjoy.

http://www.esoui.com/downloads/info7...otifySpam.html

In regards to what Garkin is doing. I never felt the need for it, cause you should know what your guild is doing, anyways

QuadroTony · 08/21/14, 02:00 PM

for example im only 50 lvl
too far from Trials
i have one main guild and 4 trade guilds, 3 of the doing trials very often
so not neccessary to see this again and again i think
and you always can see the leaderboard in the group page for things you interesting in =)

circonian · 08/21/14, 07:29 PM

Originally Posted by Garkin

If you want to completely disable raid leaderboard notifications, just unregister notifications provider:

Lua Code:

EVENT_MANAGER:UnregisterForEvent("Notifications", EVENT_RAID_SCORE_NOTIFICATION_ADDED)
EVENT_MANAGER:UnregisterForEvent("Notifications", EVENT_RAID_SCORE_NOTIFICATION_REMOVED)

Right now I'm trying to figure out how to disable notifications just for selected guilds.

I dont mess with pvp stuff, so I may be way off on what your trying to do, or there may be a better way but at a quick glance it looks like you could you hook this:

Lua Code:

-- Notifications.lua Line 462 --
function ZO_LeaderboardRaidProvider:BuildNotificationList()

Grab the raid score notifications yourself & check to see if the person is a guild member (you could also set options for showing friend notifications as well while your here it seems):

Lua Code:

for notificationIndex = 1, GetNumRaidScoreNotifications() do
        local notificationId = GetRaidScoreNotificationId(notificationIndex)
        local raidId, raidScore, millisecondsSinceRequest = GetRaidScoreNotificationInfo(notificationId)
        local numMembers = GetNumRaidScoreNotificationMembers(notificationId)
        local hasFriend = false
        local hasGuildMember = false
        for memberIndex = 1, numMembers do
            local displayName, characterName, isFriend, isGuildMember = GetRaidScoreNotificationMemberInfo(notificationId, memberIndex)
...

? Is there a way to get a list of guilds a player is in I didn't see a function for it?

If so loop through those or loop through all of the guilds to find out which guildId that characterName is in (or there may be a better way to do this part?). You all ready have the memberIndex so you dont need to check every guild member (just compare the characterNames to see if they match) using:

Lua Code:

GetGuildMemberCharacterInfo(integer guildId, luaindex memberIndex)
    -- Returns: bool hasCharacter, string characterName, string zoneName, integer classId, integer alliance, integer level, integer veteranRank

That would tell you which guild they are in and then decide if you want to show the notification and pass it on to the original function you hooked (or not)....or that might not work...I dont think you can pass single notifications back to the original function it checks all notifications it seems.

But, you could just rewrite the function to suit your needs. I'll leave the rest of my post up there though because it would still be the basic idea of how you would want to rewrite ZO_LeaderboardRaidProvider:BuildNotificationList() to do what your looking for.

circonian · 08/21/14, 07:41 PM

Originally Posted by Garkin

I'm trying a bit more complex version of this code:

Lua Code:

ZO_PreHook(NOTIFICATIONS.providers[10], "BuildNotificationList", function(self)
    for index = 1, GetNumRaidScoreNotifications() do
        local notificationId = GetRaidScoreNotificationId(index)
        RemoveRaidScoreNotification(notificationId)
    end
end)

Oh, and now I read your second post and see that. I'm assuming providers[10] refers to the leaderboard raid notifications. Which seems simpler than what I suggested (rewriting the BuildNotificationList function), but same principle looks like it would work. Inside your notification loop do something like this to check if its a guildMember:

Lua Code:

for memberIndex = 1, numMembers do
            local displayName, characterName, isFriend, isGuildMember = GetRaidScoreNotificationMemberInfo(notificationId, memberIndex)
.....

and ...same as I said in above post to figure out which guild & if you want to remove the notification or not.

Garkin · 08/21/14, 07:51 PM

Originally Posted by circonian

...

I'd like to hook ZO_LeaderboardRaidProvider but it's local to EsoUI\Ingame\Contacts\Notifications.lua.

Lua Code:

local ZO_LeaderboardRaidProvider = ZO_NotificationProvider:Subclass()

That's why I have hooked NOTIFICATIONS.providers[10]:BuildNotificationList() instead.

By the way did you check code in modified Thurisaz Guild Info which I have linked above?

Lua Code:

ZO_PreHook(NOTIFICATIONS.providers[10], "BuildNotificationList", function(self)
    for index = 1, GetNumRaidScoreNotifications() do
        local notificationId = GetRaidScoreNotificationId(index)
        local numMembers = GetNumRaidScoreNotificationMembers(notificationId)
        local showNotification = false
        local guildMembers = {}
        for memberIndex = 1, numMembers do
            local displayName, _, _, isGuildMember = GetRaidScoreNotificationMemberInfo(notificationId, memberIndex)
            if isGuildMember then
                table.insert(guildMembers, displayName)
            end
        end
        for _, name in ipairs(guildMembers) do
            for guildIndex = 1, GetNumGuilds() do
                if not showNotification and TI.GetGuildSetting(guildIndex) and TI.GetRaidScoreNotifySetting(guildIndex) then
                    local guildId = GetGuildId(guildIndex)
                    for memberIndex = 1, GetNumGuildMembers(guildId) do
                        local displayName = GetGuildMemberInfo(guildId, memberIndex)
                        if displayName == name then
                            showNotification = true
                            break
                        end
                    end
                end
            end
        end
        if not showNotification then
            RemoveRaidScoreNotification(notificationId)
        end
    end
end)

circonian · 08/21/14, 08:17 PM

Oh, yeah your right it is local.
No I hadn't looked at it, but I see you were all ready doing what I suggested.

Looks like it would work to me. Although I think you could get rid of one of the loops by doing this:

Warning: Spoiler

Lua Code:

function TI.HookNotifications()
    ZO_PreHook(NOTIFICATIONS.providers[10], "BuildNotificationList", function(self)
        for index = 1, GetNumRaidScoreNotifications() do
            local notificationId = GetRaidScoreNotificationId(index)
            local numMembers = GetNumRaidScoreNotificationMembers(notificationId)
            local showNotification = false
            local guildMembers = {}
            for memberIndex = 1, numMembers do
                local displayName, _, _, isGuildMember = GetRaidScoreNotificationMemberInfo(notificationId, memberIndex)
                if isGuildMember then
                    -- Change this:
                    -- table.insert(guildMembers, displayName)
                    -- To something like this:
                    table.insert(guildMembers, {["NAME"] = displayName, ["MEMBERINDEX"] = memberIndex})
                end
            end
            
            -- change this:
            --for _, name in ipairs(guildMembers) do
            -- To this, because were now getting a table:
            for _, tPlayerInfo in ipairs(guildMembers) do
                for guildIndex = 1, GetNumGuilds() do
                    if not showNotification and TI.GetGuildSetting(guildIndex) and TI.GetRaidScoreNotifySetting(guildIndex) then 
                        local guildId = GetGuildId(guildIndex)
                        
                        -- And I think you could then avoid doing this loop:
                        --for memberIndex = 1, GetNumGuildMembers(guildId) do 
                        
                            -- change this:
                            --local displayName = GetGuildMemberInfo(guildId, memberIndex)
                            -- to this:
                            local displayName = GetGuildMemberInfo(guildId, tPlayerInfo["MEMBERINDEX"])
                            
                            -- and last change this:
                            --if displayName == name then
                            -- to this:
                            if displayName == tPlayerInfo["NAME"] then
                                --d(zo_strformat("RL notify hit: <<1>> from <<2>>", displayName, GetGuildName(guildId)))
                                showNotification = true
                                break
                            end
                        --end
                    end
                end
            end
            if not showNotification then
                --d(zo_strformat("Removed RL notification! (i: <<1>>, id: <<2>>)", index, notificationId))
                RemoveRaidScoreNotification(notificationId)
            end 
        end
    end)
end

EDIT:
Or I may have spoke to soon. I've never done any pvp/raid stuff. I have no idea how any of it even works. I may be wrong about what I said above...I thought this memberIndex:

Lua Code:

local numMembers = GetNumRaidScoreNotificationMembers(notificationId)
        local hasFriend = false
        local hasGuildMember = false
        for memberIndex = 1, numMembers do
            local displayName, characterName, isFriend, isGuildMember = GetRaidScoreNotificationMemberInfo(notificationId, memberIndex)

was refering to the same memberIndex used for a guild members index,

Lua Code:

local displayName = GetGuildMemberInfo(guildId, memberIndex)

but I read it again and think they might not be the same? Does the first one refer to memberIndex as the "memberIndex" for members of a raid party (people involved in that notification)? If so what I said would not work.

circonian · 08/21/14, 09:43 PM

Originally Posted by Garkin

I'd like to hook ZO_LeaderboardRaidProvider but it's local to EsoUI\Ingame\Contacts\Notifications.lua.

Sorry for the jumble of 1,000 different ideas :P and I still see nothing wrong with what you did, but another option is that you could also hook: NOTIFICATIONS:BuildMasterList().

It would be the same result as what you did so this may not be useful for what your doing, but I saw it & thought I would point it out in case you (or anyone else reading this post later) had any reason to hook any other notifications it might be easier to grab them all in one place:

Lua Code:

-- hook this:
function ZO_NotificationManager:BuildMasterList()
    for i = 1, #self.providers do
        self.providers[i]:BuildNotificationList()
    end
end
-- with this:
--function NOTIFICATIONS:BuildMasterList()

and just intercept self.providers[10] (or whatever provider is needed).

Garkin · 08/22/14, 02:30 AM

Originally Posted by circonian

Oh, yeah your right it is local.
No I hadn't looked at it, but I see you were all ready doing what I suggested.

Looks like it would work to me. Although I think you could get rid of one of the loops by doing this:

Warning: Spoiler

Lua Code:

function TI.HookNotifications()
    ZO_PreHook(NOTIFICATIONS.providers[10], "BuildNotificationList", function(self)
        for index = 1, GetNumRaidScoreNotifications() do
            local notificationId = GetRaidScoreNotificationId(index)
            local numMembers = GetNumRaidScoreNotificationMembers(notificationId)
            local showNotification = false
            local guildMembers = {}
            for memberIndex = 1, numMembers do
                local displayName, _, _, isGuildMember = GetRaidScoreNotificationMemberInfo(notificationId, memberIndex)
                if isGuildMember then
                    -- Change this:
                    -- table.insert(guildMembers, displayName)
                    -- To something like this:
                    table.insert(guildMembers, {["NAME"] = displayName, ["MEMBERINDEX"] = memberIndex})
                end
            end
            
            -- change this:
            --for _, name in ipairs(guildMembers) do
            -- To this, because were now getting a table:
            for _, tPlayerInfo in ipairs(guildMembers) do
                for guildIndex = 1, GetNumGuilds() do
                    if not showNotification and TI.GetGuildSetting(guildIndex) and TI.GetRaidScoreNotifySetting(guildIndex) then 
                        local guildId = GetGuildId(guildIndex)
                        
                        -- And I think you could then avoid doing this loop:
                        --for memberIndex = 1, GetNumGuildMembers(guildId) do 
                        
                            -- change this:
                            --local displayName = GetGuildMemberInfo(guildId, memberIndex)
                            -- to this:
                            local displayName = GetGuildMemberInfo(guildId, tPlayerInfo["MEMBERINDEX"])
                            
                            -- and last change this:
                            --if displayName == name then
                            -- to this:
                            if displayName == tPlayerInfo["NAME"] then
                                --d(zo_strformat("RL notify hit: <<1>> from <<2>>", displayName, GetGuildName(guildId)))
                                showNotification = true
                                break
                            end
                        --end
                    end
                end
            end
            if not showNotification then
                --d(zo_strformat("Removed RL notification! (i: <<1>>, id: <<2>>)", index, notificationId))
                RemoveRaidScoreNotification(notificationId)
            end 
        end
    end)
end

EDIT:
Or I may have spoke to soon. I've never done any pvp/raid stuff. I have no idea how any of it even works. I may be wrong about what I said above...I thought this memberIndex:

Lua Code:

local numMembers = GetNumRaidScoreNotificationMembers(notificationId)
        local hasFriend = false
        local hasGuildMember = false
        for memberIndex = 1, numMembers do
            local displayName, characterName, isFriend, isGuildMember = GetRaidScoreNotificationMemberInfo(notificationId, memberIndex)

was refering to the same memberIndex used for a guild members index,

Lua Code:

local displayName = GetGuildMemberInfo(guildId, memberIndex)

but I read it again and think they might not be the same? Does the first one refer to memberIndex as the "memberIndex" for members of a raid party (people involved in that notification)? If so what I said would not work.

The first member index is in the raid group and it's not the same as member index in guild.

Originally Posted by circonian

Sorry for the jumble of 1,000 different ideas :P and I still see nothing wrong with what you did, but another option is that you could also hook: NOTIFICATIONS:BuildMasterList().

It would be the same result as what you did so this may not be useful for what your doing, but I saw it & thought I would point it out in case you (or anyone else reading this post later) had any reason to hook any other notifications it might be easier to grab them all in one place:

Lua Code:

-- hook this:
function ZO_NotificationManager:BuildMasterList()
    for i = 1, #self.providers do
        self.providers[i]:BuildNotificationList()
    end
end
-- with this:
--function NOTIFICATIONS:BuildMasterList()

and just intercept self.providers[10] (or whatever provider is needed).

ZO_NotificationManager is a local name, so if I want to do it this way I will have to hook NOTIFICATIONS
(global instance of ZO_NotificationManager). But I think that for my purpose is better to hook directly instance of ZO_LeaderboardRaidProvider which is NOTIFICATIONS.providers[10].

circonian · 08/22/14, 02:09 PM

Originally Posted by Garkin

The first member index is in the raid group and it's not the same as member index in guild.

ZO_NotificationManager is a local name, so if I want to do it this way I will have to hook NOTIFICATIONS
(global instance of ZO_NotificationManager). But I think that for my purpose is better to hook directly instance of ZO_LeaderboardRaidProvider which is NOTIFICATIONS.providers[10].

Yeah NotificationManager is local, that is why I said to hook it with:

Lua Code:

-- with this:
--function NOTIFICATIONS:BuildMasterList()

and yeah your way is better for what your doing, I just thought of it & thought I would post it in case someone else searches for NOTIFICATIONS and comes here looking for info/help & reads our discussion. The other way might end up being useful to someone.