Bug Hunt

[circonian]

Edit: No longer valid
I never did find anything wrong, but I was informed by the users that one updated some other addons and one installed Garkins Update 5 Compatability Tool and that solved their problems. JunkIt does not use any of those functions in Garkins Compatability Tool, so I don't know why my addon was showing up with an error in the log, but I think the problem was being caused by some other addon.

[Ayantir]

Maybe an infinite loop? I had game crashes when i was trying to debug some addons which redefine core functions
Think, you'll need to play a bit with thoses addons, reproducing bug is always a good start .

[circonian]

Originally Posted by Ayantir Maybe an infinite loop? I had game crashes when i was trying to debug some addons which redefine core functions Think, you'll need to play a bit with thoses addons, reproducing bug is always a good start .

Yeah, thank you for the advice. I tried for about 6 hours last night and no luck.

[Sasky]

If the one user can reliably reproduce, have them throw some debug output before that one line.

It's from a non-existant value within one table (not sure which). You could set the metatables on everything within there to catch the NIL error, then return some safe default value and/or print debug info. Here's rough code of it (untested):

Warning: Spoiler

-- Ignore nested lookups
local ignoreLookups = { 
    __index = function() return ignoreLookups end,
    __tostring = function(t) return "ERROR" end
}
setmetatable(ignoreLookups, ignoreLookups)
 
local function nn(val) return  (val==nil)?"NIL":val) end
local function catchBadReference(t, key)
    d("Caught an unexpected access: key " .. nn(key) .. " under " .. nn(rawget(t.__underKey)))
    return ignoreLookups
end
local metaCatchBadReference = { __index = catchBadReference }

Then you can just apply that metatable. Since nested, could probably do something like this to get the entire saved vars structure:

function applyCatch(table) {
    --Prevent loops on cyclical table references
    if val.__underKey then return end
 
    val.__underKey = "/"
    for key,val in table do
        if type(val) == "table" then
            applyCatch(val)
            val.__underKey = key
        end
    end
    setmetatable(table, metaCatchBadReference);
}
 
applyCatch(JunkIt.AccountSavedVariables.GLOBALUNKNOWNS)

So, if _iCraftingSkillType is NIL, it would
1) print to console "Caught an unexpected access: key NIL under /"
2) Return "ERROR" effectively if used as string or string access into table.