Button right-click

Loaf · 05/18/14, 08:43 AM

Hi all, I am new to addon development and as a learning aid I am creating a simple addon to store and display some mail recipient favourites. Favs are added by editBox OnEnter and stored in addons savedVariables, then buttons are created dynamically when the addon is loaded. LMB sets the mail to: field and I would like RMB to remove the buttons associated savedVar field. I can not however get the UI to respond to RMB at all.

Have this to create buttons..

Code:

local function MA_CreateButtons()
	
	if MA_SavedVars.Count > 0 then
	
		for i = 1, MA_SavedVars.Count do
			
			local MA_BC = WinMan:CreateControlFromVirtual("MA_Button" .. i, MyAddonControl, "MA_ButtonTemplate", i)
					
			MA_BC:SetHandler("OnClicked", function(self,button)
				if button == 1 then
					ZO_MailSendToField:SetText(MA_SavedVars[i])
				elseif button == 2 then
					d("Right Clicked")
				end
			end)
			
			MA_BC:SetSimpleAnchorParent(10,10+(30*i))
			
			MA_BC:SetText(MA_SavedVars[i])
			
		end
	end
end

Tried OnMouseDown and with and without registering for EVENT_GLOBAL_MOUSE_DOWN. When registered every mouse down in game seemed to be captured and triggered an error.
Despite best search efforts I am coming up empty, any help would be mucho appreciated.

UPDATE: Thanks for the responses so far, most helpful. From d(self, button) it seems that buttons have no inherent right-click detection. Adding in EVENT_GLOBAL_MOUSE_DOWN this time didn't error everything out (assuming I made some error previously) and d() shows that button 2 fires, but obviously has no effect on the buttons I have made. I recall seeing a function on here somewhere that got the name of item beneath mouse.
Will have a further play around today and see where I get.

zgrssd · 05/18/14, 10:40 AM

Have you checked wich value button actually has when the event is called (via left or rightklick)?
Try just dumping it's value into the d() function:

Code:

MA_BC:SetHandler("OnClicked", function(self,button)
	d(self)
	d(button)
	if button == 1 then
		ZO_MailSendToField:SetText(MA_SavedVars[i])
	elseif button == 2 then
		d("Right Clicked")
	end
end)

Either there is no rightclick detection at all (the design is aimed at a console port) or the ID of the button is just very differently from what you expect.

Tar000un · 05/18/14, 10:41 AM

Perhaps you should have a look to the "OnKeyDown" xml event.
I m new too and that's how i ve planed to add a key binded on my addon. ^^'

zgrssd · 05/18/14, 11:19 AM

Originally Posted by Tar000un

Perhaps you should have a look to the "OnKeyDown" xml event.
I m new too and that's how i ve planed to add a key binded on my addon. ^^'

True. "Clicked" always what righthanders would call a leftclick.
It is easy to switch the mousbuttons meaning around in Windows. So that leftclick opens the context menues and rightlick fires the "Clicked" events. That way lefthanders just have to change one setting in Windows and can work normally.

Knowing the button might not be that helpfull. You need the meaning of the button based on local UI layout. Try to find a "Rightclicked "or maybe "Context Menu" related event. It is better then trying to parse those things manually.
Those events would also cover odd cases (like the user hitting the old Context Menu button instead of the right/left mouse button as normal).

**Seerah** · 05/18/14, 02:47 PM

Originally Posted by zgrssd

Code:

	d(self)
	d(button)

By the way, you can just do

Lua Code:

d(self, button)

katkat42 · 05/18/14, 03:37 PM

Originally Posted by zgrssd

True. "Clicked" always what righthanders would call a leftclick.
It is easy to switch the mousbuttons meaning around in Windows. So that leftclick opens the context menues and rightlick fires the "Clicked" events. That way lefthanders just have to change one setting in Windows and can work normally.

THANK YOU

for understanding this simple concept, unlike, say, the people at Bethesda Softworks! I have to adjust the way I hold the mouse whenever I play Morrowind, Oblivion, or Skyrim!

Loaf · 05/19/14, 05:27 AM

As the button wasn't inherently supporting RMB, tried adding registration for EVENT_GLOBAL_MOUSE_DOWN and a function to handle the event. Seems that the function fires even when the addon main window is hidden.
I toggle hidden by parenting addon to ZO_MailSend when addon is loaded, thought that would mean that when the ZO_MailSend window is hidden my addon would not be listening for any events firing. Anyone can shed some light on the reason for this?

Maybe I need to rethink my design?

The only thing I am really missing at the minute is the ability to simply remove a single entry from the favourites list. Clear button works, but as you can see in the picture I tried a reloadUI via /rl and as the editBox had focus I added /rl to favourites list meaning it made a button so I could send rl a mail. Removal without clearing all is needed. How would you guys go about that generally?

Loaf · 05/19/14, 06:17 AM

Ok so after playing about a bit further I got right-click to work by adding the code below to the dynamic buttons virtual XML template which meant I could scrap the use of EVENT_GLOBAL_MOUSE_DOWN.

Code:

<MouseButton button="2" enabled="true"/>

Now the button does respond to RMB and I managed to alter the CreateButtons function so the associated savedVariable is removed.

One final question though (for now :P ), is it possible to have the dynamic buttons update without a /reloadUI or relog? to reflect the changes.

Tar000un · 05/19/14, 09:13 AM

Like a Element:SetText(), you can update an attribute with a function on event.

katkat42 · 05/19/14, 12:53 PM

Originally Posted by Loaf

As the button wasn't inherently supporting RMB, tried adding registration for EVENT_GLOBAL_MOUSE_DOWN and a function to handle the event. Seems that the function fires even when the addon main window is hidden.
I toggle hidden by parenting addon to ZO_MailSend when addon is loaded, thought that would mean that when the ZO_MailSend window is hidden my addon would not be listening for any events firing. Anyone can shed some light on the reason for this?

I know you said you resolved this using another method, but I figure I might as well shed some light anyway, for future reference.

Yes, when you register for an event, your callback will run every time the event fires. You can, however, register your callback to the event when ZO_MailSend opens, and unregister it when ZO_MailSend closes. I use this trick in Feed An Army, because I only need to know when a Provisioning item is finished crafting, not any other type of item. So I register for EVENT_CRAFT_COMPLETE when the provisioning window opens, and unregister when the provisioning window closes.