Junk events

[Edda]

Hello,

It looks like I am flooding the Lua/XML forum here

I searched in the wiki for junk related stuff and found 2 meaty globals :

["SI_ITEM_ACTION_MARK_AS_JUNK"] = 1787
["SI_ITEM_ACTION_UNMARK_AS_JUNK"] = 1788

These look like exactly what I need for my addon but now, I need to find the Event(s) that make use of these.

Did anyone find the junk related events ? It seems from these 2 globals that there should be an ITEM_ACTION event or something.

The event I am using right now is EVENT_INVENTORY_SINGLE_SLOT_UPDATE -> eventCode, bagId, slotId, isNewItem, itemSoundCategory, updateReason but updateReason only accounts for ["INVENTORY_UPDATE_REASON_DURABILITY_CHANGE"] = 1 and ["INVENTORY_UPDATE_REASON_DEFAULT"] = 0 so no luck here.

Any info rly appreciated.

[Seerah]

Those constants are string IDs to get the text for the dropdown to mark and unmark as junk.

[Edda]

Is there any MARK_AS_JUNK event or only the EVENT_INVENTORY_SINGLE_SLOT_UPDATE ?

[Seerah]

Install Zgoo if you don't have it installed.

Type /zgoo events

Mark an item as junk

See what it displays

[Edda]

Right !

Will check that thx.

[zolan]

Originally Posted by Edda Is there any MARK_AS_JUNK event or only the EVENT_INVENTORY_SINGLE_SLOT_UPDATE ?

There is no MARK_AS_JUNK event last I checked.

[lyravega]

In my add-on, here is how I handle junk (don't mind the if checks in front of the event registers):

Registering event & marking junk:

if QB_vars.trashTreatmentSelection >= 2 then EVENT_MANAGER:RegisterForEvent( "QB", EVENT_INVENTORY_SINGLE_SLOT_UPDATE, QB_HandlerSingleSlotUpdate ) end
...
local function QB_HandlerSingleSlotUpdate( _, bagId, slotIndex, isNewItem )
	if not isNewItem then return end
	if GetItemType( bagId, slotIndex ) == 48 then SetItemIsJunk( bagId, slotIndex, true ) end
end

Auto-sell:

if QB_vars.trashTreatmentSelection == 3 then EVENT_MANAGER:RegisterForEvent( "QB", EVENT_OPEN_STORE, QB_HandlerStoreOpened ) end
...
local function QB_HandlerStoreOpened()
	SellAllJunk()
end

In short, when we get an item, the event will fire, and we check if it is a new item, then if it is a trash item by using the passed badID and slotIndex. The API function, GetItemType() will return 48 if it is a trash quality item. If it is so, we mark it as junk.

[Garkin]

What I'm trying to use in my Dustman (testing right now)

local markedAsJunk = {}
local handleJunk = true
 
local function HandleJunk(bagId, slotId, itemLink, sellPrice)
 
   --some code here
 
   if not IsItemJunk(bagId, slotId) then
      handleJunk = false
      SetItemIsJunk(bagId, slotId, true)
      handleJunk = true
 
      --more code here
 
   end
end
 
local function OnInventorySlotUpdate(eventCode, bagId, slotId, isNewItem, itemSoundCategory, updateReason)
   if updateReason == INVENTORY_UPDATE_REASON_DURABILITY_CHANGE then return end
 
   if bagId == BAG_BACKPACK then
      local itemLink = GetItemLink(bagId, slotId)
      local itemId, quality, level = select(4, ZO_LinkHandler_ParseLink(itemLink))
      if itemId == "" or quality == nil or level == nil then return end  --empty slot
      local itemType = GetItemType(bagId, slotId)
      local _, _, sellPrice, _, _, _, itemStyle, quality = GetItemInfo(bagId, slotId)
 
      --some code here
 
      if markedAsJunk[itemId.."_"..quality.."_"..level] then
         HandleJunk(bagId, slotId, itemLink, sellPrice)
         return
      end
 
      --more code here
 
   end
end
 
local function OnLoad(eventCode, name)
   if name ~= "Dustman" then return end
 
   -- some code
 
   markedAsJunk = ZO_SavedVars:New("Dustman_Junk_SavedVariables", 1)
   
   local original_SetItemIsJunk = SetItemIsJunk
   SetItemIsJunk = function(...)
      local bagId, slotId, junk = ...
      local itemLink = GetItemLink(bagId, slotId)
      local itemId, quality, level = select(4, ZO_LinkHandler_ParseLink(itemLink))
      if handleJunk then
         markedAsJunk[itemId.."_"..quality.."_"..level] = junk and true or nil
      end
      original_SetItemIsJunk(...)
   end
 
   --more code and events
 
   EVENT_MANAGER:RegisterForEvent("Dustman_InventorySingleSlotUpdate", EVENT_INVENTORY_SINGLE_SLOT_UPDATE, OnInventorySlotUpdate)
 
   EVENT_MANAGER:UnregisterForEvent("Dustman_OnLoad", EVENT_ADD_ON_LOADED)
end
 
EVENT_MANAGER:RegisterForEvent("Dustman_OnLoad", EVENT_ADD_ON_LOADED, OnLoad)

[Edda]

Originally Posted by lyravega In short, when we get an item, the event will fire, and we check if it is a new item, then if it is a trash item by using the passed badID and slotIndex. The API function, GetItemType() will return 48 if it is a trash quality item. If it is so, we mark it as junk.

About trash items : I am VR1 and never got any trash item (if they are supposed to go under the trash inventory tab). I still wonder what they are Problem is, my addon doesn't handle 'trash items' (to mark them as junk) but any 'already marked as junk' item. Could be crafting materials or anything not 'trash items'. Therefore I can't be checking the itemType == 48 thing I guess (if 48 = trash quality item).

Here is how I am handling the garbage (note I had issues with items gained thru deconstruction or bank retrievals)

-- Loot or deconstruction
        if not IsItemJunk(bagId, slotId) and RJ.User.Memory[itemData.itemId] ~=nil and isNewItem then
        
            SetItemIsJunk(bagId, slotId, true)
            if RJ.User.Options.Verbous then d(RJ.niceName .. " |cffffff[" .. itemData.itemLink .. "]|r moved to junk !") end
            
        -- Bank pulls
        elseif GetGameTimeMilliseconds() - RJ.bankEvent < RJ.trackDelay and not IsItemJunk(bagId, slotId) and RJ.User.Memory[itemData.itemId] ~= nil and not isNewItem then
        
            SetItemIsJunk(bagId, slotId, true)
            if RJ.User.Options.Verbous then d(RJ.niceName .. " |cffffff[" .. itemData.itemLink .. "]|r moved to junk !") end
        
        -- Manually inserting new junk item
        elseif IsItemJunk(bagId, slotId) and RJ.User.Memory[itemData.itemId] == nil and not isNewItem then
            
            RJ.User.Memory[itemData.itemId] = itemData;
            if RJ.User.Options.Verbous then d(RJ.niceName .. " |cffffff[" .. itemData.itemLink .. "]|r added to junklist.") end
            
        -- Manually removing junk items
        elseif not IsItemJunk(bagId, slotId) and RJ.User.Memory[itemData.itemId] ~= nil and not isNewItem and not RJ.craftEvent then
        
            RJ.User.Memory[itemData.itemId] = nil
            if RJ.User.Options.Verbous then d(RJ.niceName .. " |cffffff[" .. itemData.itemLink .. "]|r removed from junklist.") end
        end

Might not be perfect but working so far. The GetGameTimeMilliseconds() - RJ.bankEvent < RJ.trackDelay checks if a bank pull happened in the last 50 milliseconds. The not RJ.craftEvent check if we are 'inside' a craft event (after craft started and before craft completed). Had to do this because items would sometimes (go figure) get removed from my addon junk list while deconstructing or pulling bank items.

[katkat42]

Originally Posted by Edda About trash items : I am VR1 and never got any trash item (if they are supposed to go under the trash inventory tab). I still wonder what they are

Some examples of trash items are ectoplasm, foul hides, carapaces. They are anything described as "sell this item to a merchant for gold". They show up under the "Misc" category by default; you have to move them to Junk manually (or with an add-on )

[zgrssd]

Originally Posted by Edda About trash items : I am VR1 and never got any trash item (if they are supposed to go under the trash inventory tab). I still wonder what they are

"Mark as Junk" has two effects:
They are not anymore listed in thier original category, but instead in their junk category.
Junk items can be quickly sold (with value preview) at any trader by hitting X. Especially vendor trash and white gear without a trait lands in my junkyard. Same with too low potions (when I get enough of higher level), already known recipes, and the like.

Mark as junk is really just there to give you better overview and allow you to sell trash fast.