Lua Error Help First Addon

[Yazilliclick]

Hey,

Trying my first addon and getting an error I haven't been able to solve. Probably something simple and stupid.

user:/AddOns/YazClock/YazClock.lua:13: function expected instead of nil stack traceback: user:/AddOns/YazClock/YazClock.lua:13: in function 'yc:OnAddOnLoaded' user:/AddOns/YazClock/YazClock.lua:17: in function '(anonymous)'

YazClock.lua

local yc = ZO_Object:Subclass()
local eventManager = GetEventManager()
 
function yc:New()
    yc.AddOnName = "YazClock"
    yc.AddOnEventManager()
end
 
function yc:OnUpdate()  
end
 
function yc:OnAddOnLoaded(eventCode, addOnName)
    yc:SetHandler("OnUpdate", function(...) yc:OnUpdate(...) end)
end
 
function yc:AddOnEventManager()
    eventManager:RegisterForEvent(yc.AddOnName .. "_AddOnLoaded", EVENT_ADD_ON_LOADED, function(...) yc:OnAddOnLoaded(...) end)
end 
 
yc:New()

YazClock.xml

<GuiXml>
	<Controls>
		<TopLevelControl name="YazClock" mouseEnabled="true" movable="true">
			<Dimensions x="200" y="42" />
			<Anchor point="CENTER" />
			<Controls>				
				<Label name="$(parent)TimeDisplay" font="ZoFontGame" color="CFDCBD" wrapmode="ELLIPSIS" verticalalignment="CENTER" text="Counter: ">
					<AnchorFill />
				</Label>
			</Controls>
		</TopLevelControl>
	</Controls>
</GuiXml>

Any help appreciated. If somebody wanted to give hints or code towards moving control creation into the lua and saving position between loads as those are my next steps that'd be great but I think I can figure that out eventually

[Iyanga]

And yc:SetHandler does exist?

[Yazilliclick]

Thanks Iyanga for pointing out my stupidity I knew it was something simple and silly that I was missing.

For others I added code to create a mainwindow in lua, got rid of XML and then set the handler on the mainwindow and it works.

local yc = ZO_Object:Subclass()
local eventManager = GetEventManager()
local windowManager = GetWindowManager()
 
function yc:New()
    yc.AddOnName = "YazClock"
    yc.AddOnEventManager()
end
 
function yc:OnUpdate()  
end
 
function yc:OnAddOnLoaded(eventCode, addOnName) 
 
    d("test")
    if (yc.MainWindow == nil) then  
        yc.MainWindow = windowManager:CreateTopLevelWindow(yc.AddOnName .. "_MainWindow")
        yc.MainWindow:SetDimensions(200, 42)
        yc.MainWindow:SetAnchor(CENTER, GuiRoot, TOPLEFT, 0, 0)
        yc.MainWindow:SetHandler("OnUpdate", OnUpdate)
 
        yc.MainWindow.TimeLabel = windowManager:CreateControl(yc.AddOnName .. "_TimeLabel", yc.MainWindow, CT_LABEL)
        yc.MainWindow.TimeLabel:SetFont("ZoFontAnnounceMessage")
        yc.MainWindow.TimeLabel:SetDimensions(200, 42)
        yc.MainWindow.TimeLabel:SetText("Test")
    end
end
 
function yc:AddOnEventManager()
    eventManager:RegisterForEvent(yc.AddOnName .. "_AddOnLoaded", EVENT_ADD_ON_LOADED, function(...) yc:OnAddOnLoaded(...) end)
end 
 
yc:New()

[Iyanga]

As a side note:
Is there a reason why you wrap an anonymous function around yc:OnAddOnLoaded in line 30?

[Seerah]

To clarify why it wasn't working, in your first code example (in the first post), yc is not a control/object. Script handlers can only be set on controls.

[Yazilliclick]

Originally Posted by Iyanga As a side note: Is there a reason why you wrap an anonymous function around yc:OnAddOnLoaded in line 30?

I'm using another addon as an example right now just to try and get this working. That's where that comes from.

I've got a new problem now in that even though I'm setting my handler for OnUpdate it's not being called afterwards. Code below, have bit ugly since I've been editing it back and forth while debugging.

local yc = ZO_Object:Subclass()
local eventManager = GetEventManager()
local windowManager = GetWindowManager()
 
function yc:New()
    yc.AddOnName = "YazClock"
    yc.AddOnEventManager()
end
 
function yc:OnUpdate()  
    CHAT_SYSTEM:AddMessage("On UPdate")
    yc.MainWindow.TimeLabel:SetText(GetDateStringFromTimestamp(GetTimeStamp()) .. " " .. GetTimeString())
end
 
function yc:OnAddOnLoaded(eventCode, addOnName) 
 
    CHAT_SYSTEM:AddMessage("OnLoaded") 
    
end
 
function yc:PlayerActivated()
    CHAT_SYSTEM:AddMessage("Test")
 
    if (yc.MainWindow == nil) then  
        yc.MainWindow = windowManager:CreateTopLevelWindow(yc.AddOnName .. "_MainWindow")
        yc.MainWindow:SetDimensions(200, 42)
        yc.MainWindow:SetAnchor(CENTER, GuiRoot, TOPLEFT, 0, 0)
        CHAT_SYSTEM:AddMessage("Setting handler")
        
 
        yc.MainWindow.TimeLabel = windowManager:CreateControl(yc.AddOnName .. "_TimeLabel", yc.MainWindow, CT_LABEL)
        yc.MainWindow.TimeLabel:SetFont("ZoFontAnnounceMessage")
        yc.MainWindow.TimeLabel:SetDimensions(200, 42)
        yc.MainWindow.TimeLabel:SetText("Test")
        yc.MainWindow.TimeLabel:SetHandler("OnUpdate", function(self, timerun)
            CHAT_SYSTEM:AddMessage("OnUpdate Fired")
            end)
    end
end
 
function yc:AddOnEventManager()
    CHAT_SYSTEM:AddMessage("Test2")
    eventManager:RegisterForEvent(yc.AddOnName .. "_AddOnLoaded", EVENT_ADD_ON_LOADED, function(...) yc:OnAddOnLoaded(...) end)
    eventManager:RegisterForEvent(yc.AddOnName .. "_PlayerActivated", EVENT_PLAYER_ACTIVATED, function(...) yc.PlayerActivated(...) end)
end 
 
yc:New()

I've had the SetHandler also set to:

yc.MainWindow.TimeLabel:SetHandler("OnUpdate", OnUpdate)
 
-- and
 
yc.MainWindow.TimeLabel:SetHandler("OnUpdate", function(...) yc:OnUpdate(...) end)

Originally Posted by Seerah To clarify why it wasn't working, in your first code example (in the first post), yc is not a control/object. Script handlers can only be set on controls.

Yeah thanks Seerah for wording it better!