Which addon can cause crash on item's pickup?

[QuadroTony]

when i pickup too meny items i have guaranteed crash
the best place to test this - http://forums.elderscrollsonline.com...-20-minutes/p1

it must be an addon or few who update every inv slot on pickup right?
mby you can help me find out which one

here is list of my addons
i will try not to find out which one, will test by turn on/off different addons
but mby you can help me narrow down the search

[Cairenn]

The quickest way to find out which addon is the culprit is to divide the problem in half:

• Disable 1/2 of your addons. Does the problem still happen?

• Yes? Then it is in this half.
• No? Then it is in the other half.

• Take the half that still causes the problem. Disable 1/2 of them. Does the problem still happen?

• Yes? Then it is in this half.
• No? Then it is in the other half.

• Take the half that still causes the problem ......

[QuadroTony]

i think there is some string of code i can open all folders in Notepad++ and ctrl+f this string

it will be easier
because its not only one addon, but a few i believe

[Ayantir]

I clearly think it's a combinaison of addons and miswriten code.

ex :

You loot an item (event)

- Addon 1 set this item to junk
- Addon 2 set this item to junk
- Addon 3 set this item to junk
- Addon 4 set this item to junk
- Addon 5 set this item to junk
- Addon 6 set this item to junk
- Addon 7 set this item to junk
- Addon 8 set this item to junk
- Addon 9 set this item to junk
- Addon 10 set this item to junk

- Addon 10 receive 10 singleslot update because of the 10 precedent addons.
It will trigger it's code 10 times.

If you get 5 addons of loot which set item as junk, and 7 addons which monitors your slots, you'll get 35 addons code running for 1 item.

In fact, I think it's all addons which listens to :

EVENT_LOOT_RECEIVED
EVENT_INVENTORY_SINGLE_SLOT_UPDATE

You can ctrl+F those strings.

[QuadroTony]

Originally Posted by Ayantir I clearly think it's a combinaison of addons and miswriten code. ex : You loot an item (event) - Addon 1 set this item to junk - Addon 2 set this item to junk - Addon 3 set this item to junk - Addon 4 set this item to junk - Addon 5 set this item to junk - Addon 6 set this item to junk - Addon 7 set this item to junk - Addon 8 set this item to junk - Addon 9 set this item to junk - Addon 10 set this item to junk - Addon 10 receive 10 singleslot update because of the 10 precedent addons. It will trigger it's code 10 times. If you get 5 addons of loot which set item as junk, and 7 addons which monitors your slots, you'll get 35 addons code running for 1 item. In fact, I think it's all addons which listens to : EVENT_LOOT_RECEIVED EVENT_INVENTORY_SINGLE_SLOT_UPDATE You can ctrl+F those strings.

thanks! i will try and report my findings

[Baertram]

So how do we prevent this to happen? I've added a check into event single inventory slot update to ask if the item is new and if the item type is not the one for item got deleted. Any other checks to do here to avoid the problem?

[QuadroTony]

and i can guess this behaviour also causes lags for few seconds when you Selling all junk with one button to the merchant?

[Baertram]

Sure, as the event inventory single slot update will be fired for each item too.
Depends on the amount of addons you have activated that scan the inventory items as written above.
And you are using way too much addons :-)

[QuadroTony]

they all importsant for me=) cannot delete even 1

[circonian]

Originally Posted by Baertram So how do we prevent this to happen? I've added a check into event single inventory slot update to ask if the item is new and if the item type is not the one for item got deleted. Any other checks to do here to avoid the problem?

I would say it depends on when you really need to run code. By that I mean why are you watching for the slot updates? If you don't need to process old items then checking if its new should prevent most of the problems.
Does the addon really need to update data on slot update (it may need to be done then) or could it be done at some other time like when the inventory is opened (so it only runs when the inventory is opened)...or in the inventory row callback (so it only runs when the row control is setup)?

Or you mentioned items getting deleted, if that is your purpose to monitor for deleted items it might be better to just watch for that using things like:

-- Items get destroyed by code:
ZO_PreHook("DestroyItem", OnDestroyItem)
-- Items get destroyed by dragging to main window:
EVENT_MANAGER:RegisterForEvent(FilterIt.name, EVENT_MOUSE_REQUEST_DESTROY_ITEM, PreventMouseDragDestroy)

Instead of processing every slot update.

[QuadroTony]

the same issue
re-post
im still testing my conditions

Originally Posted by inselmann Hello Circonian, thank you for your addons. I noticed that junkit autosell sometimes crashes the game. If you sell about 100+, it seems that too many requests to the clients are sent. Maybe you can check it and make a short delay between the sell requests. I tested it with no other addons installed. Thank you Best regards inselmann