Yep and this is e.g. the reason why I mentioned the keybinds should only work (visible function does this) if you ARE at the crafting table AND are at the panel where the needed operation (in this case deconstruction) should be done

I got this error when I accidentally hit my MD keybind while not being at a crafting table (I was just running through the city on my way to the stables). At first I didnt understand why the error came, so after reading inside it it mentioned the MassDeconstructor, I for some reason tried pressing the keybind for MD and it happened again.




Note: just as a test I tried going to a crating table and interacting with it then pressing the MD keybind and that works fine still. So above error only seems to happen if pressing MD keybind while not interacting with crafting station.

Much appreciated for the quick fix!

Aye, still investigating the code to see why this could happen. I guess there might be another addon invloved but cannot find where or how. If he says this happens as he mouse hovers a station this must be something which registers to the reticle.

Or maybe your keybinds are "to global" and get tried to be registered even on other panels and then call some code.

btw: If you'd change your keybindings to only be visible at the panel where they relate to you'd be fine.
No call to ZO_MenuBar_SelectDescriptor(SMITHING.modeBar, SMITHING_MODE_REFINMENT) or other mode functions needed anymore then.

Example function for the visible stuff:

Depending on your keybind you could change retVar for refine to true or for decon or extract to true. e.g. using a parmater isRefineKeybind in the function's parameter list.

In your addon functions yourAddon.IsSHowingSmithing and IsShowingEnchantment can use your event_craftingstation_interact variables e.g.

That will come in time, it will take a lot more work than seeking a less-broken method to do what it used to do.

Now let's just see if this current fix resolves the issue that your user was having.

I know and I cannot explain this myself.

But nevertheless setting the mode will also get you in trouble with other addons so forget the FCOCraftFilter problems and stop switching the modes manually where not needed please! Believe me or not...

Edit:
btw: check your manifest txt file there is an empty entry ## DependsOn:.

It's exactly what the mode buttons do, as per the code in ZOS-provided in-game UI.

None of this explains how simply running around a dungeon can be triggering Mass Deconstructor in any way. MD only acts on the crafting table interaction events.

Also the code you just quoted is what I have updated it to just in the last hour. See if anyone can replicate the error. ZO_MenuBar_SelectDescriptor will set the appropriate panel just as if the user had clicked the button.

You are right that it's basically nothing else like ZOs code does but I guess the addon here does it sometime where a mode was already set and then changes it again? Changing the mdoe will run all "prehooked"/"posthooked" code of other addons which then fail or get strange behaviour.
ZOs only sets the mode AT THE BEGINNING as you change the filter tabs like from "Create" to "Deconstruct".

Do you have any option which automatically deconstructs if you enter a crafting station or similar to this?
Like you approach the woodworking table, are at the "Refine" panel (SMITHING.mode is refine then).
Now you start the deconstruction of items and set the smithing mode to deconstruction, which will run other addon codes, which fail as they think they are at deconstruction but one is at the refine panel. Something like this?
I do not know your addon in detail.

The only thing I know is that several crafting related addons rely on a proper handling of the smithing mode/enchanting enchantigMode and this addon somehow changes it either too early or in between or whatever, so that they will break the others, or run their code and get strange behaviours.

Please check the lines where you set the mode. If at the time this happens you are currently NOT at a deconstruction panel of SMITHING or a extraction panel of ENCHANTING then you cannot simply change the modes and go on.

Either the lines in your code to set the mode are simply not needed and you can remove them.
Which should fix at least some possible addon error.
Or you'd need to find another way like simulating a button press on the smithing/enchanting tabs to activate the deconstruction/extract tab properly.

Example:

This makes no sense? Why should you start refining if you are not at the refining tab.
You need to check this before using the function instead of setting the SMITHING.mode to refining youself.
If ppl are at the refining tag they can refine, if not they need to switch.
If you set the mode to refine you let other addons call their code for prehooks/Posthooks to SMITHING.SetMode or ZO_Smithing.SetMode

Same for the other panels. I do not understand why these checks and changes are needed? If the users are not able to refine or deconstruct if they ARE NOT at the desired panel, you shouldn't need this at all.
So better build checks in before like remove the keybinds properly so they cannot start the process if they are not at the panel etc.

Another hint:
You should maybe add an event for the craft_failed as well, if you started crafting. Not always the crafting will work normal and if it fails and you do leave the station or not, your internal variables are messed.
You maybe should use your cleanup functions (CleanupAfterRefining(), ...) also at event_craft_failed and event_crafting_station_interact_end to be sure everthing is reset properly for next mass crafting.

That error should be gone now.

… that's a curly one! I'll see about fixing that one ASAP.

I think I found it:

ZO_MenuBar_SelectDescriptor(SMITHING.modeBar, SMITHING_MODE_DECONSTRUCTION)

So this will be interacting with the mode bar without simply performing the function that the button performs. Now to see if I can replicate the error the FCO Craft Filter user was experiencing (though it still doesn't explain why Mass Deconstructor is being invoked without actually interacting with a crafting table).

How do I change modes safely? This is how the buttons set the mode in the first place: smithing_keyboard.lua line 203 function ZO_Smithing:InitializeModeBar(). Each button has a callback which sets the mode.

How is what I am doing any different to what the panel buttons do?

And how is Mass Deconstructor being invoked when the player hasn't opened the crafting table scene?

Getting below error when at crafting tables when trying to mass deconstruct.

EDIT: I found out how to trigger it. It will trigger if there is a gear piece already added before starting to mass deconstruct. Clearing it manually before using Mass Deconstructor will prevent the error from happening.



EDIT2: and found another error. When exiting the crafting table before Mass Deconstructor is done produces this error:


EDIT3: Found another error. If accidentally trying to mass deconstruct again while MD is already working to deconstruct will produce this error and halt the work (and place a ?-icon where the gear to be deconned is normally displayed):



I realize that all these errors can be prevented by the user. But still, should probably be fixed?

And here we go (related to my post directly below):
Some user complaiend in the past at my addon FCOCraftFilter that something is broken. He tested and found out it's MasssDeconstructor which is changing SMITHING variables (I bet you do the same like with the ENCHANTING described below, changing the smithingMod here...) and this will make my addon's buttons don't work properly.
https://www.esoui.com/downloads/file...=1104#comments

PLEASE do not do this. Let the user swith to the extraction/deconstruction tab properly and THEN start the deon/extraction. Or DO NOT change the enchantingMopde or smithing mode and just extract the stufgf. But if you keep it running like this is will break my and other addons for sure

Please do not overwrite the ENCHANTING table values like the enchantingMode within your addon!
It will maybe destroy other addons as they rely on the "save way" of getting the enchantingMode.

I'm not sure why you'd need to change the enchating mode at all here as the game already got the enchantingMode from it's internal code. Why setting it again then and risking any error or problems?
Same with the Smithing mode!

You definately will break protective functions of FCOItemSaver this way. It relies on the mode and enchantingMode of SMITHING and ENCHANTING.

Your code looks like it will even extract if you are at the "Create glyph" enchantingMode?
Maybe some kind of auto extract as you open the crafting tables?

This will make other addons think they are at the deconstruction/extraction panel but the controlNames of these panels like the extract slots are missing and thus the protective functions will just allow the deconstruction of maybe protected items. At best this will work properly as LibFilters is maybe recognizing the SMITHING.mode or ENCHANTING.enchantingMode and think it's at the deconstruction/extract panel. But you cannot be sure. Keep that in mind and please don't blame the other protective addons if your addon is messing with the crafting tables this way and protected items get deconstructed

Thanks for your understanding.

Okay, this was an emergency release to get things working again. Let me know how much new breakage has occurred.

Easiest way to get my attention is the Maralie's Manse server on Discord, or submit an issue on GitHub.

Coming Real Soon Now™ will be a version that uses the bulk actions that were introduced with Scalecaller. Real Soon is probably next weekend.