Originally Posted by sirinsidiator
How about allowing two levels of customization? - Allow the user to download additional style packages that change the default look of libAddonMenu
- Give addon devs a way to change the look of their own settings panel
That should cover all the things that where proposed so far and allow them without the need to update the main lib for every change in style. |
I like the whole template/style package idea, BUT I think a user downloadable version should be restricted to the background. Like whether or not you want to see the original libAddonMenu borders, or no borders, or a darker background.
My main concern is a user downloadable style changing something it should not that messes up the layout/look of the addon panel we create for our addons. For example what if I had two settings set to "half" width, but a user downloads a style that widens the buttons/droopdown box and now they no longer fit next to each other in "half" width. I wouldn't want them changing any color schema I set up for my panel either.
Originally Posted by sirinsidiator
For the settings I will have to use one of the methods proposed here. - Using the ingame savedvars to store the settings requires minimal change, but at the same time feels a bit wrong because it puts library related stuff in a file that is not owned by it.
- Putting libAddonMenu into a standalone addon might look a bit inconvenient at first glance, but it would also open a few new possibilities.
- Enables saved vars
- Removes the need to bundle it with other addons and update every addon when a new version is released
- Changes the load order so that the newest version of libAddonMenu is loaded first
- Which in turn prevents problems like this
|
I'm not sure I get this, what kind of settings are we talking about saving?
The ingame savedvars is what I used for LibNeed4Research, but I admit I too didn't really like the idea of putting the savedVars in there.
However, since this is used by so many addons & every addon has to include it I think the standalone idea is a pretty good one.
Just force everyone to depend on it or add some way to check
(without watching for it to load in OnAddonLoaded) to see if LibAddonMenu has been loaded AND what the current version is, before creating the settings menu. This way addons could create the settings menu or not, depending upon if LibAddonMenu is installed & if it is the correct/up to date version, so that the addon could function either way the user just wouldn't be able to change settings without it.